Commit Graph
102254 Commits
Author SHA1 Message Date
Wolfgang Taferner a2fa7ec75f [FIX] Remove useless nested class as it breaks compilation 2016-08-25 10:46:48 +02:00
Denis Ledoux e123d16e52 [FIX] sale: fix sales team Invoiced this month field
Exclude purchases invoices from the `invoiced` field
of `crm.team`, as this count is meant to sum
the invoiced - sales - order of a sales team.

opw-686732
2016-08-24 18:21:22 +02:00
Nicolas Martinelli f30ec3022e [FIX] mail: link in livechat
When a user sends a link thanks to the livechat, the link is not
clickable is the recipient is on the frontend (e.g. visitor of the
website). On the other hand, a link sent from the frontend to the
backend works.

This is because the message is sent as "html" from the backend,
therefore no link conversion is done during the post-process of the
massege (method `message_post`).

Note that a link sent and received in the backend works because
additional formatting is done (convert emojis, add links...).

opw-686063
2016-08-24 11:25:34 +02:00
Goffin Simon ce5b802df6 [FIX] hr_holidays: undisplay refuse leaves on dashboard
The refuse leaves don't have display in the dashbord.

opw:685604
2016-08-24 09:36:40 +02:00
Nicolas Martinelli 9c67a0d1b7 [FIX] account_asset: partner must be a vendor
When creating an asset, there is no restriction on the partner. However,
there is a domain to explicitly restict the categories to the 'Purchase'
asset types. Therefre, the partner is always a vendor.

opw-686636
2016-08-24 08:51:33 +02:00
Nicolas Martinelli c4adc4a566 [FIX] website_event: ticket price
When a ticket is ordered, the price is always with format amount +
currency. However, it should match the standard format of the currency.

opw-682984
2016-08-24 08:49:54 +02:00
Nicolas Martinelli b81ed2fd01 [FIX] stock: package domain
When choosing a package for a pack operation, we should restrict the
packages to the ones which are actually available in the given
locations.

opw-684007
2016-08-24 08:48:23 +02:00
Jeremy Kersten 498b266f5c [ADD] base: add tests for mimetype detection 2016-08-23 22:30:18 +02:00
Jeremy Kersten 5a9e1af64a [FIX] base: improve last chance for detection of mimetype
Since we return nosniff header, we need to avoid the magic mimetype.

In case of picture in compute field (eg. image_small on product),there are
no mimetype saved in column, and impossible to detect it from name/extention
because url are like: /web/image/product.product/47/image_small.

So before to arbitrary return default_mimetype, we try to detect it from the
content itself.

This commit continue to fix odoo/odoo@13193
2016-08-23 21:09:20 +02:00
Jeremy Kersten 1b2dab3f50 [FIX] mail: preprocess tracking fields of type date/datetime only once
Before this commit, if a message thread was loaded 2 times, the first time
the date was well formatted, the second time that fail because momentjs cannot
parse the localized date from some locale.

Luckily, it was not bugged by default in english, because moment was able to
reparse a localized US date. But in some local as french, momentjs cannot parse
the localized date and return 'Invalid date'

Now, we move the code, to be processed only once by the chat manager, and not
in each process of the thread.

This commit closes issue #13258

Courtesy of @aab-odoo
2016-08-23 15:23:20 +02:00
Goffin Simon 6d4bb4f18c [FIX] website_portal: details of a contact
When changing the contact details of a partner which is a company contact,
all the fields related to the address must be set on the commercial partner.

The address displayed for a company contact is the address of the commercial
partner.

opw:686335
2016-08-23 14:49:57 +02:00
Martin Trigaux fceba5df8c [FIX] account: remove duplicated term in .pot£ 2016-08-23 10:58:36 +02:00
Freeman Helmuth 6715df7b94 [CLA] corporate signature for Pine View Buildings
Closes #13144
2016-08-23 10:48:31 +02:00
Damien Bouvy dc975f3b0b [FIX] pos: group pos entries by tax
When posting POS entries with the "group entries" option set on that
pos config (which is the default), it is possible to have bad net
amounts in the tax report because taxes are not used as a grouping
parameter, allowing the system to potentially group pos order lines
which have different taxes together.

Also, take into account the fiscal position set on each order when
creating the move lines (the correct tax for a line is a compute field,
so this commit may actually cause some performance degradation for big
pos sessions).

Amends 150bf7d

opw-686168
2016-08-22 17:21:07 +02:00
Jeremy Kersten 97b702a7b0 [FIX] web: fix mimetype for content_image
Since the commit odoo/odoo@36e875e which disable the second-guess from browser,
IE cannot display picture from Odoo where mimetype is wrong.
Before this commit, IE and probably other browser which one respect the header
'nosniff' don't display picture not_found and resized picutre via controller if
the original was not of type 'png'.

Eg: when we return the placholder 'not_found' if you don't have permission,
or when your resize the picture, ... we need to force the mime-type with the
new one and not keep the original mimetype.

This commit closes #13193
2016-08-22 16:25:52 +02:00
Nicolas Martinelli 2ab68047c1 [FIX] payment_paypal: missing Paypal link
When an invoice is sent by email, the Paypal link is not included,
although it is in the template.

This is because the `paypal_url` field has gone missing after Accounting
refactoring.

opw-686216
2016-08-22 14:28:10 +02:00
Nicolas Martinelli b4b04c9eb7 [FIX] mrp: BoM Structure report
When printing a BoM Structure report, the quantitites are not multiplied
down the line. For example, the BoM for Products 0 and 1:

Product 0
   8 Units of Product 1

Product 1
   1 Unit of Product 2a
   2 Units of Product 2b

When printing the BoM Structure of Product 0, it shows:
Product 0
   8 Units of Product 1
       1 Unit of Product 2a
       2 Units of Product 2b

It should be:
Product 0
   8 Units of Product 1
       8 Unit of Product 2a
       16 Units of Product 2b

opw-686167
2016-08-22 10:13:22 +02:00
Nicolas Martinelli 2c0cae221a [FIX] stock_account: raise error when valuation is zero
Commit ddbe0e1 introduces an error when the user tries to move a product
with a cost of zero. In extreme case, this is incompatible with commit
262d98b. For example, if one buys 10000 units for 17.60, and consumes one
unit at a time. The latter commit will split the quants in:
- 9999 quants at cost zero
- 1 quant at cost 17.60
This is the only solution to get a correct accounting.

However, that creates quants with a cost of zero, which therefore cannot
be moved anymore (consumed in MRP or sold).

We restrict the warning to products configured with "Standard Price".
Indeed, in this configuration, it is very lokely that the user made a
mistake / forgot to define the price of the product.

opw-686301
2016-08-22 08:22:08 +02:00
Odoo Translation Bot 43aee6db75 [I18N] Update translation terms from Transifex 2016-08-21 00:40:51 +02:00
Jeremy Kersten 54e4f3f96b [FIX] web: allow to use content_disposable without registry
When a user connect to /web/database/manager directly without the
login page before, the request don't have registry.
When the user click to backup a db, a traceback was raised:
    return request.registry['ir.http'].content_disposition(filename)
    TypeError: 'NoneType' object has no attribute 'getitem'
Because it was impossible to call content_diposable from ir_http
without registry.

Now content disposable has been moved in http.py and is callable from
anywhere.

This commit closes #13192
This commit closes #11583
2016-08-19 18:31:01 +02:00
Damien Bouvy d7939282e9 [FIX] mass_mailing: avoid too long URIs by blacklisting fields in editor call
The call to the web_editor is made through an iframe with some get
parameters. While not really a problem in itself, this has the
disadvantage of generating long URIs. In some case, since all the
fields in the views are included as a GET parameter, URIs can be
generated that go up to several thousand characters. Most servers will
return a 414 for such URIs, preventing the edition of the mail
template in the view.

To avoid this problem, this commit extends the 'html_frame' widget and
blacklist 2 fields that can get too long once encoded.

Ideally, it would probably be better to stop sending all the fields and
simply add the *needed* fields one by one, but since it's difficult to
know exactly what fields might be needed and this is stable, I'm gonna
go with this 'workaround' but conservative fix.

opw-685646
2016-08-19 17:13:34 +02:00
Christophe Simonis 58cbcbae31 [MERGE] forward port branch saas-6 up to 787a32b 2016-08-19 16:35:22 +02:00
Christophe Simonis 787a32bdaf [MERGE] forward port branch 8.0 up to ee846fb 2016-08-19 16:27:06 +02:00
Christophe Simonis ee846fbff8 [FIX] core: exception are made to be raised 2016-08-19 15:59:10 +02:00
Christophe Simonis ef1386a7d2 [FIX] core: correctly load sql file when updating modules
Do not dumbly parse sql queries by splitting on `;`. PostgreSQL will do
a better job than us...
2016-08-19 15:48:36 +02:00
Aristobulo Meneses 5e7d23f1be [FIX] website_slides: Set file size limit to 25MB to match web module limits
This commit closes #13223
This commit closes #13225
2016-08-19 15:34:58 +02:00
Jeremy Kersten 0d491775c5 [FIX] web: don't duplicate alert while backup
When you backup 3 dbs with the database manager, you had 3 times the warning.

Underscore is not loaded, so _.once not available.
This commit closes #13173
2016-08-19 15:34:58 +02:00
Martin Trigaux 0122c05eff [FIX] web: avoid report with invalid sheet name
This commit does not fix any bug in odoo/odoo but helps fixing #12788
Needed for odoo/enterprise#433
2016-08-19 15:28:27 +02:00
Christophe Simonis f571ba373a [MERGE] forward port branch saas-6 up to 826472d 2016-08-19 12:56:08 +02:00
Christophe Simonis 826472dc48 [FIX] account_asset: correct typo in function name 2016-08-19 12:45:11 +02:00
Christophe Simonis e5371329f7 [MERGE] forward port branch 8.0 up to 08ed48e 2016-08-19 12:07:14 +02:00
Goffin Simon acc7449df1 [FIX] stock: action_done with moves with pack operation
When action_done is called with moves without pack operation, the pickings
linked to the computed moves must be in state done and the date_done must
be set on each picking.

opw:685145
2016-08-18 15:10:42 +02:00
Damien Bouvy 08ed48e24c [FIX] stock,purchase: stop shortening picking type names
In purchase, a special key is set in the context to simplify the name
of the picking type: instead of the normal name, only the name of the
warehouse is used. This is problematic if more than one incoming picking
type exists for a given warehouse, as it prevents you from being able to
differentiate them. Asking users to modify the view to remove the
context key seem a bit too much to ask for something that should be
simple.

It is my understanding that this was implemented only for cosmetic
reasons, but I am willing to assume that having to select
"YourCompany: Delivery Orders" instead of simply
"YourCompany" for people who only have one picking type should not
be too disruptive or obscure.

opw-685751
2016-08-18 13:59:42 +02:00
Goffin Simon c0bb312a26 [FIX] warning: Products with Blocking Warnings can still be added to Sales Orders
Like in 8.0 when adding a product with a blocking message in a SO line, a warning
message must be raised and the product is not added.

opw:685928
2016-08-18 13:22:34 +02:00
Goffin Simon c844534f8a [FIX] account_asset: asset depreciation with refund
When an asset is created from a refund invoice, the negative amount
must be taken into account to create the depreciation moves.

opw:685630
2016-08-18 11:11:49 +02:00
Nicolas Martinelli 354017b805 [FIX] mrp: duplicate product code
The BOM Structure report shows the product code twice.

opw-684520
2016-08-17 16:16:29 +02:00
Raphael Collet d32871570a [FIX] base: extrapolate table name on uninstall for ir_model_constraints
When uninstalling a module, the model *may* be removed from the registry
before the removal of the model constraints; to prevent crashing in
those cases, a simple replace('.','_') on the model name should allow to
obtain the table name in these cases.
2016-08-17 15:21:26 +02:00
Nicolas Martinelli 19e556b34f [FIX] website_form: traceback when sending an attachment
The form builder offers the possibility to add a "Custom File Upload"
field. When the user clicks on "Send", an error occurs ("An error has
occured, the form has not been sent.").

This is because we try to send a mail linked to "mail.mail", which
doesn't make sense.

The case was actually taken into account in the code, there was just an
oversight in the code.

opw-684040
2016-08-17 14:52:10 +02:00
Cédric Snauwaert 5b4404f628 [FIX] account: optimize the bank reconciliation widget + add of a button to auto-reconcile instead of auto-reconciling directly when opening the widget.
* This new button is a behavior change, but this is needed for big databases with a lot of statement lines to process. Indeed, in that case we prefer to load the widget as soon as possible and thus let the user process the lines manually or click on that button (but at that time he knows why it takes time).
* Opimization of various method in order to speed reconciliation and view opening : added indexes, direct use of sql queries...and also removed the code that was looping on open debit/credit to propose a sum of entries to match the statement line's amount, because it was a little greedy and wouldn't give accurate results most of the time.
2016-08-17 14:23:08 +02:00
Denis Ledoux 8787476b50 [FIX] web: fix DataSetSearch to avoid race conditions
This is a following of revision
ab8a93c852

This revision solves a new case:
when quickly performing a second search
after one which has not been resolved yet in a kanban view, and the second
search is resolved before the first, it was not possible to load the form
by clicking the card of the kanban, it leaded to a
`Could not find id in dataset` web client error

This was because the ids of the dataset were altered with
the ids of the first search (the one that lasted longer), while
the records displayed were the ones of the second search
(the one that finished first)

opw-682362
2016-08-17 12:26:16 +02:00
Martin Geubelle 5fce7847e1 [FIX] purchase: fiscal position in multi-company environments
Properties depends on with which companies the records
are browsed.

When retrieving the fiscal position as sudo (from a cron), we should force
the company from the context.

After https://github.com/odoo/odoo/commit/4162b8f as the context is force in get_fiscal_position,
we should call this method with a company (and not pass the company in the context).
This has been forgot in https://github.com/odoo/odoo/commit/fe92dea

opw-684802
2016-08-17 11:51:50 +02:00
Nicolas Martinelli 717ca3390f [FIX] base_import: error message
During the import of a file, if the connection is closed (timeout,
server shutdown...), a traceback appears.

This is because `error.data.arguments` is not defined in this case.

opw-682104
2016-08-17 11:43:17 +02:00
Martin Trigaux 907f9554d4 [FIX] account: update outdated account.pot file
Fixes #13149
2016-08-17 10:31:25 +02:00
Martin Trigaux 48366920d3 [FIX] hr_expense: update the outdated .pot file
Fixes #13149
2016-08-17 09:56:46 +02:00
Goffin Simon 3846d35d02 [FIX] account_voucher: unreconcile with deleted journal items
Inspired from e2d16ea

When cancelling a voucher from a customer payment receipt,
the voucher lines linked to the deleted account move lines
have to be updated by clicking on button "unreconcile".

opw:683258
2016-08-17 09:25:01 +02:00
Nicolas Martinelli 13f164049a [FIX] procurement_jit: reassign if waiting
Use case:
- Have a stockable product A, with enough quantity on hand
- Have a stockable product B, without enough quantity on hand but
  configured on "Make To Order"
- Create a SO, confirm.

The picking is in status "Waiting Availability", althought one product
is available. The picking should be in "Partially Available", which is
actually the case if we simply "Reserve" it manually.

opw-683974
2016-08-16 16:05:08 +02:00
Damien Bouvy 6cb84a1048 [FIX] analytic: add missing context propagation
Courtesy of @adrienpeiffer
2016-08-16 15:11:31 +02:00
Nicolas Martinelli c2fe9fe0e6 [FIX] web: prevent double-click on statusbar
When double-clicking on the statusbar widget, two calls to write are
performed. This can cause unwanted behavior, and when the `write` method
takes a lot of time to process, it's not possible to prevent it
server-side.

Courtesy of @gurneyalex and @aab-odoo

Closes #13134
opw-686025

FORWARD-PORT UP TO SAAS-6!
2016-08-16 13:09:49 +02:00
Nicolas Martinelli 0350ab81b8 [FIX] web: prevent double-click on statusbar
When double-clicking on the statusbar widget, two calls to write are
performed. This can cause unwanted behavior, and when the `write` method
takes a lot of time to process, it's not possible to prevent it
server-side.

Courtesy of @gurneyalex and @aab-odoo

Closes #13135
opw-686025
2016-08-16 13:06:03 +02:00
Odoo Translation Bot 71594f5958 [I18N] Update translation terms from Transifex 2016-08-14 03:04:34 +02:00