Commit Graph
102060 Commits
Author SHA1 Message Date
Goffin Simon 978b8f64ec [FIX] sale: onchange on 'note' in a sale order
When website_quote is installed, the Terms and Conditions of the quote
template should replace the Terms and Conditions of the company.
But if T&C of the company is not filled, it will keep the note written.

opw:683543
2016-07-19 14:36:50 +02:00
Goffin Simon 02d686f9e1 [FIX] account_set: ensure_one in compute_depreciation_board
An error was raised when trying to call compute_depreciation_board with
a recordset containing more than one record.

opw:683341
2016-07-19 09:09:57 +02:00
Wolfgang Taferner 05645343c3 [FIX] account: fix typo introduced by forward-port
Broken by forward-port 3cdcc670fc

Fixed by using correct model and method name.

Closes #12818
2016-07-18 19:46:56 +02:00
Olivier Dony 36e875e796 [FIX] ir.http: make browsers trust our mime types
We determine the mime types of the files we server
automatically + manually, and browsers should not
try to second-guess it.

Browser mime-guessing is there for the myriads of
badly configured web servers out there.
2016-07-18 19:44:37 +02:00
Olivier Dony 82142475f7 [FIX] mail,base: import XML attachments as text 2016-07-18 19:44:37 +02:00
Olivier Dony 399e2bcf6d [FIX] ir.attachment: simplify xhtml-like mimetypes matching
Simplify/complements revision f6090e69e6,
forcing text/plain for xml-like files.

Ignore forced `mimetype` when downloading attachments, if the model
has its own mimetype or if we can guess it.
`default_mimetype` still available as a fallback.

See also the list of mimetypes supported by common browsers, e.g.:

 - Firefox: CParserContext::SetMimeType in:
    https://hg.mozilla.org/firefox/file/default/parser/htmlparser/CParserContext.cpp

 - Chrome:  kSupportedNonImageTypes constant:
    https://cs.chromium.org/chromium/src/components/mime_util/mime_util.cc?sq=package:chromium&rcl=1467904650&l=89
2016-07-18 19:44:37 +02:00
Goffin Simon 6cf275cc6b [FIX] account: Computation of a fixed amount tax
When an order with a fixed amount tax was returned the sign of the tax
was wrong because amount_base was negative and quantity was negative too,
then the tax was positive due to math.copysign(self.amount, base_amount) * abs(quantity)

The sign of the base amount already takes into account the the sign
of the quantity.

opw:682407
2016-07-18 12:51:16 +02:00
Goffin Simon fbca56111b [FIX] account: sign of a fixed amount tax
The sign of a fixed amount tax must be the same as the base amount.
Inspired from the computation of a percent tax.

opw:682407
2016-07-18 09:39:06 +02:00
Goffin Simon 9df6f6d576 [FIX] sale: making an advance payment in percent
When making an advance payment in percent, the function onchange_advance_payment_method
set the Down Payment Product to False. Then each time an advanced payment in percent
was made, a new down payment product was created and set in sale.config.setting in the field
deposit_product_id_setting.

Now the function onchange_advance_payment_method let the Down Payment Product
even if the payment method is in percent.

opw:683167
2016-07-18 09:14:35 +02:00
Odoo Translation Bot 691949c4b8 [I18N] Update translation terms from Transifex 2016-07-17 00:30:21 +02:00
Martin Trigaux 290e73f22d [FIX] base_setup: warn users about enterprise module
inter_company_rules is an enterprise module and can not be installed in
community version.
Disable the installation and warn the users about it.

Fixes #12800
2016-07-15 18:02:49 +02:00
Christophe Simonis fd9eb2e481 [MERGE] forward port of branch saas-6 up to e928c60 2016-07-14 16:23:22 +02:00
Christophe Simonis e928c6003a [MERGE] forward port of branch 8.0 up to 17a1304 2016-07-14 15:46:28 +02:00
Denis Ledoux 8d2d741db3 [FIX] mass_mailing: do not inherit a view on a string attribute
A string attribute value can be translated,
and therefore the inherit broken if the term is indeed
translated.

This was the case for this term "Tracked link" in the Dutch
language, the "Tracked link" term of the inherited view has
been translated, and the inherit was therefore broken as
it couldn't find the given node in the base view due to the
fact this term was translated.

opw-683128
2016-07-14 12:25:02 +02:00
Ronald Portier 17a1304285 [FIX] hr_timehseet_sheet: drop view before creation
When the schema of a view change (e.g. drop of column), the "CREATE OR REPLACE"
will not be enough and dropping the view is required.

Fixes #12754
Closes #12756
2016-07-14 11:42:52 +02:00
Goffin Simon 46c3c721fc [FIX] sales_team: _get_default_team_id
The domain term '('member_ids', 'in', False)' should use the '=' or '!=' operator.

sentry:90136545
2016-07-14 09:12:13 +02:00
Christophe Simonis a039fc509b [MERGE] forward port of branch 8.0 up to 9650249 2016-07-13 17:26:44 +02:00
Damien Bouvy 8cad4ce011 [FIX] web_settings_dashboard: user count consistency
Odoo S.A. invoices only 'non-share' (internal) users; the default
filter on the user list view does the same thing. It makes little
sense for the user counter to count all share users.
2016-07-13 16:58:31 +02:00
Joren Van Onder c902437247 [FIX] barcodes: allow users to 'click' focused buttons with Return
Return key events don't get redispatched and even if they did, it
wouldn't work because 'fake' keypress events don't trigger native HTML
event handlers.

This should be safe because Return cannot start a valid barcode.
2016-07-13 13:58:50 +02:00
Joren Van Onder 4dc228d01c [FIX] stock: don't show empty Reserved group
We hide the quants_grp if the stock.move is in the draft state. In this
case normally the value of the string_availability_info will be empty
anyway, because the _get_string_qty_information function skips moves in
the draft state.

This is especially useful on small displays, because on there the string
attribute of the field won't be shown, so you just end up with a
Reserved heading with nothing underneath it.
2016-07-13 13:58:50 +02:00
qdp-odoo bf999c168a [IMP] account: added 'form' mode in the action returned by clicking on the 'Journal Items' stat button on payments and bank statements, because it was so boring not being able to see the details or open the account.move from that view 2016-07-13 11:22:10 +02:00
qdp-odoo 2d91575b11 [FIX] account: cancelling a bank statement line linked to a payment SEPA or batch deposit should set it back to 'sent' state, not 'posted'. 2016-07-13 10:00:07 +02:00
Jairo Llopis 0529a7f9ba [FIX] tools: extract terms in correct folder
If two addons path have a common part in the folder name (e.g. `/home/alice/dev`
and `/home/alice/devodoo`), the `get_module_from_path` method may match the
wrong folder.
A file `/home/alice/devodoo/bob/models.py` would wrongly match `/home/alice/dev`
path (due to the lack of separator) and the returned module would be `odoo`
(`"odoo/bob/models.py".split('/')[0]`).

In such scenario, the translations of files (code, static folder, report) would
not be included in the exported translation file.

Force the module path to ends with a folder separator to avoid wrong matching.

Closes #12757
2016-07-13 09:43:38 +02:00
Jairo Llopis ee365bbf98 [FIX] modules: choose the right addons path
When launching a server with two similar addons path, e.g.:
- /home/alice/dev
- /home/alice/devodoo

launching the server in dev mode may crash due to the poor matching using
`path.startswith(...)` method which may make `/home/alice/devodoo/bob/main.xml`
match in addons folder `/home/alice/dev` and with a non-exitant local path
`odoo/bob/main.xml`.

Instead of relying on the name, use the `os.path.commonprefix()` method to match
on real paths and avoid partial matching.
commonprefix will only work if the folder name ends with the appropriate
separator (which is not guarantee for a user provided addons-path) so force a
trailing `/` using os.path.join(..., '')`.

Closes #12359
2016-07-12 17:21:50 +02:00
Damien Bouvy d7d07810aa [FIX] hr_timesheet_sheet: no product on employee
Some leftover code from before.

opw-683126

Courtesy of David Coninckx
2016-07-12 16:30:56 +02:00
Vincent Renaville c9b270c9a4 [IMP] l10n_ch: extend minimal chart of account. Was PR #12552. Courtesy of CamptoCamp 2016-07-12 12:15:57 +02:00
Damien Bouvy f600366092 [FIX] point_of_sale: correct previous fix
I inadvertently inverted the domains; silly me.
2016-07-12 09:26:01 +02:00
Damien Bouvy 47bb1cf44d [FIX] point_of_sale: session access rules
You should not be able to see a pos.session if its pos (config_id)
is not available to you.
2016-07-12 09:22:19 +02:00
Goffin Simon 3ea1ac7e0d [FIX] website_slides: changing channel_id on slide.slide
Steps:
-Go into Slides (into Website Admin main menu)
-Find the Slide "Odoo Explained"
-Change the channel to "Employee Channel"
-Disconnect or open a private session
-Go to the menu "Presentations" on website
-Click on "Public channel"

Bug:

Error 403

Fix:

When changing the channel_id of a slide, the custom_slide_id of all
the channels using this slide as "Slide to Promote"  has to change
in False to avoid access rights errors.

opw:682063
2016-07-12 09:01:25 +02:00
qdp-odoo 2f3249d688 [FIX] account: fixed get_pair_to_reconcile() in case there is a manual reconciliation done via the wizard on an account that has a secondary currency set. In that case, the currency to consider is always given by the special key 'skip_full_reconcile_check' in the context. OPW 682368 2016-07-11 17:47:17 +02:00
Goffin Simon 965024902d [FIX] delivery: Invoice line for delivery method
Steps to reproduce:

1. Activate the following options
** Settings > Warehouse > Products > Manage different units of measure for products
** Settings > Accounting > Accounting & Finance > Analytic accouting
2. Desactivate the following option
** Settings > Accounting > Analytic accouting > Sale > Use multiple analytic accounts on sales
3. Create a Sale order
** Add 2 qty of the product iMac
** Add in quote the delivery method "Normal Delivery Charges" and set 2 qty
** Set an analytic account under Contract/Analytic
** Set the field Create Invoice to "On delivery Order"
4. Deliver only 1 quantity of the iMac and then create the invoice
5. Deliver the last quantity of the iMac and then create the invoice

Behavior before the fix:
The first invoice contains 2 qty of the Transport
The second invoice contains 1 qty of the Transport, has no analytic account set, has no UOM set

Behavior after the fix:
The first invoice contains 2 qty of the Transport
The second invoice contains 0 qty of the Transport because it has already been invoiced

Closed #12644

opw:682284
2016-07-11 14:30:16 +02:00
Odoo Translation Bot ef83f798d5 [I18N] Update translation terms from Transifex 2016-07-10 03:01:32 +02:00
Odoo Translation Bot 5a73ff2f1f [I18N] Update translation terms from Transifex 2016-07-10 00:30:32 +02:00
Damien Bouvy 8c3b976923 [FIX] purchase: avoid scheduler crash if PO without lines exist
When a procurement needs to create purchase order lines due to
reordering rules and if an empty PO exists for the vendor of the
product, the creation of the PO line will crash since there is
no scheduled date on the PO.

opw-675706
2016-07-08 17:12:18 +02:00
qdp-odoo 68f0b8fe4e [FIX] account: bank reconciliation was auto-reconciling undistincly debit lines on bank accounts with negative amounts and/or credit lines with positive amounts where only one field (debit/credit) should be checked if the amount is positive/negative. 2016-07-08 17:03:25 +02:00
Christophe Simonis 5949eedfdb [MERGE] forward port of branch 8.0 up to 0c3cd7cb 2016-07-08 16:32:10 +02:00
Christophe Simonis 4bf9622901 [FIX] event,hr_holidays: add missing dependency to report module 2016-07-08 16:28:26 +02:00
Denis Ledoux 0c3cd7cbb4 [FIX] website_hr_recruitement: website desc translation
Backport of the revision
26c44a58df

opw-682716
2016-07-08 10:14:10 +02:00
Nicolas Martinelli 6a3cf82130 [FIX] account: unnecessary default currency
A mechanism already exists to select the appropriate currency and was
introduced in commit 1b04b1d. However, it requires a purchase journal in
the currency of the PO to work.

Note that this commit is likely to not work correctly since the method
`_onchange_journal_id` is triggered after `_default_currency`.
Therefore, even if the currency is correctly set in `_default_currency`,
it is changed to the journal currency right after.

This reverts commit 7f1d7c1cce.
2016-07-08 09:56:20 +02:00
Jeremy Kersten ba598c0e0b [FIX] website: css fix for Promote / Optimize SEO
Before the commit, the dt was forced to 160px of width by bootstrap.
Now we allow this size to be bigger, to avoid glitch in UI.

When you was inserted a long keyword, the 'delete' button was in the
overflow hidden part and so was undeletable.

We set min-width by default to 160px to keep the same behaviour by default.
And see 2 columns, but if a keyword it too long, we display it, and 'break'
the column style.

This commit closes #12703
2016-07-07 16:00:07 +02:00
Goffin Simon 8e233767b5 [FIX] point_of_sale: user_ids field in Pos Details report
A POS manager has the rights to add users in Sale Details

opw:682259
2016-07-07 15:35:24 +02:00
Goffin Simon c7c394939a [FIX] hr_payroll: creation of a salary computation line
To create a payslip line the fields:
-employee_id
-contract_id
-salary_rule_id

are required.

opw:681912
2016-07-07 15:14:25 +02:00
Christophe Combelles e38947989a [FIX] setup: backport of 6ceb0a2b1b
[FIX] setup.py: pyparsing version inconsistent with requirements

Fixes #12693
2016-07-07 14:05:20 +02:00
Nicolas Martinelli 2bf8a6541b Revert "[FIX] hr_recruitment: incorrect recruitment report"
So @sig-odoo is not the only one to revert his own fixes :-)
Anyway, we want to be able to get statistics about archived applications
as well.

This reverts commit 7e0e27ea79.
2016-07-07 12:39:59 +02:00
Christophe Simonis 45fc5f7a8f [I18N] web: change term after 3888301a2e 2016-07-07 12:38:05 +02:00
Denis Ledoux b329d6219e [FIX] hr_attendance: Attendance Error Report fail afer upgrade
After upgrading the `hr_attendance` module,
it was no longer possible to use the
`Attendance Error Report` link in the `More`
menu of employees.

This is because there were two binding actions
added in the code under the samename
(`Attendance Error Report`):
 - `hr_attendance_error_values`
 - `action_report_hrattendanceerror`

The first launch a wizard which will print the report
after filling the required data,
The second tries to directly print the report, but it
fails because required data (from the wizard) is missing.

Before update, it's the first binding action that was displayed.
After update, it was the second, which failed.

We solve this issue by changing the way the report is
created through the data, by not using a `<report/>` tag,
this one creating automatically the action binding.
Instead, we use a classic `<record/>` tag, which
doesn't create automatically the action binding.

opw-682720
2016-07-07 12:29:54 +02:00
Fabien Pinckaers 3888301a2e [IMP] web: Quantity is very misleading in reporting views --> e.g. SO Line Quantity is perceived as Quantity of products, whereas it's the count of SO Lines. Renaming to Count 2016-07-07 12:28:57 +02:00
Nicolas Martinelli 7e0e27ea79 [FIX] hr_recruitment: incorrect recruitment report
The recruitment report used in the pivot view does not filter out the
archived records.

opw-682119
2016-07-07 11:35:52 +02:00
Goffin Simon a082ec6aea [FIX] sale: Expenses in multi currency
Steps to reproduce:

-Set your company in USD
-Create a SaleOrder with a pricelist in EUR
-Create an expense in USD, with the analytic account of the SO
-Confirm the expense and post journal entries.

Bug:

The unit price of the new SO line was wrong: it was stil in USD as in
the expense.

Expected behavior:

The price unit must be converted in EUR

opw:682378
2016-07-07 11:31:54 +02:00
Nicolas Martinelli a1c3fe1291 [FIX] crm: opportunities list view
When the lead step is activated (`group_use_lead` is true), 2 dinstinct
tree views can be selected to display the opportunities.

Indeed, when the action "Your Pipeline" is selected, the tree view
`crm_case_tree_view_oppor` is displayed thanks to the method
`action_your_pipeline`. However, when the page is reloaded or the tree
view is saved in the custom dashboard, the tree view
`crm_case_tree_view_leads` is selected instead.

The fix is to specify explicitly in the action which view should be
chosen, accordingly to what is done in method `action_your_pipeline`.

opw-681488
opw-681734
2016-07-06 17:25:15 +02:00