Steps to reproduce
==================
- Go to Project > My tasks
- Drag a card to another column
-> An error occurs
Cause of the issue
==================
`personal_stage_type_ids` was not changed to `personal_stage_type_id`
opw-3036820
closesodoo/odoo#104442
X-original-commit: 3afc32af953556227dc07f8c65b5301d10fa92fe
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>
Also correct mistake in name of RDC in manifest.
Modification in the COA (clearer name) + change made on some account about reconciliation, before this commit there was way to much reconcilable account, it's now corrected
Demo company modified
Menu item added
closesodoo/odoo#104440
Task-id: 2350061
X-original-commit: 0caa35df57061576ffb14252b08379a382e39ef9
Related: odoo/enterprise#33372
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com>
Steps to reproduce:
In a base runbot with just contacts installed and the module
"account_edi_ubl_cii".
Go to contacts, Configuration, and Bank Accounts, try to create a bank
account for any user.
Issue:
The creation throws an error and doesn't let us create any bank account.
Solution:
We need to add the missing decorator: @api.model_create_multi, which is
needed when we work with vals_list.
opw-3039048
closesodoo/odoo#104427
X-original-commit: e83da6166da40f5c30c396e6aa9811c8ee1d0e6e
Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>
Since we introduced in 15.0 the possibility to limit the number of
product loaded at the launch of the POS and to load the remaining ones
in background, we don't need anymore a cache of the products to have a
faster way to start the POS.
So we remove this module as it won't be needed anymore.
closesodoo/odoo#104423
Related: odoo/upgrade#3997
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>
- Changes the tooltip of the account_prefix field
- Changes the name of the analytic_distribution field
- Changes the name of the group for the conditions
- Changes the size in the analytic_distribution_model_views of the analytic_distribution field
- Changes the name of the group for the analytic distribution field
closesodoo/odoo#103636
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
Without this, it will simply ignored the given `_text` variable as the
t-nocache part is scroped. It means it can't access natively the
variables outside of its scope unless those are passed to the scope
through the `t-nocache-var_name` form.
Basically, it resulted in the "My Cart" never shown next to the cart
badge counter.
Most of the time, this text is used in replacement of the `fa` icon, so
it led to poor UI: a floating badge left alone.
task-3044936
closesodoo/odoo#104416
X-original-commit: cd50114cc422941920ff4d579ab6b48aae75cc6a
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>
Since the settings in POS have been moved to the general settings, we
have two way to access those general settings. First throug the general
settings, second when you open the shortlist of settings editable by
every pos manager and follow the link to the general ones.
In the second case, when we arrive into the general settings, the
settings displayed are not always the one of the POS config you come
from, because by default it only show the settings of the latest pos
config editted.
So we are now checking if we are comming from a pos config to display
the correct one.
closesodoo/odoo#104391
X-original-commit: b0df10c1e497f65b891f7141055e7f339d11b4b1
Signed-off-by: Masereel Pierre <pim@odoo.com>
The payment terms printed on the invoice are ordered by date.
However, the order was applied on the string version of the date, which caused issues.
Fixed this by formatting the date to string after the ordering.
closesodoo/odoo#104388
X-original-commit: c6bc6284c390659d40a329c3b7b000579ed7c23b
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Camille Spiritus (casp) <casp@odoo.com>
Before this commit, the payment journal could be not set when starting
Stripe Connect onboarding from the settings of Website.
Now, the payment journal will be set, even if the onboarding was started
from the settings of Website.
closesodoo/odoo#104387
X-original-commit: f51ec823fde7580d078dd4769570d445e60e05bb
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: Valentin Chevalier <vcr@odoo.com>
This commit purpose is to ensure that projects created from a SOL
are created with `allow_billable` set to `True`
task-2992614
closesodoo/odoo#104386
X-original-commit: b9cecb5a77b02542a06f144a01b6f1f90b873c96
Related: odoo/enterprise#33356
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
Steps to reproduce the bug:
- Create a storable product “P1”
- update the quantity to 10
- Go to inventory > configuration > warehouse Management > location
- Select your location > current stock
- Search the Product “P1”
Problem:
In `stock.quant’ list view > the available qty is displayed, but if you
click on the line, the available qty is not displayed in the form view,
only the qty counted is displayed
opw-3018469
closesodoo/odoo#104374
X-original-commit: d956e719d43c68abe6210e3136db576aaa6f60b8
Signed-off-by: Steve Van Essche <svs@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>
Steps to reproduce the bug:
- Create a Storable product “P1”:
- UOM: unit
- Update the qty to 100
- Create an out transfert:
- Product: P1
- Qty: 2
- UOM: dozens
- Validate the transfert
- Click on the valuation button
- an SVL is created with Qty: 24 → 2 pack of 12
- Go back to the picking:
- Unlock it
- change the done qty from 2 to 3
- Lock the picking
Problem:
The quantity on the new SVL is not converted to the default UoM set on
the product.
In the write function of `stock.move.line` we calculate the difference
between the old and the new qty (3 - 2), then, the
`_create_correction_svl` is called:
https://github.com/odoo/odoo/blob/15.0/addons/stock_account/models/stock_move_line.py#L45-L48
without converting the diff qty into the product uom,
The `_create_out_svl` function is called with the `forced_quantity`
parameter:
https://github.com/odoo/odoo/blob/15.0/addons/stock_account/models/stock_move_line.py#L66
As it is a forced quantity, it will not convert it:
https://github.com/odoo/odoo/blob/14.0/addons/stock_account/models/stock_move.py#L188
Solution:
Convert diff qty in the `_create_correction_svl`, to avoid converting it
in every function it may call
opw-3041279
closesodoo/odoo#104371
X-original-commit: 30aaa668c46f899ed05dee2b6d2f810aa1e6e2e4
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>
Description is the label on invoice : tax rate is enough.
Align Finland on Odoo's new taxonomy, already available in BE
G = Goods, S = Services, IG = Investment Goods
Less active taxes for a smoother onboarding
Steps to reproduce:
- Install finish Finnish Localization(l10n_fi) module,Accounting
- Verify accounting taxes (brutto: 24%|14%|10%)
price_include checkbox is deselected
Issue:
Price_include field set to False
Cause:
Field in locale template view not defined, model defaults to False
Solution:
Field defined in tax template data and set to True for locale
opw-2992952
closesodoo/odoo#104356
X-original-commit: b67ea341d0d1967428d6e1469e194b7c976029f2
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
The dynamic placeholder result was not added in the
editable dom in some situation. When the editor was
in rollback mode `true` after a `commitChange`
( maybe because of a `_toInline` called) the result
of the dynamic placeholder was rollback.
task-3044924
closesodoo/odoo#104343
X-original-commit: e9bd4f020ff4a5dd4240fde9caef0bded9a2e28c
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Geelen Sébastien (sge) <sge@odoo.com>
The current test is based on demo data making the file red on runbot for nightly build when a localization is installed.
In order to deal with localizations, all tests must implement the accounting AccountTestInvoicingCommon class.
X-original-commit: 05509e63a7061e56b67015270d20f0c7089bdb6f
Part-of: odoo/odoo#104389
There is a check done during the receipt generation in the pos that
checks the country code of the company, assuming it is set. But it
is possible to have a company without a country set so we need to handle
this use case.
X-original-commit: 19849c61f0f8b1cb3ddc588885953158482a079f
Part-of: odoo/odoo#104389
The current test is based on demo data making the file red on runbot for nightly build when a localization is installed.
In order to deal with localizations, all tests must implement the accounting AccountTestInvoicingCommon class.
X-original-commit: 3611aaf0983b3d25822022ebeddd781f6d082bf7
Part-of: odoo/odoo#104389
When having only invoicing but being in multi-currency, the journal is not visible but "in USD" is displayed.
X-original-commit: e813b559121792f03f555b1126f5627570913b96
Part-of: odoo/odoo#104389
Before this commit, while creating/editing a task, the
description field height is not increase to use the remaining
space until the bottom screen in the project task form view.
This commit uses `FormRendererWithHtmlExpander` component as
renderer for that form view (as it is the case for the project
and project update form view to increase the description field)
and override `htmlFieldQuerySelector` getter to select the
right tag containing the description field.
task-2987387
closesodoo/odoo#104259
X-original-commit: b4873875cb687c7d09474dee146274cda1cb910a
Related: odoo/enterprise#33297
Signed-off-by: Xavier <xbo@odoo.com>
Before this commit, when the portal user is in `/my/tasks` route
and he remove the groupby and search a certain task name and no
task is found with his search, a traceback is occurred saying `task`
is not found to be able to evaluate the following lines:
```xml
<t t-set="timesheet_ids" t-value="task.sudo().timesheet_ids"/>
<t t-set="is_uom_day" t-value="timesheet_ids._is_timesheet_encode_uom_day()"/>```
in the portal template.
This commit fixes the issue by changing the xpath to be sure the task
variable is defined before evaluating task.sudo().timesheet_ids.
Moreover, this commit checks if there is any task in tasks before
displaying tbody to avoid having any scrollbar for nothing.
task-2987387
X-original-commit: 9d0b770aebaf3c9c08352bf11fb9fdf2a36f1523
Part-of: odoo/odoo#104259
If the check for messaging happens after switching from channel to starred
(where there is no composer) it would crash when using `this`.
closesodoo/odoo#104392
X-original-commit: d3091762cc5769ed13b5a828769bcd03f440a8f8
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
If an applicant goes through the salary configurator
to create his contract, the employee created will not get
the associated sign requests nor the skills as it is working
now when creating an employee from the "create employee"
button on the applicant page.
Also fixes:
- a traceback obtained on the salary configurator
when having hr_contract_salary installed and
not hr_work_entry_contract
- a traceback obtained while trying to access an applicant
form while in debug mode
task-3002185
closesodoo/odoo#104320
X-original-commit: 20d5de3490baaab62715fe0f4f2a9a48dc248d55
Related: odoo/enterprise#33332
Signed-off-by: Kevin Baptiste <kba@odoo.com>
When using the "Apply All" button to make inventory adjustments, a
wizard is opened to choose a name. Then, this wizard calls the quant's
`action_apply_inventory` method but doesn't return it.
But sometime, this method doesn't apply immediately the inventory but
ask for confirmation before (e.g.: trying to "Apply All" with quants for
tracked product but without lot/serial number).
In these cases, the "Apply All" does nothing.
closesodoo/odoo#104307
X-original-commit: e555333cf3ca2511df55105a027ca52e55c13774
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
removeContextUserInfo was a Spreadsheet asset, which is not a dependency of
Knowledge.
In order to make this feature available for all modules, it is moved in web as
an object util, that needs to be used alongside the user service in order to
dynamically remove user context information (no hardcoding).
Task-3017349
closesodoo/odoo#104304
X-original-commit: fd88fc1bbad4c0cdb44cf634b6a5621eb7597e0d
Related: odoo/enterprise#33322
Signed-off-by: David Beguin (dbe) <dbe@odoo.com>
This join is a leftover from https://github.com/odoo/odoo/pull/28248
and is not needed anymore since currency_rate is now stored on purchase.order.
Removing it allows to greatly speedup purchase.report queries.
On a database with 7000 purchase order and 1100 res_currency_rate:
From:
Planning Time: 4.411 ms
Execution Time: 19815.754 ms
To:
Planning Time: 16.914 ms
Execution Time: 77.433 ms
opw-2973044
closesodoo/odoo#104301
X-original-commit: 4ffa967eecfd930da7a0051122ed746af38ce709
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Previously, if there were module loading errors, they would typically
happen before the error service was ready, and so there is almost always
no user-facing error that shows up even though the application state may
be severely corrupted. This can be very confusing for developers who are
not used to working with JS and might not check the devtools console.
This commit makes it so that the module system will replace the contents
of the body with an error when some modules were unable to be loaded,
with the list of modules and the reason, so that the developer is not
confused as to why things aren't working as expected.
closesodoo/odoo#104155
Signed-off-by: Samuel Degueldre <sad@odoo.com>
Clicking on a smart button on the project button to access invoice/bill returned a traceback.
It was because the fields in the ORDER of the query don't appear in the SELECT with the DISTINCT.
We just remove the order of the query, as it serves no purposes here.
opw-3040389
closesodoo/odoo#104303
X-original-commit: 71a2b06b9b4205c34a3869ddc67dd6d840a5eccf
Signed-off-by: William André (wan) <wan@odoo.com>
Steps to reproduce:
- set a price on the product form;
- set a base unit count on the product form;
- define at least a pricelist with an other price;
- go to website on the product page;
- change the selected pricelist;
- change the Tax-Excluded/Included option.
Issue:
The base unit price ignores the tax included option.
Solution:
Update the display of the base unit price taking into consideration that it is not possible to set the "base_unit_price" field (otherwise we risk an AccessError).
Calculate the base unit price using "list_price" (which takes into account the tax) when we need to display it without saving.
opw-2995474
closesodoo/odoo#104302
X-original-commit: b766d68287b73b70a784e7291c567fb2e59de0c3
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>
Signed-off-by: Lefebvre Thomas (thle) <thle@odoo.com>
In this commit we fix two tracebacks that are returned
when the user tries to click on the invoice/vendor bills smart
buttons in the "project updates" view.
Also added credit notes to the "invoices/vendor bills" smart button
of the "project update" view.
task-3033278
closesodoo/odoo#104300
X-original-commit: 4f1981fb54fe726801318ad66b941a20affa0d4a
Signed-off-by: Xavier <xbo@odoo.com>
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
The previously created company_details field was introduced to allow
customers to manually edit part of their pdf headers. Only the bold
layout was not updated with this field.
closesodoo/odoo#104299
X-original-commit: 16ece79ea5305a2e427024a43313096fa200901f
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
This is done so that using owl features and functions is done using
the standard import syntax, instead of destructuring properties out
of the owl global object.
So instead of just:
`const { Component } = owl;`
inside an odoo-module, we now do:
`import { Component } from "@odoo/owl";`
Note that we haven't removed the global `owl` object so existing
code will work as is.
Furthermore, we also augmented the tsconfig.json that's generated
from the tsconfig subcommand to take into account the path
of owl.js.
Task-id: 3032274
Part-of: odoo/odoo#104260
This commit aims to handle the belgian blackbox error properly just as the sweden blackbox do.
Add an error code of 701 to handle the error messages.
closesodoo/odoo#104233
Part-of: odoo/odoo#96583
X-original-commit: 7d1e52bcd11a1c20a6c6829c56d3fabe5b0f0fef
Signed-off-by: Masereel Pierre <pim@odoo.com>
When checking whether an element was removable or not, we failed to
check whether it was within the editable area. As a result it was
sometimes possible to accidentally delete something outside of it. To
reproduce the bug, insert a link in a blank editor, then press delete
repeatedly until the whole link is gone, and then one more time. This
deleted an element from Odoo's UI.
task-2993740
closesodoo/odoo#104268
X-original-commit: 55e4e0577ac8a62d57f759572b8a5e608c7582b2
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
The condition for multi-editing the partner has now changed.
The partner cannot be changed on a line that has parts in a
(partial) reconciliation.
closesodoo/odoo#104258
X-original-commit: 1b30777ab63998d1c0b64b655e717d74b3648bcf
Signed-off-by: William André (wan) <wan@odoo.com>
The current implementation of the many2one file upload in website form
will lead to a traceback in case of m2o fields.
It is currently only working with x2many fields. Note that it was
introduced as such with [1].
Step to reproduce:
- install website_sale
- drag & drop form snippet and click on it
- select "create customer" as action option
- add new existing field
- select "Main attachment" and save
- try to submit the form with a file uploaded in that new field
-> Traceback `ValueError: Wrong value for..`
This commit makes it work for all type of relational field.
[1]: https://github.com/odoo/odoo/commit/a77f5cf42faa75a2dd3931d83ad8ea86648248c0closesodoo/odoo#104241
X-original-commit: addea33a8cb6c47bacdbfad0f3082f88763b59ef
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Hubert Van de Walle (huvw)