Issue Description:
There is an issue in the project upgrade report where an expense with a related analytic account appears twice. This occurs once as "Expenses" and again as "Vendor Bills". This problem does not manifest on runbot with all apps installed, indicating a specific configuration issue.
The installation of the 'project_purchase' module resolves the issue, as the method "_get_already_included_profitability_invoice_line_ids" within both the "project_purchase" and "project_hr_expense" modules performs a check for an 'expense_sheet_id' in account moves. This check helps to exclude these entries from the profitability items, thereby preventing duplication. However, while this solution is effective, it leads to an undesirable addition of the Purchase app to the client's database, which is not acceptable for the client.
Relevant code sections: [project_hr_expense](https://github.com/odoo/odoo/blob/1fbcfdf69b503e77e1a931d23dd47df0daf8b2fe/addons/project_hr_expense/models/project_project.py#L70), [project_purchase](https://github.com/odoo/odoo/blob/1fbcfdf69b503e77e1a931d23dd47df0daf8b2fe/addons/project_purchase/models/project_project.py#L138C15-L138C15).
Steps to Reproduce:
1. Install Expense, Accounting, Project, Sales, Employees, Contacts apps on base runbot.
2. Create a service product with 'Prepaid/Fixed Price' and ensure 'Create an Order: Project & Task' is selected.
3. Create and confirm a sales order for the service product created in step 2.
4. In the Expenses app, create an employee-paid expense linked to the sales order's analytic account (e.g., Analytic Distribution: Departments > S00074).
5. Follow the process in the Expenses app by clicking on 'Create Report' > 'Submit to Manager' > 'Approve' > 'Post Journal Entries'.
6. Access Project Updates in the Projects app.
7. Observe that in the project profitability cost section, the same expense is listed twice under different labels: once as "Expenses" and once as "Vendor Bills".
Proposed Solution:
The proposed solution involves modifying the domain of the `_add_purchase_items` function within the `project_account` module, specifically at [this code section](https://github.com/odoo/odoo/blob/763f88e2d45cb7ba107db135eecd0365ba2b8c8b/addons/project_account/models/project_project.py#L14). The enhancement would entail adding a condition to the function's domain to exclude any IDs that are already present in the profitability report. This approach will efficiently prevent the double counting of expenses, ensuring that each expense is represented only once in the project profitability report, thereby maintaining accuracy and consistency in financial tracking. This solution focuses on enhancing the existing functionality with a targeted and efficient modification, ensuring minimal impact on other system components while effectively addressing the issue.
opw-3522293
closesodoo/odoo#149623
X-original-commit: 0902d57dd1653018d6ae72554b39e4e01fa4d6d7
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Ilya Rudy (ilru) <ilru@odoo.com>
As _compute_quantities_dict does use stock.move as a source of calculation
we need to make sure that the dedicated owner is set also on inventory
moves which was forgotten and resulted in wrongly computed quantities
in the past in case of such an use case.
closesodoo/odoo#149596
X-original-commit: 02d5c04e85e0bc1b9c0edf66969066ba4f2d769c
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Wolfgang Taferner <w.taferner@wtioit.at>
The user can define automated actions for sending data to a remote
server using a webhook.
To prevent this feature from sending unwanted data from a test database,
this commit neutralizes the field `webhook_url` to an invalid URL.
When the action is run, a warning is logged.
closesodoo/odoo#149592
Signed-off-by: Bouvy Damien (dbo) <dbo@odoo.com>
This reverts commit 185adf6fb487fa260bb6dfe985638bc545de7fa2.
The change was made to "fix" line breaks with rating feedback in
helpdesk. However, it's not ok to apply `inline` display layout
for all non-user made message body, as usual block display is
expected for html tags like `<div>` or `<p>`.
The correct fix should be to remove these unwanted `<br>` in the
feedback rating messages. We don't know how they appeared, but
this is a specific minor issue in helpdesk rating, so reverting
the fix is a higher priority.
closesodoo/odoo#149570
X-original-commit: 1ba04da76f391cd4543a8d3b1e6dbecf6a2cb558
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Currently the form sheet have a flex-grow-1, the chatter could use less
horizontal space to leave more space for the form sheet's content.
This commit widen the form_sheet by applying a flex-grow-2 and
reduces the chatter's top bar total width by removing the icons and
applying a sup tag on the micro information displayed aside the icons.
Since the icons are removed there is no need to test if the icon is
rendered with it's appropriate text anymore thus we can remove these
two lines. Additionally the `text-warning` on the span was unnecessary
since it's already applied on the button parent.
task-3641988
closesodoo/odoo#147136
Related: odoo/enterprise#53208
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Problem
---------
In the commit 24345812cb015e86f362f8c35176646239bfb803 (odoo), we
modified the extraction of attachment in such a way that mails coming in
a journal from aliases with several attachments create several invoices.
Due to the urgency of the task, the computation of whether an attachment
needs auto-extraction or not, has been skipped which failing some tests
that had been silenced. Linked PR #49816 (enterprise) fixes it. However,
as a comment on the said PR suggested, we should add a context key that
disable the auto-extraction.
Objective
---------
Add a context key that disable the auto-extraction and update commit
2bfe69be5c64743d0bf35793a427878170d0b3c6 (enterprise) to use the said
context key.
Solution
---------
1. Remove the override of the `_needs_auto_extract`
2. Manually set the main attachment of the created moves so that
`register_as_main_attachment` is not called when accessing the move.
This removes the auto-extraction without the need to use the key (we
still keep the context key as suggested by the OCR team).
closesodoo/odoo#149525
Related: odoo/enterprise#49816
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Steps:
- Install project.
- Go to the project.
- Create or edit the project name to excessively long.
- Then go to Kanban view.
- The project name would overflow.
Issue:
-Before this commit, in the project's kanban view, if the project's name was
excessively long, it would overflow.
Cause:
-When the name is excessively long it would overflow out of the div element.
Fix:
-After this commit the name is now shortened by applying the 'me-5' Bootstrap
class.
task-3676094
closesodoo/odoo#149007
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Currently, if you have Spanish POS installed and create a Cash In/Out,
you are met with an error.
Steps to reproduce
------------------
* install `l10n_es_pos`
* start a POS session
* click on the hamburger button in the top-right corner > Cash In/Out
* add any amount and confirm
You should be met with an error.
Fix
---
At first glance, the original condition:
```
partner?.id !== props.data.simplified_partner_id
```
and the revised condition:
```
partner && partner.id !== props.data.simplified_partner_id
```
might seem equivalent. However, they behave differently when `partner`
is `null` or `undefined`.
In the original condition, the optional chaining operator evaluates
to `undefined`, leading to the following `undefined !==
props.data.simplified_partner_id` (which is most likely true).
The revised condition will shorcircuit when `partner` is falsy, ensuring
that the code only executes when `partner` is a truthy object.
opw-3667287
closesodoo/odoo#148688
Signed-off-by: John Laterre (jol) <jol@odoo.com>
This reverts commit 6c59eea421.
smtplib is expecting the Context of ssl found in the stdlib and the
Context object of the pyOpenSSL lib isn't a drop in replacement. The
various `TLS_METHOD` constants are not the same and the Context object
of pyOpenSSL lack a `wrap_socket`-like method.
opw-3640374
closesodoo/odoo#149566
X-original-commit: 028277129897c7d49942a148a0ac295386cd2d89
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Fix done directly on Github to not have to wait for the weekly sync.
Already corrected on Transifex.
closesodoo/odoo#149544
X-original-commit: 1a0bee8af2b28987a631c84311227ebd55ec632a
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
With the last realease of owl, .trim now implies .lazy. This means that
if t-model.trim is used, the value will be updated in the state only when
the change event is triggered. Here we adapt the helper editFavoriteName
which was supposed to update the state value.
X-original-commit: 7a16b75a35a5bd60190ee5b437b925a2fa99fb70
Part-of: odoo/odoo#149507
We update owl to 2.2.9. Our version was 2.2.7.
Release notes:
https://github.com/odoo/owl/releases/tag/v2.2.8https://github.com/odoo/owl/releases/tag/v2.2.9
These releases contain small improvements
2.2.8:
- [IMP] template set config: getTemplate function
- [IMP] parser: .trim modifier implies .lazy modifier
- [REF] parser, template_set: factor out parseXML function
2.2.9:
- [IMP] reactivity: replace sets with small arrays for performance
X-original-commit: 91a1f495b260ab23df80d74faeae25a5883deda0
Part-of: odoo/odoo#149507
In large database, the time to unlink a sale.order (or any record with mail.thread) can be take 1 seconde.
After it is so fast.
closesodoo/odoo#149296
X-original-commit: 6bd9f408a18c019416b5bd981de50b54432f5690
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
pos*: point_of_sale, pos_restaurant
The current approach to book/release a table isn't so intuitive,
knowing that when selecting an empty table from the floor plan:
- an empty order is created on that table, displaying it as booked
on the floor plan
- as long as the order remains empty, we display a "Release table"
button in order to delete the related empty order and display
the table as free on the floor plan
Here is the change brought by this commit:
- Change the "Release table" button to "Book table"
- Don't create an empty order on the table until User either:
- hits "Book table"
- starts adding products to the cart
- Table can be released by deleting the order
- Deleting the last order on the table, redirects User to the floor
- Control Buttons are not accessible with unbooked tables
plan
closesodoo/odoo#145896
Task-id: 3624323
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Before this commit, the `report_invoice_wizard_preview` was rendered well in
html and in the preview (settings page) but not when downloading it ; the
"total" table was pushed all the way to the right.
opw-3648586
closesodoo/odoo#149509
X-original-commit: 232c257c1554f2f47b589a971cdf9f98227ef53c
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Adrien Milis (miad) <miad@odoo.com>
In the lead's enrichment, the fields containing tags have an hardcoded
background for some reason... which, in dark mode, makes the tags' label
illegible (as it is a light text on light background).
This commit fixes it by forcing a darker gray when rendered in dark mode
(where the dark mode's bundle is applied, like in the backend).
Steps to reproduce:
- Open CRM
- Create an opportunity using a well-known domain in the email address
(for example)
- Click "Enrich"
- A card appears in the chatter containing the matching company's
information
- Switch to dark mode
=> Sectors, Technologies Used... tags keep the light background
opw-3678598
closesodoo/odoo#149409
Signed-off-by: Samuel Degueldre (sad) <sad@odoo.com>
Commit [1] changed the class from .ui-draggable to .o_draggable in the
`snippet_version` test, specifically in the run function that checks
if all snippets have their `[data-snippet]` properly set.
Indeed, `.o_draggable` is set on the parents of draggable elements and
not on the elements which are draggable themselves. This lead to a
`.every` on an empty array which returns `true`, and therefore avoids
the `console.error` but did not properly check the snippets.
This commit changes the selector to all snippets which do not have
a [data-module-id] which should be all snippets that are draggable.
[1]: https://github.com/odoo/odoo/commit/7594d71ca8610d5947e80f325ccb57abc23c2c76
Related to task-3079246
closesodoo/odoo#148824
Signed-off-by: Guillaume Dieleman (gdi) <gdi@odoo.com>
Before this commit:
Users could change the mailing stage from the Kanban view, which was
inappropriate since stage changes should occur within the defined workflow.
Reason:
The state field in the Kanban view was not marked as readonly, allowing
unintended stage changes.
After this commit:
Users can no longer modify the mailing stage directly from the Kanban view.
Instead, stage changes should occur through the workflow.
Task-3555209
closesodoo/odoo#140081
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
This commit ensure a multi company flow made of push rules can be
triggered by a stock user having access to the first company only
manual push
Stock1 -> interco -> Stock2
(comp1) (comp2)
Let a user working in company 1 confirming and validating a transfer
from Stock1 to the intercompany location. The push rule (defined in
company 2) will create and confirm the stock move to resupply Stock2
closesodoo/odoo#149492
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
closes#149428
**Impacted versions:** master, 17.0
This appears to have been introduced by
24c8ff9b28 on #139474.
**Steps to reproduce:**
1. Log in as admin user
* _The error also happens while logged in as portal user, but they
do not see the traceback._
2. Go to website, add item to cart, and click "Checkout"
3. Under the "shipping' section, click "Add address"
4. Click save and an error is raised (see traceback below and in task
comments)
* _The error also occurs if you just leave one required field as
blank, rather than all fields._
**Current behavior:** If logged in as an internal user, a traceback
error (below) is raised. If logged in as a portal user, a 500 error page
is shown.
```
Traceback (most recent call last):
File "/opt/odoo/core/odoo/http.py", line 1722, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "/opt/odoo/core/odoo/service/model.py", line 133, in retrying
result = func()
File "/opt/odoo/core/odoo/http.py", line 1749, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/opt/odoo/core/odoo/http.py", line 1866, in dispatch
return self.request.registry['ir.http']._dispatch(endpoint)
File "/opt/odoo/core/addons/website/models/ir_http.py", line 235, in _dispatch
response = super()._dispatch(endpoint)
File "/opt/odoo/core/odoo/addons/base/models/ir_http.py", line 222, in _dispatch
result = endpoint(**request.params)
File "/opt/odoo/core/odoo/http.py", line 722, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/opt/odoo/core/addons/website_sale/controllers/main.py", line 1346, in address
'use_same': is_public_user or ('use_same' in kw and str2bool(kw.get('use_same'))),
File "/opt/odoo/core/odoo/tools/misc.py", line 468, in str2bool
raise ValueError('Use 0/1/yes/no/true/false/on/off')
ValueError: Use 0/1/yes/no/true/false/on/off
```
Note: Based on a quick check, the value of `kw.get('use_same')` is
`None`, which causes the `str2bool` check to fail. The value of
`use_same` appears to be set within the `website_sale.address` template,
but it seems that the value should always be `True` or `False`, not
`None`.
**Expected behavior:** The "add address" page is shown with a red
highlight around any required fields that are missing a value.
**Video link:**
https://github.com/odoo/odoo/assets/7907616/4e103c73-417f-4d1a-93e3-8c1d7beeb918
Support ticket number submitted via odoo.com/help: 3,685,876
closesodoo/odoo#149432
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Have company 1 (main company) and company 2
Activate Website for company 1
Switch to company 2
Setup a POS
In Settings > Point of Sale, activate 'Use QR code on ticket'
Open POS session
Make an order, save qr link from receipt, close session
Open the saved link without being logged in
Complete form and request invoice
Issue:
Error will block the operation
```
Incompatible companies on records:
- '/ (Reversal of POS closing entry POSS/2024/01/0004 for order Shop/0004 from session POS/00002) 16%' belongs to company False and 'Account' (account_id: '209.01.01 VAT carried forward not collected') belongs to another company.
- '/ (Reversal of POS closing entry POSS/2024/01/0004 for order Shop/0004 from session POS/00002) 16%' belongs to company False and 'Originator Tax Distribution Line' (tax_repartition_line_id: 'account.tax.repartition.line,54') belongs to another company.
- '/ (Reversal of POS closing entry POSS/2024/01/0004 for order Shop/0004 from session POS/00002) Acoustic Bloc Screens' belongs to company False and 'Account' (account_id: '401.01.01 Sales and/or services taxed at the general rate') belongs to another company.
- '/ (Reversal of POS closing entry POSS/2024/01/0004 for order Shop/0004 from session POS/00002) Acoustic Bloc Screens' belongs to company False and 'Taxes' (tax_ids: '16% (MX)') belongs to another company.
- '/ (Reversal of POS closing entry POSS/2024/01/0004 for order Shop/0004 from session POS/00002) 105.01.02 105.01.02' belongs to company False and 'Account' (account_id: '105.01.02 National customers (PoS)') belongs to another company.
```
This occurs because when Website is installed, requests from public user
will keep in context the id of the company associated to the website,
company 1 in this case.
opw-3629683
closesodoo/odoo#149410
X-original-commit: 6fce2e5bf34468099a0c62669687847ed36621bf
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Andrea Grazioso (agr) <agr@odoo.com>
The anglo saxon accounting was set in the wrong field.
It should be set in the field 'anglo_saxon_accounting' on the company
and not 'use_anglo_saxon' on the configs.
task-3642826
closesodoo/odoo#149190
X-original-commit: 3160749a173b01e93f91dea72d1dcc5370ea44f7
Signed-off-by: William André (wan) <wan@odoo.com>
*: mail, pos_sale, pos_self_order, website_sale
=== `oi-close` adaptation ===
Prior to this commit, `oi-close` icon was based on the default
sans-serif font. Depending on this, there could be alignment and size
inconsistencies with the Odoo UI icon library.
This commit adapts `oi-close` to use a custom icon from the UI icon
library to make it more robust and maintain consistency with this
library.
=== corner arrow icons adaptation ===
Prior to this commit, directional icons related to the four corners were
misaligned.
This commit adapts these four icons so that they are properly aligned.
task-3618046
closesodoo/odoo#144598
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This commit adds a new event listener on the odooEditor which listens for
external history steps (if collab mode is enabled), and changes the state of
the record's dirtyness when a user receives external steps.
This way a user will see that the record has been modified when he is editing
a collaborative html field.
task-3609594
closesodoo/odoo#145928
Related: odoo/enterprise#51579
Signed-off-by: Nicolas Bayet (nby) <nby@odoo.com>
Steps:
- Install planning app.
- Open Planning.
- Click on search bar menu.
Issue:
- The groupBy column width is more than expected.
Cause:
- groupBy and filter menu size changes depending on their
groupBys and filters names so giving bigger name to filters
and groupBy increase their size and there was no max-width
set on then and because of setting name and giving bigger
string on field makes that column unexpectly big.
Fix:
- set max-width on `o_filter_menu` and `o_group_by_menu` to
avoid unexpected bigger size for filter and groupby columns.
task-3607270
closesodoo/odoo#140412
Signed-off-by: Romeo Fragomeli (rfr) <rfr@odoo.com>
The index is needed to be able to unlink/delete lines because of the
check of foreign keys.
closesodoo/odoo#149417
Signed-off-by: Cedric Snauwaert <csn@odoo.com>
How to reproduce:
1. Go to website slides.
2. Open any course.
3. Add review or Edit the review.
The title of the modal should be visible but it is not because the text has the
same color as the background (white).
Technical note: the modal is defined in a dark zone where the text color is
white. The modal title uses the h5 tags that automatically inherit its color
from its parent, so the title is white as well. To solve the problem we add the
class "bg-white" on the modal-content div to indicate that the background of
the modal is white so that the color of the h5 has a good contrast on a white
background (here black). We also removed the CSS rule for
"o_rating_popup_composer_label" as it was not being applied.
Task-3640496
closesodoo/odoo#149405
X-original-commit: 0f158f4c3b51a4caa20dda337d13e905c99540fd
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Commit ceb8b78 introduced a mechanism to throw an error if some address
fields were empty. The mechanism was introduced to prevent us from
sending False as an address detail to Adyen when it was not set since it
might negatively affect the fraud check score.
It however caused some payments not to go through because it relied on
Odoo's utils to extract the house number from the address, which would
fail in some circumstances (e.g., when the number is placed before the
street name). In some other cases, empty address details that were
previously accepted by Adyen caused the error to be thrown.
With this commit, we now pass Unknown instead of False or empty string
for the address details that are not set and that are not required by
Adyen in practice, unlike what is stated in AVS documentation. This
delegates the responsibility to block the payment to Adyen as the address
check and the related error are removed from Odoo.
closesodoo/odoo#149365
X-original-commit: 771b7ebd55646d8c96938e562802b47cb92d18fb
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: anko-odoo <anko@odoo.com>
A date filter with an empty value would still create a domain filtered
on the current year instead of being bypassed.
closesodoo/odoo#148984
Task: 3668916
X-original-commit: 763f88e2d45cb7ba107db135eecd0365ba2b8c8b
Related: odoo/enterprise#54095
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Step:
- Navigate to the project module.
- Select any project.
- Click the status button on the Kanban view's top left.
- This action redirects to the project update Kanban view.
- Notice that the status field is unexpectedly editable.
Issue:
- In the project module, accessing the project update Kanban view allows
unintended editing of the status field.
Cause:
- Due to the new modifications made in the kanban view where the user is allowed
to perform selection from the view itself, the status field also resonates the
similar behavior.
Fix:
- By adding the 'read-only' attribute in the Kanban view specifically for the
status field, we can restrict the unintended modifications to this field.
This implementation ensures that users cannot edit the status field directly
from the Kanban view.
Task-3610481
closesodoo/odoo#144336
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
When a user try to import (to edit) some account.tax, some verification are done on pos.order.line.
The search is done in sudo but the read is executed with the current logged user.
So pos.order.line from others companies are check with a user who don't have access to these companies.
And the AccessError exception is triggered.
This PR aims to fix the permission issue by adding a sudo() for the read on pos.order.line
closesodoo/odoo#149288
X-original-commit: 1c22f6bd36ffcade3d84d0f76bbb3b9d1dc8c4c1
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Before this commit, deleting recurrent events from Odoo in list view mode was allowed with the synchronization active, which could trigger to spamming emails on Microsoft side. Additionaly, deleting events with the synchronization off was also deleting events on Microsoft, which should not happen.
After this commit, the deletion of recurrent events is not allowed anymore when the synchronization is active by triggering an UserError message. Also, when the synchronization is off, deleting events in Odoo don't also delete events on Microsoft side.
closesodoo/odoo#149278
Task-id: 3563501
X-original-commit: a932aee25b2ae5f6a3c0e50154c5db6ba6ea06bf
Signed-off-by: Gabriel de Paula Felix (gdpf) <gdpf@odoo.com>
To reproduce:
- Install POS with demo data
- Install Indian localization(l10n_in)
- Open POS terminal
- Click on the load demo data
- Traceback thrown
Fix:
The issue occurs when the demo data executes the closing of the sessions.
The l10n_in _post method checks for a company state that is not yet set
at that point. It is important to note that this issue only arises
when loading demo data on a DB that doesn't contain demo data. The solution
is to extract the part of the method that executes the demo data linked to
the main config and to override it to not perform that part in the l10n_in_pos.
closesodoo/odoo#149011
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Current behavior:
When you create a sale order with an analytic account, and settle it in
the POS, the analytic account is not set on the POS order invoice lines.
Steps to reproduce:
- Create a sale order with an analytic account (in other info tab)
- Confirm the sale order
- Go to the POS and settle the order
- Pay and invoice the order
- Go to the invoice and check the analytic account on the invoice lines
Note:
I based my fix on what was already done in the sale_order creation to
set the analytic distribution correctly on the invoice lines.
opw-3635140
closesodoo/odoo#147737
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
The unit tests introduced in 4820be3c only work if pdfminer is installed.
As it's an optional dependency, it may not be installed in some environments.
This commit skips the tests if pdfminer is not installed.
See also: 6fa4dbf2closesodoo/odoo#147720
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
This commit adds a test on the following flow:
A subcontracted product has its component having the three route
- ressuply on order
- buy
- MTO
Receiving the subcontracted product will create a delivery for the
component to the subcontractor, then a purchase order to buy it.
Confirming this very PO should create a receipt stock move linked to
this delivery.
closesodoo/odoo#147344
X-original-commit: 0044fd8bb6966011bd3943bff0bd58bcd111338f
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Method _is_purchase_return had a complex check intended to detect
subcontract return move. This Check would incorrectly pass for
subcontract move when the destination location (input) does not belong
to the customer warehouse.
To fix this issue, we can check the field StockMove.is_subcontract,
however this field is only available if mrp_subcontracting is installed.
Furthermore, the check itself make no sens in purchase_stock if the
module mrp_subcontracting is not install Hence, we can move this check
to mrp_subcontracting_purchase.
With Purchase & Mrp Subcontracting installed:
- Create Component C, consumable
- Create Product P, storable, Set Vendor V under Purchase Tab
- Create BOM for P, subcontracted with Vendor V, and C as component
- In the Warehouse, set 2 steps reception
- Set Input parent location to 'Physical Location'
- Create PO to vendor V, product P, confirm, receive Product
=> Received Qty for P in PO show 0
OPW-3216011
X-original-commit: bf666d33af4ac32563e159cb6e79483d6f37b3d6
Part-of: odoo/odoo#147344
do not compare types, for exact checks use `is` / `is not`,
for instance checks use `isinstance()`Flake8(E721)
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
Steps to Reproduce
===================
1. Open any course
2. Go to the review tab
3. Tap on the comment button.
-> Currently the avatar image is a bit messy
Technical Reason
=================
This issue occurred after the portal redesign
https://github.com/odoo/odoo/commit/df8535fbd40e1e5c09dbe616a3332c76c23525c8
After this commit
==================
The Avatar image is well-ordered.
Task-3625896
closesodoo/odoo#146092
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
`replied_ratio` shouldn't be tested against bounced_ratio, neither
should be `opened_ratio` against `clicks_ratio`.
`_prepare_statistics_email_values` function returns list, whose last
two values are: `clicks_ratio` and `bounced_ratio` instead of
`opened_ratio` and `replied_ratio`. Also checking `replied_ratio` and
`opened_ratio` doesn't make sense, when testing sms.
task-3485424
closesodoo/odoo#149267
X-original-commit: a2bb6dea6d81a777c7aed73c8b7a38e015408676
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
The kanban's create button ("New") is usually displayed in the
ControlPanel. But in the select/create dialog (like many2one dialog),
the create button is moved to the footer.
On small screen, the Many2X fields' selection view switches from a list
view to a kanban one but a different condition was used to display (or
not) the create button in the ControlPanel, which explains why the
ControlPanel's create button appears only on small screen (and not in
the same dialog open on desktop-like screen size).
This commit fixes it by reviewing the condition applied in both the list
and kanban views and normalizing them to be based on the (existing)
`showButtons` prop that controls the additional buttons added to the
ControlPanel.
Steps to reproduce (with a smartphone like screen size):
- open Contacts app
- open a contact
- open the company's selection
=> two "New" buttons are displayed (top and bottom)
opw-3431221
closesodoo/odoo#149329
X-original-commit: c21c600189b36b7b4b352f8017467c8ef7d07c87
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Peppol and Italian edi both uses a proxy user. We should only use Italian
proxy users when checking demo mode otherwise Peppol production proxy users
can interfere and trigger an error like 'Company already have prod connection'.
Also we don't want to delete demo Peppol connections.
opw-3675908
closesodoo/odoo#149276
X-original-commit: 078543cfe34427fe96932536bc283fcdf2ce2251
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Thomas Beckers (tbs) <tbs@odoo.com>
ilru-odoo