When syncing the values of the invoice, the balance might need to be
recomputed if some business fields changed.
The detection of the changed fields was flawed because of a missing
rounding, leading to a false positive detection.
Reproduce:
* Using demo data
* Create an invoice in EUR (company USD)
* Add a line for `[E-COM07] Large Cabinet` (price 209.30)
* Select the partner
* Validate the invoice
task-pad
X-original-commit: 9e2b32523ac3975a68796ce534b4f9ee367cbf9e
Part-of: odoo/odoo#104018
In the forum form view, the description field is not aligned well and
is too compact. This is because of [1] (and related commits of that big
rework), which changed the way form view groups are rendered (using grid
display).
- eLearning -> Forum -> Forums
- Open any record
- In the "Options" tab, there is a description field at the bottom of
the view
=> The description field is too compact (hard to view and edit the value
from the field).
In master, this should in fact be changed to not use any group.
[1]: https://github.com/odoo/odoo/commit/a2b894989ea33364dd29a7d412e4bd4260c1f5efclosesodoo/odoo#103994
X-original-commit: 3dc42aafffc3c41db732a6e52af7956ea1d0da0e
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Since #98551, groups have been moved from views fields to xml content
to harmonize the behavior of xml and view groups.
Nevertheless, this reduced the coverage of the test verifying settings user
are always able to open the settings view.
This commit brings back part of that coverage, checking for each application manager
group that the settings view can be opened and saved correctly.
closesodoo/odoo#103989
X-original-commit: bb067f894a5e5511370990b98981e739565d2f2a
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
The "Mexican case" is the following:
When reconciling a journal item having a foreign currency with another one expressed using the company currency, the reconciliation is made on the foreign currency.
This is needed for Mexico since you are free to pay an MXN invoice with an USD payment.
So, you are free to pay an invoice of 120 MXN at a rate at which 120 MXN = 40USD with either a payment of 120 MXN, either a payment of 60 USD at a date in which 120 MXN = 60 USD.
Otherwise, some reconciliations should ignore this behavior. For example, making a cut-off on an invoice using "current assets" accounts. In that case, the invoice has a foreign currency on the product line but not on the cut-off journal entry.
With the current reconciliation, the lines are no longer fully reconciled even they have the same balance.
To handle this case, this commit is restricting the "Mexican case" to the receivable/payable accounts.
closesodoo/odoo#103769
Issue: 3009187
X-original-commit: dd7c473af20499f179cd4661402a0eb209cf1db2
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>
Both dynamic snippets and visible on mobile use the `d-none` class:
- dynamic snippets activate it by default and only remove it when the
content is ready to be displayed
- visible on mobile makes the section `d-none` when it must be hidden on
mobile and the class is contradicted by another class which is only
taken into account non-mobile
This commit introduces a dedicated class to temporarily hide the dynamic
snippets.
task-2930503
closesodoo/odoo#103637
X-original-commit: 7b3be2f183f53bfcb5f365a2c26127da0702dc15
Related: odoo/upgrade#3980
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Since [1] the visibility options were removed from the products snippet.
This commit restores the visibility options.
Steps to reproduce:
- Drop a products snippet.
- Select it.
=> The visibility options were not shown.
[1]: https://github.com/odoo/odoo/commit/57a1776c3695b1fec6ffa0b6ec3de59518b8a0a9
task-2930503
X-original-commit: 47172c76f8020abdab2a7bd7bdfece6760b8316f
Part-of: odoo/odoo#103637
Steps to reproduce:
- go to Project app;
- select a project and create an activity and make it late;
- edit another project and create an activity for today;
- edit yet another project and create a future activity;
- click on the activity clock in the main menu bar (there are one late activity, one today and one in the future);
- click on "late".
Issue:
All three projects with activities are shown.
Cause:
There is no filter provided for this purpose.
Solution:
Add a filter on activities according to the deadline.
opw-3002778
closesodoo/odoo#103526
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
'Barcode GS1 Parser' test sent RPC to the server (moreover
it was wrong rpc). Fix it.
closesodoo/odoo#102239
Signed-off-by: Steve Van Essche <svs@odoo.com>
Purpose:
In the Forecast view of the CRM module, when recurring revenues are activated,
they are not shown in the progress bar of each stage of the kanban view. Only
the prorated expected revenue (non-recurring) are shown. In the regular
kanban view, they are shown.
To display them, we extended the CrmKanban view, which already possesses this
behavior, since behaviors relevant to the CrmKanban view are also relevant
to the ForecastKanban view.
As for the forecast kanban cards, when recurring revenues are activated,
they show "regular" recurring revenues instead of "prorated" recurring
revenues. Expected revenues are prorated. This is misleading for users.
The goal is to show prorated recurring revenues instead of just
recurring revenues.
Task-2994146
Task-3006404
closesodoo/odoo#102037
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
When creating a recipient from composer_suggested_recipient the user
is free to modify the partner form however they want.
This can lead to them inputing data which will create a partner
that does not match the suggested partner data.
In that case the box acts as if the partner was not created.
This aims to remove the partner in such cases and warn the user.
task #3016112closesodoo/odoo#104005
X-original-commit: 51dd925d3660609b03349c42377e15064461eb3e
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, project sharing form view: the name field was long.
After this commit, name field will be aligned.
task-3010685
closesodoo/odoo#103978
X-original-commit: 74a069226294044fa8901aed6b02bc25c4e11b21
Signed-off-by: Xavier <xbo@odoo.com>
Before this commit, Task form view > timesheets notebook > the remaining hours
field is not correctly aligned due to extra span inside the view.
So in this commit, extra span will be only added if `allow_subtask` is enabled
and `subtask_effective_hours` is greater than 0.
task-3010685
X-original-commit: 6f697a0930bd780da772d2c69abe3e3c4428c5c5
Part-of: odoo/odoo#103978
Before this commit, Project > '# of tasks' from the burndown chart was not
translatable to any language
So in this commit, Project > '# of tasks' from the burndown chart will be
translatable to any language
task-3010685
X-original-commit: 1593436ac4ebbb121d3dc0a9725c74f3d7f0ad39
Part-of: odoo/odoo#103978
The new WOWL Kanban view supports that luxon be used in the archs.
Legacy kanban had a similar support but for moment.js
Obviously, new archs can't work with legacy implementation because of this.
This commit aims at providing some sort of hackish support, only valid in
the transition phase.
At least one use case has popped up, that is, when editing such kanban view with Studio.
In that case, there was a crash, which is fixed with this commit.
closesodoo/odoo#103821
X-original-commit: 14f56b324d241f35b742781424535cecf26a218e
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
In the new version of Odoo you have to declare the
variables in the minified files
closesodoo/odoo#103789
X-original-commit: e08858e5ed02fe74160dabd6a91e1de88640956f
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
It is not possible for a user to add a carrier directly on a picking if
the invoicing policy of that carrier is set to "Real Cost"
To reproduce the issue:
1. Enable a carrier C
2. Setup a shipping method SM:
- Carrier: C
- Invoicing Policy: Real Cost
3. Create and confirm a SO with a product
4. Edit the related picking P:
- Carrier: SM
5. Validate P
Error: a Validation error is raised "The operation cannot be completed
[...] Model: Sales Order Line (sale.order.line), Field: Description
(name)"
When validating the delivery, we try to create a new SOL with the
shipping cost. We then update its description with the carrier name.
However, since the carrier has been directly added on the picking, the
sale order does not have that information. We should rather get this
information from the delivery.
OPW-2862306
closesodoo/odoo#103986
X-original-commit: 611bd008075f5b8f8080281ae877ada3076a9e7a
Signed-off-by: Adrien Widart <awt@odoo.com>
Signed-off-by: Tiffany Chang <tic@odoo.com>
Before this commit, while selecting the project and task and project only while
creating a product the description was interchanged
After this commit, the description is perfect
task-2969228
closesodoo/odoo#103985
X-original-commit: 6668d5e5e1111d105f549ae1264eaf34c965caa9
Signed-off-by: Xavier <xbo@odoo.com>
This commit moves some code from components to models,
so that eventually all business code will be in the models.
[IMP] mail: Move code from components to models (DiscussMobileMailboxSelectionItem)
Task-3004221
[IMP] mail: Move code from components to models (ActivityMarkDonePopoverContent)
Task-3004282
[IMP] mail: move code to models (MessageComponent)
Task-3000365
closesodoo/odoo#104003
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, When we share project in read only access
at that time access error raised when we try to open the task
by shared link due to invalid access on account.move.
So in this commit, check the read access for the account.move and
if the public user has right to read the invoice then allow
to search on move.
task-2889455
closesodoo/odoo#104001
X-original-commit: 1d6474f58056be3515e5023c26dcef56b8dddc91
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
Before this commit, fields using Many2OneField in their template (for
example, the many2one_avatar field) had a wrong style for the external
button (the arrow on the right to open the record in form view).
closesodoo/odoo#103981
X-original-commit: c63493ab7b19a238304b2d7791c28bf1a52c0d2f
Signed-off-by: Luca Vitali <luvi@odoo.com>
Before this commit:
The behaviour of the text were not identical in edit mode and after save, the
word was wrapped in edit mode.
After this commit:
To make the behaviour identical by unsetting the default overflow property
in edit mode.
Task-2878307
closesodoo/odoo#103975
X-original-commit: 6177fac863a29c86ed4e5ede8d48aa31da3a8508
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
As the shortcut formulas don't use the normal way of
defining expressions, some formulas may start with
characters that would be considered as indentation
by the literal_eval. This removes such characters
closesodoo/odoo#103968
X-original-commit: b39db297f25d71fdd7122e0d16bb92c7372f9617
Related: odoo/enterprise#33143
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Julien Alardot (jual) <jual@odoo.com>
This reverts commit 092d652b1f38b804657b6e1d383a157615cf9487.
It was not a bug.
Because coupons should not be restricted to the partner assigned to them
anymore.
opw-3027251
closesodoo/odoo#103958
X-original-commit: 7804a7aeca78f9f9a49838c6a3621c766e5f5e55
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>
Before this commit, when opening emoji picker for the 1st
time, content was blank for a small time.
This happens because data of emoji picker is lazy loaded
until opening of emoji picker the 1st time. The problem
is that it gives the impression that emoji picker is not
working, but it's actually loading.
This commit fixes the issue by showing a "loading..." screen
while the emoji picker is loading data.
Task-3015932
closesodoo/odoo#103957
X-original-commit: 22472cd4d2681c07371c8515bb964553b7c2b700
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
The `set_table` has been changed to `setTable`, but the previous name
was still used in `_onDoRefund`.
closesodoo/odoo#103948
Issue: https://github.com/odoo/odoo/issues/103866
X-original-commit: af5ca27a24ea4affa86206d8bad5e9da9707685c
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
When a change was made on the same record, the editor could wrongly
be reset.
Step to reproduce:
- Go in knowledge app
- Click inside the editor outside a template block
- Click on inside a template block
- Click inside the editor outsie a template block
=> The editor is reset
closesodoo/odoo#103947
X-original-commit: d0a079a76c3f5078178717966e3d4caf0987ebf9
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
We had an index with the same name as would be generated by the ORM.
Instead of putting index=True as it is a bit of an hack, we just change the name of the index.
closesodoo/odoo#103945
Issue: https://github.com/odoo/odoo/issues/103473
X-original-commit: 819fa66546fbb53b808711b38c3296406c45c717
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com>
When a lot of components are trying to do the same `search_read`, they
are spamming calls to the server when they could be batched instead.
Instead of using `search_read`, we can also call `precision_get` which
is `orm_cache`d
To reproduce:
* Main settings: activate/check "Analytic Accounting"
* Menuitem: Accounting > Accounting > Journal Items
You should see a lot of calls of `search_read` to `decimal.precision`
closesodoo/odoo#103928
X-original-commit: 332a673b6b289761ae3c42d1bfa8effca475abf1
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>
Remove the call to `t-on-click` in the arch of form/kanban views as it
crashes when the view is opened in studio.
Instead use a dedicated `<widget>`.
closesodoo/odoo#103820
X-original-commit: 2a213a150b4421ce4da32db754651cfc41adbef4
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Before this commit: if you use the lot/serial number for the products, it
won't load correctly through the UI.
closesodoo/odoo#103940
Issue: https://github.com/odoo/odoo/issues/100888
X-original-commit: 0e2ea5ff786185a72916e5582fdbf45271819b8c
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>
When writing a workorder start or end date from its manufacturing order
(and if the MO is unplanned), an error is thrown
Steps to reproduce:
1. Install Manufacturing
2. Go to Settings > Manufacturing > Operations and enable Work Orders
3. Open an MO with Work Orders
4. Unplan the MO
5. Add a Scheduled End Date to one of the Work Orders
6. Save
7. An error is thrown
Solution:
Compute the new duration only if both `start_date` and `end_date` are
set (and one of `date_planned_start` and `date_planned_finished` is
passed in values)
Problem:
When only one of `date_planned_start` or `date_planned_finished` is
written on an `mrp_workorder` (and the other is not set), the method
`_calculate_duration_expected` is called but it fails because it passes
a False value instead of a datetime which will raise the error `'bool'
object has no attribute 'tzinfo'`
opw-3004280
closesodoo/odoo#103927
X-original-commit: 35a596dbbc4e2e55461bf7e5e8ae12873249d4af
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>
Make the xlsx import display warning for things that couldn't be imported,
but only if Odoo is in debug mode.
Odoo task 3035674
closesodoo/odoo#103671
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
In the Odoo Community edition, the barcode picture to invite the user to scan his badge
in kiosk mode has no size restriction. This creates a layout issue when displaying the attendance
kiosk mode in community.
This commit fixes the layout by restricting the size of the picture to the size of the enterprise version.
task-3036986
closesodoo/odoo#103892
X-original-commit: 02ab64e110ae2cb8e0d2a304886147be9e450a87
Signed-off-by: Kevin Baptiste <kba@odoo.com>
The goal of this commit is to restore the behaviour of the legacy
attach_document widget.
How to reproduce :
- clicking on the attach_document button and selecting a file
In legacy:
We have a full reload of the view (Render and reload the record).
Before this commit:
Render the view without reloading the record.
After this commit:
We reload the model which causes a rendering of the view and a reload of
the record.
Why do we have to reload the record ?
If the action linked to the attach_document button modifies the record,
we want this modification to be applied in the view and not only on the
server side. To do this, we need to reload the record data to ensure
that all the changes are displayed in the view.
closesodoo/odoo#103891
X-original-commit: 82d4f0cd2f0265393cf66cd7be1a0a714584400c
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Signed-off-by: Georis François (fge) <fge@odoo.com>
Partner Autocomplete wasn't available anymore on the name/VAT of
`res.company` records since its Owl conversion.
closesodoo/odoo#103886
X-original-commit: f12176755a97bcee66722d9d9281ae7ac6424dbc
Signed-off-by: Georis François (fge) <fge@odoo.com>
Signed-off-by: Louis Baudoux (lba) <lba@odoo.com>
See the explanation here:
https://github.com/odoo/odoo/blob/5069c8fd1cee063827873de0f6c2d9fe938337a9/odoo/addons/base/models/ir_ui_view.py#L1209-L1217
The strategy was to create a temporary
<t groups="..."> node which gets deleted after the postprocessing.
The deletion counted on the fact `groups` was the only attribute set
to delete this temporary technical node. In case
someone configured manually in a view architecture directly a t node
with a groups and something else.
But, studio adds another attribute to nodes with "groups=" in the
context of the studio edition (`studio=True` in the context)
https://github.com/odoo/enterprise/blob/7e66f89e1c85852908edc45e72706e51838960b0/web_studio/models/ir_ui_view.py#L53
and therefore another attribute was added on this temporary technical node,
which therefore didn't get deleted properly before being send to the
webclient.
So, we change the heuristic, instead of relying no the fact
`groups` was the only attribute, set a technical attribute on the node
to identify it comes directly from the postprocessing and it must
be deleted properly before being sent to the webclient.
closesodoo/odoo#103832
X-original-commit: 53c684a69bbe8894f05306631272bcf08c226f96
Related: odoo/enterprise#33096
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
The payment terms view needed a bit a change so this PR change a few things:
* Make the title of the payment terms bigger like the other view in odoo
* Group the company, note and display on invoice so that they are aligned
* removing the section Terms and the span
This PR also change the display of payment terms on invoice when printing or previewing them. Now :
* If there is one line (no cash discount) it's not displayed
* If there is one lone with cash discount) it's displayed
* If more than one line then displayed
Before this PR it was presented with a table but now the line are displayed like a list.
closesodoo/odoo#103778
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Current behavior:
If you try to edit the form view of pos.order in studio, you get a
traceback.
Steps to reproduce:
- Install point_of_sale
- Go to PoS order
- Click on studio
- Click on the button to edit the form view
- You get a traceback
opw-3008565
closesodoo/odoo#103838
X-original-commit: b616cad62a66aaaf8bfc7c79dbafd87174b9a1f6
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>
Tiffany Chang (tic)