Commit Graph
128469 Commits
Author SHA1 Message Date
Christophe Simonis 81f024b545 [FIX] point_of_sale: allow opening the pos interface
The `cash_control` constraint [1] is only relevant when the field
`cash_control` is modified. Do not check it when opening the pos UI.

[1] added by 733fb360d2
2019-07-29 15:59:40 +02:00
Christophe Simonis ac5c493c37 [FIX] base: remove usage of @api.multi
Oversight of previous forward-port.
2019-07-29 14:48:26 +02:00
Christophe Simonis d5e1fd16b4 [MERGE] forward port branch saas-12.4 up to cda4f3c308 2019-07-29 14:10:30 +02:00
Shreya Modi ae71f95371 [IMP] mass_mailing_sale: traceback due to invoice stat button
when opening the sale promotion in mass mail, it creates a traceback
due to invoice compute method as it does not have invoice id because
of changes in account.move.

task-2036203

closes odoo/odoo#35202

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-07-25 07:20:22 +00:00
Julien MougenotandLucas Perais ed18095127 [IMP] base: Configure document layout
The onboarding modal for setting up the few base fields of a company
has now been moved to a wizard
It is accessible from the general settings, but also in the onboarding
section of sale and account modules.

The following company settings are editable with that wizard:

- Set report **layout**:
The user can chose the overall look of the report. The current choices
are : *Standard* (default), *Background*, *Boxed* and *Clean*.

- Set company **logo**:
Changes the company logo.

- Set report **colors**:
The user can set the primary and secondary colors of the report through
a newly added widget allowing to pick a custom color.
When changing the **logo**, colors are automatically set to its most dominant
colors.
> A "Reset colors" button also triggers the color calculation.

- Set report **font**:
Changes the overall font of the report. Only Google Fonts are used
for enhanced compatibility.

- Company **tagline**, also called "header"
- **Footer**
- **Paper format**
- Report **preview**:
A mockup of a final report
Automatically updates when changing **layout**, **logo**, **colors** or **font**

Co-authored by: Julien Mougenot <jum@odoo.com>

closes odoo/odoo#33863

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>


Co-authored-by: Lucas Perais <lpe@odoo.com>
2019-07-29 08:29:26 +00:00
Julien Mougenot a8c93df9c8 [IMP] web: add noTransparency option for colorpicker dialog
Added a boolean option to toggle opacity settings on the colorpicker dialog widget.
When set to true, both the opacity slider and the opacity input are hidden in the
dialog. When not set or set to false, opacity settings remain unchanged.
2019-07-29 08:28:15 +00:00
Julien Mougenot edc60f7fb4 [REF] web,web_editor: moved ColorpickerDialog to web
The reason this widget was moved is that the next improvement
([IMP] base: Configure document layout) defines a new field (FieldColor)
which needs to call the colorpicker dialog inside of the base module.
This couldn't be done while the dialog was located in the wysiwyg assets.
2019-07-29 08:28:15 +00:00
RomainLibert db8d22621f [FIX] hr: Add the color field to public employee
The color field is necessary to be able to display some fields
(many2many_tags) and used in the kanban views

closes odoo/odoo#35216

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-07-26 11:45:48 +00:00
svs-odoo 5d5db35f87 [FIX] sale_timesheet_purchase: remove uninstall_hook
The commit f3999314af introduces a
declaration of non-existing `uninstall_hook` in the manifest, causing
error when trying to uninstall the sale_timesheet_purchase module.
This commit simply removes it.

Task #2039731

closes odoo/odoo#35106

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-07-26 11:51:02 +00:00
svs-odoo f26a6306b3 [IMP] stock,*: hide Advanced Scheduling setting
Before this commit, the stock's setting Advanced Scheduling was always
visible, even when it's empty. Now, it is invisible until sale_stock or
purchase_stock makes it visible (it's needed because they each add an
option into it).

Task #2039731
2019-07-26 11:51:02 +00:00
svs-odoo 088a1709f4 [FIX] stock_account,mrp_account: align Update Cost button
Task #2039731
2019-07-26 11:51:02 +00:00
svs-odoo 13e30d581a [IMP] stock_account: inventory valuation groupby product
In the Inventory Valuation report, values must be grouped by product_id.

Task #2039731
2019-07-26 11:51:02 +00:00
svs-odoo b4a435606c [IMP] stock: change position of picking type field
In the picking form view, places the picking type field before location
fields, thus user is prompt to set it before locations because the
onchange on the picking type erases the location fields.

Task #2039731
2019-07-26 11:50:56 +00:00
svs-odoo 0c26d65980 [FIX] stock_account: traceback when create quant
How to reproduce:
- Active multilocation in inventory setting;
- Go on product form view;
- Click on Update Quantity / On Hand button;
- Create a new quant.

With stock_account, we encounter a traceback when creating a new quant
in some case where the `location_id` isn't set by default, because it
tries to compute the value and it checks location to know if the quant
must be valueted or not.

Task #2039731
2019-07-26 11:46:34 +00:00
svs-odoo 02101ace6d [FIX] stock: inventory at date for single product
On stock list view of a single product, when user click on "Inventory at
Date" button, the displayed report shows all products.
This commit makes the report only shows the current product.

Task #2039731
2019-07-26 09:25:25 +00:00
svs-odoo 2edf100c8f [FIX] stock: hide lot_id on quant list
Before this commit, the field `lot_id` was hidden when useless for the
editable quant list, but was always present in the readonly quant list.
Now, the `lot_id` is hidden when appropriate in the two lists.

closes odoo/odoo#35008

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-07-26 12:22:34 +00:00
svs-odoo b39173a8ff [FIX] stock: edit quant without company id
Some quant can have no company_id (quant for partner locations).
But when user edit a quant, the stock move `company_id` is based on the
quant's one. As the `company_id` is required for a stock move, we force
to take the `company_id` of the user in case the quant don't have one.

Task #2035465
2019-07-26 12:22:34 +00:00
svs-odoo 70f99448d5 [FIX] stock: forbid edition of inventory loss quant
As quant from inventory loss location balances real quantity, it could
be really hazardous to able user to modify it. That said, modify it now
has no effect. So, with this commit, we exit the quant write method in
case of user tries to modify it manually if the quant location is
inventory loss, and we inform the user he can't modify it.

We could set the field as readonly in this case, but it's clearer for
user to inform him/her in case he/she tries to modify the quant than set
the field as readonly and take the risk user don't understand why he/she
can modify some quant and can't modify some other.

It would be preferabler to raise an UserError in the write than do
nothing in the write and return a warning in the onchange, but in case
we raise an error in the write method, user side the field is still in
edit mode and then, every time user clicks somewhere but on Discard, it
will raise the error again and it's not convenient for the user.

Task #2035465
2019-07-26 12:22:34 +00:00
Adrian Torres 2971bf6100 [MOV] core: put things where they belong
This commit moves some ir_ui_view specific functions into ir_ui_view.py
and removes some old-api <-> new-api compatibility shims as well as
removes orm.py since it has 0 to do with the Odoo ORM.

closes odoo/odoo#34826

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-26 09:07:19 +00:00
aca 78565b1dc9 [REM] web_settings_dashboard: Merge module into base_setup
Purpose
=======

Currently, when we click on “Settings” on the Home Dashboard, we arrive
on a new Dashboard with several pieces of information like Installed Apps,
invite new users, or translations. Some informations are reachable in
several ways, which is not necessary.

We would like to remove this page and replace it with the General Settings
page directly. That makes more sense to the user who click on “Settings”. The
present informations will be dispatched in the menu or in the general settings
for a better usability.

Specification
=============

This commit move code from web_settings_dashboard in order to put the features
in settings directly. To do so, we choose to move code to base_setup, and create
widget on the settings form view to keep features. Concerned features are: invite
users, dev tools, odoo edition number and IAP account link.

TaskID: 2006910

closes odoo/odoo#34290

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-07-26 09:53:46 +00:00
Yannick Tivisse a8893ad299 [IMP] utm: Add linkedin medium in data
closes odoo/odoo#35094

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-07-26 08:47:03 +00:00
Yannick Tivisse 430a10c39b [IMP] hr_recruitment: Remove informative field
Not used anywhere, and will be correctly implemented with the
referral application.
2019-07-26 08:47:03 +00:00
Yannick Tivisse 43c5a7d74f [IMP] web: Implement confirm attr on kanban views
Purpose
=======

On a form view, it's possible to add a confirm attribute to open a
popup when clicking on a button.

This mechanism is not implemented on kanban views, and would imply to
create a specific wizard just for that in the referral application.
2019-07-26 08:47:03 +00:00
Yannick Tivisse 0c07495391 [FIX] website_form: Allow to post a message with attachments
Coming from the sudo() modification. The mail.message is created in sudo,
but the user is still the public user, who doesn't have a email address,
leading to an raised error.
2019-07-26 08:47:03 +00:00
Hetal Dhanak 199bf06ca1 [FIX] website_sale_coupon: show promo code success message.
Previously, success message for promocode was visible only
when user clicked on "I have a promocode". even
when it was successfully applied.

After this commit, message will always appear once a promocode
has been successfully applied.

Task-2027008

closes odoo/odoo#34591

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-07-26 08:53:36 +00:00
Yenthe666 a2a5ff806e [IMP] crm_iap_lead,website_slides: add name on main elements
for easy xpaths

closes odoo/odoo#34909

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-26 08:13:55 +00:00
Yenthe666 1f87abfead [IMP] utm,website_slides: add sheet to form view
For better rendering

closes odoo/odoo#30629

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-26 08:07:44 +00:00
Khalid Hazam 759130af16 [CLA] BADEP signs Odoo CCLA
closes odoo/odoo#35193

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-26 07:35:29 +00:00
王挺 ac658522df [IMP] Stock: "Manual Replenishment" translatable.
closes odoo/odoo#35200

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-07-26 00:58:47 +00:00
Simon Lejeune 72c36aaf90 [REF] stock: scrap in receipt
In the receipts, you can only scrap after the reception. This implies
that the source location of the scrap move is the destination location
of the picking.

Create the scrap move as draft, else in the receipt it used the state of
the picking (done) and calling _action_done again resulted in double
valuation layers

task-2042399

closes odoo/odoo#35179

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-07-25 14:32:05 +00:00
Enric Tobella 2486259ef9 [IMP] base: reduced number of checks on module loading
If you have a module with several dependencies or a complex dependency
graph, the system repeats the number of checks of a module.
For example: we have 4 modules A, B, C and D, where A depends on B and C,
B depends on D and C depends on D.
Before this patch, we check once if A is installed, once if B is
installed, once if C is installed and twice id D is installed.

With this patch, D is checked only once.

On this example, the difference is minimal but on worse scenario as
explained on the below issue, the processing time was provoking a
timeout on test platform
https://github.com/odoo/odoo/pull/29779#issuecomment-452821082

Cherry-pick to master of #29779

closes odoo/odoo#35185

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-25 14:01:55 +00:00
Lucas Perais (lpe) a6f66f8bcf [FIX] web: translatable size of binary fields
Before this commit, the string containing all size units for binary fields
was comma separated.
The problem with this is that comma got also translated into the language's specific
comma-like, whereas in this case it is obviously a technical separator which shouldn't be translated

After this commit, we separate unit size with pipes (|), hoping that this character
- is easy to find on any keyboard
- has no language specific equivalent

OPW 2041975

closes odoo/odoo#35183

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-25 13:03:48 +00:00
王挺 3d397f208a [CLA] Add another email to tanghulu0608
closes odoo/odoo#35160

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-25 14:09:37 +00:00
Adrian Torres bc99500799 [FIX] base: fix oversight
The bug triggers during an upgrade of base (tested while migrating from
12.0 to master).

Introduced at 074074e570

closes odoo/odoo#35153

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-24 14:52:03 +00:00
Robot Odoo 46843ee488 [MERGE] event(_sms): integrate SMS into event communication scheduler
PURPOSE

Allow the user to schedule SMS communication on events

SPECIFICATION

In event.event form view:
* rename tab 'Email Schedule' to 'Communication'
* add a selection field at the beginning of event_mail_ids with label 'Send'
and values 'Email' and 'SMS Text Message' (required with default value
'Email');
* add support of SMS template and SMS sending in event communication;

Add SMS template data
* Name: Event: Registration (see data)
* Name: Event: Reminder (see data)

Improve registration model
* add a mobile field to the attendees form view: https://nimb.ws/p0VvyS

Technically this task uses the newly-introduced API methods allowing to
send and schedule SMS.

MIGRATION

Some notes on migration

* event.registration: new mobile field in addition to phone, may be void;
* event.type.mail and event.mail: new notification_type field. Existing
rows: set value to 'mail'.

LINKS

Task 1922187

closes odoo/odoo#34705

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-07-25 17:27:00 +02:00
Thibault Delavallée 62ac23f0b9 [ADD] event_sms: allow to schedule SMS in event communication
PURPOSE

Allow the user to schedule SMS communication on events

SPECIFICATION

In event.event form view:
  * rename tab 'Email Schedule' to 'Communication'
  * add a selection field at the beginning of event_mail_ids with label 'Send'
    and values 'Email' and 'SMS Text Message' (required with default value
    'Email');
  * add support of SMS template and SMS sending in event communication;

When sending SMS on event registrations, keep a log of what has been sent.
Use mobile or phone field of event registration as both may contain valid
values, like partner model.

Add SMS template data
  * Name: Event: Registration (see data)
  * Name: Event: Reminder (see data)

Improve registration model
  * add a mobile field to the attendees form view: https://nimb.ws/p0VvyS

Technically this task uses the newly-introduced API methods allowing to
send and schedule SMS.

LINKS

Task 1922187
Part of PR #34705
2019-07-25 11:47:20 +00:00
Thibault Delavallée 2e2fd3f8a7 [IMP] event: improve test class and data to help reusing them
PURPOSE

Allow the user to schedule SMS communication on events

SPECIFICATIONS

In order to add tests this commit performs a quick cleaning of event common
class to speedup and prepare new tests.

Containing
  * move data creation in class and use savepoint;
  * move registration creation in its own method to allow calling it if
    necessary;
  * clean some unnecessary variables.

LINKS

Task 1922187
Part of PR #34705
2019-07-25 11:45:08 +00:00
pha-odoo 947715b046 [FIX] iot: pass dict to scale action
Scale action took a string as argument.
It now takes a dict so parameters can be passed to action methods.

closes odoo/odoo#35136

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-07-24 09:42:44 +00:00
Xavier-Do 735ee5487c [IMP] core: improve test logs
1. Make test logs clearer & remove redundancies

Instead of having an ERROR log right when the test fails then print
the useful / relevant information at the end of the test suite,
immediately print the traceback. Keep the final summary. Also avoids
having to wait for the entire test suite to end before a dev' can know
the failure details of a specific test.

Done by working at a lower level and replacing the custom
test stream mess by a custom Result class which prints and formats the
information we want. Replace TextTestRunner by a bare-bones custom
Runner object to tie it in.

2. Provide useful location information on test failure

Leverage the work above to log the test function's failure location:
previously logging would point to within TestStream which is not
useful.

Here, on failure the traceback is used to discover the caller info and
point to the test line which fails instead. similar to unittest's
_exc_info_to_string (https://github.com/python/cpython/blob/93e8aa62cfd0a61efed4a61a2ffc2283ae986ef2/Lib/unittest/result.py#L173).

3. Replace direct logging in browser_js by raising errors

Properly marks the test as in error, and the error traceback points to
the tour definition / launcher (python side) rather than common.py
and/or module.py.

Also removes unused dbname parameter that was added in
/278ed718e9805edf088642ba10d3b7c4e5716c31/openerp/modules/module.py#L361
for nor visible reason

closes odoo/odoo#34996

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-07-25 12:09:27 +00:00
Alexandre Kühn cda4f3c308 [FIX] mail: send ir.needaction notifications
Revision on https://github.com/odoo/odoo/commit/de7c119e666d108564b3889d1c08e5bf2e4da082

Partners are registered on notification channel
`(dbname, 'ir.needaction', partner_id)`.

closes odoo/odoo#34974

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
2019-07-18 10:12:16 +00:00
Christophe Simonis 18edb1c205 [FIX] stock_account: adapt test to new version (again)
The right patch was already there, I should just have to remember to get
it. See https://github.com/odoo/odoo/pull/34912#issuecomment-511794024
2019-07-26 17:56:21 +02:00
Christophe Simonis 7233c6ffa2 [FIX] stock_account: adapt test to new version
Oversight of previous forward-port.
2019-07-26 16:33:08 +02:00
Antoine Guenet af56405753 [FIX] website_form_editor: properly edit select fields
Select fields were not `contenteditable=true`, which means they could
not be edited. Besides, being that each of their option was individually
considered a snippet, and that they were contained in `div` tags, they
were effectively unbreakable, which means that adding new options by
hitting `ENTER` did not work (note: this also currently doesn't work
properly in v12.0, for other reasons as the concept of an "unbreakable"
node didn't exist yet). This fixes those issues.

closes odoo/enterprise#4817

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

X-port/Cherry-pick of odoo/enterprise@af51d9ff2a
2019-07-26 15:21:48 +02:00
Christophe Simonis bfd34e14b1 [MERGE] forward port branch saas-12.3 up to 40e8b67179 2019-07-26 15:12:29 +02:00
Christophe Simonis 40e8b67179 [FIX] mail: add missing requirement in test
Oversight of previous forward-port.
2019-07-26 14:34:48 +02:00
Christophe Simonis e0f9c092cc [MERGE] forward port branch saas-12.2 up to 1d6d790513 2019-07-26 11:32:43 +02:00
Christophe Simonis 1d6d790513 [FIX] mail: adapt test to new version
Oversight of previous forward-port.
2019-07-26 10:36:18 +02:00
Christophe Simonis a4b1b532ea [MERGE] forward port branch 12.0 up to b82df99d7a 2019-07-25 20:01:05 +02:00
Christophe Simonis b82df99d7a [MERGE] forward port branch saas-11.3 up to 5f419d4ad3 2019-07-25 18:38:32 +02:00
Christophe Simonis 7702d07d39 [FIX] base: force user's group view update when deleting a module category
On the users' view, groups are shown grouped by application (module category).
Deleting a module category should, therefore, regenerate the view.

closes odoo/odoo#35181

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-07-25 14:21:53 +00:00