When checking the DOM for tour step trigger, the ":visible" jQuery
filter was used to get the visible elements. The problem is that this
filter does not care about the visibility css property. So, for jQuery,
a display:block and visibility:hidden element is visible.
This was an issue as kanban ghosts or settings panels in odoo are
hidden thanks to the visibility property instead of display.
Commit 57c09e8a8e was supposed to fix the problem but only made it
worse in some cases. Since the new option parenting system, the
customize button visibility should not be determined on creation as
parent and own options are appended on snippet focus. Also, removing
the dropdown header if it was alone was a bad idea as this is it which
contains the information of options and all the options have not
necessarily a <li/> tag in the dropdown.
For example, the many2one option has no <li/> in the dropdown and is
the only option of the field snippet. So with the previous commit, the
dropdown header was removed as there is no <li/> in the dropdown other
than this header. So as the header was removed, on snippet focus, there
was no way to determine the many2one option exists, so its on_focus
method was not called.
Now, the dropdown-header is always kept. The visibility of customize
button is determine on snippet focus.
The field price_subtotal_signed on an invoice line contains the line
subtotal:
- untouched if the invoice is of in_refund or out_invoice type,
- negated if the invoice is of in_invoice or out_refund type
At one point in time (not found), commit 649b289f using absolute value
of price_subtotal was introduced because price_subtotal_signed sometimes
had the wrong sign.
But this is source of an issue since it is possible to have an invoice with
two lines such as : 100€ and -20€, the report would then display 120, whilst
80 should have appeared.
This commit remove the use of absolute value, and if some old report data
(pre saas-6 migration with wrong migration script) are reported wrong
for an instance, it should be corrected manually.
opw-683952
closes#13118
After commit 6739e10, we have two widgets to be able to choose
two dates according to the operator (e.g. between).
So, the second widget is not always available.
'toString' generates the string to put in the facet and should
convert the second date only if the second widget exists.
Before this commit, it was not possible to make search filters with
only one date because we try to get value of widget that does not exist.
Commit 9b69184ff. removed field 'state' of model 'project.project', and
converts domains using it to use field 'active' instead. However, the domain
of the many2one field in the task form view hasn't been correctly converted
(['state', 'not in' , ['closed', 'cancelled']] should be ['active', '=', True]).
The many2one fields and their search bar were not working anymore since
the loss of some functionnalities with commit b309f3ab54.
* The dropdown which regroups a snippet options list is hidden if it
does not contain any option. This was not the case anymore because it
now always contains a dropdown title. This is fixed by simply removing
this title if it is alone in the dropdown.
* Snippet options attached to an element whose parent is not editable
cannot be moved/deleted/duplicated as it is supposed to remain where
it is. This is often the case for many2one fields and the feature was
simply lost in the refactoring.
This fixes an issue when a one2many computed field is recomputed: all computed
lines are created twice.
Consider a simple case, where the value of the field is a single line. The
execution goes as follows:
* invoke `recompute()`
* write value `[(5,), (0, 0, vals)]` to the field
* command `(5,)`: invoke `unlink()`
* delete existing lines
* invoke `recompute()`
* write value `[(5,), (0, 0, vals)]` to the field
* command `(5,)`: invoke `unlink()`
* no more existing lines, return
* command `(0, 0, vals)`: invoke `create()`
* create a new line
* mark the field as recomputed
* command `(0, 0, vals)`: invoke `create()`
* create a new line
* mark the field as recomputed
There is a recursive call to `recompute()` inside `unlink()` that recomputes
the field while it is being written. The fix simply prevents the recursive
call to `recompute()`, just like in methods `create()` and `write()`.
Commit cfb8e8700a introduced a new template for meeting invitation page.
This template used bootstrap row's without any container which added
an ugly useless scrollbar at the bottom.
This commit uses valid bootstrap by simply removing the bootstrap
column layout (as there is no column but only centered content) and
using a simple container. Also, wraps the table in a .table-responsive
div so that the template is mobile-friendly.
Also fixes a typo in the template name.
This tries to be the smallest patch possible in order to avoid triggering
another display issues, so we only patch in the ms-hight-contrast section
which only applies on ie 10/11.
* The view-manager weren't displayed correctly; they didn't fit 100% of
the screen width. This is fixed by explicitely seting the top, right,
left, bottom attributes.
* The modals content were not displayed. This was due to 2 issues:
* The rule that we patch in the first point set the position of
`oe-view-manager` as absolute with an importang flag. Because of
this important, the rule that reset the position of the
`oe-view-manager` as static in modals.less was not honored. So
we also patch this rule with an important flag inside the same
file (so that all the fixes related to ie10/11 are in the same
place).
* Now that the modals are displayed, they do not fit 100% of the
screen. It's because the `max-height: 100%` of `.modal-content`
set in modals.less does not work in ie10/11, due to some bug
with the flex displays. We set the height to 450px so that the
modals are kind of correctly displayed on a 1366x768 screen
(their content are still scrollable).
related to rev 1ccd87a037closes#12929
The field symbol is not required on a res.currency (it should and will be
changed in master). In case it is not set, do not display the currency in the
rapport.
Fixes#11346
FIX 1
-----
If the partner_id is not allowed, we return the placeholder.
Before this commit, the status as undefined and raise traceback.
UnboundLocalError: local variable 'status' referenced before assignment
FIX 2
-----
Fix the defaultheader to avoid to have:
[[('Content-Type', 'image/png')], ('Content-Length', 43)]
And so, during parsing by werkzeug:
ValueError: need more than 1 value to unpack
Change default definitions of funds clearing accounts to be assets
instead of liquidity. Without this fix, reconciling to these
accounts during bank reconciliation is not generating the correct
journal, but is treating the process as a matching step (which it
is not).
For existing data, the accounts will need to be manually changed
from liquidity to current assets.
Closes#12996
Commit 977db823c7 refactored the web module so that it gathers
common features of community and enterprise. The problem is that the
web.webclient_bootstrap template content lost its groups attributes.
This had the effect to make the client crash when accessing the
template for calendar invitation for example, as the template was
trying to render menus without menu data.
The button does not recompute the cache, it removes it which will be recomputed
when you launch a POS.
Hide the button when there is no cache (e.g. after installation).
The main content of the web client was set to grow/shrink so that it
fills the window (thanks to flex). However, to be able to shrink as
much as necessary the min-height needs to be forced to 0.
Without this fix, the web client was overflowing on the bottom of the
page, making impossible to access some menu items.
The price of the delivery is incorrectly converted to the currency of
the user in the payment template (next to "Total").
Instead, it should be in the currency of the sales order.
opw-682306