View rendering from javascript has recently been made to check
permission(through PR #44993).
Some assets required by the iframe editor are rendered in JS so that they
can be injected into the iframe, but their permissions had not been updated.
It causes a crash while creating website popup and resulting into an empty
html field ('Website Popup Content').
This commit fixes that by adding groups="base.group_user" to the
required template.
Task Id : 2292026
PR #54798closesodoo/odoo#55626
X-original-commit: c4fed6350f0024e809a2fc632891aab8be05d25e
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
A POS payment method should be translatable.
opw-2314353
closesodoo/odoo#55623
X-original-commit: 84cb31f8632785caf9a313c8423550b5ca51ed11
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
According to what has been discussed in https://github.com/OCA/l10n-spain/issues/1434, there's a problem with
this account, that can be put in 2 places in the balance sheet, depending on its
nature.
Unfolding it in 2 using same prefix, we can guide users in which account they
should book their balances according the nature, and define reports according
these accounts without the need of modifying them each time.
ClosesOCA/l10n-spain#1434closesodoo/odoo#55619
X-original-commit: d8a9fc8b5ef858942c6529e09cb75a11225519d3
Related: odoo/enterprise#12295
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Before this commit, the 'snippet_option_update' event was triggered
whether or not it was a preview update. In the preview update case,
nothing was done, ever. This commit removes the preview notification.
If it ever becomes useful, it can be restored at that moment.
This commit actually solves a bug introduced by [1]: that snippet update
notification is now triggered after a setTimeout delay to allow events
to bubble before the UI update it will trigger (in non preview mode).
The side effect this had was that, between each preview, the execution
chain was deferred of a setTimeout delay between each step (even though
previews do not update the UI). This was enough to allow for a paint
refresh.
So before this commit, if option C was selected, then the user hovered
option A then option B, the option C was visually re-enabled between A
and B. This won't be the case anymore after this commit.
Long story short: restore no-flickering when previewing options.
[1]: https://github.com/odoo/odoo/commit/2616c8950fd615561e720660bcc39e018f4061e4
Part of https://github.com/odoo/odoo/pull/55588closesodoo/odoo#55588
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: website
Before this commit, editor widgets were updated by 3 successive calls
to methods 'setValue', 'updateUI' and '_updateUI'. The last two were
in charge of updating the UI depending of the value that was set, only
in specific condition (like "if the widget is not focused", "or not
previewed", ...).
This is now in fact useless: 'setValue' can be in charge of the UI
update. Indeed, when a value is set on a widget there is no reason to
not update its UI anymore. This was useful when the UI was updated on
preview, which is not the case anymore. This could also be useful for
widget with multiple options attached to them... but in those rare cases
updating the UI multiple times (one time per option method) should not
be a problem.
Part of https://github.com/odoo/odoo/pull/55588
_read_from_database was removed in the ormpocalypse of 13.0 . It was used in
hr leaves report to make leave name (holding description) anonymous for
people not belonging to HR groups. Since 13.0 _read_from_database has been
removed. A security has been added in read_group itself, preventing to try to
read name through read_group.
In this commit we therefore simply remove dead code as the feature itself
is still alive.
Task ID-2285881
closesodoo/odoo#55610
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
timeout should be an integer
closesodoo/odoo#55103closesodoo/odoo#55586
X-original-commit: 9dbc3e3807750ae471b8ede61674ce05ca30c0cf
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
- Install Contacts and Belgium - Accounting (l10n_be)
- Go to Contacts and create a new Contact:
* Select Switzerland as Country
* Enter "CHE-123.456.788 TVA" ad VAT
The VAT is auto-updated to "CHE123456788TVA", removing all special characters.
The entered VAT is converted to its minimal representation, stripping whitespaces and seperators.
And it is this compacted value that is stored.
As defined here (https://www.estv.admin.ch/estv/fr/home/mehrwertsteuer/fachinformationen/steuerpflicht/unternehmens-identifikationsnummer--uid-.html),
the Swiss VAT format should be CHE-XXX.XXX.XXX TVA.
Therefore, the VAT will be automatically formated to the official format.
opw-2291581
closesodoo/odoo#55582
X-original-commit: d75614e22f5b0b72e6bebd9cafba36fe32b9eb51
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Allow the user to indicate if a column should be visible or not on
mobile viewport.
task-2308828
closesodoo/odoo#55195
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
PURPOSE
Remove an unused template that was never called. Let us clean it.
LINKS
Task ID-2241513 (eLearning onboarding and testing)
PR #55567closesodoo/odoo#55583
X-original-commit: 0f160586afdf139781049fd95c8c56e80c5522da
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
PURPOSE
Before this commit, when you used the 'image' widget when the record name was
``..`` (double dots) it couldn't retrieve the image since the double dots was
decoded as the parent directory shortcut. After this commit, the double dots
will be replaced by -- with the downside to loose the true record name.
SPECIFICATIONS
Replace the .. (double dots) with -- in the filename.
Using .. may seem like a strange use case but if you actually try to find
a partner called ".." in a production database, you might be surprised ...
LINKS
Task ID-2241513 (eLearning onboarding and testing)
PR #55567
X-original-commit: dcb7a924c36cd3f3aeef891ddd8830bd66322025
PURPOSE
The rating_avg calculation wasn't correct. It divides by 100 instead of
multiplying by 100.
Followup of e4a4ffb974
LINKS
Task ID-2241513 (eLearning onboarding and testing)
PR #55567
X-original-commit: 35e286b9295d692bbeadea3e65708de4376924db
- Create an invoice using a tax exigible on_payment.
- Refund the invoice with 'Full refund'.
=> Traceback: The lines are already reconciled.
Explanation:
Odoo tried to reconcile all lines having a reconcile account, including the one set on taxes.
- The first reconciliation is made on the receivable account triggering the cash basis entries that will be reconcile with the tax account.
- The second reconciliation fails because the account has been reconciled to the cash basis entries.
closesodoo/odoo#55594
X-original-commit: 01f2a4c3d95b4ea762ef34ae56ee717a9614cb1a
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
When trying to generate translation for a model that is not present in
the registry (leftover of migration?), the code used to return
self.browse(), expecting an empty recordset.
self was however a TranslationModuleReader that has no browse method
return empty recordset with no model specified
closesodoo/odoo#55574
X-original-commit: c004f00bdec83b7c56664425011db53db85da53a
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Remove the support and the conversion from record to localId and back from
localId to record.
Part of task-2308312
closesodoo/odoo#55481
X-original-commit: fc5e8be4e65518770a281f0dffae07854d20073a
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, redirection to non-channel/non-partner origin
thread was opening the form view of partner with matching id with
origin thread.
This happened because such redirections used hard-coded model
'res.partner' instead of the actual origin thread model.
task-2312993
closesodoo/odoo#55463
X-original-commit: 773cb5ddfd4c63fb9387623494d344e20520acba
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
This fix non-appearing chat windows if messaging becomes initialized after
ChatWindowManager was first mounted.
closesodoo/odoo#55592
X-original-commit: 96f5bfb9da21668eadaa7bbe81d10d0bfd4f4483
Related: odoo/enterprise#12286
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit, the rating buttons were displayed inside the
chatter an could be used to "rate" from there. Intend is to display
these buttons only on email: the message in chatter should not have
these buttons.
This commit fixes the problem similarly to what has been done in
13.3. Note that this solution is quite poor, because it could remove
content from other messages that inadvertently hit this CSS selector,
but at least it works for all existing rating messages.
task-2282414
closesodoo/odoo#55591
X-original-commit: 4474adef45be3289728edc289ecc71c38abcf1b8
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Issue
- Accounting & Purchase
- Create a PO for wood corner
- Create a bill for wood corner, add a ref
and auto complete with the previous PO
The ref is replaced by the PO's one
Cause
In purchase account_invoice _onchange_purchase_auto_complete
we update all the bill values with the PO values including
the PO ref (empty or not)
Solution
Exclude the ref of fields to be updated
OPW-2313418
closesodoo/odoo#55560
X-original-commit: ae0c3b600403a21a196e51ce88fa6b25990f2b64
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
From the Sale app create a new Quotation with a long customer
reference. Click on "Save" and then Print.
In the generated report the fields relative to the order details are not
correctly displayed: the general font size is scaled down to make the
text fit the page which is not the correct behavior.
The font size should remain fixed and all the element
should be visible, eventually spanning over multiple lines.
This is due to the broken bootstrap support of QtWebKit, used by
wkhtmltopdf to generate pdf reports.
In particular the new flexbox style introduced in the library is not
supported and every element based on it will be ill-displayed.
The solution is to fall back to the subset of supported features to
implement a different solution, which keep everything on one line but
avoid the font resizing and every possible overflow.
opw-2261573
closesodoo/odoo#55555
X-original-commit: 2dd3ed327aad6fecdcfd4b53c4338bf47e44401b
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
The problem of using fields.Date.today() instead of
fields.Date.context_today() arose with the recent changes in the
account.move._post() method used in the POS tests, around 1 am.
This commit changes all occurences of today to context_today.
closesodoo/odoo#55511
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
- Install hr_timesheet and sales;
- Create a product, set it as a service product with units of
measurement in days.
- Set the product as a task will be created from SO;
- Add a timesheet for one day to a task in a project (8 hours for
instance);
- The smart button on the sales order shows the time logged for that
project.
Before this commit, when the timesheet encoding unit is 'Hours', the
smart button shows the correct logged time (8 hours). But, when the
timesheet encoding unit is changed to 'Days', the samrt button shows
0.125 Days instead of 1 Day. This occurs because the uom used to create
the uom factor for the widget is not the Timesheet encoding unit.
opw-2301510
closesodoo/odoo#55544
X-original-commit: 2a7ec79c6a4563b608a4525ebccdea5978799caa
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Since commit 1b30a78b, LRU is now based on OrderedDict and keys can be found
on dictionnary 'd' directly.
closesodoo/odoo#55541
X-original-commit: 3f093da75765d66ed1e2d828e8b41ed05d936d0b
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Thanks to this setup, we will be able to run the tours independently to any demo data.
To do so, the HttpSavepointCase is born to do the same as HttpCase but with a setUpClass.
--task: 2290120
Since [1], the sub-headings edition was not possible anymore in the
'options' tab of the editor panel. This is because the visibility of
rows is now automatic, depending of the visibility of the inner widgets.
The custom code for that row visibility, controlled by the user, was
thus not working anymore.
Note: this fix solves the problem with big hacks. Better code will
handle foldable zones generically.
[1]: https://github.com/odoo/odoo/commit/8d57f21d7df2033f462ead60fcb5abba4546213e
Part of https://github.com/odoo/odoo/pull/55529closesodoo/odoo#55529
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: web_editor
This will more probably change again in the future but this is a first
step towards a hierarchized 'options' tab for the editor panel.
Part of https://github.com/odoo/odoo/pull/55529
- Create a product P which cannot be sold (purchase only)
- Create a customer invoice
The product can be select on the invoice.
The `sale_ok` (as well as the `purchase_ok`) field is not taken into
account in the domain.
The solution is a bit hacky but has the advantage to be safe in regards
to customizations.
opw-2308897
closesodoo/odoo#55442
X-original-commit: 88b0b664606bb42acf26165e2b7fdda44a15e0a7
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
To reproduce (V12) using a fresh database with demo data:
1. Install eCommerce and Sales
2. Change Mitchell Admin settings so that he can see the 3 companies
3. Go into Settings and set a distinct "Terms and Conditions" text for each companies
4. Go the Website > Configuration, set "My website" to "Company_1" and save
5. Go to the website shop and buy any items
6. Find its corresponding Sale order (should be on Company_1)
=> "Terms and Conditions" used in the SO is the one of "YourCompany"
Analysis:
The terms and conditions are not specified in the SO creation,
so it runs the default value code to determine its value.
However the default code just ask to use the OdooBot company "Terms and Conditions".
https://github.com/odoo/odoo/blob/b6bf91d26b8fb45997b266c16be620d834a97cc7/addons/sale/models/sale.py#L121
OPW-2297114
closesodoo/odoo#55424
X-original-commit: 60565b5cd42da080e36fee5a94bcf8eafd15934d
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
When sending a letter with a PDF containing pictures, it could happen that the default timeout of 15s is too short.
Parameter "snailmail.timeout" has been added to allow configuration of this timeout.
Also a default value of 30s has been set instead of 15s.
opw-2276125
closesodoo/odoo#55415
X-original-commit: 796373ae674248cb96c576ccb968d7f19a732317
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Issue
- Login as Mitchell Admin
- In Projects module, Create a new project
- Set Visibility to 'Invited employees'
- Create new task and assign it to Mitchell Admin
- Edit the task and add Marc Demo as follower
- Login as Marc Demo
- Go to the task previously created
- Add an other follower
IrRule Error
Solution
Use sudo() to find all followers of a document.
opw-2303443
closesodoo/odoo#55521
X-original-commit: e0d064ffe4013ed727bdc780a3d0a7c6b16e6e9c
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>
Some module description had changed without updating the .pot
closesodoo/odoo#55503
X-original-commit: ae3c28fe189468e91872971c397e62bad30e28f0
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Issue
- Sales > Create a quotation
- Click on quotation date or start
writing in it
On chrome, if addresses autocomplete is enable
and have data to show, a dropdown will overflow
on the datepicker
Cause
This is mainly a chrome issue and the only way
to solve it without a fix is to disable the
autocomplete totally which is not really a
solution since we want the autocomplete on
adresses
Solution
Add the autocomplete off on datepicker field
OPW-2308278
closesodoo/odoo#55470
X-original-commit: b40fef968ab000870574ae45ba482288cdf94ad1
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
Currently, when form view is opened in edit mode and if you proceed
through the tab(keyboard) then focus is skiped on radio field.
For Ex: in project when you procceed through the tab it will skip the
visibility field radio.
The issue occurs because the radio is inherited from the selection
field and in selection field the focus is set on 'select' while
there is no method to set the focus in radio and radio does not have
'select' element it has 'input'
So in this commit, override the method getFocusableElement in radio
widget and set the focus on 'input' instead of 'select'.
closes odoo/odoo#52073
Taskid: 2252798
Closes: #52073
Related: odoo/upgrade#1430
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Purpose of this task is, the invoicing wizard is being able to
define a period with a start and an end date would allow a bit
more flexibility.
Currently, the invoicing wizard allows to invoice timesheets
up to a certain date.It is links all timesheets before or equals
this date in the sale order are invoiced.
In this commit, we add another date field so that the user can
define a period with a start and an end date and rename the
'invoice timesheets up to' field into 'Timesheets Period'. Also,
use widget 'Daterange' in both fields and update tooltips
accordingly this fields. By default we leave this two field empty.
After this commit behaviour of invoicing wizard:
-If these fields are empty, include all timesheets without
distinction in the invoice
-If these fields are set, only include the timesheets that fall
within this period in the invoice
-If applicable, only include approved timesheets
TaskId:2252798
Closes: #52073
Currently, in Configuration > Service Type > Add a new service type.
The category field is mandatory but it does not appear on list view.
So in this commit, display the mandatory category field on list view
Currently, in Configuration > Manufacturers. The count of Models is
always 0 because the it's compute stored field without the depends
so not computed each time.
So in this commit, fix the count of models by adding a correct trigger
closes odoo/odoo#55475
Taskid: 2296851
Closes: #54515
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
The following changes are made in this task:
1. Remove order tabs and replace with ticket list.
2. Top bar color change.
3. Search bar in the product screen is moved in the top bar.
4. List of sub-categories are now in the same line as the category
breadcrumbs.
closesodoo/odoo#55100
Task-id: 2276678
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
The method `_get_unavailable_intervals` was only available on
`resource.resource`. It's now moved to the `resource.calendar`.
closesodoo/odoo#51311
Taskid: 2253893
Related: odoo/enterprise#10616
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Make the employee presence icons more descriptive.
Allow to quickly filter the Presence Reports based on the user status.
closesodoo/odoo#54527
Taskid: 2246447
Related: odoo/upgrade#1488
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Installing base_automation module the methods: create, write, unlink and compute_field
are patched.
So, they will be used for all models.
It is important to save resources as possible.
The patched methods in base.automation read the original data
before to change so run all base.automation records.
But What about if there are not base.automation records?
So, we can save an extra read for all models
The same to pre-filter and post-filter
It adds a return early in order to skip this extra task when it will be useless.
closesodoo/odoo#52134
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Purpose of this commit is to add some mass mailing tests in test mail full
(with all community mailing capabilities installed). In this commit we notably
tests unsubscribe and view URLs computation in sent emails, as well as
the invisible preview block for email clients.
Task ID-2239327
Task ID-2239327
PR #49886
Related: odoo/enterprise#10091
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
PURPOSE
When displaying an email in a list the mail client (gmail, outlook...) computes
a preview based on the content. This preview is generally not well computed as
it contains a lot of garbage and tags while it should contain only relevant
text.
SPECIFICATIONS
To build this preview, all mail clients read the content of the email.
The only way to be able to customize the preview is to add an invisible
HTML element at the beginning of the email with the wanted preview text.
We add at the end of the preview `‌` (zero-width non-joiner) to
fill the end of the preview in order to not have the beginning of the
mail at the end of the preview. It doesn't work with simple space as
the mail clients trim each HTML element content.
Task ID-2172125
PR #49886
asa-odoo