reuse current_thread result
No needed to call threading.current_thread() on evry arg setting
closesodoo/odoo#32000
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
There was one tax group per tax which was strange, so remove all duplicated tax group and only keep one tax group per tax percentage (0%, 6%, 12%, 21%)
closesodoo/odoo#32517
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
While everything looks pretty perfect without this commit,
setting margin on `.dropdown-toggle` and not on its parent
`.o_dropdown_kanban` itself will cause glitches in Studio.
While selecting the dropdown using Studio, the class responsible
for displaying outline (that indicates the selection) is applied
on '.o_dropdown_kanban', which is okay, but the actual child is
positioned using margin, so the outline on parent div looks ugly.
This commit fixes the issue by applying the margin on the proper
selector.
Task 1916583
closesodoo/odoo#30049
Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
This commit improves the usability of ModelFieldSelector widget
with following points:
- add a placeholder on the input for searching fields
- add more height to the same input for consistency
- properly show 'X' sign within header
Task 1916583
Before this commit, if none of the pricelist is available for the website
then frontend ecommerce will crash. This issue is arrived from #30675 PR.
The reason behind crash is, if there is no pricelist associated with
the website then the ecommerce will not get the currency and breaks the
frontend shop.
This commit will restrict user from making those changes which breaks the
frontend shop. We will ensure that atleast one pricelist is available for
each website.
task-1966811
Closes: #32534
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
OPW 1961781
The related field user_type_id on account.move.line was slowing down the ORW when whanging the type of an account. This field was almost never used except in account_reports.
closesodoo/odoo#32303
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Changed the error message when the user hasn't enough karma.
Add link to the FAQ to understand how to get more karma.
Task-ID: 1952473
Closes: #32161
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Rating Improvements on product page:
1) Now we display ratings filter in descending order which
is common behavior for eCommerce/Appstore sites
2) Stop scrolling to top while removing selected rating filter
3) UI improvements for mobile/tablet view
4) Percentage is rounded up to two decimal points so that
it does not look ugly
task-1850446
closesodoo/odoo#28245
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Currently, when we open the website on iPad, the navbar is not displayed
properly (systray items are overlapping on the website menu). This
commit fixes the issue by using '+' icon on the navbar top menus if
there is not ample space. This commit also converts multi company
selector with 'fa-building' and multi website selector with 'fa-globe'
icons on smaller screens.
task-1945020
closesodoo/odoo#32321
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
website_sale adds a call to sale_get_order to ~every website page (in
order to validate & display the shopping cart).
Before this change, this calls get_pricelist_available() and triggers
two different computations of property_product_pricelist on every page
even for a public user with no cart / SO. This, in turn, generates ~20
queries and adds 20ms (total) / 10ms (sql) to ~every page load.
Fix: early return if the user doesn't have an SO (either in session or
in DB) and we're not in a case where we want to force one.
Loading "/" with just website_sale installed on a new DB,
- before: 53 queries, 31ms ±5 (sql), 75ms ±5 (all)
- after: 32 queries, 21ms ±1 (sql), 53ms ±3 (all)
closesodoo/odoo#32492
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Purpose of this task is,
Default payment ref for wire transfer is confusing and not really helpful as it will induce encoding errors customer side
So, I removed modulo part in payment reference
Task Id : 1946656
Closes : #31853
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
currently, if the user selects Multiple prices per product
in Multiple Product Prices, the user cannot set product
directly from product.pricelist formview.
purpose of this commit is to make multiple prices par product
fromview quick editable and reflect that to the product.product formview.
Task-ID: 1904777
Closes: #30540
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Purpose of the task is when extra fee is activated on the payment acquirer,
the customer is no warned about extra cost when choosing the payment acquirer.
so display the extra fees on payment acquirer when doing the payment.
Related Task ID : 1845815
Closes : #31730
On user form view, when no employee is linked to the user, we want
to display a message to the HR Officer (only) with the possibility
to create the employee profile with prefilled information.
Task-1916925
closesodoo/odoo#29659
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
Since d77ce4c2a9, the feature of editing own employee profile was
added. It was complicated with the access rights point of view because the
hr.employee fields are protected (groups="hr.group_hr_user"). To allow editing
its own hr.employee, it was required to `sudo` the field_view_get of res.users
(as the profile form view is a res.users form view, with related field from the
employee).
- Bug
The problem is that calling `fields_view_get` as `sudo` each time breaks the `groups`
mecanism on res.users views (not only form view). For instance, adding a field
on the form view with a group will always make it visible as the `groups`check
is done in sudo mode.
- Solution
This commit tries to fix this matter but reducing the `sudo` usage to
- only form view (we don't want this to applied to every res.users view type)
- only for internal user
- only in the flow of the "self editing profile", by checking the current action
- only for the current user (avoid to get the profile of other res.users by
using the same action)
- Side effect
The `groups` mecanism is still breaking on the "my profile" form view, as the
`sudo` is still applied in that case. We might tolerate this as the view should
only be accessible for the current user.
This is not perfect at all, but cleaning that properly might involve to redevelop
this sensitive feature.
Task-1916925
Task #1949652
Some fields were renamed/moved around to improve the survey.survey
form usability.
closesodoo/odoo#31775
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
In order to allow the user to ealisy retake the survey he just either passed
or failed (in case of scoring activated), a retry button is added not only
in case of failed scoring survey (like it was already the case)
but also for non scoring survey.
This button is also added in the review survey page, to get direct access to
retry the survey.
The rule is the following and apply to all survey types :
If not quizz passed (this will be always true for non scoring survey):
if is_attempts_limited
if attempts left
Add retry button
else
Add retry button
Task ID : 1950429
PR #31802
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
purpose: de88a727b2 introduced
a change in the sale order view. it reduced dramatically the size
of the 'terms and conditions' widget.
This commit set back easily readable dimensions
Task : 1950799
closesodoo/odoo#32129
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Purpose: clean mail.mail creation code and use standard mail creation or
template send_mail method. In those addons we ensure author and email_from
are set to maching values, leading to more consistent emails.
Related task ID 1965040
PR #32459
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose: clean mail.mail creation code and use standard mail creation or
template send_mail method.
In crm iap lead we can avoid custom mail creation by correctly using
send_mail method of mail template and its arguments.
Related task ID 1965040
PR #32459
Purpose: clean mail.mail creation code and use standard mail creation or
template send_mail method.
In calendar there was strange code creating an email based on a template
then updating some values on its mail.message record created through
inherits. It seems simpler to correctly set some specific email arguments
to MailTemplate.send_mail() method and avoid this kind of code construction.
Related task ID 1965040
PR #32459
Attachments when generating an email based on a template are done in two
steps, see notably [1]. However mail generation replaces attachments using
a 6 command. This means existing attachments given through email_values
are not correctly managed and this leads to invalid command given to the
m2m field.
This commit fixes that by correctly generating a list of commands, using
4 (add) for new attachments coming notably from reports linked to the template.
Related task ID 1965040
PR #32459
[1] https://github.com/odoo/odoo/commit/f789005c9a6c26322565a1af7cc4e57a60eab9f0
As a start_tour helper was added on the python side (PR #32316),
a javascript helper counterpart was needed as suggested on the PR.
closesodoo/odoo#32441
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
- Improved description of point of sale application
- Removed status from card like 'In Progress' and 'Unused'
- Click on top-right corner of POS kanban card, it shows 'Sessions' and 'Sales Orders', now it will shows 'Orders' and 'Sessions'. (for usability purpose).
- Improved Multi-Currencies wording same as invoicing
- Removed 'Advanced Currencies Setup' from settings(when clicking on 'Multi-Currencies').
- Improved list view label on 'Point of Sale'.
- Added 'PoS Product Categories' feature in 'Restrict Available Product Categories'.
- In PoS config setting, 'Pos Interface' string is put instead of 'Order Interface'.
- Filter and display issues were there when setting 'Currencies' from 'Multi-Currencies', now it is resolved.
- String 'PoS Product categories' is put instead of 'PoS Category', as it seems meaningful.
- 'Restrict Available Product Category' is ticked but any category is not selected (it means it is kept blank), then all categories are shown at POS screen.
- Allow to set default category from the available categories
- 'iface_start_categ_domain_ids' is removed because domain for 'iface_start_categ_id' is given directly in the model. So 'iface_start_categ_domain_ids' will not be required anymore.
This commit is related to task id: 1925458
closesodoo/odoo#30808
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
On a sale order, if all for product are services, we hide
the delivery related button ('add a shipping cost' and 'recompute delivery price')
Task : 1940491
closesodoo/odoo#32145
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
With this commit, `description_sale` is now editable in frontend.
We also display a clear placeholder to warn user that anything in this field
will be reflected on backend document (SO/Invoices).
task-1951231
closesodoo/odoo#32206
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Before this commit, the syntax to start a tour was extremely verbose.
With this new method, it is possible to start a tour by just giving the
essential parameter: the tour name.
The full set of features from browser_js are kept by using **kwargs.
closesodoo/odoo#32316
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
This merge changes lot of small things in sale modules. The 3
main points are
- Sales Orders form view: reorganize fields for a better usability
and renaming labels
- Sale PDF report: renaming labels and titles, moving some report section
- Quotation Portal: improving style, moving section and renaming labels
Task-1920476
closesodoo/odoo#30550
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
In described Modules, there are some fields label like Unit of measure, Discount,
Ordered Quantity, etc... in views(list,form), report and portal, that are messy
and barely readable when lots of features are installed.
Purpose of the task is to shorter that all fields label to make clean view in
order to make it more readable without getting labels uselessly spread out on
several lines
Related to task #1933746Closes#31962
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Rename the attachment file name.
Restore the option : have the name of the customer who viewed the quotation on the email notification
TaskID: 1920476
closesodoo/odoo#30550
Small changes in quotation portal view:
* Reposition the 'Expiration Date'
* Added Incoterm info
* Added ":" after address
* Rename Details => Pricing
* Rename Optional Products => Options
* Remove "discount" in the column "discount" after the % In the
section "Options" add "10% discount" like in the printed report
* Add payment terms note
Purpose is to make it a little more beautiful and cleaner
for end user.
Task-1920476
Change capital letter "A" in Invoicing Address ..etc
Added space between address and "Quotation number"
Remove the time of the quotation date
Replace "expiration date" next to "quotation date"
Rename Optional Products to "Options" and place it above the terms and conditions.
TaskID: 1920476
closesodoo/odoo#30550
The list view of account.move.line is now editable (and grouped by
account.move by default).
Morever, when grouping by move, there are now action buttons in the list
view header.
Part of task 1915702
closesodoo/odoo#32337
Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
By using proper BS4 classes for alert, so it looks better and it is more
compatible with themes.
Also removed the unused "Option not available".
closesodoo/odoo#32061
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Base issue: unnecessary inherit of composer on mail.message. Indeed there are
a lot of unused fields coming from mail.message as well as message specific
behavior (notify, check access, various business methods) not relevant for
composer.
Specifications
* remove inherit from mail.message;
* re-define used fields;
* ensure everything still works;
Commit linked to task ID 1907153 and PR #28464
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Mail composer does not support channels. Indeed as it can be used to post
a message or send an email it only supports partners. Previously field
channel_ids given to the composer was used only in website_forum. However
it is not used and therefore simplest way of solving it is to remove it.
Anyway allowing to have channels followers of forum tags and being notified
of new publications is probably more spammy than really necessary. Especially
that it never worked.
Commit linked to task ID 1907153 and PR #28464
Some counters are not up to date notably taking in to account community-only
and test-mail with enterprise only counters. Those are used notably when
developing to ease quick check of counters.
closesodoo/odoo#32370
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Kazantcev Andrey