Commit Graph
131573 Commits
Author SHA1 Message Date
Pierre Masereel 5ce1b759ca [IMP] delivery: archive delivery carrier
Since the field active hase been removed from the form view of carrier
we were not able to archive it from there anymore.

So we've added back the 'active' field in invisible on the form view,
and also added a ribbon on archived records.

closes odoo/odoo#39498

Task-id: 2115880
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-10-29 09:58:07 +00:00
Nicolas Martinelli 2bdb85c59c [FIX] point_of_sale, stock: do not crash if no email set
- Create a POS user for which the corresponding partner has no email
  address.
- Connect to the POS with the created user
- Sell a product which creates a picking (e.g. Customizable Desk)

The picking is created in draft and not validated.

This is due to:

https://github.com/odoo/odoo/blob/6435b27c35faeafca452d26fa7fd50a7fe964029/addons/mail/models/mail_thread.py#L2199

We disable tracking and post the message as `sudo()`.

opw-2091808

closes odoo/odoo#39490

X-original-commit: 972b4bad55e76500847a525459865b81d6ad2ee0
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-29 09:23:09 +00:00
Nicolas Martinelli baa243bb46 [FIX] stock_account: value extra move MTO
- Create 2 products A & B in MTO, B with 'Buy' route + supplier
- Create a BOM for A: 1 Unit of B
- Create a MO for 1 Unit of A
- In the PO created, change the quantity from 1 to 2, receive the
  products
- In the MO, produce the unit and use 2 units of B

The extra move of B is not valued.

This is because the list of move to value is created before calling
`super()`. Indeed, the extra move is created in `super()`, and
moreover since this extra move is MTS (not MTO), the move line is
properly linked to the right move (unlike in #39121).

We add the extra move to the list of moves to value.

opw-2087592

closes odoo/odoo#39484

X-original-commit: 00737ffeb8604f1713b559fbd3061b572435b413
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-29 08:15:42 +00:00
oco-odoo 54d846ab1c [FIX] account: tax report lines: use new syntax env.company instead of env.user.company_id to get the default country of a tax report line
closes odoo/odoo#39471

X-original-commit: d62d4e198368a14dff50fd16f391f18c9ceec422
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-10-28 17:21:26 +00:00
Joseph Caburnay 46a897dead [IMP] delivery: clean the shipping methods config
The shipping method configuration (with carrier) is a bit messy,
with a lot of fields which have been added => reorganize the fields
and the view to add coherence (on each carrier + between the different
carriers) and improve ease of use.

closes odoo/odoo#38052

Task-id: 2046300
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-10-17 10:24:44 +00:00
Xavier Morel a480398bf3 [FIX] SSF: modifier based on m2m value
m2ms are internally represented as "6" commands, however in domains
it's possible to compare an m2m value to a list of ids (to
investigate: whether this is an artifact of internal webclient repr or
part of the real contract).

Add a workaround in SSF modifier computation to convert the m2m
command storage to a simple ids list.

A better fix would probably have been to represent the m2m as a list
of ids internally (and only convert on load / save) however it not
completely trivial as it has to be done recursively in order to
properly handle an m2m inside an o2m. So it's a complete change of the
internal data model (which should probably go alongide more
fundamental changes e.g. properly handling parent refs, etc...)

Also add very minor support for widgets (mostly so it's possible to
set widget=many2many on an o2m field).

closes odoo/odoo#39467

X-original-commit: 927979beff9e5d4f6c88078862779eaa88f4e07d
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-10-28 16:03:39 +00:00
Victor Feyens 7720bb21ed [FIX] purchase: sections and notes.
https://github.com/odoo/odoo/pull/34737 didn't go in enough depth to
ensure sections and notes don't break purchase flows.

closes odoo/odoo#39474

X-original-commit: 1e8ea4f5628878dbc667c27d4e76ab42d3f140ea
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-10-28 18:04:23 +00:00
Swapnesh Shah 198f0df814 [FIX] sale: Set default value for sales_count
Fixes https://github.com/odoo/odoo/issues/39431
Assigning default value for non-stored compute fields is required in 13.0

closes odoo/odoo#39468

X-original-commit: b00c9b982241d83f07e03b10851cc55884e3c2fc
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-10-28 16:35:11 +00:00
Victor Feyens fe83659dbf [FIX] stock: lot default company.
closes odoo/odoo#39464

X-original-commit: d0cd57c90bcfdcf98698a68acabdc72001406d13
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-10-28 15:48:20 +00:00
Christophe Simonis 7aa813d023 [FIX] sale_timesheet: force empty context in defined action
Helps module upgrade.

closes odoo/odoo#39461

X-original-commit: d6a69c1ddf1fd8219057bf8f47f271ea5ac95b23
Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-10-28 14:58:57 +00:00
Lucas Perais (lpe) 1d40e94011 [FIX] web: calendar: fetch records in right timezone
Before this commit, the calendar searched records on the wrong time ranges
which did not take into account the timezone of the user
It obviously resulted in some records not being there

After this commit, all the relevant records are fetched according to the right
time range in UTC, corresponding to start/end of the week/month/day of the calendar

OPW 2076114

closes odoo/odoo#39466

X-original-commit: 0f10927efe490bd82e7c23e0fc646dd6c8de2d27
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2019-10-28 15:49:14 +00:00
fw-bot b973577803 [FIX] payment_stripe_sca: include payment reference in dashboard
Makes it easier for users to match Odoo payments with information
from the Stripe dashboard.

closes odoo/odoo#39465

X-original-commit: 0a55cb29542da20bb9d0543e2b30d125124f861b
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-10-28 15:48:55 +00:00
Damien Bouvy b87a0ba88f [FIX] payment_stripe: correct tests
Adapt the API changes in Stripe. Use correct test data existing in
Stripe dashboard for our test account.

closes odoo/odoo#39455

X-original-commit: 4dab64285ab410f239935437b273a0c97951e902
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-10-28 14:16:50 +00:00
Joseph Caburnay 4d91d008c2 [FIX] point_of_sale: pricelist_id in available_pricelist_ids
When Pricelist is activated in the General Settings, pricelist_id field
is now available in the form view even if the use_pricelist is False.
This means that pricelist_id field should be independent from
available_pricelist_ids when use_pricelist is False. The value of
available_pricelist_ids becomes a restriction to pricelist_id when
use_pricelist if True.

closes odoo/odoo#39454

X-original-commit: 98b778de85668d87f2cd2dfc687c2b4c28474b0a
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-10-28 14:16:15 +00:00
Robin Heinz 8e3be15025 [IMP] point_of_sale: Add langage for cutstomer details in pos.
Now we can change the language of the customer inside the POS front end.

closes odoo/odoo#37195

Task-id: 1917704
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-10-28 13:34:20 +00:00
Lucas Perais (lpe) bbbfca2d97 [FIX] web, tools: static inheritance supports replace in debug mode
Have a parent template
Have a child, in extension inherit mode of the parent
The child has a xpath like
`<xpath expr="." position="replace" />`

Before this commit, there was a crash.
That was because the Comment
(which indicates which templates modified the parent)
was taken as the replacer node
instead of the actual content of the xpath

After this commit, there is no crash, and it works as expected

closes odoo/odoo#39453

X-original-commit: 02d790e1d21b78395e489f57bf30c82f728cbee6
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2019-10-28 14:15:53 +00:00
Raphael Collet eccfdd5512 [FIX] models: filtered_domain on Falsy date/datetime fields
The purpose of this patch is to avoid `filtered_domain` to crash with
domains on date/datetime fields when the fields are `False` on some
records:

    records.filtered_domain([('date', '<', '2019-10-28')])

closes odoo/odoo#39449

X-original-commit: dae379adebedb3ed9bd38a2d6925ba6aefef1e7f
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-10-28 13:27:35 +00:00
David Tran 16f548ed7a [FIX] stock: couldn't select another warehouse on product.replenish form
Wrong key in default_get. It should be `company_id` instead of `company`

closes odoo/odoo#39448

X-original-commit: 0859a5b073aeadf7cfa5e32b7c45cce7a1933f0d
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-10-28 13:27:16 +00:00
Hiral Bhavsar 72dd5cdbc3 [FIX] crm: opportunity restored tracking title
Currently, the "Opportunity restored" note appears while changing the tracking
field's value, which is incorrect.

The "Opportunity restored" title should only appear when the modification is
done by clicking on the "Restore" button.

Thus, make a condition proper to display this title "Opportunity restored".

task-2089784

closes odoo/odoo#39447

X-original-commit: 14453bf9dc6677056329b4599c798d6bf5273980
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-10-28 13:26:59 +00:00
Raphael Collet fa991061ee [FIX] base_automation: actions triggered by a field computed with other fields
The issue is the following: if both fields F1 and F2 are computed by the
same compute method, actions based on changes on F1 may not be triggered
when F2 forces their recomputation.  This is caused by the API of the
method `_compute_field_value` that takes as parameter the field that
triggered the recomputation.  The method must consider all the fields
computed by the method.

closes odoo/odoo#39440

X-original-commit: ceddb710a17e552061b9ad3cbc2647d7eae6567d
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-10-28 12:38:45 +00:00
Goffin Simon 6c1340bb6f {FIX] website_event_sale: Updating cart with unavailable ticket
Steps to reproduce the bug:
- Create an event E with max available seats = 1
- Register to E with public user and leave the cart
- In backend, register an attendee for E and confirm it
- Go to the cart, try to update the line with the registration

Bug:

The line was not updated to 0 and so the customer had to buy an unavailable
ticket.

opw:2091720

closes odoo/odoo#39439

X-original-commit: af3938eb3f97a8c8804130788c18b515da1d84e7
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-10-28 12:33:57 +00:00
Jeremy Kersten e19227d3ba [IMP] website*: clean sitemap
From now, you need to explicitely add sitemap=True if you want your controller
into the sitemap.

It's the default value, but if you forgot it, it will raise a Warning on runbot.
It will avoid wrong controller in sitemap and duplicate (empty) content.

From now, if your model contains a field website_id, the modelConverter for
sitemap will automatically add the domain:
   "[('website_id', 'in', (False, current_website_id))]"

It avoid redundant declaration and ugly url in redirect/rewrite view.

Migration: need to remove it from url_from in website.rewrite

task-2065018

closes odoo/odoo#39427

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-10-28 10:36:56 +00:00
jvm-odoo e2176749f6 [FIX] web: fix relational field slow connection multi-edit
To reproduce the issue, go in the settings of the employee app,
simulate a slow 3G connection, modify the working hours:
    * Select the first one, modify it but don't save it,
    * Click on some others working hours consecutively
      They will be all editable
    * Edit them quickly

Before this commit:

    - You get an error

After this commit:

    - You get no error and the behavior is the same than in V12:
      the working hours are updated consecutively

Note: when you stress the relational field quickly, there is a moment
where this.$el is undefined. This is the reason why the error is raised.

OPW-2088558

closes odoo/odoo#39435

X-original-commit: 2acb76ffbb2f1ca2a6af0e316da15ce605f2273a
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-28 11:54:10 +00:00
Swapnesh Shah 5fef9d27d0 [FIX] hr_org_chart: Compute non-stored fields in superuser mode
closes odoo/odoo#39428

X-original-commit: 1f2ff1e93b6fcbf2d6a2153465aa81852cc65816
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-28 11:10:47 +00:00
svs-odooandsle-odoo 596b246f93 [IMP] stock: add signature field on picking
On a delivery type picking, adds a button to able the partner to sign
the delivery on receipt.

task-1878607

closes odoo/odoo#39183

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Co-authored-by: sle-odoo <sle@odoo.com>
2019-10-28 10:46:06 +00:00
svs-odoo c5fbb9cc23 [IMP] web: add widget signature
Adding a new widget to display a sign button in the form view.

task-1878607
2019-10-28 10:46:06 +00:00
svs-odoo 49b5f30202 [MOV] web: signature_dialog
Remove SignatureDialog from `signature.js` to put it in its own file,
`signature_dialog.js`. The purpose of this change is to be able to
require SignatureDialog in any other file and to separate dialog and
field business.

task-1878607
2019-10-28 10:46:06 +00:00
Hetashree Chauhan 3116191e78 [IMP] mrp: log activity on parent manufacturing order.
Before commit: - If there are multi level production order,
and user cancelled any one then,
there is no activity logged on related production order.

After this commit: - In multi level production order
(i.e. one production order creates another production order
to consume the raw material)
 if user cancelled raw material production order then,
exception will be generated on main production order,
so that user can easily get the idea that
raw material for this production order is not available.

[ADD] sale_mrp: add testcase for cancellation of the multilevel production orders

task-1819526.

closes odoo/odoo#28708

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-10-28 10:30:29 +00:00
Joseph Caburnay 2bc65e9052 [FIX] base: residue after making res_name a non-stored field
res_name is made non-stored in 8fffe89b0481af057fd6908a52af775578b9fce1
but the groupby filter using the field is not. The filter has to be
removed as well because groupby only works with stored fields.

closes odoo/odoo#39396

X-original-commit: 495124497c733b4bb272fb0d65e132b024a99917
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-10-25 16:08:50 +00:00
Joseph Caburnay 84a981dc9c [FIX] point_of_sale: no read access to bank statement
When installing point_of_sale, the admin user only belongs to
group_account_invoice and not on group_account_user. Because of this,
the record rule define in point_of_sale that allows access to
account.bank.statement and account.bank.statement.line models does not
work as intended. This commit now allows read access to the said account
models.

Task-id: 2083597
X-original-commit: b521605c166ba03079bc15899a7dc3129326c98c
2019-10-25 16:08:50 +00:00
svs-odoo b95651f681 [FIX] product_expiry: quant expiry search filter
Before this commit, the "Expiration Alerts" search filter for quant
return a traceback because it tries to render hours/minutes/seconds but
there aren't supported. This fix just removes them.

closes odoo/odoo#39416

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-10-28 08:59:34 +00:00
Aurélien Warnon aa53ba02fe [FIX] website_slides: fix course_member tour rating step
The last step of the 'course_member' test tour adds a new rating on the course.
This commit improves the test by actually checking the rating is added.

At the same time, we fix a potential build error caused by the fact that the test was closed
potentially before finishing the rating request.

Task#2091810

closes odoo/odoo#39393

X-original-commit: e26e99fae06d49f83ed2bfc9927dc60ec1af3b83
Signed-off-by: awa-odoo <awa-odoo@users.noreply.github.com>
2019-10-25 15:24:25 +00:00
Katherine Zaoral e32e73dbbe [ADD] l10n_ar: add new CUIT number to Reponsable Inscripto demo company
closes odoo/odoo#39394

X-original-commit: dc3025da4d176d8270d12849b286bf788e78b22f
Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-10-25 15:24:44 +00:00
qsm-odoo 118bff26dc [FIX] website, *: restore website js loading
* web_editor

Commit https://github.com/odoo/odoo/commit/7e2b0ebe7996c9fa35f75949b7fc8cd5a58d7c36
broke the website JS loading as it added a dependency to a lazy loaded
JS module which was not even always lazy loaded.

A test so that this does not happens anymore will be made in another
commit.

Related to task-2092386

closes odoo/odoo#39391

X-original-commit: 5ac269d722f9ff8c206215dd1c07b8544cfd5382
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-10-25 14:40:53 +00:00
Victor Feyens f09e7fbaa8 [IMP] doc: build a module links
closes odoo/odoo#39395

X-original-commit: af66df3337e3a5cbf3cb7b7832460f0af1d97cc7
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-10-25 15:25:01 +00:00
Victor Feyens 5eec683183 [IMP] doc: guidelines references + minor corrections
X-original-commit: c83e999c6a8b16f78dfd9f944936439a53d2b52f
2019-10-25 15:25:01 +00:00
Victor Feyens 1b87271106 [IMP] doc: controllers organisation + minor correction
X-original-commit: c58751f21b49173cb51afd9ff2f01077f7610fb5
2019-10-25 15:25:00 +00:00
Victor Feyens 3917aa5fa2 [IMP] doc: views column_invisible info
X-original-commit: 82a90aa23c3d64b2d2e0cfa9d545b34fb33ec337
2019-10-25 15:25:00 +00:00
Victor Feyens 74a5b93fc3 [REM] doc: views business guidelines
Old outdated Odoo screenshots, and UI guidelines have no worth in the doc...

X-original-commit: c260f4af275d2b5b745f97274a7571bd1211eb0e
2019-10-25 15:25:00 +00:00
svs-odoo 1455e130c9 [IMP] mrp_product_expiry: wo confirmation
With product_expiry, when a workorder is done, we check if there is
expired lot in components. If it is, we ask confirmation to the user.

Task #1938656

closes odoo/odoo#36680

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-10-25 13:50:37 +00:00
svs-odoo a953898837 [ADD] mrp_product_expiry: confirmation wizard
When user produces for a Manufacturing Order, if he/she uses an expired
component, a confirmation wizard will ask if he/she really wants to use
this component.

Task #1938656
2019-10-25 13:50:37 +00:00
svs-odoo 7d7b902eac [IMP] product_expiry: change expiry alert compute
The production lot expiry alert was based on the field `alert_date`.
Now, it will be based on the field `life_date` since if user set only
one field, there is more chance this field will be filled but the field
`alert_date` will not.

Task #1938656
2019-10-25 13:50:37 +00:00
svs-odoo adbfb968da [IMP] product_expiry: add expiry date in lot ZPL
Adds "Best before date" and "Expiration Date" on LN/SN ZPL print format.

Task #1938656
2019-10-25 13:50:37 +00:00
svs-odoo 197ef3ea68 [IMP] product_expiry: expired wizard confirmation
When user tries to validate a picking with expired production lot,
displays a wizard for the confirmation popup. This wizard shows which
lots are expired.

Task #1938656
2019-10-25 13:50:37 +00:00
svs-odoo f30b17b0cd [IMP] product_expiry,stock: expiry date in lot report
Adds "Best before date" and "Expiration Date" on LN/SN pdf report.

Task #1938656
2019-10-25 13:50:36 +00:00
svs-odoo decef03acf [IMP] product_expiry,stock: expiration_date at receipt
User can now define the lot's field `expiration_date` when he/she
receipts a tracked product using the expiration dates.

Task #1938656
2019-10-25 13:50:36 +00:00
svs-odoo 69957aec9b [IMP] product_expiry: add expiration search filter
Adds a search filter on quant list for expired lot.

Task #1938656
2019-10-25 13:36:47 +00:00
svs-odoo 8cec00f90d [IMP] product_expiry: add removal_date on quant list
Sets quant lines in red if removal date has been exceeded.

Task #1938656
2019-10-25 13:36:47 +00:00
svs-odoo 9559bf90a8 [IMP] product_expiry: onchange on production_lot dates
Computes production_lot date fields when the user manually changes the
`life_date` field.

Task #1938656
2019-10-25 13:36:47 +00:00
svs-odoo ca06bfaf4f [IMP] product_expiry: visual changes
Changes the label and tooltip of expiration date related fields.

Task #1938656
2019-10-25 13:20:38 +00:00