Commit Graph
166719 Commits
Author SHA1 Message Date
vava-odoo ce24ef8e13 [FIX] website_sale: missing class for cart warning
Before this commit, the warning message on the cart could be duplicated
when editing the cart, as it was not reloaded by the js. This commit
makes sure that the warning message is re-rendered, and removed if
needed.

task-3537684

Part-of: odoo/odoo#137844
2023-10-19 17:01:11 +00:00
amdi-odoo 7109f480ec [IMP] survey: add scoring after each page
Purpose
=======
Add a scoring option displaying the correct
answers after each page when taking the survey.

Specifications
==============
When the user submits the page:
- highlight in green the correct answer(s)
- highlight in red the wrong answer(s)
When the correction is displayed, prevent
the user from changing their answers.

Handling all question types that can specify
a correct answer:
- Numerical box
- Date
- Datetime
- Simple choice
- Multiple choice

Task-3374998

closes odoo/odoo#129329

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2023-10-19 17:01:08 +00:00
Valeriya(vchu) aebe30a91b [FIX] website_sale_picking, payment: always show payment options radio
After commit 0b69bf02 the following bug appeared.
Steps to reproduce:
1) activate only 'on site pick' shipping method
2) activate only 'pay on site' payment provider
3) add product of type 'product' to the cart and proceed to /shop/payment
4) observe the traceback
This bug happens in website_sale_picking checkout_form.js when payment
option is clicked on not yet initialized payment form widget.

With this commit we always show payment options radio even if there is
only one available, which allows to remove the problematic code in
website_sale_picking.

opw-3475563
opw-3451097

closes odoo/odoo#139130

X-original-commit: 2b6ef409dc2187905812b1a8f6491210699ba76d
Related: odoo/enterprise#49147
Signed-off-by: Valeriya Chuprina (vchu) <vchu@odoo.com>
2023-10-19 14:47:36 +00:00
Olivier Dony 4798486a2d [FIX] payment_stripe: ensure init of stripe Elements
The `setupFutureUsage` parameter must be passed correctly to the
Elements API, and must match the value that is provided in the
paymentIntent [^1]. If there is a mismatch, the payment will fail with an
error: "The provided setup_future_usage (off_session) does not match the
expected setup_future_usage (null). Try confirming with a Payment Intent
that is configured to use the same parameters as the Stripe Elements"

Due to customizations or default values, it is possible that the
`tokenizationCheckbox` (`o_payment_save_as_token` input) is checked by
default, even though the `is_tokenization_required` property of the
transaction context if false.

In this situation, the Stripe Elements params would not be initialized
with a `setup_future_usage` (cfr [^2]), yet the checkbox status would be
passed as `tokenizationRequired` to the transaction route [^3], leading to
the preparation of a Payment Intent with a mismatching value [^4].

The eventListener code is present to sync changes to the checkbox
status, but the initial state of the checkbox was not guaranteed to be
synced with the Stripe Elements. This patch adds the missing step,
similar to the event handler code 15 lines below.

[^1]: https://stripe.com/docs/api/payment_intents/create#create_payment_intent-setup_future_usage
[^2]: https://github.com/odoo/odoo/blob/e26c007dd14de9d0cbf76181e8054a3498e67bd9/addons/payment_stripe/static/src/js/checkout_form.js#L19C1-L21
[^3]: https://github.com/odoo/odoo/blob/e26c007dd14de9d0cbf76181e8054a3498e67bd9/addons/payment/static/src/js/payment_form_mixin.js#L327
[^4]: https://github.com/odoo/odoo/blob/882fc6d1479797215a104cb1fc1ee7a0bb9c84c7/addons/payment/controllers/portal.py#L306C2-L308

closes odoo/odoo#139116

X-original-commit: 9d8da1d14484fa466bb67e8002ce15526ebef676
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
2023-10-19 14:47:34 +00:00
Adrien Minne (adrm) 8535e4d8b7 [IMP] spreadsheet: remove default exports
This commit removes the default exports from the spreadsheet module.
They don't bring anything except confusion when importing a mix of
default and named exports.

closes odoo/odoo#139071

Task: 3559536
Related: odoo/enterprise#49129
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
2023-10-19 14:47:31 +00:00
tsm-odoo 8c57d34e02 [FIX] website_livechat: fix tour failing nondeterministically
This commit fixes the `website_livechat_chatbot_flow_tour` that was
failing in a nondeterministc way. This is due to the tour sometimes
taking more than `60` seconds which is the default timeout for python
tours.

Most of the time is consumed waiting for the user to finish its
multiline input. This issue is solved by shortening the delay to
consider the multiline input as done: from `10`s to `500`ms.

fixes runbot-24557

closes odoo/odoo#139034

X-original-commit: 7788f2f1879dda2381a7d2e93e8a0472f4621d14
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2023-10-19 14:47:30 +00:00
FrancoisGe f0efa1dca8 [FIX] web, im_livechat: click twice on a record in a x2many
Before this commit, if you click twice on a record in x2many, two dialogs
are opened containing the same record.

Solution:
=========
Prevent a record from being opened as long as a record in this x2many
is already open.

How to reproduce:
=================
Go to a form view with an x2many
Click on the first record in the x2many
Click a second time on the record of the x2many (before the dialog is opened)

Before this commit:
-------------------
Two dialogs are opened with the selected record

After this commit:
------------------
Only one dialog is opened with the selected record

closes odoo/odoo#138984

X-original-commit: 31a9b13
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
2023-10-19 14:47:29 +00:00
Achraf (abz) 99f3d059bd [FIX] website_sale: Allow users to change ribbon background_color
- Install `website_sale`
    - Go to /shop
    - Click on Editor and Edit a product
    - Add a new ribbon/badge
    - Changing text color works
    - Changing background color doesnt

Because `bg-primary` has an `!important` background_color

closes odoo/odoo#138712

X-original-commit: c6f4929f65b899736c556f8f0bb7824883a6d893
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
2023-10-19 14:47:27 +00:00
Pieter Claeys (clpi) 6e20ea5f12 [IMP] mrp: pre_mark_as_done validate serials and workorders
When marking an MO as done in the shop floor, the pre_mark_done method
is used to determine if there are any issues before putting the MO in
the 5 second validation queue.
However, there were two cases that were not yet caught here:
1. Pending quality checks on a workorder
2. Duplicate serial number on the final product
This commit adresses both of these cases.

closes odoo/odoo#137535

Task: 3456827 (nr 28)
Related: odoo/enterprise#48379
Signed-off-by: Steve Van Essche <svs@odoo.com>
2023-10-19 14:47:23 +00:00
Pieter Claeys (clpi) ac9a02d14e [IMP] mrp: shop floor cosmetic improvements
Small cosmetic changes to improve the UX of the new shop floor app:

- Rename of the ready MO filter as it was quite long in the shop floor
search bar;

- Add `desktop_list_view` in the context when opening a WO from the
  workcenter kanban view to always open the desktop view even once
  `mrp_workorder` is installed.

Task: 3456827
Part-of: odoo/odoo#137535
2023-10-19 14:47:23 +00:00
Pieter Claeys (clpi) 2f56c8c0bb [IMP] mrp: time tracking consider now as end date
When changing the duration on a time-tracking entry on a workorder, set
the end time to now and calculate the start time by detracting the
duration, instead of the other way around.

Task: 3456827 (nr 35)
Part-of: odoo/odoo#137535
2023-10-19 14:47:23 +00:00
Xavier Bol (xbo) adb0476e5f [FIX] product,sale,point_of_sale: fix sales page visibility
Before this commit, the `Sales` page is always visible in product
form view when `point_of_sale` and/or `sale` modules are installed
even if the product cannot be sold.
The reason is because the initial condition contained in
`attrs="{'invisible': ...}"` for that page has been completely removed
since the recent changes to remove `attrs` attribute and allow having
python condition inside `invisible`, `readonly` and `required` attributes
(instead of having only True or False as value for those attributes).

This commit reviews the visibility condition for that page to completely
hide that page in product module as it is currently the case but it also
adds the condition we had in attrs. That is, in product module, the
invisible attribute for that page will be equal to `1 or not sale_ok`
(and so always invisible thanks to `1 or ...`) and when `sales` or
`point_of_sale` modules will be installed then `1 or ` will be removed
to just keep `not sale_ok` inside `invisible` attribute.

task-3506730

closes odoo/odoo#135840

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-10-19 14:47:20 +00:00
Xavier Bol (xbo) fed423910b [FIX] product,*: fix purchase page visibility in product form view
Before this commit, when purchase app (or account) is installed,
the `purchase` page in product form view is always visible even
if the product displayed in the form view cannot be purchased.
The reason is when `attrs` has been removed and replaced by python
condition inside `readonly`, `required` and `invisible` attributes,
since the purchase page had `attrs="{'invisible': ...}"` and
`invisible="1"` defined in its attributes, the condition in `attrs`
has completely removed when the `attrs` has been deleted.

This commit fixes the issue by updating the initial invisible defined
in product module to have `invisible="1 or not purchase_ok"` to keep
the condition that was initially defined in `attrs`.
In purchase and account module, instead of replacing `invisible="1"`
by `invisible="0"`, we will just remove `1 or` to show the purchase
page only if `not purchase_ok` as it was the case before.

task-3506730

Part-of: odoo/odoo#135840
2023-10-19 14:47:20 +00:00
Gurupreet Singh 5624809daf [FIX] point_of_sale: add the invisible condition defined in product
Before this commit, the product view is extended to change the `invisible`
attribute of page with name attribute equals to `inventory`. The problem
is in the initial form view that page has a invisible condition and
the extended view defined in `point_of_sale` module completely overrides
that condition without rewriting the initial condition.

This commit reintroduces the initial condition to also hide that page
when the product is a service type.

task-3506730

Part-of: odoo/odoo#135840
2023-10-19 14:47:20 +00:00
jugj-odoo da28dc6618 [IMP] hr_attendance : Bumping counters in tests
Due to the Systray item add for attendance,
an additional rpc call will be performed for employees,
meaning that different counters have to be bumped.

closes odoo/odoo#135439

Related: odoo/upgrade#5234
Related: odoo/enterprise#47384
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2023-10-19 14:47:18 +00:00
Jurgen (jugj) bf67f1e20e [IMP] hr_(holidays)_attendance : Revamp Attendance V17
Part-of: odoo/odoo#135439
2023-10-19 14:47:18 +00:00
Sina Chaichi Maleki (cmsi) 6173b5a0e8 [IMP] hr_contract: retain contracts menu without payroll
Previously, without the payroll app, the menu item for contracts in
the employee app was not available. To improve accessibility and
user experience, the contract menu item is now kept and visible
when hr_contract module is installed.

closes odoo/odoo#133586

Related: odoo/enterprise#46541
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
2023-10-19 14:47:16 +00:00
Lopes Marc (loma) 893a6e4f8e [IMP] website_forum,*: populate with forums, posts and comments
* website_slides_forum

Populate a database with different quantities of forums, posts
and comments.The number of replies per question and comments per post
(question or reply) are defined by weights.

We use SQL queries in the '_populate' method to update certain fields
automatically managed by the ORM, as well as the 'last_activity_date' of
posts (questions).
The aim is to give posts, replies and comments varied and consistent
create_dates, as well as a wide variety of authors (create_uid).

Task-3349374
Task-3463533

closes odoo/odoo#132042

Signed-off-by: Florian Charlier (flch) <flch@odoo.com>
2023-10-19 14:47:14 +00:00
ravb-odoo c2fdf83e0b [IMP] sale_timesheet,_*: improve mail template and portal view
_*= account, hr_timesheet
This commit improves the Portal functionality and add email template:

- improve email template for invoice includes timesheet (add link in mail which
  redirect to timesheets linked with invoice).
- improve timesheets template by renaming labels and internal header/footer.

task-3251680

closes odoo/odoo#127224

Related: odoo/enterprise#43593
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-10-19 14:47:11 +00:00
ravb-odoo c44d8d7deb [IMP] sale_timesheet,_*: add dynamic label for timesheet record
_*= account, hr_timesheet
This commit improves the Portal functionality and add email template:

- improve email template for invoice includes timesheet (add link in mail which
  redirect to timesheets linked with invoice).
- improve timesheets template by renaming labels and internal header/footer.

task-3251680

Part-of: odoo/odoo#127224
2023-10-19 14:47:10 +00:00
Adrien Guilliams (adgu) d43c0c73c0 [IMP] pos_restaurant: improve preparation display demo data
The demo data linked to the preparation display (in restaurant)
where a bit light.
This enterprise PR adds more data to the demo data and move some
to previous stages so that user can play more with them.
In this commit we adapt the number of customer to the corresponding
orders that have more orderlines.

Enterprise PR: odoo/enterprise#48841

closes odoo/odoo#138478

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
2023-10-19 13:20:30 +00:00
Xavier-Do 4820be3cb7 [IMP] base: add test for wkhtmltopdf generation
The current used version of wkhtmltopdf manages is frozen to 0.12.5
because some features used by odoo are only available in this version
using a patched qt.

Anyway, it become difficult to keep this version up to date, especially
with Ubuntu Jammy and updates of the dependencies used by wkhtmltopdf.
More than that because of qt related issues, wkhtmltopdf maintenance
will end soon.

Adding a test to check some caracteristics of pdf reports may be usefull
to check that current version is still working, and eventually to find
an alternative solution.

This test checks that pdf reports contains the expected headers and
footers elements with the correct page number (2 record of 2 pages)
This also check that the pdf is in the expected A4 format.

Future test may check other formats, margins, layout,
page size/pagebreak combination, (table of content?), ...

This test may also check performances and existing limitations.

closes odoo/odoo#136626

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2023-10-19 13:20:28 +00:00
Thomas Becquevort (thbe) cc6f85af2a [IMP] account: Better UX during account_accoutant_tour
Description of the issue/feature this commit addresses:

The current onboarding account tour is sometimes broken.
The purpose of this commit is to fix it and make it run smoothly.

Desired behavior after the commit is merged :

This commit modifies the onboarding account tour to clarify the messages that
are shown, add messages to certain steps and try to make it impossible
for the user to be lost during its entierty.

Adding this improvement, the onboarding account tour better fills
its purpose.

task-3375344

closes odoo/odoo#135187

Related: odoo/enterprise#47306
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
2023-10-19 11:59:50 +00:00
miad-odoo f4f85cbc98 [IMP] crm,event_crm: add foldable to domain field
In this commit, we add the 'foldable' option to the domain widget in crm and
event_crm.

Task-3458063

closes odoo/odoo#132008

Related: odoo/enterprise#45768
Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
2023-10-19 11:59:47 +00:00
“moda” 470715e552 [FIX] point_of_sale: fix traceback when creating combo
Previously, when you wanted to create a combo from a product form, a
traceback was raised because you were trying to calculate the minimum
price of non-existent combo_line_ids.

Now the code has been adjusted and there's no more trackback.

closes odoo/odoo#139148

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
2023-10-19 10:45:59 +00:00
Adrien Widart (awt) e1c287621e [FIX] purchase_stock: ignore the receipt of returned qty
In some cases, the received qty of the POL is incorrect

To reproduce the issue:
1. Create and confirm a PO
2. Receive the product
3. Return the product:
   - Update quantities on SO/PO: False
4. Receive again ("return the return"):
   - Update quantities on SO/PO: False
5. Open the PO

Error: The received qty of the POL is incorrect, it includes the
second receipt

The second receipt is processed as a classic receipt, so we simply
add the done qty of the SM to the received qty of the POL. We have
to improve the conditions.

OPW-3483449

closes odoo/odoo#139140

X-original-commit: 4067bd6061c1d2e2a351ac8875a038015b410ad5
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Signed-off-by: Adrien Widart (awt) <awt@odoo.com>
2023-10-19 10:45:58 +00:00
Lucas Lefèvre (lul) 838ee8d18d [FIX] spreadsheet_dashboard_*: set explicit en_US locale
The en_US default locale in o-spreadsheet is m/d/yyyy but it's mm/dd/yyyy in odoo.
Because of this mismatch, spreadsheets from the source code of odoo (dashboards,
templates) will have a small warning saying the spreadsheet locale and the user
locale mismatch.
That's because existing spreadsheet don't have any locale and the default one is
used.

This commit adds the locale to all o-spreadsheet json files.

Notes:
- we could have completely upgrade the json file format to the latest
  o-spreadsheet version (version: 14), but just adding the settings is enough

closes odoo/odoo#139133

X-original-commit: 76f77f0bca6852846079f1fe0de6080554f96ac2
Related: odoo/enterprise#49148
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
2023-10-19 10:45:53 +00:00
Ahmad Khanalizadeh df104e7101 [REV] point_of_sale: traceback when downloading the report
The commit https://github.com/odoo/odoo/pull/137446/commits/a0b59559
leads to a traceback when clicking on "Download sale report" button
when closing the session.

Traceback:
```
tuple index out of range
Traceback (most recent call last):
  File "/data/build/odoo/addons/web/controllers/report.py", line 113, in report_download
    response = self.report_routes(reportname, docids=docids, converter=converter, context=context)
  File "/data/build/odoo/odoo/http.py", line 697, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/data/build/odoo/addons/web/controllers/report.py", line 42, in report_routes
    pdf = report.with_context(context)._render_qweb_pdf(reportname, docids, data=data)[0]
  File "/data/build/odoo/addons/account/models/ir_actions_report.py", line 58, in _render_qweb_pdf
    return super()._render_qweb_pdf(report_ref, res_ids=res_ids, data=data)
  File "/data/build/odoo/odoo/addons/base/models/ir_actions_report.py", line 819, in _render_qweb_pdf
    collected_streams = self._render_qweb_pdf_prepare_streams(report_ref, data, res_ids=res_ids)
  File "/data/build/odoo/addons/account_edi_ubl_cii/models/ir_actions_report.py", line 58, in _render_qweb_pdf_prepare_streams
    collected_streams = super()._render_qweb_pdf_prepare_streams(report_ref, data, res_ids=res_ids)
  File "/data/build/odoo/addons/account_edi/models/ir_actions_report.py", line 14, in _render_qweb_pdf_prepare_streams
    collected_streams = super()._render_qweb_pdf_prepare_streams(report_ref, data, res_ids=res_ids)
  File "/data/build/odoo/addons/account/models/ir_actions_report.py", line 20, in _render_qweb_pdf_prepare_streams
    return super()._render_qweb_pdf_prepare_streams(report_ref, data, res_ids=res_ids)
  File "/data/build/odoo/odoo/addons/base/models/ir_actions_report.py", line 708, in _render_qweb_pdf_prepare_streams
    html = self.with_context(**additional_context)._render_qweb_html(report_ref, res_ids_wo_stream, data=data)[0]
  File "/data/build/enterprise/web_studio/models/ir_actions_report.py", line 19, in _render_qweb_html
    return super(IrActionsReport, self)._render_qweb_html(report_ref, docids, data)
  File "/data/build/odoo/odoo/addons/base/models/ir_actions_report.py", line 895, in _render_qweb_html
    data = self._get_rendering_context(report, docids, data)
  File "/data/build/odoo/odoo/addons/base/models/ir_actions_report.py", line 910, in _get_rendering_context
    data.update(report_model._get_report_values(docids, data=data))
  File "/data/build/odoo/addons/point_of_sale/models/pos_order.py", line 1538, in _get_report_values
    data.update(self.get_sale_details(data['date_start'], data['date_stop'], configs.ids, data['session_ids']))
  File "/data/build/odoo/addons/pos_daily_sales_reports/models/pos_daily_sales_reports.py", line 68, in get_sale_details
    user_currency = config_currencies[0]
  File "/data/build/odoo/odoo/models.py", line 5901, in __getitem__
    return self.browse((self._ids[key],))
IndexError: tuple index out of range

```

opw-3558365

closes odoo/odoo#139128

X-original-commit: 8b19e29e8ead8229cebbb6224979264a59334209
Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>
Signed-off-by: Ahmad Khanalizadeh (khah) <khah@odoo.com>
2023-10-19 10:45:52 +00:00
Hugo Carlier (Huca) 561775fda9 [FIX] hr_timesheet: avoid access error in project sharing
Steps
=====
- Install hr_timesheet
- Create a project shared (in edition) with a portal user
- Creata a task with a subtask and log timesheets for the subtask
- As a portal user open the parent task form
- Go in the timesheet tab
- Click on the button "Sub-tasks Hours/Days Spent" at the bottom of the
  page

Issue
=====
An access error appears for an uom.uom record.

Cause
=====
Portal users have no access to uom.uom records. The method
_apply_timesheet_label uses this model to determine if the time spent
needs to be displayed with an 'hours' or a 'days' label. This raises a
traceback when it is called by a portal user.

Fix
===
The method _apply_timesheet_label is called as sudo, following the fix
that was already done in project sharing (see odoo/odoo#73341).

task-3527521

closes odoo/odoo#139125

X-original-commit: 01b1cf07bc1fb618d34065271cdc07fce561337f
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-10-19 10:45:52 +00:00
dhrs-odoo 6df6108221 [FIX] hr_timesheet: manage missing space issue
In this commit we have manage sufficient space between allocated
hour and the percentage.

task-3248965

closes odoo/odoo#139113

X-original-commit: 1722359f1bedd238b162dd8f4c07d648d6d2d114
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-10-19 10:45:50 +00:00
Roy Le b726842e47 [FIX] account: avoid error when internal user (no accounting
permissions) see Invoices & Bills at /my/account

Issue:
Internal user cannot see their Invoices & Bills at
portal without permissions in the accounting

Fix:
Verify that the read operation is allowed for the current user

closes odoo/odoo#139141

X-original-commit: 5ebab949a06ec338cc28e912317a74bbfb3fe6ac
Signed-off-by: William André (wan) <wan@odoo.com>
2023-10-19 07:23:42 +00:00
shy 5f586a50b4 [FIX] account: bold styling applied to the element
attribute style has two apostrophes (') at the begininng and end

this prevents the bold style from being applied

The modification was made in the tax_totals.xml file

while ensuring that it doesn't affect any other element

closes odoo/odoo#139087

X-original-commit: 7414d61e85e38c6159c53337be6c1750d3b7dfcd
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-10-19 07:23:41 +00:00
shy b3f320b78e [CLA] signature for PallaviSrivastavaa
X-original-commit: c76238eece48bbf86bf521b0f3ec23d7a677d6df
Part-of: odoo/odoo#139087
2023-10-19 07:23:41 +00:00
Martin Maes 1d2e31d037 [FIX] website_sale: remove unnecessary call
As mentioned in https://github.com/odoo/odoo/pull/105848#discussion_r1324796532, the ``_getCurrentLocation`` method was called on every page of ecommerce, while it was doing nothing unless if we are on the payement page.

Putting the call in the ``if`` ensures that there are carriers on the page and thus calls it only when on the payment page.

closes odoo/odoo#139086

X-original-commit: 65e7535fc9392e7b9355a31fa8f7c8abc1e3518f
Signed-off-by: Martin Maes (marm) <marm@odoo.com>
2023-10-19 07:23:40 +00:00
Renilkumar Kajavadra 4c1cab9e41 [FIX] website: singleton error while creating an order in website
When the user has contacts with different websites and tries to create an order,
a traceback will appear.

Steps to produce the error:
- Install 'website_sale' and 'contacts'
- Create 2 websites: 'Website A' and 'Website B'
- Go to Contacts > New > In Sales & Purchase, select 'Website A'
- Create another contact with 'Website B'
- Go to Website > eCommerce > Orders > New > try to enter Customer

Error: A traceback appears:
'Expected singleton: website(6, 16)'

https://github.com/odoo/odoo/blob/1cb866347eed8c43d1da225f441cc3b3ce9c5a01/addons/website/models/res_partner.py#L42
Here, instead of partner, self is used.
So when the user tries to create an order,
it will lead to above traceback.

sentry-4545021252

closes odoo/odoo#138929

X-original-commit: b053805d96c5fd8a9579e49b4f842f488c4adf60
Signed-off-by: Adrien Widart (awt) <awt@odoo.com>
Signed-off-by: Renilkumar Kajavadra (reka) <reka@odoo.com>
2023-10-19 05:36:56 +00:00
Alexandre Kühn 743d8cd8c1 [FIX] hr: 'Open Profile' should open public employee form
Before this commit, when an internal user attempted to open
profile of a user from dropdown menu of private chat window
with that user, there was crash.

Steps to reproduce:
- install `test_l10n_be_hr_payroll_account` with demo data
- connect as Laurie Poiret
- Open chat window with Marc Demo
- Click chat window header => "Open Profile"

It happens because the action to open the profile was attempting
to open "hr.employee" form, which require specific access rights
(hr manager). The current user is not necessarily an hr manager,
so the action fails.

This commit fixes the issue by opening the public form view of the
employee, which is accessible to all internal users.

opw-3555889

closes odoo/odoo#139134

X-original-commit: bdce8c72cd06cb783973beb62382bfd8a8ae249e
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2023-10-19 04:31:55 +00:00
Bastien PIERRE 38260f3262 [FIX] web: prevent command palette to lose focus
The command palette has the priority when useAutoFocus is call.
Like that, the command palette will not lose focus when clicking
on an app on the home menu and then directly opening the command
palette before the app mounting

TASK ID: 3338117

closes odoo/odoo#139124

X-original-commit: 660d27ac38c225559ea3697a24a34ac70ede8ec1
Signed-off-by: Florent Dardenne (dafl) <dafl@odoo.com>
2023-10-19 02:28:10 +00:00
Noe Antoine bb1ea07920 [FIX] website_{forum_}slides: improve perf of logged_in rules
(Introduced in 16.3, 86c6266)

--- ISSUE

From there, partner_ids and partner_all_ids m2m fields became computed
fields in order to return only active records as we read them from
the slide.channel.partner table, not checking the active field of that
table (not supported by framework).

Ir rules of records check if current user's partner is inside partner_ids,
or partner_all_ids of a given course. (joined the course for partner_ids,
invited or joined the course for partner_all_ids)

The issue is that all ir rules searching on these fields lead to very
slow loading of slides (channel, slide, homepage) and forum pages (as
soon as we have a forum linked to a course). This comes from the fact
that in some templates, we read records and evaluate rules on the spot,
in python. (for instance tags of courses on homepage)

As some courses have tens of thousands of attendees, this evaluation is
very slow in python, and there is no quick solution at framework level.
Therefore, computing thousands of partners for each access rule linked
to a course is too slow.

--- SOLUTION

The existing fields is_member and is_member_invited are used inside ir
rules instead. _search methods are added and we check whether course
is inside courses of current user's partner ones. It improved all times
a lot, see BENCHMARK below.

Tests already exist to assert the search methods indirectly.

--- LOCAL BENCHMARK (16.3) - IntelCore i5-8265U CPU 1.60GHz - Firefox

ROUTE                                   BEFORE (s)        AFTER (s)
/slides                                 5                 <0.15
/slides/all                             7.6               <0.15
/slides/course_c                        4.2               <0.2
/forum                                  5.5               <0.15
/forum/forum_c                          6                 <0.25
/forum/forum_c/post_y                   4.4               <0.25
/forum/forum_c/post_y/edit_answer       2.5 + 2.5         <0.3 total
/forum/forum_c/post_y/edit              2.8               <0.2
/forum/forum_c/post_y/reply             3 (+6 post)       <0.35 total
/profile/user/id                        2.3               <0.4

DETAILS

- course_c: 43k attendees
- forum_c: forum of course_c
- post_y: 2-3 answers
- logged user: 'portal', with 7 courses
- deactivated GC cron as many populated invited attendees were
to be removed, and it can take a lot of time

    POPULATIONS

- 20k   forum.forum (avg 2 answers)
- 20k   mail.message (about 2 answers per post)
- 10    forum.forum (+20 on courses)
- 20    slide.channel (half 'members' visibility)
- 300k  slide.channel.partner
- 'large' for other models

--- LINKS

UPG PR: odoo/upgrade#5246
Task-3444633

closes odoo/odoo#139104

X-original-commit: 019d9d4808994cd819d13fab2d6ddfdffeb621e7
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2023-10-19 01:23:32 +00:00
Aurélien Warnon 66ba5119ca [IMP] calendar: prepare appointment type mail templates fields
This commit does some preparation work to allow the appointment type to specify
a custom mail template to send when an appointment is booked/canceled.

It simply adds a hook method to be able to customize the behavior when sending
the invitation email as well as removes some parts of the current invitation
template that will be rendered useless.

See enterprise counterpart for more details.

Task-3547269

closes odoo/odoo#138547

Related: odoo/enterprise#48874
Related: odoo/upgrade#5269
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2023-10-19 00:00:17 +00:00
Louis Baudoux 2d5de1f1b0 [FIX] partner_autocomplete: fix minor issues in jsvat library
Fixes a few issues in `jsvat`:
- Since the end of 2022, valid Belgian VAT numbers starting with `BE1`
  have been attributed, the regex had to be adjusted.
- Since Brexit, Northern Ireland has to use the `XI` prefix instead of
  `GB`.
- Removes the default country code logic. As Odoo is used worldwide, it
  didn't make sense to use `GB` as the default country code when no
  country code is mentioned.

closes odoo/odoo#139098

X-original-commit: f486a41f729ea7e934c81671972b3b1162986860
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Signed-off-by: Louis Baudoux (lba) <lba@odoo.com>
2023-10-18 21:21:15 +00:00
Aurelien van Delft (avd) 1fe5e34a52 [FIX] mrp: fix availability_status of merged components
Suppose the following configuration:
 - 1 BOM
 - 2 Lines with the same product_id , same uom_id
 - Enough stock for the first line
 - Incoming PO for second line, with date_order=today

Currently the line will be displayed as "Available" because
the availability_delay of the second component is also 0.0.

Changing > to >= marks the second line as "Expected", which makes
more sense. This also fixes the same issue for "Estimated" lines.

closes odoo/odoo#139067

X-original-commit: 249f331f9524860bbf0f0a7b092cbd26ebdb6840
Signed-off-by: Aurélien van Delft (avd) <avd@odoo.com>
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
2023-10-18 20:09:01 +00:00
Aurelien van Delft (avd) b368860f28 [FIX] mrp: batch _get_component_data in mrp_report_bom_structure
Currently when showing a BoM Overview, the stock_availability
is computed for each bom's component. This means that there will
be one read_group on report.stock.quantity by component. As this
is a postgresql View, querying it too often can degrade the overall
performances.

This commit tries to improve on that by computing the stock_availability
of all components without bom at the same level at the same time. Let's say
there is a BoM with 4 components, none of which has a bill of materials
of their own. Before this commit there would have been 4 read_groups, one
by component. Now there will only be 1 read_group.

Example speedup: customer database with 7M stock.moves,
7M stock.move.lines. BoM Overview with 33 nodes in the component

Tree: 3min30s -> 1min30s
X-original-commit: 8fa7a11bf41152a06537144c20d04921d3643272
Part-of: odoo/odoo#139067
2023-10-18 20:09:01 +00:00
Valeriya(vchu) e8fcbeab2d [IMP] payment_demo: enable demo provider by default when installed
task-3557315

closes odoo/odoo#138466

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
2023-10-18 18:27:28 +00:00
Valeriya(vchu) 55a3b661dc [IMP] account_payment: set default bank journal on providers
Set the default value of provider's `journal_id` to the first compatible
bank journal, if such exists, to improve the user experience.

Part-of: odoo/odoo#138466
2023-10-18 18:27:28 +00:00
Abderraouf Ghrissi (abgh) b9532e7549 [IMP] project: Improve ux
Before this commit:
- project.task > list view: Currently, the progress is displayed
in purple if less than 100% and in red if above. The two colors
don't contrast a lot, making it hard to read. In addition, it
is not coherent with the color we usually apply for the remaining
hours in the rest of the app.
- onbording tour: the manual saving step is no longer necessary
as records are now automatically saved. In addition, showing it
doesn't provide a wow effect and is an extra opportunity to lose
people in the process

After this commit:
- the following color code was applied for the progress bar:
*if progress < 80 -> green
*if progress is between 80 and 100 included -> orange
*if progress > 100 -> red

- step removed.

task-3475170

closes odoo/odoo#132854

Related: odoo/enterprise#46162
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-10-18 18:27:25 +00:00
Arnaud Joset 5fa618cb99 [FIX] microsoft_account: remove approval consent when admin use 2FA on Microsoft Azure.
Before this commit, when the Database is using an enterprise Azure account/environment which has a configuration of
'Multifactor authentication', the users gets pop-up asking for approval.

See https://learn.microsoft.com/en-us/azure/active-directory/manage-apps/application-sign-in-unexpected-user-consent-prompt
The solution is to remove the parameter 'prompt': 'consent' from the authentication URL which is not considered a good practice by
the Microsoft support (see attachment in task).

closes odoo/odoo#139075

Taskid: 3463417
X-original-commit: 1e1f84531b37f7f256f8a8670ed7efddae6fe1ba
Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
2023-10-18 16:52:08 +00:00
Hubert Van de Walle (huvw) b87e54bce4 [FIX] web: no_create option ignored for many2one + many2many_tags fields
Steps to reproduce
==================

- Install purchase_product_matrix,web_studio
- Go to purchase
- Click on a record
- Open studio
- Click on the "Products" tab > Edit List view
- Edit the product field
- Widget: Many2one
- Disable creation: enabled
- Close studio
- Create a new record
- Add a new line
- Type some random text in the product field

-> The option create is available

Cause of the issue
==================

When the can_create attribute is not passed, the `canCreate` ends up
undefined. This means the default value of true is used and the
`no_create` option is ignored.

The can_create attribute should actually be passed and there is a bug in
python in the `_editable_tag_field` function, but it is not something we
can change in stable due to the fact it it requires an explicit change
in some views to pass the validation and thus, this requires an addon
upgrade (`-u ...`).
See https://github.com/odoo/odoo/pull/138032

opw-3432903

closes odoo/odoo#139068

X-original-commit: 4b6756e1775488e230bc25767adf5744f0ea9149
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>
2023-10-18 16:52:06 +00:00
Arnaud Joset 68a7ae269d [FIX] hr_homeworking: fix locale of homeworking day
Before this commit, when the locale was not in english, the following
traceback was observed:

 ```
Uncaught (in promise) Error: The following error occurred in onWillStart: "res[employeeId][((intermediate value) + "_location_id")] is undefined"
    OwlError owl.js:87
    wrapError owl.js:2604
    onWillStart owl.js:2647
    useModelWithSampleData model.js:165
    setup calendar_controller.js:48
    setup attendee_calendar_controller.js:10
    setup appointment_calendar_controller.js:15
    setup google_calendar_controller.js:11
    setup hr_homeworking_calendar_controller.js:12
    setup microsoft_calendar_controller.js:11

 ```

closes odoo/odoo#139052

Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
2023-10-18 16:52:05 +00:00
Trinh Ngoc Hung 763002a841 [FW][FIX] payment: pass amount_to_refund as a kwarg
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#138918

Forward-port-of: odoo/odoo#138460
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
2023-10-18 16:52:02 +00:00
Horacio Tellez (hote) dff6a0fe55 [FIX] payment_mercado_pago: forbid float amounts for currencies w/o minor unit
The Chilean Peso and Colombian Peso don't have a minor unit. MercadoPago
requires amounts be expressed as integers. Failing to send such amounts
as integers results in an error.

opw-3292798

closes odoo/odoo#138859

X-original-commit: 75fa1e55207050e57b8b912b5e0607c8a3e31515
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
2023-10-18 16:52:01 +00:00