Remove useless link between message and shortcodes
There is a o2m / m2o link between mail.message and mail.shortcode. However
this link is not used: 'messages' (m2o from shortcode to message) is never
set. Anyway there is no usage of this link: shortcodes are replaced in
message body and that's it.
Improve link preview code
* remove useless indirections;
* improve performance of link creation, cleanly support batch-creation;
* name methods according to ORM;
* use tools for html empty;
Also cleanup link preview tests: concatenate tests when possible, improve
setup, use real-life scenarios (using 'message_post' notably), remove useless
data creation.
Task-3557985 (Mail: Message cleanup (shortcode, link))
Prepares Task-36879 (Mail: Support MultiCompany Aliases)
closesodoo/odoo#138938
Related: odoo/upgrade#5292
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Improve link preview code
* remove useless code indirections;
* improve performance of link creation, cleanly support batch-creation (could
lead to 98+5 URLs to the same domain creation within default 10 seconds
instead of 98+1 but we feel it's ok);
* name methods according to ORM;
* use tools for html empty;
Also cleanup link preview tests: concatenate tests when possible, improve
setup, use real-life scenarios (using 'message_post' notably), remove useless
data creation.
Task-3557985 (Mail: Message cleanup (shortcode, link))
Prepares Task-36879 (Mail: Support MultiCompany Aliases)
Part-of: odoo/odoo#138938
There is a o2m / m2o link between mail.message and mail.shortcode. However
this link is not used: 'messages' (m2o from shortcode to message) is never
set. Anyway there is no usage of this link: shortcodes are replaced in
message body and that's it.
Task-3557985 (Mail: Message cleanup (shortcode, link))
Prepares Task-36879 (Mail: Support MultiCompany Aliases)
Part-of: odoo/odoo#138938
'email_formatted' on 'res.company' model depends on its formatted catchall
and its underlying partner formatted email. However we do not need to
give 'partner.id.email_formatted' trigger in the compute methods as it is
not stored and thus do not need to recompute it for every change of linked
partners in DB; it is valid for the current transaction. It allows to lessen
invalidation of computed fields.
Task-3557985 (Mail: Message cleanup (shortcode, link))
Prepares Task-36879 (Mail: Support MultiCompany Aliases)
Part-of: odoo/odoo#138938
Created custom filters using tag_ids for the tour to click on
using the add custom filter in the filter dropdown was buggy when used in the tour
the o_filter_condition div didnt update when changing the custom filter
Task-3511261
closesodoo/odoo#138930
X-original-commit: cf44186bdd082bb822eb1801534f8bf4b5a904e2
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Correspondent in thread can be null and lead into crash
when getting thread action and im status.
Replace correspondent with chatPartner when type is chat.
The fix is to solve the problem so that it is not blocking
systray and chatWindow tests related.
Also, this fix small issue of systray overflowing issue.
closesodoo/odoo#138913
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Since [1], the notification option for the live chat button does not
work. This commit restores it.
[1]: odoo#122834
task-3555864
closesodoo/odoo#138904
X-original-commit: 2f8683d22a781fce6cc5c1c39b0018f1b531fa8a
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Manage worksheet templates on maintenance requests.
Also add 'Notes' and 'Instruction' tabs in form view.
closesodoo/odoo#127616
Task: 3186753
Related: odoo/enterprise#43763
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
When a tax is created using an unsigned tax tags AND a signed tax tag,
the mapper in the chart template model was crashing, skipping the needed
mapping for the signed tax (the unsigned tax doesn't need to be mapped
as it comes from a template).
task-3520182
closesodoo/odoo#138840
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Pierre-Rodéric Roose (prro) <prro@odoo.com>
Steps to reproduce:
- Install account.
- Go to Payment terms, and select any term (or create a new one).
- In the form, we can see a description box with some darker color.
- Now activate Dark Mode.
We don't need to apply a different background to these payment terms.
Based on similar field in the rest of odoo is better to remain without
any background.
opw-3465888
closesodoo/odoo#138852
X-original-commit: 9c13d961763df9e6a1359cc4645842c055c6d931
Signed-off-by: Andrea Grazioso (agr) <agr@odoo.com>
Signed-off-by: Maruan Aguerdouh Mohtar (magm) <magm@odoo.com>
pos*: point_of_sale, pos_self_order
In this PR, we improve the tracking_number computation decreasing the
number of string manipulation and increasing the number of int manipulation
in the backend. In the frontend, the computation of the tracking_number
was wrong. It was previously taking the whole session id and concatenate
it with the whole sequence number. We also fix that. It now takes the
last digit of the session id and the 2 last digits of the sequence number.
We also improve the payment_screen. Now, when the user arrives on the
payment_screen. If there is only 1 payment method. This payment_method
will be chose by default.
We also fix the display of the tracking number in the order reminder
page in pos_self_order.
Enterprise PR: odoo/enterprise#48991closesodoo/odoo#138813
Signed-off-by: David Monnom (moda) <moda@odoo.com>
The color refresh button in the document layout configuration modal is
misaligned and moves the content when clicked
This commit adapts the CSS to have a proper absolute placement and
apply a height on the o_field_widget in this view to fix the issue.
task-3378759
part of: task-3326263
closesodoo/odoo#138774
X-original-commit: 907373d6e7556ecd17b0c0a87b3705e242f9d628
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Tax group are currently ordered by sequence only.
Only 2 localizations of ours have defined the sequence on them.
So, most of the tax groups have the same sequence.
The order of search made on them is thus undeterministic.
It can be seen when running the test test_generate_xml_sale with
l10n_ee_reports installed, it fails sometimes (1 in 50 to 100).
Because the invoice amounts are grouped and ordered by tax groups.
Linked to runbot error 24595
closesodoo/odoo#138890
X-original-commit: 7535c6091cb841a428ea0f4cc6d4bb1779e70346
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com>
The `MoneyDetailsPopup` allows users to specify the exact
amount of each coin or bill present at the closing of the session.
This popup does not however have a easy to use interface, as there is
no button to increment/decrement the number of bills of a certain type.
In this commit we create a new component called `NumericInput`.
This is an input surrounded by increment/decrement buttons.
We use this component in the `MoneyDetailsPopup`.
We create the component `TModelInput` in which we extract the functionality
used by both the new `NumericInput` component and the existing `Input` component.
We also refactor the `Input` component such that it now extends this new `TModelInput`
class.
closesodoo/odoo#138851
Task: 3555403
Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
Previously, a link was included when creating a channel,
but this was unnecessary since there is no way to see the link
when you are not in the channel.
This commit removes the link while keeping the notification
to show the author and time of channel creation.
closesodoo/odoo#138668
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
[1] tried to remove nondeterminism from bus tests. However, several
issues remain:
- the asset watchdog bundle is added to the registry during bus tests.
Websocket tests wait for the `connect` event after starting the environment.
This `connect` event can be triggered sooner than expected since the asset
watchdog services starts the bus.
- a the random delay is added to the reconnection attempts.
- `nextTick` is kept when waiting for a client to leave the worker.
This commit fixes those issues.
[1]: https://github.com/odoo/odoo/pull/138221closesodoo/odoo#138639
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit:
There were no default icon set when a new activity type is created.
After this commit:
When user will create a new activity type, 'fa-tasks' will be added as
its default icon.
task-3525592
closesodoo/odoo#136952
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
For PEPPOL, the Customer Reference field on invoices is a required
field. In Odoo it can be blank when creating an invoice from scratch.
In order to avoid errors when sending PEPPOL invoices, we want to
set the Customer Reference to the invoice name when no reference was
provided.
task-3499548
closesodoo/odoo#135158
Signed-off-by: Laurent Smet (las) <las@odoo.com>
In 15.0, the SEO dialog did not allow trailing/leading spaces.
However, in Odoo 16.0 one can add leading and trailing spaces in their
SEO keywords.
This is becausethe commit which converted the SEO dialog to OWL [1] did
not trim new keywords, which could lead to keywords with trailing space.
It means that those keyword won't be marked as checked in the SEO
Dialog.
This commit removes trailing spaces when opening the SEO Dialog, in case
of an existing DB having such a case, and also when adding new keywords.
To note that trailing spaces will still be inside the page until the SEO
dialog saves the SEO data again.
Note that there might be (or might have been at some point) some cases
of migration which seems to lead to those spaces being added when the
user land in Odoo 16.
[1]: https://github.com/odoo/odoo/commit/ac55f2bb113ecf7c774fe6e96d28e716184a97d1
opw-3460300
closesodoo/odoo#138872
X-original-commit: 69c0293b59468c24c92b8b900cba7dd93bbbd0cf
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>
This will make it consistent with items applying to templates and
with form view where internal reference is shown.
It doesn't look like there is any reason to not displaying it in variants.
closesodoo/odoo#138866
X-original-commit: 9f53b8d2185a1abf9635c9d9f6c5378943da4d0a
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Since b1f1f21, Partner Autocomplete wouldn't work anymore on VAT numbers
as the field on which the widget was added was replaced by another one,
without the widget.
To fix this, the widget will now be added dynamically in `_get_view` so
that it happens after modifications made through view inheritance.
Another way of fixing this was proposed in b14a3af, but required an
upgrade of the `base_vat` module.
closesodoo/odoo#138865
X-original-commit: 6f7baee9899a350eade07c41d3c557fdca0d0904
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Louis Baudoux (lba) <lba@odoo.com>
https://github.com/odoo/odoo/pull/137502 changed how we handle homeworking
records. However, it would throw a traceback if luxon was using any non
english localizations to get the week name of a date. This commit fixes this by
setting the us location before getting the weekname as we rely on it to get the
default data for that day.
closesodoo/odoo#138831
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Live chat bundle structure changed in [1]. This PR misplaced a scss
file which results in a class missing from the Odoo backend. This
PR solves this issue
[1]: https://github.com/odoo/odoo/pull/138536closesodoo/odoo#138830
Signed-off-by: Didier Debondt (did) <did@odoo.com>
Before this commit, the order history page needed a small ui improvement
The amount and tax were initially separated using justify-content-between
, placing the title on the left and the amount on the right.
To align with Odoo's aesthetics and achieve a ticket-like look, they are
now right-aligned in a table. Additionally, based on feedback, spacing
around the ticket has been removed and the layout has been a little bit
revamped for a cleaner appearance.
task-3500874
closesodoo/odoo#138828
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Since [1], the live chat button is displayed after a conversation ended.
This change introduced a bug with with the chat bot.
Steps to reproduce:
- Open a chat with the bot
- Reload the page
- Close the live chat
- Open another chat
- The bot does not start
[1]: https://github.com/odoo/odoo/pull/134513closesodoo/odoo#138826
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Fixed cumulative attribute not passing from odoo and also added a checkbox to
the odooLineChart side panel, enabling users to easily switch between cumulative
and non-cumulative display modes.
the chart shows cumulative data, offering a comprehensive view of data progression.
Deselection displays regular non-cumulative data.
Task-3420844
closesodoo/odoo#138708
X-original-commit: 90eeb7318a6ac1b0d1a4a41715f3a895f3d5d8b6
Related: odoo/enterprise#48954
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
In odoo/odoo#135245 we added context={'active_test': False}
on the all_employee_ids on hr.leave model.
While it might have sounded like a good idea on the first glance
(we see the avatar of the archived employees), it will potentially
cause more side effects than bring good.
For example, for the employees that left the company and came back,
if might cause issues when we are trying to create time off for them.
It also introduced noise in the views.
Here we alter this change.
closesodoo/odoo#138686
X-original-commit: 9c09272f28aac4e66e3343a0e397540e222336fb
Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
Following 116879e17e81657f48a7d11780d8d30715ecc68f a few improvements were needed to make it more
complete.
task-3484125
closesodoo/odoo#137522
Related: odoo/enterprise#48563
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
To reproduce the issue:
1. Create a planned receipt with two lines:
- 10 x P
- 10 x P
2. Confirm and set the done quantities:
- 12 x P
- 8 x P
3. Validate
Error: The receipt is directly processed and a backorder is created.
In case a backorder could be created, we should first display the
wizard that asks for a user's confirmation
When checking for the backorder wizard, we compare, for each
**product**, the sum of the demands with the sum of the done
quantities. In the above use case, we will have `10 + 10 == 12 + 8`,
so we don't display the wizard.
However, while processing the SMs, this is different. For the second
SM, we will set its demand to 8, create a third SM with a demand
equal to 2 and create a new picking (the backorder) for this new SM.
This behaviour is legit, the backorder creation makes sense. This is
why this commit fixes the wizard display conditions.
OPW-3373255
closesodoo/odoo#138863
X-original-commit: 5affa219d8add6f256030b699f61ddf77a928c82
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart (awt) <awt@odoo.com>
Add a missing demo file in the manifest.
The file is missing from the migration of website_event_question
to website_event in this commit : cc60fcd45c
Task-3549598
closesodoo/odoo#138443
X-original-commit: c33cf8a8dfb4ff926894685836cf820bba71787a
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
In the conditional_visibility_1 tour, when setting up the UTM Medium,
the "Email" value is searched for.
But if more records (like with the design-themes testing enabled) push
this value out of the autocomplete initial proposition, the value cannot
be selected.
This commit fixes it by adding a step that search for the "Email" value
to ensure it is in the autocomplete propositions' list.
closesodoo/odoo#138834
Note: detected on the Lastest Chrome builds on the runbot (nightly)
X-original-commit: 8993a187f9918478f106c1913885cf980a6a9698
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
before this commit when the user created new quotation from
Contact/Opportunity/Quotation archived taxes were added to the quotation
because the context was active_test = false
after this commit the context is configured back to active_test = true
when creating quotation
opw-3470555
closesodoo/odoo#138829
X-original-commit: 5970132a809c7cfe2a935b961284150e24aaf93f
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Steps to reproduce:
- Create a BoM with two component lines using the same product.
- Have enough in stock for the first line but not for both.
- Open the Overview
Issue:
The merged line will show as 'Available' even though there isn't enough
product in stock for the combined quantity of both bom lines.
Now gets the latest availability amongst merged lines.
closesodoo/odoo#138794
X-original-commit: 24454b2f76c2a917fb5f9975dcbf4df4a307c843
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
`=ODOO.BALANCE("100,200", "2022")` works but
`=ODOO.BALANCE("100, 200", "2022")` does not work (notice the extra space).
With this commit, the account codes are trimmed.
closesodoo/odoo#138850
X-original-commit: 7fd3fd60cc7cd207626f49ba1cf40232ced9d4ff
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Try to Upload a Vendor Bill xml having an invoice line
with billed_qty 0
Issue: Traceback caused by ZeroDivisionError
opw-3497841
closesodoo/odoo#138843
X-original-commit: 0b3387390539e7379f1794c16f8ebf59fd4af9f8
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
Signed-off-by: Andrea Grazioso (agr) <agr@odoo.com>
When the side panel of a pivot is opened while the side panel of
another pivot is already open, the datasource of the first pivot is
used instead of the datasource of the second pivot. This can lead to
tracebacks, or to wrong data being displayed.
closesodoo/odoo#138338
Task: 3463289
X-original-commit: b6df2d807f7ffe0f0f89d894307e31d779f138e2
Related: odoo/enterprise#48775
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
This commit permits to check if the text theme is translated before
asking IAP for a text generation. We need the text to already be in the
target language to be able to generate the text in the target language.
task-3248852
closesodoo/odoo#136937
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit implements a demo mode in which a user can register to
peppol. The demo user performs no communication with the proxy server,
instead making and receiving only mocked calls and responses.
The @handle_demo decorator is added and utilised in order to avoid
adding the specific (and mostly irrelevant) branches of this of demo
functionality to the body of the code. When the edi_user has the
edi_mode 'demo' this decorator diverts the execution of the
function (excepting when running tests, whenupon it is ignored).
Specific logic is added to the res config settings in order to specify
which modes are availble to the current user based on the
"account_peppol.mode_constraint" config param, and the
"saas_trail.confirmation_token" config param. This allows us to default
users using runbot/demo-data/saas-trial databases to "demo" mode
registration.
task-id: 3497466
3497725
closesodoo/odoo#136909
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Adds the translation in French en German of account groups of l10n_lu localization.
task-3497904
closesodoo/odoo#138809
X-original-commit: 3770c062cae0b869ab4e096d33c931911cab34fd
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
Signed-off-by: Hugo Poncelet (hupo) <hupo@odoo.com>
Problem
---------
User want to verify (when he want) if he has bills on Peppol and the
status of his customer invoices. Currently, the only option is wait for
a cron that runs twice a day.
Objective
---------
- Add a button in the Kanban card of the customer invoices that updates
the status of invoice send by Peppol.
- Add a button in the Kanban card of the incoming journal that fetches
received bills on the Peppol network.
Solution
---------
This commits does several things in order to achieve the objective:
- Seperate the peppol cron function into business action and cron
function
- Add an interface on the journals so that they can call the peppol
business functions
- Add an inverse function that resets the journal `is_peppol_journal` to
False and sets that field to True on the relevant journal.
- Add a related field that checks whether the company has peppol active
- Add the buttons on the Kandan Dashboard view that call the relevant
cron function thanks to the interface. It edi users on the target
companies so that only the target companies are updated when a button is
pressed and not all companies.
task-3531222
closesodoo/odoo#137840
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Current behaviour before commit:
When cropping an image, pressing ENTER creates new paragraph behind the
widget, due to this, changes are not getting applied on image and it disappears.
Desired behaviour after commit:
Now hitting ENTER works same as apply button, Changes are getting applied
when pressing ENTER.
task-3383447
closesodoo/odoo#138789
X-original-commit: add0d782fceebb84285a5f16952b852a29cf5a10
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
The kanban card do not display their outline on the bottom side of the
card. This is due to a negative margin (used to compensate for the
border bottom of the card).
This commit removes the border top if the kanban_record as a prior
kanban_record sibling, using its sibling border_bottom as its border
top and getting rid of the negative margin.
task-3488451
closesodoo/odoo#138772
X-original-commit: bf89d4ec951c77f5c7a01ccbad5edf0f7110f706
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Adds 2 accounts in the Chart of Accounts for l10n_co for the cash difference gains and losses and set them as default accounts.
task-3546441
closesodoo/odoo#138198
Related: odoo/enterprise#48683
Signed-off-by: John Laterre (jol) <jol@odoo.com>
In this commit 2 issues are fixed. The first issue is when trying to load
demo data when the default pos configs are deleted. The second is when trying to
reload onboarding data when the products are already loaded but archived
(task-3539455).
steps to reproduce the first issue:
- load db without demo data
- delete pos created by default
- create a new pos config
- open and try to load demo data
steps to reproduce the second issue:
- load db without demo data
- open pos and load demo data
- archive products
- open pos and try to load demo data
changes:
- main pos config demo data has been separated from onboarding data.
- condition has been added in the search count of _pos_has_valid_product
method to check for archived products.
closesodoo/odoo#138035
Related: odoo/enterprise#48621
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Odoo's Mergebot