Commit Graph
115014 Commits
Author SHA1 Message Date
Pierre Masereel 57f6c12834 [FIX] point_of_sale: add menu taxes to POS
When only point_of sale module is installed, it is impossible to modify
existing taxes because the One2many tags widget doesn't allow to open the
taxes and edit them. So we add a menu item allowing to modify them.

It is needed if we want to set a tax included in the price.
2018-02-23 11:19:48 +01:00
Christophe Simonis d6f5b7e2e6 [FIX] payment_ogone: correctly decode 3DS html form 2018-02-23 11:15:46 +01:00
Lucas Perais (lpe) 801b02f0ce [FIX] account: reconciliation widget: avoid created lines proposition may be empty
Before this commit, when stroking "Enter" in the filter, a JS traceback popped, because no created lines where found

After this commit, we control that we have created lines

OPW 1814309
2018-02-23 11:10:57 +01:00
Simon Lejeune 001b360458 [FIX] stock_account: fifo vacuum
If the vacuum finds that there is nothing to do regarding the accounting
entries, do not call `_account_entry_move`, else an accounting entry
will be created for the entire cost of the compensated move.

opw-1817372
2018-02-23 11:07:45 +01:00
Jeremy Kersten 708ad186d5 [FIX] website: sitemap is not translatable
Disable the multilang on the route sitemap to avoid the user to be redirected
from /sitemap.xml to /<lang>/sitemap.xml
2018-02-23 10:37:09 +01:00
Jeremy Kersten 7179008ffa [FIX] doc: fix link to our website
Remove wrong slash trailing

Now, in V11, matching of page are done on the exact name.

Previously, the error was transparent because we was using a
dedicated controller that allow trailing slash.
https://github.com/odoo/odoo/blob/11.0/odoo/http.py#L936

https://webmasters.googleblog.com/2010/04/to-slash-or-not-to-slash.html

    http://example.com/foo/ (with trailing slash, conventionally a directory)
    http://example.com/foo (without trailing slash, conventionally a file)

    Google treats each URL above separately     (and equally) regardless of
    whether it’s a file or a directory, or it contains a trailing slash or
    it doesn’t contain a trailing slash.

    Different content on / and no-/ URLs okay for Google, often less ideal for users

   Special case for homepage
       Rest assured that for your root URL specifically,
       http://example.com is equivalent to
       http://example.com/ and can’t be redirected even if you’re Chuck Norris.
2018-02-23 10:36:15 +01:00
Jeremy Kersten dee3b87ae4 [FIX] website_customer: fix sitemap when customer had no country
Before this commit, the sitemap will crash if you have some res.partner
without country that are publish and with an assigned_partner_id.

Now, we only search for customer with country that are set and avoid to have
a traceback:
  File "/home/odoo/src/odoo/11.0/addons/website_customer/controllers/main.py", line 31, in sitemap_industry
    loc = '/customers/country/%s' % slug(country['country_id'])
  File "/home/odoo/src/odoo/11.0/addons/http_routing/models/ir_http.py", line 91, in slug
    identifier, name = value
  TypeError: 'bool' object is not iterable
2018-02-23 10:36:15 +01:00
Adrian Torres ff7efbb1e8 [FIX] website,sale,auth_signup: prevent shared field deletion
The field `auth_signup_uninvited` is defined in the 3 aforementioned
modules, yet they are independant modules in respects to one another.

This means that whichever module is installed first will create an XMLID
for the field, if this module is uninstalled before the other two: boom!
crash when changing general settings because the res.config.settings
field set by the other two modules no longer exists.

To solve this, we simply ignore the field during ir_model_field.unlink()

Fixes #23171
2018-02-23 10:28:10 +01:00
Aaron Bohy ad1cceb4fb [FIX] web: one2many and onchange corner case issue
Let's assume a one2many list view inside a form view, displaying
a single char field A. There is an onchange on the form view
returning a command 0 (CREATE) for the one2many. The command 0 only
specifies a value for field A. The one2many list isn't editable, so
when a sub-record is clicked, it is open in a form view (in a
dialog). In this form view, an x2many field B is displayed in a sub
list or kanban view.

Before this rev., it crashed when the user tried to open the
created one2many sub-record (returned by the onchange) in the form
view, because of the presence of the x2many field B, which wasn't
correctly processed by the BasicModel (its value was undefined,
whereas it must be a valid, empty, dataPoint).

Moreover, the limit of the x2many field B wasn't set, so a pager
was displayed as soon as it contained at least one record.

Fixes #22050
2018-02-23 10:01:39 +01:00
Nicolas Martinelli 8a29e37dda [FIX] sale_timesheet: format amount
Due to the representation of floats, it may happen that the amounts in
the project overview appear with much more decimals than expected.

We use the usual `monetary` widget to render the amounts.

opw-1814843
2018-02-23 08:59:28 +01:00
Martin Trigaux 370c944c2f [IMP] pos_mercury: do not translate technical error messages
Error messages are given by vendor and have specific meaning
Translating it does not specifally help to find out more about the problem
pos_mecury is intended for US market anyway
2018-02-23 08:45:40 +01:00
Christophe Simonis 69ef302aa0 [FIX] website_quote: call existing method 2018-02-22 19:45:42 +01:00
Christophe Simonis e5987434c6 [MERGE] forward port branch saas-15 up to 9cfd4a5c07 2018-02-22 19:06:31 +01:00
Christophe Simonis 9cfd4a5c07 [MERGE] forward port branch saas-14 up to caea203ba6 2018-02-22 18:59:43 +01:00
Christophe Simonis caea203ba6 [MERGE] forward port branch 10.0 up to f492c73080 2018-02-22 18:57:02 +01:00
Christophe Simonis f492c73080 [MERGE] forward port branch 9.0 up to cd21ea414e 2018-02-22 18:56:22 +01:00
Nicolas Martinelli 5ce76a0e70 [FIX] hr_payroll, resource: no attendances
Method `get_day_work_hours_count` can return 0 if no attendance is found
in the calendar. Therefore, we must make sure to not divide by zero,
otherwise, boom boom.

Closes #22900
opw-1815095
2018-02-22 16:32:43 +01:00
Alexandre Kühn 58eea6b3b3 [FIX] mail: backport fixes on the composer from saas-11.2
This commit back-port some fixes from saas-11.2 on composer.
Tests are available only in saas-11.2 and up.

List of fixes:

1. Pressing TAB with @ mention propositions should cycle through them
  (see https://github.com/odoo/odoo/commit/497a44ab7f04e377decf5fde42f075616f764f26)
2. Prevent a crash when focusing out the emoji button
  (see https://github.com/odoo/odoo/commit/1753017255f3f078ede05a68842f440e02b64630)
2018-02-22 16:11:06 +01:00
Nicolas Lempereur fbbd070a21 [FIX] point_of_sale: make pricelist tour pass
The change in 3ae382f8d3a caused a similar error to ef91c141f6.

So the tour failed in enterprise because account_taxcloud caused a
customer tax to be added to the "Orange Butterfly" product.
2018-02-22 14:27:54 +01:00
Duc Dao ad3cc1b231 [FIX] resource: Fix default empty timezone
Since the method `_get_leave_intervals` assumed that field `tz` is always filled in.
There is a case in default function, when `self._context` had key `tz` but its value was `False`,
which may causes null value of field `tz` and lead to mismatch interval between leave and payslip
2018-02-22 14:09:49 +01:00
Christophe Simonis cf2d07aa22 [MERGE] forward port branch saas-16 up to 521c29317c 2018-02-22 13:53:28 +01:00
Dennis Sluijk f2501bfd3c [FIX] web: return dialog in web.CrashManager functions
This is more a architecture fix than a bug fix.  With this commit, it is easier to modify the behavior of the dialog using the super function. like this: this._super.apply(this, arguments).opened(...)

PR #23255
2018-02-22 12:01:57 +01:00
Goffin Simon 0da5d63f52 [FIX] account: Register a partial payment as fully paid
Due to this commit: 3267e76520

Steps to reproduce the bug:

When registering a payment for a customer invoice in an other currency than
the company currency and marking it as fully paid, it raised an error:
"Wrong credit or debit value in accounting entry !".

Reason: counterpart_aml['debit'] and counterpart_aml['credit'] were both incremented
and it violated the constraint credit*debit=0

opw:815465
2018-02-22 11:52:52 +01:00
Goffin Simon 5cdefcc39a [FIX] purchase: Adding PO on refund vendor bill
The function  _prepare_invoice_line_from_po_line has not been
designed to compute in a right the quantity for a  line in an
in_refund invoice. So it has no sens to display the field purchase_id
for a refund vendor bill.

Closes #23095

opw:816717
2018-02-22 11:21:13 +01:00
Nicolas Martinelli 075f13ac63 [FIX] pos_discount: error if misconfigured product
In case the discount product is misconfigured and therefore not loaded
by the POS, a traceback appears when applying a discount.

Add a comprehensive error message instead.

opw-817527
2018-02-22 11:01:40 +01:00
Nicolas Martinelli 310e3c15fd [FIX] pos_discount: default product
Several issues:
- If product `product_product_consumable` was deleted, an error is
  raised.
- The default values are inconsistent with the fact that
  `module_pos_discount` is `False` at POS creation.
- The domain should ensures that both `available_in_pos` and `sale_ok`
  are `True`, otherwise the product won't be loaded by the POS.

opw-814426
2018-02-22 10:50:28 +01:00
Yannick Tivisse 521c29317c [FIX] l10n_be_hr_payroll: Adapt the warrant costs to the new 20% law
https://www.claeysengels.be/en-gb/news-events/m/a/rulingdienst-begrenst-gebruik-warrants-en-opties-op-bevek-aandelen-invoering-van-de-20-grens/

The law seems to change every 2 days.
2018-02-22 10:28:27 +01:00
Christophe Monniez cd21ea414e [FIX] packaging: include missing files needed for tests
The test_mimetypes and base_import modules need various files for their
tests. Before this commit some of those files (.ods, .odt, .xlsx, .docx,
.zip) were not included in the packages.

Fixes #22778
2018-02-22 10:22:42 +01:00
Lucas Perais (lpe) ab37094ec4 [FIX] website_quote: default require_payment instead of compute
Commit a0f8ee92c3 solved the use case where
a quotation was created through the website shop and where the default quote's
template's require payment should be transmitted to the quote.
However, this commit made the field readonly

This present commit solves both problems by assigning a default to the problematic field
rather than computing it

OPW 817510
2018-02-22 10:17:56 +01:00
Adrian Torres 8e7aaf8c82 [FIX] sale_management/account_invoicing: properly reinstall
Commit 985c224 introduced a way to properly uninstall these two modules,
however if a user were to reinstall them the views would stay inactive,
in the case of sale_management this would mean some menus were missing,
in the case of account_invoicing this meant that not even the top-level
menu would not appear, effectively misleading users into thinking the
module was not installed.

The solution is to create a post_init_hook (to ensure that all
potentially missing menus are already installed) that activates the
previously deactivated menus.

Fixes #23245
2018-02-22 09:55:59 +01:00
Romain Derie 97cae87812 [FIX] portal: use user timezone to display hours on portal chatter
Before this commit:
User timezone would be taken into account when displaying message date on
chatter. It would always display the hour in the server format (UTC).

Now, we correctly use the user timezone to format the date being sent by the
server.

This closes #22812
2018-02-22 08:55:37 +01:00
Joren Van Onder 3ae382f8df [FIX] point_of_sale: do not recompute manually set prices
The POS recomputes order lines when the pricelist changes. This is
different from the sale app on purpose: in a usual POS flow the customer
and thus pricelist is selected after taking the order.

But users commonly use a 'Miscellaneous' product when they are selling
something that is not in their POS system. The user can select this
product and manually set the price. When now a customer is
selected (even if the pricelist has not changed) these miscellaneous
order lines get recomputed. So now the cashier is forced to input
these prices again.

To avoid this we keep track of lines that have had their price changed
through the UI and we don't update them.

opw-817353
2018-02-21 16:12:40 -08:00
Christophe Simonis dbb713c2f8 [MERGE] forward port branch saas-16 up to 49f8548557 2018-02-21 19:17:01 +01:00
Christophe Simonis 49f8548557 [MERGE] forward port branch saas-15 up to 085ff2f9c4 2018-02-21 18:36:36 +01:00
Christophe Simonis 085ff2f9c4 [MERGE] forward port branch saas-14 up to 8c692aac88 2018-02-21 18:09:17 +01:00
Christophe Simonis 8c692aac88 [MERGE] forward port branch 10.0 up to aad677c338 2018-02-21 17:57:00 +01:00
Christophe Simonis aad677c338 [MERGE] forward port branch 9.0 up to 4432e1d5c3 2018-02-21 17:35:11 +01:00
Christophe Simonis 4432e1d5c3 [FIX] project: do not reset task's partner when changing project if project is not linked to a specific partner 2018-02-21 17:26:16 +01:00
Josse Colpaert 6ec6d3e8a1 [FIX] stock: remove action_traceability method on lot fixes #22299 2018-02-21 17:14:13 +01:00
jem-odoo cb53485d71 [FIX] sale: reinvoice only vendor bills
When validating a vendor bill, we want the product
with expense policy set to be reinvoice on the open
sales order matching the analytic account of the invoice
line. Applying the same mecanism for customer invoice
does not make sense, as we might confirm a SO and validate
its invoice, we don't want a new SO line to appear (avoid
loop).
Unfortunately, since a long time, this is possible in Odoo,
and really make no sense. We should only take negative
analytic lines (coming from vendor bills and expense, not
the customer invoice) into account for adding SO line.

This commit correct this problem to avoid having
many null SO line created on customer invoice validation.
All test cases are correctly written, but there was no
check to prevent this mecanism to be apply on customer
invoice.
2018-02-21 16:59:39 +01:00
Martin Trigaux 113385fdd7 [FIX] pos_mercury: do not translate mercury XML
untranslatable content
2018-02-21 16:43:30 +01:00
Christophe Simonis 68379cadbc [MERGE] forward port branch 10.0 up to 2bdc0cc7eb 2018-02-21 16:37:49 +01:00
Swapnesh Shah d6174dd226 [Fix]mrp: Removed unused copy_data method 2018-02-21 15:55:08 +01:00
Nicolas Martinelli c0fa53e45c [FIX] crm: link in planner
The link to configure incoming emails is not correct anymore after the
Sales reorganization.

opw-813987
2018-02-21 15:49:14 +01:00
Yannick Tivisse 4d614f55c3 [FIX] l10n_be_hr_payroll: Use the warrant costs on gross computation
Purpose
=======

The warrant cost formulae has been modified at 5d22170.

Instead of using the (remaining) warrant costs formulae, use the corresponding field instead.
2018-02-21 15:14:26 +01:00
Christophe Matthieu 5fb21b4db4 [FIX] web: evaluation of xml templates must be retro compatible
Issue:
domain="[('date','=',time.strftime('%%Y-%%m-%%d'))]"
is converted into a domain equal [('date','=','%2017-%12-%12')]
instead of [('date','=','2017-12-12')]
2018-02-21 15:09:16 +01:00
Christophe Simonis 2bdc0cc7eb [MERGE] forward port branch 9.0 up to 2120e667b9 2018-02-21 14:36:35 +01:00
Olivier Dony af7860c94c [FIX] project: restore portal visibility
Odoo 11 comes with unified features for Project Tasks and Project
Issues. Specifically, issues were retro-fitted into tasks, and saw their
specific features added to the features of tasks.
During this refactoring, the portal controller for issues was superseded
by a unified portal controller for tasks, via
623ea43268

One case was lost in the process: portal visibility of
tasks/issues/things that are individually followed by customers, without
the customer following the project itself.
This is important for `transversal` projects, such as a "Helpdesk"
project common to all customers, where each customer only sees their own
issues.

This commit restores the feature, previously added to issues by
1cc8252a95

Note: this clearly requires a proper regression test, to be added soon.
2018-02-21 14:12:15 +01:00
Nicolas Martinelli 1fa6b63c0f [FIX] stock_account: groupby
Set the groupby according to what is done in `_read_group_raw`.

opw-816358
2018-02-21 14:03:40 +01:00
Nicolas Lempereur e2280783a2 [FIX] mail: no view edit on forum link in notif
When sending notification from the frontend, if a template is rendered
for it and the user has the group "website.group_website_publisher" he
will get inherit_branding adding on elements things like:

  data-oe-id="42" data-oe-model="ir.ui.view" data-oe-field="arch"

but the chatter system has feature automatically redirecting an element
that have attribute "data-oe-id": this caused for example that a
link notification towards the forum would instead be redirecting to
editing the view of the notification.

This fix distinguish the inherit_branding in the chatter feature and
ignore them.

opw-813333
closes #23225
2018-02-21 13:39:25 +01:00