Issue: after many2one updates, the cache of the corresponding one2many
fields was inconsistent when the latter depends on `active_test`. One
of the values in cache was updated, while the other was left intact.
We simplify the cache by not making the field depend on context: the
cache value contains all the records in the relation (corresponding to
`active_test=False`). The value of the field is automatically filtered
by the `active` field when the value is accessed.
This makes it easier to maintain the cache value, guarantees its
consistency, and avoids queries to read the one2many field with
`active_test=False`, after having set it with `active_test=True`.
The aim of this commit is to remove the mail notifications when there is no more credits on IAP accounts for SMS integration with stock.
Task-ID 2077783
closesodoo/odoo#37559
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
rating_per_user was instanciated the wrong way, as all the key pointed to the
same reference. Once a value was modified in the value dict, all the other
values in rating_per_user were also updated.
Task ID: 2076656
PR #37511
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
It's a non sense to be able to write on rating_last_image/feedback field as it is a related
to a computed field based on the last rating, given by someone.
We should not even try to corrupt data !
Task ID: 2076656
PR #37511
As the percentage bar is translucid, white rating icon is not really easy to see.
Using the main rating image - red for :(, orange for :| and green for :) - is more
convenient.
Also, this fixes the height of rating chart as the bottom border was not visible when 0%.
Task ID: 2076656
PR #37511
If the visitor starts a livechat session, his anonymous name was 'Visitor'.
Since visitor info are now stored, we can use the visitor name instead, if a visitor
can be retreived.
Task ID: 2076656
PR #37511
This commit adds a placeholder to the field where the visitor has to put his email
to be more self speaking. (Otherwise, the visitor could not know what to put on this field)
Task ID: 2076656
PR #37511
Since there is now a possibility for the user to ask a copy of the conversation,
livechat window should not be closed after feedback, to let the user choose to
receive a copy.
The behaviour was no aligned between positive and neutral/negative feedback.
Before, when sending a positive rating, the rating was not sent as a message on the channel
and the window didn't close.
But for neutral/negative feedback, the window was sending the rating as a message on the channel
but the chatter closed immediately.
Now, the rating is sent as a message for any type of rating.
If this is a neutral / negative rating, the reason field appears.
After sending the reason, the window stays opened.
Task ID: 2076656
PR #37511
- AFIP code in UOMS saved as char
- fix missing account_id in demo data
- Remove demo data that was throwing error
- merge res country data to csv file.
- move res currency AFIP code data to csv file
closesodoo/odoo#37457
Signed-off-by: Josse Colpaert <jco@openerp.com>
Before this commit, m2m fields were not updated when multi editing
in a grouped list.
Now, the fields are updated no matter how many levels of groupBys
are applied to the list.
Part of task 2078807
closesodoo/odoo#37589
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
o_control_panel have this layout:
+-------------------------------------+
| PADDING |
| +----------------------------------+
| | breadcrumb o_cp_searchview |
| | o_cp_left o_cp_right |
| +----------------------------------+
+-------------------------------------+
As you can see, there is a padding on the edge of the widget.
In Odoo 12.0, before the control panel refactoring (odoo/odoo@40dd121938)
the search view was a widget by itself (addons/web/static/src/js/views/search/search_view_mobile.js).
Note that in this case, once the following condition:
"ev.target === this.el" was reach the normal behavior
was executed.
But now the search view is embedded in the control panel.
There is a side effect: clicking on the padding of the control panel
triggers the "_onOpenMobileSearchView" and the condition is always true.
Therefore we try to open the search more even if it doesn't exist.
But anyway, the search view (full) shouldn't be opened when we click on
the control panel.
After this commit, the listener is scoped to o_toggle_searchview_full,
to avoid this side effect.
Steps to reproduce:
* Open any app with a control panel (e.g. accounting)
* Select a record (e.g. an invoice)
* Click on the padding of the control panel (BUG)
closesodoo/odoo#37587
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Before this commit, the product 'My Company Tshirt' had too much PTAL and PTAV which lead to an overloaded matrix.
This commit removes the 'Sleeves' attribute, reorder the other attributes and remove the Size attributes '2XL' and '3XL'.
task-2052537
closesodoo/odoo#37543
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
Before this commit, it wasn't easy to find a demo product template that opens either with the product configurator or with the matrix from a list view.
To fix that, this commit appends '(CONFIG)' to the name of all demo product templates that open with the product configurator and '(GRID)' to all demo product templates that open with the matrix.
task-2052537
When accessing an URL, there is some computation to check if you try to access
a lang. Part of this job is to get the closest language available.
For instance, you could try to get `/fr_BE/..` and it would redirect to
`/fr_FR/..` if french is installed but not belgian french.
There is a known issue when loading files/assets from a module starting by the
same letter than a lang, in debug assets.
Only reported case was `hr_XXX` modules which would be redirected to `hr_HR`
lang (croatian).
So, the issue would only occur when:
1. Debug assets is enabled
2. hr_HR lang is activated
3. only hr_XX modules would be impacted
But since 269aa59411, the issue would appear even if `hr_HR` was not activated.
This commit restore the issue to its minimal case, when `hr_HR` lang is
activated.
closesodoo/odoo#37494
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
- In the sms marketing app, the count of valid sms
recipient for contact list was not consistent in all app.
Fix by appling the mailing_sms context value also in the
mailing mailing form.
TASK_ID : 2075733
closesodoo/odoo#37248
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
The name for a mass mailing is now automatically generated, then
put the name field in settings and only visible/editable on debug mode.
TASK_ID : 2075733
- Now tree view is editable, because of that it was possible to change
subject and targeted model in mass mailing. Fix make it readonly explicitly.
TASK_ID : 2075733
- For the sms marketing, by default the sms is now log
on the chatter of the record (like with the sms composer).
But can be disable it with keep arhives unchecked (in debug mode only).
TASK_ID : 2075733
- In the sms marketing, the sms_allow_unsubscribe is now False by default
and move the field in the setting page.
- Improve the unsubscribe link for the sms : adding "\nSTOP SMS : "
message before the link.
TASK_ID : 2075733
- In the mail/sms marketing, when we send a mass mailing (sms or not)
with the mailing list selected, all the mailing list is take in account,
domain is not correctly modify. Fix the onchange function.
TASK_ID : 2075733
- In the sms marketing form view, a space is missing between the text
and a next_departure field -> Fix
- In the sms marketing form view, the sms content is now required
order to fix traceback due to a empty sms (when the sms was send).
- In the the sms marketing tree view : change the name field
with the subject field
(due to the change with name -> subject of mailing)
TASK_ID : 2075733
- In the mail/sms marketing form, compress all blue ribbons into
one to avoid multiple space between ribbons.
- In the sms marketing form, we add a clicked stat button to have
the same information that the kanban view.
- In the mail marketing form (when sms is enabled), when the state is in draft, stat buttons
opened and replied was present for no reason (only with sms marketing installed).
Fix by adding correct invisible condition.
TASK_ID 2075733
- Revamp the kanban view of the mass mailing (and mass SMS)
model to be more concise and readable. Also fix the issue of no border progress
bar in community version (same view).
- In the kanban view of mail marketing, when mailing list model is
targerted, the count of record was not correct.
Create a display condition if mailing list is used to fix the issue.
TASK_ID : 2075733
Commit c7f11aa fixed computation leave length but
forgot to adapt the code when a 2 week calendar is used.
This leads to a traceback when creating a leave for an employee
with a 2 week calendar.
This commit rectifies this.
closesodoo/odoo#37566
Signed-off-by: Romain Libert (rli) <rli@odoo.com>
rev[0] writes the qty done on the move lines directly in put_in_pack,
meaning hitting discard in the delivery wizard left the move lines with
a changed qty_done. We fix that by editing the quantities in
_put_in_pack in the stock module and getting the right move lines in the
delivery modules: meaning, get the normal or suggested ones (a fix
missed by rev[1]) then with quantities or 0 quantities.
[0] e03c1a836f
[1] f6d88a2e8dclosesodoo/odoo#37563
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
=======
Purpose
=======
government rule that "GST registration should be obtained by a taxable person under GST in each of the State or Union Territory, from where the taxable supply of goods or services is made"
So we managed this using journal
User create journal and partner for other states
After user can select journal in Sale order, Purchase order and warehouse
========
Solution
========
-Add a field on the journal to define the GSTIN
-Add sale and purchase journal field in warehouse
-On the SO/PO, add the journal field and based on the warehouse journal it set automatically fill if warehouse journal is set.
task 1917619
This reverts commit 42834e4eb3.
finished_workorder_line_ids contains finished products and by products.
Naming the section by-products is not clear when the settings isn't
enabled.
closesodoo/odoo#37588
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Fixes#33254:
* was in mail despite using mail.channel (which breaks if mail is not
installed, and web doesn't depend on mail)
* changes to sudo() broke previous behaviour (of having odoobot
message the admin, we ended up with the admin messaging themselves)
so fix that
* also get the channel and message with the user's context, otherwise
since we're during the login procedure the context could be as
little as just the lang from the browser and apparently channel_get
automatically creates a translation which would break if the
browser's lang is not installed in Odoo
closesodoo/odoo#37580
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
[`psycopg2` includes a submodule called `sql`][1] which provides more safety and comfort when dealing with raw SQL queries.
As of today, it works fine with Odoo unless SQL query logging is enabled.
This patch fixes that problem, allowing usage of that module.
[1]: http://initd.org/psycopg/docs/sql.htmlclosesodoo/odoo#37561
Signed-off-by: Christophe Simonis <chs@odoo.com>
only activate multi-edit on list with specific attribute.
When the attribute multi_edit="1" is set on the tree view the user
can select a/some records and it will activate the multi-edit
with confirmation dialog (even for a single record).
Also, on-change are not applied when using multi-edit
closesodoo/odoo#37525
Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
Due to the merge of account.invoice.line and account.move.line
some views doesn't exist anymore.
On desktop, we only need editable list view to do the job but
it's not the case on mobile!
On mobile, the kanban view is loaded instead of "tree" and
the form view is opened when we add a record.
Before this commit, the corresponding form view wasn't usable
on mobile and some fields were hidden like product_id.
As kanban view and form view are important on mobile, we get them
back like on saas-12.3. So the workflow is quite similar as before.
Steps to reproduce:
* Open Odoo in mobile
* Go Accounting App
* Create a new record
* Add a new line
* There is no product field (BUG)
Task ID : 2061797
closesodoo/odoo#37424
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Move and adapt gantt unavailability related methods (
_get_work_interval() and _get_unavailable_intervals() ) from
hr.employee to resource.resource. This move allows the unavailability
to be generated for users without related employees (like in FSM in
enterprise).
Task-2069861
closesodoo/odoo#36785
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
Before this commit, automations triggering on new records caused onchanges to break out-of-context record rules, hence preventing to create the record.
This commit filters out new records from the list of records matched by the domain of an automation.
task-1998636
closesodoo/odoo#37360
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
Co-authored-by: Raphaël Collet <rco@odoo.com>
purpose of this commit is to show payment token while making payment with sale order
before this commit:
in SO payment, there is a filter for s2s acquirer, and becuase of that filter, if brings
tokens of the acquirer which is set to s2s currently
after this commit:
payment token will be shown for particular user, now it will not depends on mode of acquirer
task- 2028285
closesodoo/odoo#37562
X-original-commit: 0ebfe8575a8bac0f6b4c0ba1f1084701d73c4c74
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
- Remove the useless domain set on the field.
- Fix the belgium PCMN to work with accrual.
closesodoo/odoo#37560
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
- Create a workcenter with a capacity of 500 units
- Create a BOM with a routing generating one work order in the WC
created
- Create 3 MO with the following real durations:
MO 1: 1000 units produced in 420.95 seconds
MO 2: 1000 units produced in 120.28 seconds
MO 3: 1000 units produced in 60 seconds
- Create a MO for 1 unit
The Duration expected is computed as
The Time Cycle is computed as:
(420.95 + 120.28 + 60) / (1000 + 1000 + 1000) = 0.20041
The Total Expected is computed as:
0 + 0 + (1.0 * 0.20041) * (100.0 / 100.0) = 0.20041
0.20041 seconds is not realistic based on the previous MO real
durations.
This is because the Time Cycle doesn't take into account the workcenter
capacity. If we can produce 60 units in parallel in 60 seconds, that
doesn't mean we can produce 1 unit in 1 second. Therefore, the Time
Cycle should be multiplied by the WC capacity, which gives a Time Cycle:
500 * (420.95 + 120.28 + 60) / (3000) = 100.205
Which is much closer to the real duration.
opw-2070759
closesodoo/odoo#37548
X-original-commit: 9d3a73f64feb3b9e71c50a04adb6206b6393c757
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Section 7.1.2 of RFC 7231 requires preservation of URL fragment
through redirects. Our old JS redirection code was necessary when
browsers did not consistently implement it. Apart from a few odd
and marginal exceptions they all do it now, so we can stop that.
Raphael Collet