Make partner_id and guest_id properly exclusive.
Allow creating a channel member from its form view.
closesodoo/odoo#140272
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, when opening a thread in the Discuss app and
changing to another active thread from the Messaging Meu in the
systray, the new thread was mistakenly renamed to the previous
active thread name.
This happens because the component `AutoresizeInput`, which is used
to show the thread name in the header of Discuss app, also allows to
rename the thread. The code to trigger rename was too naïve, in that
a click away was considered as a rename operation on the current
thread.
This commit fixes the issue by triggering the editing of the value
in the `AutoresizeInput` component only when the click away happens
while the input had focus. The click in messaging menu will not
trigger it as the input is not focused.
Task-3570377
closesodoo/odoo#140208
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Currently, if a user has an active deferred entry whose account has been deprecated in the mean time,
we create a move line containing this deprecated account which raises an unclear error to the user.
Now, instead, we let the user create deferral entries for deprecated accounts.
We also add a test to check that old moves are not taken into account when generating deferral entries.
task-id 3544877
closesodoo/odoo#140155
X-original-commit: 47f97fb208ee6c6fc4ce522bc7ad648ea6bbe07c
Related: odoo/enterprise#49758
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Ricardo Gomes Rodrigues (rigr) <rigr@odoo.com>
This commit adds tests for the pos_self_order module. The tests are
written in javascript and use the odoo testing framework. The tests
cover the following scenarios:
- attribute selection
- combo selection
- kiosk mode
- mobile mode
closesodoo/odoo#140138
Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
Before, error handling didn't work in point_of_sale when offline.
This was due to poor error handling.
Now, the "limited functionnalities" popup is displayed correctly.
closesodoo/odoo#140037
Related: odoo/enterprise#49705
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
The field date_order cas removed in a previous commit.
Thus, this line needs to be removed as well.
closesodoo/odoo#133654
Related: odoo/enterprise#46580
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
When the pr of the skip receipt was merged, the vat letter feature was missing.
This commit put it back to the point of sale module so we can inherit it again in other modules.
Signed-off-by: rhe-odoo <rhe@odoo.com>
m
Part-of: odoo/odoo#133654
There is a button in the header to register subcontracting process
(when needed). And there is an additional button in the view with
the purpose to correct data later after the encoding. However we
can't set button with optional="hide". We rename it with an edit
icon
Part-of: odoo/odoo#140307
It's bad practice to use the "extension" inheritance mode for a custom
component. In this case, inheritance is only necessary for the
"StockMoveX2ManyField" custom field.
In this commit, we will therefore use primary mode to generate a custom
template used only by "StockMoveX2ManyField".
closesodoo/odoo#140301
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Purpose:
-------
The "StockMoveX2ManyField" custom field has given rise to a new need,
that of being able to edit a record in an x2many directly or from a dialog.
This is the first use case to require the ability to do both at the same time.
This particular use case highlighted a bug preventing a change from being saved.
How to reproduce:
- Go to a form view with an x2m using a custom widget
- Open an x2m record in dialog mode
- Close the dialog
- No changes have been made to the record, so the save button is not displayed
- Edit a field in the same record
Before this commit:
The save button is not visible
After this commit:
The save button is visible.
closesodoo/odoo#140298
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
This commit removes useless function from legacy/utils.js and removes it
from several backend bundles. The file is moved in wysiwyg and frontend
bundles as it is still used in these bundles.
task id: 3439226
closesodoo/odoo#140260
Related: odoo/enterprise#49812
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Before this commit, cliking on a popover that was open inside another
popover closed both of them.
After this commit, the popovers are not closed. them will close only if
we click out of them and the popovers they opened.
closesodoo/odoo#140258
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Purpose:
--------
Before this commit, if you edit a char field with an onchange in
an x2many, the FormStatusIndicator buttons will flicker.
How to reproduce:
-----------------
- Go to a form view with an x2many field in list mode
- Type a char in the char field of a record
- The FormStatusIndicator buttons are visible
- Click outside the char field
- An onchange is triggered
Before this commit:
The FormStatusIndicator buttons will disappear until the onchange returns.
After this commit:
The FormStatusIndicator buttons remain visible.
closesodoo/odoo#140179
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Fixes the receipt payment lines name (replacing "Bank" by the payment method name).
closesodoo/odoo#140098
Task-id: 3572422
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
In this commit, we add the mention of the service type on the ticket and
when the service is "table", we add the table stand number.
We also fix a problem with stripe and adyen where the ticket does not
print the order but an empty order with the kiosk.
closesodoo/odoo#140047
Signed-off-by: David Monnom (moda) <moda@odoo.com>
Change the global filter icon from the `fa-search` to something more
filter-like.
Also use the same icon in shared dashboard.
closesodoo/odoo#139164
Task: 3560817
Related: odoo/enterprise#49166
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
In this commit, we will remove "closestScrollable", "compensateScrollbar"
and the last usage of "scrollFixedOffset" outside of dom.js.
closesodoo/odoo#140181
Part-of-task: 3439226
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Before this commit, the domain on ``employee_id`` and ``employee_ids``
would be computed in a computed method ``_compute_allowed_employee_ids``.
However, due this compute method not triggering for new records, the
domain was not correctly set.
Additionally, this way of computing the domain was not very efficient.
With this change, the domain is computed correctly and efficiently.
closesodoo/odoo#140146
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
The forms where we have ribbons do not provide a great user experience when the internal links are right below the ribbon. Because of the shape and size of the ribbon, the internal link button on the topmost fields gets behind the ribbon. Because the rectangular part of the ribbon is transparent, we can see the button, but cannot click or hover over it, because the ribbon element takes over. To resolve this, I set the pointer-events of ribbon to none. The ribbons already do not have any click events so this solution seems okay.
Steps to Reproduce:
1. Move a helpdesk ticket to the archive.
2. Try to move to the customer page using the internal link.
Current Behavior:
The link button cannot be hovered over and clicked.
Expected Behavior:
The link button should be above other elements and clickable.
OPW-3468153
closesodoo/odoo#140099
X-original-commit: c9aa5fb7645470c5a63784e58fdb4ee9acf7d5e8
Signed-off-by: Bastien Fafchamps (bafa) <bafa@odoo.com>
Signed-off-by: Simon Goffin (sig) <sig@odoo.com>
In this commit, we are adding partner to the order receipt as it is
needed for the receipt in india and for the loyalty module.
closesodoo/odoo#140046
Signed-off-by: Robin Heinz (rhe) <rhe@odoo.com>
Currently, the "Amounts to settle" button in the "Vendors" drop-down menu
opens a view showing all the account.move.line that are to be reconciled.
Also, they should only be shown when their residual is less than zero.
This commit makes it now so that when clicking on that button, only the amls
linked to a purchase journal are shown and another "Amounts to Settle" button
has been added in the "Customers" drop-down menu to show the amls linked to
a sale journal
task-3572482
closesodoo/odoo#140040
Signed-off-by: William André (wan) <wan@odoo.com>
Tooltip items are not correctly sorted anymore after migration to last
Chart.js version in the commit eb530b83b06a057f96.
This feature is fixed in this commit.
task-3552948
closesodoo/odoo#139676
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
A "quantity_done" removal was missed in the MO Overview report, which
made it so the report would throw an error when opened for a done MO.
Also replace "Reserved" with "Quantity" in the overview so that
it is more consistent with pickings + is more intuitive since it is
currently confusing that when the qty produced is updated, then it
appears that the qty reserved changes (rather than a qty being done)
closesodoo/odoo#140246
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
This happened when auditing an aggregation line with a sum_children formula. A test was added in enterprise to prevent that to occur again in the future.
closesodoo/odoo#140200
X-original-commit: 1b24098676c1334666fc11b9973f76f4d200fa27
Related: odoo/enterprise#49783
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: John Laterre (jol) <jol@odoo.com>
Follows commit: ffef01e327.
It caused an issue in Firefox:
On the sale order form view (with the field "notes" handled by the OdooEditor),
clicking on a Many2one made the browser crash because the method getSelection
did not exist on the target which was the input element.
It did not crash in chrome as the event's target was always the Document.
The added test actually tests the feature of the referenced commit, and checks, as much
as possible, that there is no crash.
closesodoo/odoo#140143
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Since c8ca9da7bc, the tooltips in the
charts can come out of the container and make the scrollbar appear,
which is not desired. In this commit, we fix that.
task-3568895
closesodoo/odoo#139987
X-original-commit: c1f08c60b7272e5a30951c53b67427e2f205b722
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
This commit removes the requirement that the records count should be
set before the edit domain button is shown for domains which must be
edited in a dialog. This could be annoying in cases the records count
loads slowly.
task-3561782
closesodoo/odoo#139969
X-original-commit: f2ba825eac5e4bda3d1b1d3676a1b737701c0fb8
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
Signed-off-by: Julien Carion (juca) <juca@odoo.com>
-> This commit add/change the name of the page corresponding to the string
attribute because To be able to detect a field, Knowledge needs to be able to
read its page name.
For more reference: Task-3501211
Task-3524474
closesodoo/odoo#137428
Related: odoo/enterprise#48315
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Since [1], highlighting a pinned message from the notification sent
to the channel does not work anymore. This is due to a `super` call
missing. This PR fixes the issue.
Steps to reproduce:
- Go to a channel
- Pin a message
- Click on the "message" link
- Nothing happens
[1]: https://github.com/odoo/odoo/pull/121418closesodoo/odoo#139948
X-original-commit: 68992ba05eb48459800df17707741295a4f47c9c
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
It is sometimes desirable to completely remove a field
from the automated tracking message
when setting a custom message that already covers the change being made.
Add a filtering method on threads to allow models to selectively
hide tracking values from emails and messages.
task-2974500
closesodoo/odoo#109606
Related: odoo/enterprise#31795
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Steps to reproduce:
-------------------
- create a job application;
- add an applicant name;
- add an email with a wrong format.
- save;
Issue:
------
A traceback occurs.
Solution:
---------
Check that the normalized email exists
(that it is not `False`) before using it.
opw-3544918
closesodoo/odoo#139952
X-original-commit: 3f52f9e84e42f5ad13ca96a92ea40b9a35d4353c
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
This patch provides the possibility to implement a custom security layer on top
of Odoo's imbus notification system and ir_cron live triggering system.
The key addition is the `ODOO_NOTIFY_FUNCTION` environment variable (opt-in),
which can now define a custom postgresql function to be called instead of the
default `pg_notify` function. This allows for greater flexibility and control
over the notification and triggering mechanisms within Odoo.
closesodoo/odoo#140089
Signed-off-by: Fabien Meghazi (fme) <fme@odoo.com>
Problem
---------
Previously, when receiving an email with several attachments, we created
1 invoice that contained all the attachments.
Objective
---------
We want to create several invoices depending on the attachments received.
No invoice should have more than one PDF document.
No invoice should have more than one XML document.
Other attachments should be placed in seperate invoices (except for the
first invoice that can contain 2 attachments: ex. image and PDF).
Solution
---------
Update the _extend_with_attachments to behave like such.
task-3526248
closesodoo/odoo#140196
Related: odoo/enterprise#49779
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Steps:
- Open Time-Off
- Go to configuration
- In public Holidays
- Create a new public holidays
Issue:
- The validation error occurs.
Cause:
- It get employee from the company which is not selected due to this
employee consider as a invalid employee.
Fix:
- Add domain in employees_groups so it consider only selected companies
employee while creating public holiday.
Task: 3504636
closesodoo/odoo#140185
X-original-commit: fe88f384d186cf4e3e5505dde78d68e286c34a0e
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Louis (wil)