In sign, we don't want to show the view all option when choosing sign options
for a sign item in a template. This commit adds the noViewAll prop to the
many2many_tags_field component.
task-3233643
closesodoo/odoo#122157
Related: odoo/enterprise#39787
Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
Since [1], the DOM of the studio icon has changed, and no longer
matches the selector of the clickbot menu. As a consequence, it
no longer entered Studio. This commit fixes the selector.
[1] odoo/enterprise#9da0c9fab6c066aa97bc8cb99eb0e54b5a76a08f
closesodoo/odoo#128040
X-original-commit: aba563c58ec890bbf33d4a7d3cc34e9b2a4012a0
Related: odoo/enterprise#43910
Signed-off-by: Luca Vitali (luvi) <luvi@odoo.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This is reproducible in lots of ways, here's one:
- Inventory -> Products -> Any storable product
- Click on Update Quantity
- Click on the cell where the 'History' and 'Set' button are
This raises a traceback as the `cell` assigned right before is null at
that point. Indeed, since those cells from a special kind of column made
of buttons (o_list_buttons), those don't have a `name` attribute to
find, hence the traceback.
closesodoo/odoo#128014
X-original-commit: 222dc64be51cc8e711278cff96392e755ba39fd4
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
=== ISSUE ===
If you open the calendar module with an event with attendees, the status
button showing if the user accepted the invitation or not is missing a
left margin.
=== AFTER ===
We add a `ms-1` class to the buttons to space them correctly.
task-3389679
part of task-3326263
closesodoo/odoo#127976
X-original-commit: 86595f718ec5824d53f49ae7495677dd31551d57
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
The use-case is a first call to onchange2() where:
- a one2many field has a default value with a new line
- some onchange method discards that line
The diff should not return a "delete" command for the discarded line,
since the client does not know about it. Instead, for that first call,
it should behave like if the initial value of the field was empty.
Part-of: odoo/odoo#127718
This commit simply restricts the clickable with of any checkbox component
to be restricted to the checkbox (or toggle) itself so that the user can
no longer toggle it from possibly a long range.
opw-3378955
closesodoo/odoo#127118
Signed-off-by: Luca Vitali (luvi) <luvi@odoo.com>
This commit reduces the vertical padding of `.o_kanban_header` to
display more kanban cards at a time in the view vertically
part of task-3326263
closesodoo/odoo#127827
X-original-commit: dc5f4f7cef67b256eb50cb15e1ae1f22aa124966
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
This commit makes use of the useAutoFocus hook to focus the input
when the SelectMenu opens. This usage of the hook can replace the
manual focus that was applied when the dropdown opened.
The feature can hardly be tested with newer tests, since the behavior
is identical, and the focus on the input was already tested.
closesodoo/odoo#127864
Signed-off-by: Bastien Fafchamps (bafa) <bafa@odoo.com>
Steps to reproduce the bug:
- Go to Apps, and install the Knowledge App.
- Go to Knowledge and create an article, and a child article.
- Inside the child article, go to Properties tab and add a property.
- Go to edit the property, and inside the popover,click on the
delete button, atleast 2 times.
- Now we got more than 1 popover to confirm the delete of the
property, click delete on all of them.
Issue:
Once the first popover is confirmed, we properly delete the property
but now we are going to get an error because the property is already
deleted and we won't be able to find the property to delete.
Solution:
We need to check if we can find the property we want to delete
before doing any further actions.
opw-3371753
closesodoo/odoo#127584
X-original-commit: 7f5aed12fb143928cc82eeeea712363cb79b1171
Signed-off-by: Maruan Aguerdouh Mohtar (magm) <magm@odoo.com>
This commit forces the video element to take all the space available.
Steps to reproduce:
* Open the barcode APP (on iOS device)
* Click on "Tap to scan"
* On iOS the video element doesn't take all space => BUG
closesodoo/odoo#127763
X-original-commit: 29e677ed84c0b7324488cfebf2d44b9247716c54
Signed-off-by: Romain Estievenart (res) <res@odoo.com>
Signed-off-by: Romeo Fragomeli (rfr) <rfr@odoo.com>
Before this fix, a condition like "Foo is not set" created via the domain
selector would be badly described in the facet as "Foo is set".
We fix that problem and add a test that covers that situation and similar
ones.
closesodoo/odoo#127447
X-original-commit: a6b7de5d62906e5508585e0b994bf95544d10476
Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
This commit fixes the filtering of choices when the choices or the groups
props values are updated. Before this commit, the filter was only triggered
when the length of choices or groups differ.
Instead, it is prefered to apply the filter of choices whenever those props
are updated (in a dedicated useEffect).
A test has been added, updating the choices props, while having an object with
the same number of choices, while having different values. Before this fix, the
filtering wouldn't be applied correctly, since the filter wouldn't be triggered
because the object has the same number of values in it.
closesodoo/odoo#127733
Signed-off-by: Bastien Fafchamps (bafa) <bafa@odoo.com>
This commit changes the behavior of the "Search More..." option in
Many2XAutocomplete and analytic distribution by making it available
as long as there's at least one record in the search results and by
renaming it to "View all".
task-3258625
closesodoo/odoo#126041
Related: odoo/enterprise#43660
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
This commit changes the hex_color param which is not relevant
anymore since we are now using a color_index to make use of
a css class to take advantage of its responsiveness.
Task-3384796
closesodoo/odoo#127677
X-original-commit: a5687eac9115f1c8274f52e6662b23b8ad26f72f
Related: odoo/enterprise#43792
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This commit fixes the position of the notification
manager which was wrongly placed in the dom and
caused the notifications to be behind dialog's backdrop.
closesodoo/odoo#127631
X-original-commit: 381d574974bcfe274291628889459148ad741812
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>
Web lacked a default route for /robots.txt meaning that if you didn't
installed website (which comes with a full fledged robots.txt) you would
get a 404 page not found.
closesodoo/odoo#127402
Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
Steps to reproduce
==================
- Install purchase_stock
- Use a mobile viewport
- Go to Purchase
- Click on a record
- Try to set the "Deliver To" field
- Click on a record
-> An action is triggered and the record is not selected
Cause of the issue
==================
[commit] removed the only use of `forceGlobalClick`.
When it is set, KanbanRecord.selection_mode evaluates to true.
Solution
========
forceGlobalClick should be set when selecting a record from the
SelectCreateDialog.
[commit]: https://github.com/odoo/odoo/commit/6e18fb3c35281bdba26d9616150141298975bb40
opw-3337018
closesodoo/odoo#127632
X-original-commit: 7a1db9fade48d231a71084624fa0063989afd2b9
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>
Some buttons were stuck together or some had too much of a gap between
them, this commit aims to harmonize the space between buttons.
task-3378519
part of task-3326263
X-original-commit: 68d16f5b2131f44b2dfc3a5d6756aea8987b3fd5
Part-of: odoo/odoo#127613
=== ISSUE ===
If you open a list view and group item by, the caret at the beginning of
the row is not aligned.
=== AFTER ===
We had a `align-items-center` class on the container to make sure items
are centered vertically.
task-3398704
part of task-3326263
closesodoo/odoo#127595
X-original-commit: 920cfa51aad26b71884fb0187264a0f65ea4edd0
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Prior this commit, the "Settings" title was displayed before
`.o_cp_buttons` when it should be displayed after
This commit also adapts the position of `.o_dirty_warning` so it goes
after the title and can benefits from `.o_control_panel_breadcrumbs`'s
`.align-items-center`
part of task-3326263
closesodoo/odoo#127568
X-original-commit: 169031b8302f935265a36607b0f14c9b5d5ff722
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Currently, the domain editor dialog doesn't handle domains like
[('foo', '=', uid)] if you don't provide the (user) context in the
component props.
Since this kind of domain is expected to work everywhere, the component
now uses the user context by default to evaluate the domain.
There's no need to provide the context everytime the component is used.
closesodoo/odoo#127565
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
The domain component in readonly mode doesn't display dynamic/contextual
values.
For a domain `[('foo', '=', uid)]` the component displays "foo =" instead
of "foo = uid"
Part-of: odoo/odoo#127565
=== ISSUE ===
If you navigate to MRP and open a work center, there is a missing gap
between the `back` and `login` buttons.
=== AFTER ===
We add a `gap-1` class to the container to make sure these buttons are
correctly spaced
task-3398605
part of task-3326263
closesodoo/odoo#127558
X-original-commit: 76d54c260504ad53df6b2890552e78526abbf704
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Prior to this commit, in day and week view, the calendar's header was
misaligned due to the "week number" cell not having a left padding like
the cells below it.
`.fc-widget-header` resets the padding on the`.fc-axis` elements in the
header, thus making the header cells equal to their "day" cells below,
but the "week number" cell should have been an exception.
Adding the missing padding on `.fc-week-number` realigns all the headers
with their respective cells.
task-3326634
part of task-3326263
X-original-commit: 24547b3fb1db572bf358ff2e5a87bc76fb46c169
Part-of: odoo/odoo#127200
- The private addresses have been removed from the "res.partner" model.
- The employees' private address information has been moved to the "hr.employee" model, preserving the old records but emptying the private information fields.
- The applicant's private address information has been moved to the "hr.applicant" model, following the same approach.
- More generally, some efforts have been done to ensure we only create and use the same partner from the application form, to the employee creation and also the user creation.
- The salary configurator offer mechanism has been improved to provide stability (no more arguments in URL), traceability (track changes and responsibles) and reporting.
closesodoo/odoo#120586
Taskid: 3101400
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
The commit [1] removed two async module and caused a reorganisation
on the module loading.
Since that commit, the patches could be applied in a different order
and be applied after a save of one these patches.
This commit fixes a case where we save the reference of a patched
function that we call it later with missing patches.
[1]: 96687f29496ab4cf16ae2ab1584ef1a6a3fb4a11
Part-of: odoo/odoo#121185
The commit [1] removed two async module and caused a reorganisation
on the module loading.
Since that commit, two tests that throw an error failed
because the error message was written in the console
and the server considered this as a test fail.
Now, the error message is not written in the console anymore.
[1]: 96687f29496ab4cf16ae2ab1584ef1a6a3fb4a11
Part-of: odoo/odoo#121185
The commit [1] removed two async module and caused a reorganisation
on the module loading.
Since that commit, `uniqueId` did not begin with the id 1 in its test
and so the test failed.
Now, the variable containing the last id of `uniqueId` is set on the
function itself. This allows us to reset the id in the test.
[1]: 96687f29496ab4cf16ae2ab1584ef1a6a3fb4a11
Part-of: odoo/odoo#121185
This commit removes two top level await in test files and reorganises
a bit the tests setup as the module loading sequence has changed.
The commit also converts the modules that contained
these top level await to esm.
The goal of removing async modules is to simplify the
module loader in the future.
task id: 3265979
Part-of: odoo/odoo#121185
Purpose
=======
It is currently impossible to display a json field on a form view without
defining a specific widget.
Allow displaying the json field in its simplest form, aka the stringified
content in readonly mode.
TaskID: 3101400
Purpose:
This commit adds Emoji_picker functionality to the web_editor,
allowing users to conveniently add emojis to their text and
improving the overall user experience.
Specifications:
Now we can insert emoji in web_editor using `/emoji`.
Task id: 3253958
closesodoo/odoo#125137
Related: odoo/enterprise#42772
Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>
This commit fixes an issue with dialog buttons where it is possible
to trigger their action multiple times if the network is slow. This
is solved in form dialogs and x2many dialogs by disabling the buttons
when the user clicks on them.
opw-3291929
closesodoo/odoo#120151
Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>
This fix is a continuation of an old fix https://github.com/odoo/odoo/pull/121689
After fixing the display of numbers to be always on the right , The symbol also should be display the same as in english from ltr.
Also the headers and the footers are not placed well, they should be aligned with the numbers.
Steps to reproduce the issue :
1-install arabic language
2-go to accounting / customer invoices and you can see the placement of the symbol is reversed
opw-3295573
closesodoo/odoo#127231
X-original-commit: 8fcdc24abf4734d020cb41392a2e449a73433d3b
Signed-off-by: Bastien Fafchamps (bafa) <bafa@odoo.com>
Signed-off-by: Mahdi Cheikh Rouhou (macr) <macr@odoo.com>
This commit adapts several spacing issues related to the formView and
alerts.
task-3355091
Part of task-332626
closesodoo/odoo#127201
X-original-commit: a137b33dbbf0d18ac6909f958d126c7922d12a61
Related: odoo/enterprise#43579
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Since the introduction of Milk design[1], the fixed width for icons has
been removed in `view_button`.
This creates alignment issues when we have several buttons with icons
displayed in a grid or list (eg. status buttons).
This commit fixes this issue.
[1] commit 824024f
task-3387198
Part of task-3326263
closesodoo/odoo#127090
X-original-commit: a801dc6c74031e5593063ccac0245b2fe32c8ef3
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
We make the domain selector accept any expressions in the first and
second components of a domain condition. Along the way, we have found
necessary to refactor the Tree type (see domain_tree.js) and use it
directly in the domain selector instead of having yet another auxiliary
structure. Another simplification brought by this commit is that the
virtual operators is, is_not, set, and not_set are introduced earlier
and make possible to simplify the way operators are managed.
closesodoo/odoo#126350
Related: odoo/enterprise#43161
Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>
Some props like className were declared as optional in TagsList while
they are not used by the component. We remove them from the props
declaration.
Part-of: odoo/odoo#126350
We make TagInput use the generic component TagsList. This gives a better
looking/working to the editors used for the operators "in"/"not in" for
char fields.
Part-of: odoo/odoo#126350
A string representation of a domain like "[('bar', '=', false)]" is
evaluated by py.js the same way as "[('bar', '=', False)]".So both domains
are recognized as correct while false is not a valid python expression.
We do the same in domain selector, the expression "false" ("true")
will be understood as "False" (resp. "True").
Part-of: odoo/odoo#126350
The computation of the default value used by an editor used to assume
that the (default) operator is equal. We now pass the operator info to
getDefaultFieldValue in order to be able to have a different default
operator ("in" will become the default operator for relational fields).
Part-of: odoo/odoo#126350
The key negate is defined as mandatory in the definition of the type Tree.
We add them at some places (event if it did not pose a problem for now:
undefined and false are both falsy).
Part-of: odoo/odoo#126350
This commit makes the datetime hook independant from the props update
mechanism it previously relied on (onWillStart & onWillUpdateProps) to
update its internal props.
This was an incoming issue as the future relational model will rely on
fine-grained reactivity to update the fields rather than updating the
model and re-rendering all child components (effectively calling
'onWillUpdateProps').
Now, the hook relies on an internal state that tracks whether the props
given by its caller changed from one render to another, which is checked
at render time (i.e. in 'setup' and 'onWillRender').
closesodoo/odoo#125039
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Before this commit, 2 implementations of a "shallowEqual" function
coexisted, one in 'web/core/utils/objects.js' and another in
'web/core/utils/arrays.js'.
This commit only keeps the one in objects.js and makes the other simply
import and export it as well (easier to maintain while also easier to
find for those who want to work with arrays), while also taking an
optional comparison function argument in case the comparison needs to be
more specific (e.g. compare DateTime objects).
Part-of: odoo/odoo#125039
Leonardo Pavan Rocha