Steps to reproduce:
1- Install Sales and Events modules
2- Create a new Event and event registeration
3- Create a sale order for this event
4- Check the sales smart button in the event's form
5- Cancel the sale order and check the smart button
Current behavior before PR:
When you create a sale order for an event and then cancel it the value of this sale order will not be deducted from the sum of the sale values at the sale smart button in the event form.
Desired behavior after PR is merged:
When you cancel a sale order related to an event the sale smart button value will be updated
opw-3543943
closesodoo/odoo#140547
X-original-commit: b5554f6f7597b44adfa318655bab1eab19158303
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Youssef Bashandy (yoba) <yoba@odoo.com>
Main changes :
Force context values to avoid traceback in
action_generate_lot_line_vals
Before :
When calling action_generate_lot_line_vals from a repair order,
a traceback occurs due to the missing 'default_location_dest_id'
in the context.
After :
We enforce 'default_location_dest_id' in the repair order form
to ensure it is available when we call action_generate_lot_line_vals
closesodoo/odoo#140500
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Incoming picking should almost never be in a waiting ('confirmed') state. So we check if the location bypasses reservation and that no move is in MTO.
Changing the main_flow_tour because removing the "Waiting" status from incoming picking forms makes it unable to find "Ready" in Mobile UI.
closesodoo/odoo#140180
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
In order to improve the user Experience and not uselessly
block access to the document, we prevent collaboration error
to open the traceback dialog.
task-3568680
closesodoo/odoo#139964
X-original-commit: df39cbc4dbc1922e91c53278db7fdcb12f01306e
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Geelen Sébastien (sge) <sge@odoo.com>
In some cases the changes done in the editor were lost when using other element of the the UI.
For example : changing the tab containing the editor component to another one.
To avoid loosing the changes made by the user in those cases, we force an urgent commit change
in the `onWillUnmount` hook.
task-3530998
closesodoo/odoo#137716closesodoo/odoo#139959
X-original-commit: b2c3775ea01bfdb8e0dd40b3b8e57534c1785116
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Geelen Sébastien (sge) <sge@odoo.com>
*: account, hr_recruitment, project, lunch, mrp
By removing the absolute positioning on ".o_favorite" inside kanban
views, we allow it to align naturally with the rest of the elements,
thus removing the custom code that was needed for padding.
By doing so however the icon - which is now only visible on hovering the
card in the Project's kanban view - should remain visible at all times.
The behaviour would be the same as in other kanban views: an outlined
star when not active and a full yellow star when it is.
The margin on the kanban heading in the Manufacturing orders has been
removed to realign the top elements.
task-3462098
closesodoo/odoo#131559
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
The clickbot test fails after October because of a hard coded month. It
needs to be refactored but let's skip it in emergency.
closesodoo/odoo#140641
X-original-commit: f9ec63dc3d865a24ec7da3f9389ce6b46fb66a83
Related: odoo/enterprise#49990
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Steps to reproduce:
- Configure a payment provider (e.g. Stripe)
- Go to the portal account of an user (e.g. Marc Demo)
- Click on "Manage payment methods"
- Save a payment method to create a payment token
- /!\ Go back to payment provider configuration and make a typo in the credentials
(This will be needed later to trigger a payment transaction error)
- Go to Accounting and create an invoice for Marc Demo
- Confirm the invoice
- Register payment:
* Payment Method: Stripe
* Saved payment token: [payment token of Marc Demo]
- Create payment
[1st issue]
The payment transaction fails (as the credentials are incorrect),
but no information about it appears on the invoice.
[2nd issue]
It is not possible to register another payment (with the payment provider) because
there is an unique constraint on the reference field of "payment.transaction" model
and each attempt of registering a payment uses the same reference.
Solution:
[1st issue]
Link invoice to payment transaction.
Messages related to payment transaction will be logged on the invoice automatically.
[2nd issue]
Generate reference with "_compute_reference" method instead of always using the same one.
opw-3499200
closesodoo/odoo#140533
X-original-commit: 8c98efe036972c43a95c28509e91c356ddc84084
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: Anh Thao Pham (pta) <pta@odoo.com>
It adds advanced data on the picking view.
It's not needed by default so we hide it
closesodoo/odoo#140577
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
A traceback is generated if config currencies are none. This is because we are trying to access the 0 index which does not exist in a None object.
Steps to reproduce:
1. Go to studio.
2. Click on reports.
3. Search for sale details.
4. Click on sale details report.
Current Behavior:
As we click on the sales details report, a traceback pops up.
Expected Behavior:
There should be no traceback and the report editor should open smoothly if nothing wrong.
Note:
We also remove Timezone information from the start_date to match the
format of the date when it's provided by the user.
e.g. : "23/05/2024 08:25:34" instead of "23/05/2024 08:25:34 TZInfo"
OPW-3501650
closesodoo/odoo#140575
X-original-commit: c816f47eaabcb2aedce91887287f34ac8f16320a
Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>
Signed-off-by: Robin Engels (roen) <roen@odoo.com>
`''.join` would strip the `Markup` out, so the markup would appear
literally in the result instead of being interpreted as HTML.
Also switch to using dict-style formatting, it's a touch clearer (and
shorter) for this case, since `e` is already a dict (hopefully).
closesodoo/odoo#140496
X-original-commit: 4d88e1df4deb5f1aab23ca117f6b6261babec3f7
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Currently, although the journals are filtered to only show purchase journals,
there is no constraint preventing users creating a new journal of any
other type. This commit adds a constraint.
closesodoo/odoo#140458
X-original-commit: 014435f09cabbf0b21f3f9809eb1e0f13d35661a
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Aliya Tastemirova (alta) <alta@odoo.com>
Main changes:
Change the style and postion of the Put In Pack Button on the
stock.picking form view
Before:
Button is aligned on the left and has the style primary
After:
Button is aligned on the right and has the style secondary
closesodoo/odoo#140430
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Steps to reproduce:
1. Install Inventory app.
2. Enable "Storage Locations" in Inventory settings.
3. Create a new product known as "X". Set it's tracking to "By Unique Serial Number".
4. In Inventory -> Configuration -> Operation Types -> Receipts, set "Use Existing Ones" to true.
5. Create a new Receipt, add a new line of product X.
6. In the "Details" page of the X line, click "Import Serials/Lots".
7. Enter at least two lines of two serial numbers and import.
Bug:
Notice that the "Lot/Serial Number" column on each row are blank.
This is happening because the view used for stock move lines here will
display either the lot_id field of a sml, or the lot_name field,
based on varying conditions. In this case, setting "Use Existing Ones"
to true will cause the lot_id field to be displayed (and the lot_name
field to be invisible). When importing lots, only the lot_name is set
with the user's input but the lot_id is left blank. So because lot_id
is empty, the column is empty. But this works as expected
when "Use Existing Ones" is false because it displays the correctly
set lot_name. When the receipt is validated,
the lot is created and lot_id for each of the smls is set,
so now it displays properly.
Fix:
when "Use Existing Ones" is set first check if lot exists and set it in
that case, otherwise create and set a new lot at that moment
opw-3498812
closesodoo/odoo#140400
X-original-commit: c5a35a1c2a7e16adbd3f2b1e37509003bcfac957
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
Before this commit, the "OdooBot has a request" notification in the
Messaging Menu -- which suggest to enable push notifications -- had
a muted style, which looks as if the item is unimportant and was
read by the current user.
This is an important notification, at an equivalent level of
importance than needaction notifications. This was already
highlighted by this item contributing to the global Messaging Menu
counter.
This commit fixes the issue by not muting this notification. To do
so, it enhances prop `muted` on `NotificationItem` component:
- 0 (default): the notif is unmuted
- 1: the notif is slightly muted
- 2: the notif is hard-muted
0/1 are equivalent to the different muted style of notification in
16.4, while `muted: 2` shows a hard-muted notification when the user
choose to manually mute a channel, as to not receive any notification
from it.
Some logic related to "mark as read"/"counter" logic has been moved
to this muted prop concern, as not all notification that have mark
as read or a counter necessarily must be muted, e.g. with "OdooBot
has a request".
Task-3566799
closesodoo/odoo#140380
X-original-commit: c60fdbb25b38899ceeb89e76abc35c3474ce1f5b
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
In this commit we hide the printing errors in `pos_self_order`.
At the moment, they are show to the user, but that is not
desirable behavior in a kiosk environment.
Such printing errors might, for example, be encountered when the printer
is out of paper.
closesodoo/odoo#140271
Signed-off-by: David Monnom (moda) <moda@odoo.com>
This will help the upgrade process. Currently, there is an harcoded[^1]
inherit tree stored in the upgrade source. By storing this information
in the databases, we:
- avoid this hardcoded list.
- support more than the standard modules.
task-3504720
[^1]: hardcoded, but autogenerated.
closesodoo/odoo#140261
Signed-off-by: Raphael Collet <rco@odoo.com>
This commit fixes:
- hide `read_duration` and `expected_duration` in MO list view.
- hide `component availability` byt default in bom overview,
unless if coming from mrp forecast.
task-3547356
closesodoo/odoo#140244
Related: odoo/enterprise#49802
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
This commit fixes an issue where the interior of the arrow of the
disabled `o_arrow_button` was darker on hover
task-3573542
closesodoo/odoo#140122
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Before this commit:
Channel was not getting unpinned after being deleted
After this commit:
- Channel gets unpinned for all the channel members after being deleted
- If a user leaves channel/group then all of the messages of that channel/group
are removed from the user's history/starred/inbox channel.
Task-2814440
closesodoo/odoo#139972
X-original-commit: 4767d6001d15628768388bcac98c04ab185040c8
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Steps to reproduce the bug:
- In Website edit mode, drag and drop an "Images Wall" snippet onto the
page.
- Click on the first image of this snippet.
- In the "Animation" options of the image, select "On Hover".
- Save the page.
- Click on the first image of the "Images Wall" snippet.
- Bug: The image in the slideshow still has the overlay that appeared
due to the hover effect.
This commit fixes this issue by resetting images to their original
source in the slideshow.
task-3562305
closesodoo/odoo#139695
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
This PR improves the overall design of all the views in the Frontend
side of the module Event.
The design was outdated and was not consistent between the different
pages.
List of changes:
- events: cleaning of scss, filters consistency and responsive
(with off-canvas).
- submenu: design and responsive behavior (dropdown)
- registration page : overall design and the ticket list is inside a
modal, to help with cases like having a lot of tickets. To be improved,
on a separate page instead of a modal.
- talks and agenda: design, cleaning of scss, filters consistency and
responsive (with off-canvas).
- sponsor template: minor design modification
- exhibitors: design, cleaning of scss, filters consistency and responsive
(with off-canvas).
- location: minor design modification to be consistent with others pages,
but need improvement in the near future.
- meet: design, cleaning of scss
- booth selection: overall design
task-3083658
closesodoo/odoo#137729
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Prior to this commit, the button with the search icon, inside the search
bar, was `primary, which is not consistent with the filters that are
`light`.
Part-of: odoo/odoo#137729
This commit improves the overall design of all the views in the Frontend
side of the module Event.
The design was outdated and was not consistent between the different
pages.
task-3083658
List of changes:
- events: cleaning of scss, filters consistency and responsive
(with off-canvas).
- submenu: design and responsive behavior (dropdown)
- registration page : overall design and the ticket list is inside a
modal, to help with cases like having a lot of tickets. To be improved,
on a separate page instead of a modal.
- talks and agenda: design, cleaning of scss, filters consistency and
responsive (with off-canvas).
- sponsor template: minor design modification
- exhibitors: design, cleaning of scss, filters consistency and responsive
(with off-canvas).
- location: minor design modification to be consistent with others pages,
but need improvement in the near future.
- meet: design, cleaning of scss
- booth selection: overall design
Part-of: odoo/odoo#137729
If one edits an input value in a dialog and click on the dialog header,
the blur event is prevented because the dialog is draggable and the
pointer down native behaviour is prevented by the draggable hook builder.
This can cause data losses or the dialog content to not be render correctly.
For instance, this happens with the debug input of the domain selector
dialog.
We fix that by triggering the blur event programatically.
closesodoo/odoo#140436
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
- using a string to join `Markup`s is useless, that just strips out
the `Markup`
- the entire toplevel `Markup` can be formatted in one shot
closesodoo/odoo#140428
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Prior to this commit, the content of the payment summary did not include
line breaks when the text was too long, creating layout issue.
To fix that, this commit adapts the font size and forces the text to
break.
task-3576830
closesodoo/odoo#140423
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
The express checkout form template could not be rendered when no payment
provider supporting express checkout was passed.
closesodoo/odoo#140415
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Steps:
- Install `website_sale`
- Enable `On-site payment & picking`
- Set 200$ for on-site picking fees
- Go to /shop
- Put a product in the cart and go to checkout
If you click in the element box containing on-site picking it will compute
the delivery fees, but if you select it with the radio button it will not.
closesodoo/odoo#140376
X-original-commit: 3d81439f7ded68a2002a8585da63c6d72a7b65ca
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>
The live chat relies on `session.origin` to send its requests to
the server when its embed in an external page. `web.base.url` is
only set when a user authenticates and is wrong when no user
connected yet. Since `session.origin` uses the value of `web.base.url`,
a crash occurs when opening the website with live chat enabled on a
fresh instance of odoo. This commit removes the use of `session.origin`
in the frontend code since it is useless anyway. The `url` function
is used to format URLs since it either happens `session.origin` if
available or `location.origin` otherwise.
Steps to reproduce:
- Create a new odoo database with website_livechat installed
- Go to the log in page
- A crash occurs
closesodoo/odoo#140156
X-original-commit: 62e266e
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
In views with a searchbar, we want the filters to be displayed
directly when they are activated, without waiting for the view to
be reloaded. This is to provide a direct feedback to the user.
Before this commit, this didn't work in grouped kanban view with
progressbar. The regression has been introduced by [1] which moves
the progressbar logic out of the model. With [1], the rendering of
the KanbanController waits for the progressbar data to be loaded
in onWillUpdateProps, thus delaying the rendering coming from the
WithSearch when a filter is toggled.
This commit applies the same logic as for the model: we do not wait
for the loading promise in onWillUpdateProps. That way, the
rendering coming from WithSearch is synchronous, but a reload is
initiated and another rendering will be scheduled by the Controller
itself when the data will be loaded.
This commit also adds a test for the model case, as it appears that
this wasn't tested.
[1] 58ca40b032closesodoo/odoo#139967
X-original-commit: 47cf6e326f5a795984bac2138b169503c3dd099c
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
Before this PR, newly created direct message would be added at the bottom of the
list instead of the top.
This PR fix the issues by sorting the direct messages when creating a new direct
message channel.
Task-3566728
closesodoo/odoo#139960
X-original-commit: 60cf880102615a524f2fa89c71be7f1b08d931d1
Signed-off-by: Didier Debondt (did) <did@odoo.com>
Steps to reproduce:
- Enable Storage locations
- Add two lots in stock:
- lot_shelf_2 in WH/Stock/Shelf 2
- lot_shelf_1 in WH/Stock/Shelf 1
- Enable the 'Closest Location' removal strategy on its product category
- Create a delivery using this product and mark it as todo
Issue:
lot_shelf_2 will be selected even though it should take the one from
Shelf 1.
When filtering on the location, we need to filter on the location name
instead of this is.
Also, when creating a new quant on a product using the 'closest'
location, the filter will create a traceback because it will try to
filter on a NewId.
closesodoo/odoo#140175
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Steps to reproduce:
- Enable product expiry
- Add two lots in stock:
- lot_1 expired in 5 days
- lot_2 expired in 2 days
- Enable the 'First Expiry First Out' removal strategy on its product
category
- Create a delivery using this product and mark is as todo
Issue:
lot_1 will be selected even though it will expire later.
Following 2151a34, _gather() can now use `self` to filter on itself
instead of performing a search() to save some time.
Problem is, no sort_key was defined for 'fefo' strategy.
Part-of: odoo/odoo#140175
[Context]
Sales Order can be connected to projects. Before this commit archived projects
were counted in the stat-button, but not in the related to stat-button project kanban view.
We want to show archived (i.e. "non active") projects in both.
[Reproduce behaviour before this commit]:
- run odoo 15 with: sale_management,project,timesheet_grid
- In Project, create:
- project A
- project B
- In Sales/Products/Products, create:
- product A (set: type="Service", Create on Order="Task", project="project A")
- product B (set: type="Service", Create on Order="Task", project="project B")
- In Salse/Orders/Quotations:
- Create Quotation
- add "product A" and "product B"
- save & Confirm
- OBSERVE: stat-button "projects" shows 2 projects
- Click on: stat-button "projects"
- OBSERVE: kanban view shows 2 projects
- Archive one of project
- go Project/"Project A"/Edit/Action/Archive (require debug mode)
- Go back to created Quotation
- OBSERVE (Desired): stat-button "projects" shows 2 projects
- Click on: stat-button "projects" and OBSERVE
- OBSERVE (Not-Desired): kanban view shows 1 projects (it excluded archived one)
[Fix]
Modified domain in the function/action related to the stat-button.
opw-3500711
closesodoo/odoo#140364
X-original-commit: eef4506f32f09dcda9990556e55131bc17855dcc
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Fixes 2 use cases:
- barcode redirect after picking is validated (should return to menu
instead of refreshing the validated picking). Issue was due to missing
renaming of "on_close" to "onClose" after refactor occured
- ensure the auto-print action during MO validation always has a context
because the "Shop Floor/MES" expects any returned actions from
validation to always have a context to add the extra context parameter
of "skip_redirection" to it
closesodoo/odoo#140352
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
The lot and product label wizards were refactored to have diff
variables, so the auto-printing parameters need to be updated to match
Part-of: odoo/odoo#140352
Before this commit:
On creating link in debug mode produces prop validation error, and link
dialog doesnot appear
After this commit:
Now the issue is resolved and link dailog appers.
task-3571940
closesodoo/odoo#140178
X-original-commit: 8519cbab2e22506b12a1d93066c2c4fd87e753fe
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Sanjay Sharma (shsa) <shsa@odoo.com>
Prior to this commit, when you removed a social link in the header,
there was an error.
This is because `website.header_social_links_no_color` targets selectors
that do not exist in this situation.
task-3572219
closesodoo/odoo#139883
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit, the avatar next to composer in Discuss app
had the top aligned with the top of the text input of composer.
The avatar is smaller than the input, and the text in the input
is centered, so the alignment looks off.
This commit fixes the issue by offseting the avatar so that
when the composer has only 1 line, the avatar is vertically centered
with the input.
Note that this alignment should be fixed, i.e. if the input field has
more than 1 line, we want to keep the avatar in the same place, hence
why the avatar is just statically offset.
Also align composer avatar with message list, by removing the
`align-justify: self` that was moving avatar slightly towards the
discuss app sidebar.
closesodoo/odoo#140398
X-original-commit: 5fe4297f3d1a988ae65617c177046a223bc62890
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Prior to this commit, the Request for Quotations (RFQ) dashboard suffered
from a visibility issue. Specifically, the values displayed on the right
section of the dashboard were using a background color class that was not
correctly used leading to poor differentiation between the values and
their corresponding labels/titles.
This commit apply the correct background colors to these elements.
task-3573792
closesodoo/odoo#140395
X-original-commit: c46970dc773f8985acdb0d07ce9faa5e7d204641
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Signed-off-by: Xavier Luyckx (xlu) <xlu@odoo.com>
Before this commit, messages in livechat from visitor POV show
2 emoji icons in the quick actions. This is confusing and comes
from 2 actions sharing this exact same icon: "Add a reaction"
and "View reactions".
This commit fixes the issue by reducing the number of quick message
actions to 2 for the embed live chat. In other contexts there's
"Reply-to" and "Mark as Favorite" in quick actions, so the
"View reactions" item is always in expand menu.
Note that this "dirty" fix come from 2 actions with same icon.
Eventually we should fix that by clearly making icons unique.
This solution is decent for the time being, giving us more time
to make a dedicate icon for one of the emoji actions.
task-3498446
closesodoo/odoo#140335
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
There is an exact case where having a grid mode block inside a mega menu
item will fully bug: all elements will be on top of each other.
In order to reach this case, you need to:
- Create a mega menu
- Make the block inside this mega menu use grid mode
- Find a screen size where this mega menu will be part of the extra menu
items (hidden in the `+` entry)
- BUT the screen size should not toggle the mobile view
Point of attention when trying to replicate the issue:
When you enable grid mode, the result will depend on the available size.
So be sure to not enable the grid mode on a megamenu which is already
hidden in the extra items when you are in edit mode, in such a case,
there is no bug.
This commit simply disables the grid mode in such a case, it will thus
behave like the grid mode in mobile view and therefore be responsive
(disabled in mobile).
opw-3547405
closesodoo/odoo#139956
X-original-commit: fb209432049d9874308a2bdc3c9d2baa210ccced
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Step to reproduce:
- Create a pos session
- Create a new order
- Process the payment (the syncing has to be long to notice the issue)
Issue:
You can still click on buttons in the interface payment screen and
trigger tracebacks
Cause:
The ui is not blocked while syncing orders
Solution:
Block the ui while syncing orders
closesodoo/odoo#140342
X-original-commit: 61dd356e48e7d0bfe1c8758c3835b858e2aa8de0
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: fja-odoo <fja@odoo.com>
Youssef Bashandy