Commit Graph
115303 Commits
Author SHA1 Message Date
Aaron Bohy 3dd93ed129 [FIX] base: settings view: don't patch jQuery
especially to alter the behavior of a standard function to make it
behave like a function that is already available (defined in our
extension of jQuery).
2018-03-15 16:55:53 +01:00
Martin Trigaux dc7b2dff02 [FIX] crm: partial backport of 78b7996d
It appears there is more partners withotu a create_date than I expected on
legacy databases

opw-1827099
2018-03-15 16:37:02 +01:00
Yannick Tivisse 206209a461 [IMP] l10n_be_hr_payroll: Add name on views to allow inheritance 2018-03-15 16:03:01 +01:00
Martin Trigaux 850d0a79b7 [I18N] product: followup of 192dc39ef7
Was stating in 192dc39ef7 that 'Public Pricelist' was already present but it
was actually 'Public Price'
So term was missing.

Still related to #23686
2018-03-15 15:47:35 +01:00
Martin Trigaux 192dc39ef7 [FIX] product: remove wrong reference to pricelist
The pricelist `list0` is name 'Public Pricelist' and is already present in the
product.pot file.
USD is the renamed name after installing website_sale

Closes #23686
2018-03-15 15:16:42 +01:00
Lucas Perais (lpe) 61216f116a [FIX] web: add many records in m2m list
Have a model with a m2m (field A)
  this m2m has also a m2m (and displayed as m2m tags in the view) (field AA)
Have a domain on field A, to trigger the search view selection
Click on add an item
Select everything in the modal, making sure that there is more than 40 records

Click on Select

Before this commit:
There was a traceback indicating the local data did not contain records >= 40
This was because the internal data repository was constrained by a limit

After this commit:
We adapt the limit of the local data repository and there is not traceback

OPW 1823400
2018-03-15 15:11:08 +01:00
Raphael Collet f31516566e [FIX] base: validate domain of field used in view
When a field has a domain like `"[('foo', '=', bar)]"` and is in a view, check
that `bar` is in the view as well.  Note that the check should only occurs in
editable views (form or editable list) and when the field itself is editable.

OPW 1820269
2018-03-15 14:16:38 +01:00
Nicolas Martinelli 65214c01b5 [FIX] mrp: BOM count on product
- Create a Product A with attribute color and attribute values white and
  black.
- Create 3 products (Components 1, 2 and 3)
- Create a BOM for A like:
  Component 1, Variant column is empty
  Component 2, Variant white
  Component 3, Variant black
- Go to Inventory > Master Data > Product Variants, and open one of the
  2 variants of Product A

The BOM count is zero, while it should be 1.

The current implementation of `bom_count` doesn't take into account
attributes that can be set on the BOM line.

opw-1814973
2018-03-15 13:35:54 +01:00
Nicolas Martinelli 8f9770f076 [FIX] product_extended: "Compute from BOM"
Display the 'Compute from BOM' button on the simplified view of
`product.product`, alongside the 'Cost' price.

opw-1814973
2018-03-15 13:35:54 +01:00
Nicolas Martinelli 7e724f96c5 [FIX] product: display Cost price of product
The 'Cost' price should be displayed in the main form view of
`product.product`, not only the simplified view.

The reason is that the field `product_variant_count` has the same value
for the product and the template, therefore it cannot be used to make
the distinction between the two models.

To do so, we need to reintroduce the `is_product_variant` field to make
the distinction between `product.product` and `product.template`.

opw-1814973
2018-03-15 13:35:54 +01:00
Nicolas Martinelli 56749cf098 [FIX] product_extended: compute price
Remove the limitation introduced in 6feefe4d10, since the
`standard_price` field is now available on `product.product`.

opw-1814973
2018-03-15 13:35:54 +01:00
Jeremy Kersten 1cd63d8190 [FIX] website_sale: dont show variant option when not active
Before this commit, a user that ccick 'Customize' on th eproduct page
see the 'List View of Variants' aven if option 'Variants' in settings
was disabled.

Now we hide this view if the group for variants is not enabled in the settings.

This commit closes #23398

That means that a user that enable the view while the variants was enable,
need to disable the view before disable the variants.
2018-03-15 12:35:24 +01:00
Raphael Collet 07a73ce27f [FIX] stock_account: standard price on average
Avoid the division by zero when the available quantity becomes zero.

OPW 1826912
2018-03-15 12:15:20 +01:00
Yannick Tivisse 0eb58775c9 [IMP] hr: Add a specific marital status 'Legal Cohabitant'
Purpose
=======

Currently both 'Married' and 'Legal Cohabitant' are considered as the same thing.

We should separate these 2 marital status to have a more accurate information.
2018-03-15 11:18:19 +01:00
Nicolas Martinelli 642466fa20 [FIX] stock: picking in mobile view
- Switch to mobile view
- Go to Inventory > Delivery Orders > Create
- Add an item, save & close
- Save the picking

Error: impossible to save because a mandatory field is not set.

The kanban view used in mobile should not contain the `date` field,
which is not included in the view `view_move_picking_form`. Otherwise, a
`date: false` value is sent to the server.

opw-1816837
2018-03-15 11:15:30 +01:00
Jeremy Kersten 1227c8de28 [FIX] website_sale_comparison: fix comparison when 'list view variant' is enabled
Before this commit, when the user enable 'List View Variant' from the
customize menu, the add to compare failed.

This commit closes #23397
2018-03-15 11:13:11 +01:00
Jeremy Kersten 076b87134d [FIX] website_sale_wishlist: fix wishlist when 'List view of variants' is activated
When the view 'List view of variants' is enabled from the customize menu,
wishlist was broken and return traceback because product_id was null

This commit closes #23395
2018-03-15 11:13:11 +01:00
Jeremy Kersten 45c270ddd2 [FIX] website_sale_comparison: remove from compare queue when delete from list view
Before this commit, when you was comparing several products (/shop/compare?products=x,y,z)
when you had clicked on 'delete product y' from the top, that was comparing x and z; but
your compare queue continue to be x,y,z.

Now we delete from the compare queue the product y.

This commit closes #23532
2018-03-15 11:13:11 +01:00
Jeremy Kersten df13de780f [FIX] sale: fa coherence in portal
Done label was a copy/past from cancel tag (bad icon, bad color)

This commit closes #23594
2018-03-15 11:13:11 +01:00
Nicolas Lempereur 87c09b8ebc [FIX] account: false complete_tax_set tax default
When setting a chart of account on a company, we have default taxes from
the default chart of account different from chosen one.

But if a chart of account is chosen, it should override them in the
onchange_chart_template_id function. This works as expected for a
truthy complete_tax_set chart of account template, but not for a falsy
complete_tax_set chart of account template.

The complete_tax_set indicates that we don't want to set default taxes
and the user should do it or modify the given tax rates himself.

opw-1824751
closes #23655
2018-03-15 09:52:13 +01:00
Nicolas Martinelli 7d52d6e89b [FIX] crm: create opportunity from kanban
- Create a customer, set an address
- Create an opportunity from the kanban view

The address fields are not filled in in the opportunity.

We add all fields filled in by `_onchange_partner_id_values`

Complement of commit e2bbee6df5

opw-1816438
2018-03-15 09:14:52 +01:00
ougc27 935b6d6aab [FIX] base_address_city: add missing placeholder
for city and city_id fields
To be consistent with the other fields

Closes #23662
2018-03-15 08:59:06 +01:00
Géry Debongnie 7287c672f5 [FIX] web: x2m: properly reset limit/offset to initial value
When we discard an element, we want to make sure that the new state is
not corrupted by previous user operations.  In our case, we possibly had
a limit and an offset values modified by the user.

This could lead to unpleasant situations, with incorrect data displayed
on the form view.

Note that this actually fixes a new bug introduced by commit
https://github.com/odoo/odoo/commit/e7fab234201e357da52c3576ad2e8fc9ceee9359
(this is the commit that introduces the tempLimitIncrement attribute)
2018-03-14 17:03:23 +01:00
Géry Debongnie 4586b876f2 [FIX] web: unselect current row before changing page
The issue here is quite simple.  If we are editing a multipage one2many
field, then we click on the pager, we need to properly unselect the
current row.

If we do not do that, then we can enter invalid data.  For example,
assume that there is a readonly field. We click on add, it creates a
(virtual) record with no value for that field.  When we click on the
pager, we select the next page, and bypass all validation.
2018-03-14 17:03:18 +01:00
Géry Debongnie 4fd9db52a2 [FIX] web: prevent issues with pager and x2m and limit
When we are in the process of adding a record, we do not want to update
the pager count.  The reason is that if the user is at the limit (so,
1-40/40, no pager visible), then click on add, there will be a pager
shown with 1-40/41.  Now, imagine that the record currently being added
as a required field, and the user clicks on the pager. In that case, we
need to discard the newly added record (bringing the total back to 40),
then move to next page, which does not exist anymore.

So, to fix this issue, we simply consider that a record being added
does not count, from the point of view of the pager.
2018-03-14 17:03:11 +01:00
Goffin Simon 8df915da05 [FIX] payment: Payment integration with Authorized.net making double transactions
When making a payment with authorize.net by clicking on "Pay Now" in the shop, it was
possible to send several transactions for the same SO because the button "Pay Now"
was enabled before being redirected.

opw:1819588
2018-03-14 14:50:14 +01:00
Simone Orsi d9235a8f14 [FIX] base: update docstring
set_* methods are deprecated (cf warning in code below)
should use set_values instead

Closes #21171
2018-03-14 14:27:58 +01:00
Nicolas Martinelli 19255ee260 [FIX] website_sale: image in carousel
- Create a product with 3 variants
- Put a picture on the template, then on all variants but the first one
  (the one with computed for field `product_variant_id`)
- Check "Multi image" setting in website config

In the product page of the eCommerce, the carousel is not displayed.

This is because the template only checks if the first variant has an
image in order to display the carousel. It should check all variants.

opw-1823242
2018-03-14 13:17:12 +01:00
Florent de Labarre 54942f0921 [FIX] product: prevent modifying variant attributes
On the product_normal_form_view
to be consistent with the product_variant_easy_edit_view view.
product.attribute.value values should not be modified from the product view but
using the variant configuration from the product

Consistent with what was wanted at a4d88c9efd

Closes #23298
2018-03-14 10:47:37 +01:00
Jeremy Kersten e449055189 [FIX] website_sale: disable link from pivot view for sale.report
Before this commit, linking was enable for pivot view of model sale.report.
User that click on a cell will be redirected on a default view list/form
with all fields.

Now linking is disabled.

If you want to open the sale order on click, you need to start with the
pivot view from model sale.order.

This commit closes #23445
2018-03-13 18:16:12 +01:00
Goffin Simon e68ab50a77 [FIX] payment_authorize: test_10_Authorize_form_render
Introduced by 669c23d58d

opw:1817597
2018-03-13 17:48:16 +01:00
Thibault Delavallée dab7368c43 [IMP] doc: improve wording of guidelines introduction
Purpose of this commit is to clean a bit the wording and to clarify how to
handle guidelines between stable and development versions.
2018-03-13 17:26:29 +01:00
Thibault Delavallée 820926f5ba [IMP] doc: improve guidelines related to Git and commit messages
Purpose of this commit is to explain with more details how to write commit
messages. Content of the Git section is also updated with last decisions
and conventions.
2018-03-13 17:26:29 +01:00
Nicolas Lempereur c2f910717a [FIX] portal: dynamic chatter not editable
60c920d4a should solve duplication of chatter when editing the website.

But portal module doesn't depends on website, so eg. on a instance with
just helpdesk (and no website) we would not see the chatter on the
frontend.

This fix reverts 60c920d4a and adds another solution not depending on
website.

opw-1813792
closes #23614
2018-03-13 15:41:59 +01:00
Goffin Simon 669c23d58d [FIX] payment, payment_authorize: company field in authorize.net
Steps to reproduce the bug:

-Just purchase a simple product using Authorize.net
-Click on "Pay Now" to be redirected to Authorize.net gateway

Bug: The company field added during checkout page was not filled.

opw:1817597
2018-03-13 15:02:51 +01:00
Lucas Perais (lpe) d4c8a7cfb4 [FIX] web: view dialog select among filtered entries
On an editable line with a many2one
Click to create a record
Click on create a record in the many2one
It opens the form view of the object in a modal, which has a many2many list, which choices are domainized
Click 'add an item' on this list
It should open a modal with the filtered choices
Click on any of the existing record

Before this commit:
There was a traceback in JS
That was because the event bubbled up to a parent, when it shouldn't

After this commit:
The whole flow unfolds without errors

OPW 1823205
2018-03-13 14:35:05 +01:00
Priyanka KakadiyaandMohammed Shekha 97fe1f0507 [FIX] web: FormView: handle string attribute on groups
Before this rev., this attribute was ignored for groups containing
sub groups.

Task 1786309
Closes #23514

Co-authored-by: Mohammed Shekha <msh@openerp.com>
2018-03-13 12:51:44 +01:00
Aaron Bohy c761ab2c5b [FIX] mail: redirect: prevent double-clicks
This rev. increases the wait interval of the redirect handler
called when a document is clicked in a mail thread (e.g. in the
'Inbox' in Discuss). This increases the protection against
double-clicks (preventing the document from being opened twice,
thus making twice the required RPCs, and from appearing twice in
the breadcrumbs).

A more robust solution (at the ActionManager level) will be
developed for saas-11.2 (where the ActionManager has been
refactored and is testable).
2018-03-13 12:51:44 +01:00
Aaron Bohy 7263424622 [FIX] web: Kanban: less tweak to prevent overflow
When the bottom left and right areas were taking to much space, the
right one overflowed the kanban card, because those two areas
weren't allowed to shrink. This might occur for example on the
sale.order view.
2018-03-13 12:51:44 +01:00
Aaron Bohy afbf90db00 [FIX] im_livechat: avatar size in operator kanban view
This rev. improves the layout of the inner kanban view for
operators in livechat channels, mainly by setting a max-width on
their avatar (with classname 'o_kanban_image').

The motivation of this commit comes from a feedback following an
internal migration.
2018-03-13 12:51:44 +01:00
Aaron Bohy 61f64c0166 [FIX] web_editor: FieldHTML: break long words
to prevent them from overflowing the form sheet.
2018-03-13 12:51:44 +01:00
Nicolas Lempereur 088e3d2fec [FIX] website_event_sale: pricelist show no discount
On the website when selling a ticket, a percentage discount may be
applied on the ticket price.

This percentage is calculated as:
  {event product price} - {event product price reduced} / {event product price}

So with a ticket price 20, a linked product priced 60 reduced to 30, we
would get a ticket price 10 on the website.

This commit hide the discounted price if the pricelist that is applied
was configured as "Discount included in the price".

opw-1807889
closes #23611
2018-03-13 12:24:58 +01:00
Christophe Simonis c921d94236 [MERGE] forward port branch saas-15 up to 3730a0d2df 2018-03-13 12:05:36 +01:00
Darshan Kalola 2b392636c4 [FIX] web_editor: rpc of 'many2one' snippet option
Before this commit, changing the value of a many2one field on the
frontend was not possible anymore since 11.0 because the RPC 'order'
parameter was not properly formatted with the new conventions.

See task-1767802
Closes https://github.com/odoo/odoo/pull/23545
2018-03-13 11:37:59 +01:00
Duc Dao 66c7e130d5 [FIX] base_setup: don't crash if template is empty
Before this commit:

* Activate debug mode.
* Go to general settings > Document Template.
* Change the Template selection to the empty value.
* Click on "Edit Header".

Result: Traceback.

This happens because we try to concatenate the value of the template
field to a string, and since it's empty (False) boolean and str can't be
implicitly concatenated, this of course raises an uncaught error.

After this commit:

* We check if a template has been selected before performing the
concatenation.

Closes #22736
Fixes #22622
2018-03-13 10:53:32 +01:00
Adrian Torres 84b6c46943 [FIX] registry, loading: re-init inherited SQL views
Before this commit:

* Install any module that creates a SQL view and another that extends
this view.
    e.g.: sale and pos_sale for `report.all.channels.sales`.

* Uninstall the module that extended the SQL view.
    e.g.: uninstall pos_sale.

* Try to access the view from the web client -> Traceback, table not
found.

This happens because when reloading the registry, postgres drops the sql
view and it must be re-initialized.

After this commit:

We solve this issue by calculating all missing tables/views during the
uninstallation process, and re-initializing all of them right before
reloading the registry.

Also remove sql-view hacks in the modules `sale` and `sale_margin`.

Fixes #23528, #23529, #23530
2018-03-13 09:41:43 +01:00
Goffin Simon 31a0bdec73 [FIX]stock: Default scheduled date in a stock.picking
When creating a stock.picking with the barcode, a default scheduled date
is required if you want to go further.

opw:1824629
2018-03-13 09:24:53 +01:00
Martin Trigaux bfffe17d37 [FIX] account: duplicated entry in pot file
Added at 57ff6a17b7 and 3715244a51
2018-03-13 08:47:15 +01:00
Christophe Simonis 3730a0d2df [MERGE] forward port branch saas-14 up to 0e898eae35 2018-03-12 18:48:15 +01:00
Christophe Simonis 0e898eae35 [MERGE] forward port branch 10.0 up to 0440e25380 2018-03-12 18:16:02 +01:00