Commit Graph
130534 Commits
Author SHA1 Message Date
RomainLibert 39ebe4094e [FIX] hr: fix button layout 2019-09-23 07:56:12 +00:00
Yannick Tivisse 285f2f9d47 [FIX] hr*: Grant user's rights to demo user for HR applications 2019-09-23 07:56:12 +00:00
Yannick Tivisse 1b21a9cf55 [FIX] hr_holidays: Reset leave type if employee changes actually 2019-09-23 07:56:12 +00:00
Yannick Tivisse 213b9bda7d [FIX] hr_holidays: Fix expected singleton issue 2019-09-23 07:56:12 +00:00
qsm-odoo fbae846daf [FIX] website_mass_mailing: adapt snippet options
The snippet options UI was not adapted to the new web_editor UI.

closes odoo/odoo#37250

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-09-23 09:30:01 +00:00
qsm-odoo 7b92e13533 [FIX] web_editor: fix section drag and drop error (2)
Forward-port of https://github.com/odoo/odoo/commit/6f14b488fb380c6a3f1b7361b9901de3f07fd9ea
was not properly done.
2019-09-23 09:00:45 +00:00
Josse Colpaert 83ce8859c8 [FIX] l10n_cn: states moved to base
closes odoo/odoo#37201

Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-09-20 09:14:23 +00:00
Odoo's Mergebot bfab398889 [MERGE] (mass_mailing_)sms: replace icons
Improve branding and icons quality.

TASK 2061424
PR #37243

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-23 11:42:15 +02:00
William Henrotin 070456169b [FIX] mrp: open stat buttons with proper id
On the workcenter form view, the stats button open some analytics but
the wrong worcenter id is given into context. it uses active_id but this
id refers to the first object of the breadcrum and so could be something else
than a workcenter.

closes odoo/odoo#37233

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-09-23 08:13:34 +00:00
Kevin Baptiste b354f017a0 [FIX] hr_recruitment: remove 'active' statbutton
Since the introduction of the ribbon widget, the boolean_button widget
does not exist anymore.

closes odoo/odoo#37232

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-09-23 07:33:24 +00:00
Martin Trigaux ade9341212 [IMP] website: do not use a default name for visitors
See 'Webiste Visitor (date)' as display name
Remove default value as a way to easily detect if somebody has already
a name or not

Note using the id in the display name is a bad (may not be set yet)
but is used knowlingly as a short way to differentiate 2 visitors.

Linked to task id: 2073714

closes odoo/odoo#37230

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-09-23 08:14:43 +00:00
Martin Trigaux 33dc3bd995 [REV] website: revert commit 5b9a81a2
Comparing on translated string does not work as two people in different language
won't get the same result in the name_get
2019-09-23 06:15:09 +00:00
sri-odoo 4be2cdf623 [REF] mass_mailing_sms: replace app icon 2019-09-22 09:33:17 +00:00
sri-odoo 6d76501345 [REF] sms: redesign mail thread icon 2019-09-22 09:33:17 +00:00
sri-odoo ec9eadc352 [REF] sms: replace mail/systray fail icon
Use SVG format to improve rendering in HiDPI display while keeping tiny
the file size.
2019-09-22 09:33:17 +00:00
sri-odoo 59498db811 [REF] sms: redesign composer button 2019-09-22 08:21:33 +00:00
Jinal Patel 59c90e9b1d [FIX] mail: pass context from schedule activity
Problem is that while creating Opportunity from schedule activity at the
bottom of the activity view, context was not applied.
For Example, CRM > Pipeline, while creating opportunity that will create
a lead because context was not applied.
In this commit, context should be applied.

task-2072491

closes odoo/odoo#37139

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-19 11:28:00 +00:00
wan efd97b7ea0 [IMP] account: review the hierarchy of account type selection
* Add an equity section inside the balance sheet
* Divide profit and loss into Expense and Income
* Reorder the Expense and Income types

closes odoo/odoo#36599

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-09-10 09:11:35 +00:00
wan f98f5fea0c [IMP] account: change the accrual wizard action name
The previous name (change period) was misleading and not really correct.
2019-09-10 08:33:07 +00:00
Geoffroy Larue 7294c377db [IMP] hr_timesheet: access logic
Fix various incoherences related to timesheets :

- Hide the progress field on the task form view if user hasn't
- timesheet user access.  Remove the possibility to link a new
   timesheet to a task belonging to a project not allowing timesheets.

Task-2066533

closes odoo/odoo#36475

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-09-19 09:26:27 +00:00
Kevin Baptiste c48648a7a5 [FIX] hr_org_chart: prevent line from appearing on transparent image
Before this commit, the tree line of the org chart was appearing under
images with a transparent background.

closes odoo/odoo#37212

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-09-20 14:36:32 +00:00
Odoo's Mergebot 2461caf620 [FIX] hw_drivers, point_of_sale: Fix receipts & keyboards
- In KeyboardUSBDriver, we use xlib to translate keysyms. The encoding
of returned chars is now utf-8. We don't need to treat special
characters differently anymore.

- Some receipts still had part of their backgrounds black.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#37168

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-09-23 10:55:41 +02:00
Antoine Prieels e8f041ac3d [FIX] point_of_sale: Black background receipts
Some receipts still had part of their backgrounds black.
2019-09-19 11:29:46 +00:00
Antoine Prieels d8a2cf04bd [FIX] hw_drivers: xlib encoding with keysyms
In KeyboardUSBDriver, we use xlib to translate keysyms. The encoding
of returned chars is now utf-8. We don't need to treat special
characters differently anymore.
2019-09-19 07:44:55 +00:00
Antoine Prieels 37bdade9a2 [IMP] hw_drivers: Add manufacturer on IoT Devices
Add the possibility to set a manufacturer on IoT Devices.

closes odoo/odoo#36748

Taskid: 2062227
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-09-19 06:01:08 +00:00
Odoo Translation Bot 974261f7e9 [I18N] Update translation terms from Transifex 2019-09-22 01:19:57 +02:00
David Beguin 7f485c8d10 [IMP] website, website_* : improve visitor kanban view
This commit review the design of the visitor kanban view.
There is now two style for kanban card.
Ungrouped : the card takes all the width of the screen. It's simulate a nice tree view.
Grouped : Same design as before. ('normal' kanban card)

Apply visitor kanban views redesign also in :
- website_livechat
- website_crm
- website_sms

Task ID: 2073714
PR #37081

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-20 09:40:26 +00:00
David Beguin 368c4be99b [IMP] website : remove is_connected filter by default in visitor views
In order to see all the visitors, we remove the is_connected filter.
So that a visitor that disconnect 2 sec ago can still be visible.
Anyway, there is a connection status in the views.

Task ID: 2073714
PR #37081
2019-09-20 08:55:38 +00:00
David Beguin 5b9a81a2c6 [IMP] website : increment visitor name to be identifiable
This commit aims to rename the visitor that has no lead and no res.partner
to 'Website Visitor #id'.
So that the visitors can be identified when, for example,
an operator talk with multiple visitors.

Task ID: 2073714
PR #37081
2019-09-20 08:55:38 +00:00
qmo-odoo 79bfdbf30c [MOV] mass_mailing_sms,link_tracker: Move convert_links_text to link_tracker
This method being needed in the new social app, it made sense to move it to
the link_tracker module to make it available for mass_mailing_sms and social
to avoid unnecessary duplicated code.

LINKS:

closes odoo/odoo#34973

Taskid: 2045210
Pr: 37143
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-20 14:44:57 +00:00
qmo-odoo 6c531b3afb [IMP] utm: Add header to utm.campaign form
This commit moves the header previously defined in mass_mailing
in preparation for the cta added in the social module.

Task ID: 2045210
PR: #36416
2019-09-20 14:44:56 +00:00
David Beguin 17e8402523 [IMP] website : store visitor timezone
In order to be able to send push notifications using recipients timezone,
the visitor timezone is now stored in DB.

The visitor timezone is only updated once, when found_visitor_timezone
cannot be found in localstorage. Once the timezone is updated,
found_visitor_timezone is added to localstorage.

Task ID : 1936643
PR #34973
2019-09-20 14:44:56 +00:00
Aurélien Warnon 08108486d5 [FIX] fix translations URL in translation.js
The URL given to load the translations had an extra '/'.
(/website//translations/xxx)

This caused a http redirection that failed for "Mixed Content" on https environments.
2019-09-20 13:34:53 +00:00
Aurélien Warnon 869a5b83a5 [IMP] web: add capability to disable records drag/drop on kanban views
This commit adds a recordsDraggable option on the kanban view that allows to completly disable
the drag and drop feature.

This is a preliminary work for the social 'Feeds' kanban where the user should not be able to drag and drop posts.
2019-09-20 12:12:09 +00:00
Lucas Lefèvre f783a1cc94 [FIX] hr_holidays: Don't reset leave manager only if manually changed
When changing an employee's parent_id, the leave_manager_id
should be updated to the new parent_id's user, UNLESS
leave_manager_id was changed manually.
i.e leave_manager_id != previous parent_id

closes odoo/odoo#37190

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-09-20 12:30:11 +00:00
Lucas Lefèvre 79228dd4d0 [FIX] hr_holidays: Call onchange parent_id
Currently, parent_id is defined on hr.employee. This field
as an onchange defined.

But the inherit of hr.employee.base in the leave module
adds an onchange('parent_id'). The onchange method is never
called because the onchange in hr.employee does not call super
(which it's not supposed to do because the parent model
does not have the parent_id field).

To fix the issue, parent_id and all its onchange methods
are now defined on hr.employee.base
2019-09-20 09:23:27 +00:00
Lucas Lefèvre fa172f2e4d [FIX] hr_holidays: Set leave manager if empty
Currently, when an employee's manager (parent_id) changes,
the leave manager (leave_manager_id) is set to the new manager
if it was not manually changed (leave_manager_id != parent_id.user_id).

Please, note that `parent_id` is an `hr.employee` while `leave_manager_id`
is a `res.users`. Hence if `leave_manager_id` is not set, we have
`leave_manager_id == False`.
Next time we change `parent_id` (employee with a user)
we have `False != parent_id.user_id` and the leave_manager_id
is not set.
2019-09-19 13:01:44 +00:00
qmo-odoo b16ce3f89e [IMP] mass_mailing_sms: add missing SMS information to UTM campaigns
This commit adds the concept of sms into the utm.campaign

  * Add "Send new sms" button to the cta
  * Add a SMS stat button
  * Add a sms page in the notebook

LINKS

Task ID 2074813 (FP request UTM refactor)

closes odoo/odoo#37185

Pr: #37185
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-20 14:22:06 +00:00
qmo-odoo af601da9be [IMP] utm, mass_mailing: clean utm.campaign model, form view and stat buttons
This commit cleans up the utm.campaign form view:

  * Don't display mailing related things if no mailings on the campaign or
    if the campaigns were not activated in mass_mailing settings;
  * Stat button for the mass mailings was wrong, it was displaying the number
    of mails instead of the number of mailings;
  * Remove unused global click ratio field all other fields/methods related
    to its computation;
  * Remove ab testing cta on campaign form;
  * Add groups on mailing related fields to avoid access errors;

LINKS

Task ID 2074813 (FP request UTM refactor)
PR: #37185
2019-09-20 14:21:25 +00:00
qmo-odoo ad98c63400 [IMP] utm: add header to utm.campaign form
Considering that mass_mailing, mass_mailing_sms and social all had their
own buttons to add in the header, the header previously defined in
mass_mailing had to be moved into the root utm form view.

Task ID 2074813 (FP request UTM refactor)
PR: #37185
2019-09-20 14:21:12 +00:00
qmo-odoo ecd93e6639 [IMP] link_tracker: add global click count on campaign
Having a global click ratio on the campaign was pointless considering the
nature of the social.app and its posts. Therefore, we decided to have a
global click count which gives a better idea of the popularity of the campaign
itself.

Task ID 2074813 (FP request UTM refactor)
PR: #37185
2019-09-20 14:19:36 +00:00
Debauche Stéphane 1692d1ff3e [FIX] mass_mailing: ease marketing automation inheritance
Purpose of this commit is to add an anchor in mass mailing view in order
to ease some marketing automation fixes.

Also reset the sms composer context when sending sms from an sms mailing
as it may create some issues when sending manually an sms from a marketing
activity (see enteprise). Indeed wrong participant is chosen.

Task ID 2073158 (marketing automation fixes)
PR #37185
PR odoo/enterprise#5693
2019-09-20 14:05:41 +00:00
ryv-odoo 114c2423b3 [FIX] mass mailing: fix some mailing form view glitches
In the email/sms marketing form (edition), only on debug mode, we can get
a js traceback (bootstrap tooltip can't be show for a invisible element,
the domain field in this case) when we change the recipient model from Mailing
List -> a other model -> Mailing List. We avoid the traceback by putting
invisible a parent div of the domain fields instead of the domain field
itself.

In the email/sms marketing form (edition), we can create a email/sms marketing
without any recipient model which cause a issue on the kanban view (blank
space). Also behind the scene the mass mailing contact model is used. To
clarify and fix the issue in kanban view, the recipient model is now required
in the form view.

In the email/sms marketing form (debug mode only), we can create a email/sms
marketing with "allow A/B testing" checked without a campaign marketing
(not logical), which lead to a traceback when the email are sent. To fix
this issue, we move the "Allow A/B testing" field in the group form called
"marketing" and when it is checked the campaign marketing field is mandatory.

Task ID 2058738 (mass mailing internal testing)
PR #37185
2019-09-20 14:05:41 +00:00
Thibault Delavallée 39f6cedcf3 [IMP] mass_mailing: use subject as rec name of mailings
As mailings are now using subject as naming field and name is now a technical
field used for utm source, let us use the subject as rec_name of the mailing
model.

LINKS

Task ID 2072130
PR: #36935
2019-09-20 14:05:41 +00:00
qmo-odoo 1c614e34dc [IMP] mass_mailing: hide name field on the mailing and always display subject
This commit hides the field "name" of the mailing.mailing model.

Instead of having both fields "name" and "subject" on the form, "name" will
only be visible in debug mode leaving only "subject" to be visible for other
users. Indeed name is a more technical field used to create and find UTM
source record back while subject is the real business field.

This change implies that the name will now be set by default in the create
method so that the UTMs keeps working as they were. The name will be
constructed as follow: "subject create_date".

If the admin decides to set the name himself, the name will not be set
by default. Field is set in debug mode to allow its edition.

In mass mailing sms subject field is made visible. The name field being only
visible in debug mode now, the subject field had to be made visible in the
mailing form of the mass_mailing_sms module.

LINKS

Task ID 2072130 (hide name on mass mailing)
PR: #36935
2019-09-20 14:05:41 +00:00
Thibault Delavallée 99585eacfb [FIX] website_slides: avoid computing access fields as sudo
As compute sudo is now the default values let us ensure fields controlling
actions and access are done using the current user, not admin.
2019-09-20 13:44:09 +00:00
Remy Voet 428da3d539 [FIX] sms: number is actually not really required
sms, in the form view of sms composer (mass composition) : we got a blocking
message when we validate the composer sms with records which doesn't have a
phone number.

However we generally explicitly handle void numbers: in composer in comment
mode there is an User Error, and mass mode has specific error code to put on
sms records telling number is void (and sms is in error, meaning it will not)
be sent.

As sms record is required notably for mass mailing traces and marketing
automation traces we have to keep sms records with void numbers. We therefore
remove the required attribute on sms record.

Task ID 2073016 (sms fixes)
PR #37185
2019-09-20 13:44:09 +00:00
ryv-odoo 7087e969ca [FIX] sms, mass_mailing : fix some glitches, perform YAB2B
Specifications

  * sms, in the form view of sms composer : the count of all record doesn't
    match the reality in a multi-company environment. The search_count was
    done is sudo, then records of other company was taken in account in the
    count. Fix by explicitly setting fields as computer_sudo=False;

  * mass_mailing, in the kanban view of mail marketing : A warning ribbon
    ("insufficient credit") appeared on the kanban item of mass mailing, but
    the message was for sms marketing views only. Change the attributes to be
    invisible for mail marketing;

  * mass_mailing, in the form view of mail mailing : Weird default domain
    filter ([0 = 1]) was display instead of an empty domain filter;

  * mass_mailing_sms, in the test sms wizard, remove a duplicate error message :
    When the number format was wrong a duplicate error message pop up. Fix by
    simplify the model and remove useless computed fields.

  * mass_mailing_sms, in the test sms wizard, rename the label "Number" to
    "Number(s)" to show that it can multiples ones.

Task ID 2073016 (sms fixes)
PR #37185
2019-09-20 13:44:09 +00:00
Thibault Delavallée 91705a2d7c [ADD] mass_mailing_event_track_sms: allow to perform SMS marketing on speakers
PURPOSE

Do like Mail Speakers, but with SMS, in a single "Contact" button.

SPECIFICATIONS

Specifications:
  * on event form view, rename "Mail Speakers" button to "Contact Speakers"
    and open a mixed for view on mailing.mailing allowing to choose the type
    of mailing;
  * send SMS to all speakers;
  * see https://drive.google.com/file/d/1-7iDaNJSZbdTW1PYMU2vWtfPHGJmN7SF/edit

FP "Testing Weekend nothing works" request

LINKS

Task ID 2075183 (sms on speakers)
PR #37185
2019-09-20 13:44:09 +00:00
Thibault Delavallée 2901da02e8 [ADD] mass_mailing_event_sms: allow to perform SMS marketing on attendees
PURPOSE

Do like Mail Attendees, but with SMS, in a single "Contact" button.

SPECIFICATIONS

Specifications:
  * on event form view, rename "Mail Attendees" button to "Contact Attendees"
    and open a mixed for view on mailing.mailing allowing to choose the type
    of mailing;
  * send SMS to all attendees;
  * see https://drive.google.com/file/d/1-7iDaNJSZbdTW1PYMU2vWtfPHGJmN7SF/edit

FP "Testing Weekend nothing works" request

LINKS

Task ID 2074848 (sms on attendees)
PR #37185
2019-09-20 13:44:09 +00:00