pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] hr_holidays: Set leave manager if empty

Browse Source 
Currently, when an employee's manager (parent_id) changes,
the leave manager (leave_manager_id) is set to the new manager
if it was not manually changed (leave_manager_id != parent_id.user_id).

Please, note that `parent_id` is an `hr.employee` while `leave_manager_id`
is a `res.users`. Hence if `leave_manager_id` is not set, we have
`leave_manager_id == False`.
Next time we change `parent_id` (employee with a user)
we have `False != parent_id.user_id` and the leave_manager_id
is not set.
This commit is contained in:
Lucas Lefèvre
2019-09-19 13:01:44 +00:00
parent b16ce3f89e
commit fa172f2e4d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/hr_holidays/models/hr_employee.py
+1 -1
View File
@@ -124,7 +124,7 @@ class HrEmployeeBase(models.AbstractModel):
super(HrEmployeeBase, self)._onchange_parent_id()
previous_manager = self._origin.parent_id.user_id
manager = self.parent_id.user_id
if manager and self.leave_manager_id == previous_manager:
if manager and self.leave_manager_id == previous_manager or not self.leave_manager_id:
self.leave_manager_id = manager
def _compute_show_leaves(self):