Commit Graph
116891 Commits
Author SHA1 Message Date
Nicolas Lempereur 388eff5b58 [FIX] web: load more with progressbar load more
Be in a grouped kanban view with progressbar with limit 10:

- records 1 to 10 are loaded on a column
- do "Load more..." on a column => records 11 up to 20 are loaded
- do "Load more..." 2nd time => records 11 up to 20 are loaded
- do "Load more..." 3rd time => records 11 up to 20 are loaded
- ...

While in reality it should be:
- do "Load more..." 2nd time => records 21 up to 30 are loaded
- do "Load more..." 3rd time => records 31 up to 40 are loaded
- ...

This was caused by the progressbar reloading the column's group. This
set the loadMoreOffset to 0 thus forgetting the current state.

Without the change, added tests failed with:

 records of column are loaded => actual: "1,2,2", expected: "1,2,3"

opw-1878359
closes #26628
2018-09-03 15:58:52 +02:00
Martin Trigaux 98665aca1c [FIX] transifex: actually escape strings containing a '
The report's template is wrong
should becomes

text:'The report\'s template is wrong'

but previous code had no effect
2018-09-03 15:03:09 +02:00
Goffin Simon bc913d9d2b [FIX] point_of_sale: Print receipt on Safari
As explained on stackoverflow with
https://stackoverflow.com/questions/23626998/safari-print-issue-with-javascript-window-print
There is an issue with javascript window.print() on Safari

Steps to reproduce the bug:
When clicking on button "Print receipt" in the point of sale, nothing happened.

opw:1858205
2018-09-03 13:23:21 +02:00
len-odoo b95b4035e4 [FIX] web: tab selects first many2one entry without triggering spurious create
Suppose you select a customer for a sale order.
You type the beginning of his name "think", and a name_search is triggered
which finds matching results, with first result "Think Big Systems".
There are three ways to select it: click, enter or tab.
Now there can be a warning set on this customer
("Bad client, only accept cash", or "good client, offer discount").
In that case, clicking on tab would trigger the onchange displaying the warning,
but it would also set floating to true, which means a dialog to create client
"think" would appear.
This happens if the onchange is delayed, and thus the call to reset the floating
state is triggered only after the focusout completed, instead of before.

Coauthored with @aab-odoo

opw 1866619
opw 1874475
2018-09-03 12:09:56 +02:00
Nicolas Martinelli 122f06b86e [FIX] l10n_th: withholding taxes
Withholding taxes should have a negative value.

opw-1865270
2018-09-03 12:05:30 +02:00
Nicolas Martinelli 5b89ca142d [FIX] purchase: vendor reference
In case no PO has a vendor reference, keep the value.
2018-09-03 11:57:49 +02:00
Goffin Simon d448849ba3 [FIX] delivery: Error message for unavailable delivery methods
With a fixed price delivery method, the error message was not displayed when
the address doesn't match.

Inspired from function base_on_rule_rate_shipment

The error message was not clear enough.

opw:1879204
2018-09-03 11:13:34 +02:00
Martin Trigaux 5700f960d4 [ADD] test_translation_import: new duplication test
To make sure what was corrected is tested
2018-09-03 11:02:56 +02:00
Martin Trigaux e656a350a6 [FIX] test_translation_import: correct test
Now that it is tested, actually correct it
2018-09-03 11:02:56 +02:00
Martin Trigaux a9cd97f58e [MOV] tests: move test to be executed
The test was in a folder not checked by the runbot
The test, as it, is actually failing and it will be corrected in the next commit
2018-09-03 11:02:55 +02:00
Martin Trigaux 1566c0ab3b [FIX] tools: avoid loading duplicated code translation
This commit fixes two bugs:

- a8469c45 was fixing the case where the first line was not 'code' but broke
  the usecase where a po started with code line

- Correct the usecase where a pot and po file do not have the same line of code
  by matching on res_id=0

This avoids to have a pot expecting a code message at line 42 and a translation
at line 43

Closes #26722
2018-09-03 11:02:43 +02:00
Nicolas Martinelli e6390a76a6 [FIX] purchase: overwrite vendor reference
Overwrite vendor reference only if there is a PO linked to the bill.
Otherwise, any addition of product will erase what the user just typed.

Closes #26734
2018-09-03 09:54:34 +02:00
Odoo Translation Bot d40145a42e [I18N] Update translation terms from Transifex 2018-09-02 04:09:57 +02:00
len-odoo a822d3ee41 [FIX] hr_timesheet: add float_time widget on float time field in pivot view
Since pivot views can use fancy widget attributes, we use one to display some
float time value (getting 8:30 instead of 8,5).

opw 1876445
2018-08-31 15:49:32 +02:00
len-odoo 8c1204954e [FIX] web: display values according to widgets in pivot view
The pivot view didn't take into account the widget set on the fields.
In particular this was a problem for float fields that store time values.
They are now displayed with float_time if declared as such in the view.

opw 1876445
2018-08-31 15:23:31 +02:00
Nicolas Martinelli 078c3ec492 [FIX] payment_authorize: remove incorrect fields
`firstName` and `lastName` should be filled in for Australia, but the
implementation is not correct since:
- it assumes that the name is first name + last name, which is not the
  case in all countries (e.g. France)
- it doesn't take into account that the name could be a company name

This reverts commit 26974d4e5f.
2018-08-31 13:37:25 +02:00
Nicolas Martinelli ce6400e098 [FIX] mass_mailing_event: event domain
- Create an event, add an attendee
- Click on the stat button 'Mail Attendees'

The domain is shown as 'Event', '?', [id].

This is because the domain selector widget doesn't support the `in`
operator. Supporting it is not trivial, since ultimately `field_utils`
cannot parse a list of ids for a Many2one. It's less intrusive to change
the domain, since a standard use of the method will simply contain a
single id.

opw-1878322
2018-08-31 13:15:40 +02:00
Gert Pellin 26974d4e5f [FIX] payment_authorize: add required fields for wespac Australia (#26709)
for the payment processor wespac there are required fields we do not send.

required:
•Card Number
•Expiration Date
•Amount
•First Name
•Last Name
•Address
•City
•State/Province**
•Zip Code (Postal Code/Postcode)**
•Country
•Email

** These fields are optional if the billing address is not in the U.S. or Canada. If the address is in the U.S. or Canada, the two-digit State/Province code must be provided, along with the Zip/Postal Code.
2018-08-31 11:29:38 +02:00
Magnus 4877030d64 [FIX] fatal error when trying to enable logrotate
4e5119c6e5 didn't account for
`tools.config['workers']` being `None` on windows, resulting in the
entire thing crashing when trying to execute `None > 1` in Python 3.

Fixes #26447
2018-08-30 16:20:10 +02:00
Christophe Simonis 0fd5c70940 [MERGE] forward port branch saas-15 up to 6b1b507deb 2018-08-30 15:56:03 +02:00
Nicolas Martinelli 39162d0ff0 [FIX] point_of_sale: multiple lot numbers
- Product tracked by lot:
  3 units of lot A
  2 units of lot B
- On the operation type 'PoS Order', only tick 'create new SN/LN'
- Make 2 PoS orders for 2 units.
- Close the PoS session.

The first picking (2 units of lot A) is done, but the second picking is
ready but not done.

The issue comes from the world famous error:
'Cannot set the done quantity from this stock move, work directly with
the move lines.'

We apply the same logic than in commit f0028bc837

opw-1878256
2018-08-30 15:23:04 +02:00
Nicolas Martinelli 2f87bb5169 [IMP] mrp, stock: make _set_quantity_done available in stock
The method is also useful in other modules, so make it available directly
in stock.
2018-08-30 15:23:04 +02:00
Aaron Bohy 68332a0177 [FIX] web: fix evaluation context of the domain selector
The domain was instantiated without being given any evaluation context.
As a result, the uid variable was not defined,
crashing the js if present in a user-defined filter.

opw 1866852
2018-08-30 14:55:06 +02:00
Florent de Labarre 1ece9412be [FIX] stock: avoid useless processing
Define variables `product_id` and `rounding` to avoid useless Python
processing when accessing the corresponding values.

Closes #23111
opw-1868447
2018-08-30 14:01:54 +02:00
Moises Lopez e68350fcb5 [FIX] project: iterate on a single task
Do not retrieve the attachment of all records
Performance impromevement when iterating on a large number of records

From #26446
2018-08-30 13:33:52 +02:00
Christophe Simonis 6b1b507deb [MERGE] forward port branch saas-14 up to ab8e27382f 2018-08-30 12:43:43 +02:00
Christophe Simonis ab8e27382f [MERGE] forward port branch 10.0 up to 09ad560660 2018-08-30 12:43:12 +02:00
Davor Bojkić - Bole 09ad560660 [ADD] base: add Kosovo to list of countries
According to discussion on jvOrsouw/Odoo11#1

Closes #20605
2018-08-30 11:58:05 +02:00
Christophe Simonis 50bd9376d7 [MERGE] forward port branch 10.0 up to 90ce4733ae 2018-08-30 11:10:22 +02:00
Nicolas Martinelli 052a5702c5 [FIX] purchase: keep vendor reference
Create a PO and assign any string to the Vendor Reference field. Confirm
and create an invoice.

The Vendor Reference field on the invoice is empty, while it is expected
to be filled in.

opw-1879379
2018-08-30 10:07:35 +02:00
Nicolas Martinelli 90ce4733ae [FIX] website_sale: add back compute_currency function from qweb template
Unless there is a a bug, do not remove a currency conversion.

This reverts commit 5028da3873.
2018-08-30 09:56:53 +02:00
Mitali Patel 5028da3873 [FIX] website_sale: removing compute_currency function from qweb template (#26606)
compute method called 2 times in t-esc case when monetary field has "from_currency ::
 1) value_to_html: compute method call when qweb monetary widget is return value as a html.
     see https://github.com/odoo/odoo/blob/10.0/odoo/addons/base/ir/ir_qweb/fields.py#L325
 2) compute_currency : compute_currency method is pass from controller into render engine and it is call the compute method.
So, we removed compute_currency method from qweb template in the t-esc with monetary widget.
2018-08-30 09:26:49 +02:00
Lucas Perais (lpe) e65c8826ef [FIX] sale_timesheet: timesheet cost with company on analytic account
FIXUP da2140b

The above commmit was half-right in the business logic, but overlooked that if a user is not
in the company of the project, it will crash.
This use case worked before that commit

While agreeing that a little more clear access right is needed
like for example be able to get the project_time_mode_id on the companies
that are in user.company_ids,
the aim of this present commit is to avoid regression

OPW 1878204
closes #26539
2018-08-30 09:21:02 +02:00
Lucas Perais (lpe) b8fe404eae [FIX] project: portal should see projects only when he has tasks
before this commit, on /my/tasks, in the filter dropdown, every project that had visibility = portal was displayed
regardless of whether the portal user was a follower or not

After this commit, we search project in a more clever manner

OPW 1878187
closes #26615
2018-08-30 09:17:23 +02:00
Goffin Simon 1962d17c4b [FIX] hr_attendance: White screen if employee is not set
When the user was not linked to an employee, the first screen of the Attendance app
(the check-in/out screen) stayed white.

opw:1880582
2018-08-30 09:12:34 +02:00
Nicolas Martinelli 93a586be7c [FIX] calendar: recurring events
Do not parse the rule with `rrulestr`, because converting back to string
will change the original rule.
2018-08-30 09:04:23 +02:00
Joren Van Onder a1802fa327 [FIX] point_of_sale: iface_print_auto doesn't require a POSBox
Auto-printing works with and without a POSBox. Skipping the print
screen only works with a POSBox.

Was possible in v10, small oversight of
80e89c7a11.

opw-1874390
2018-08-29 14:39:01 -07:00
Christophe Simonis 0b8ef693a0 [MERGE] forward port branch saas-15 up to 0dc8588c5b 2018-08-29 16:45:36 +02:00
Goffin Simon 7b87212ea8 [FIX] account: Wrong quantity in Invoices analysis
Steps to reproduce:

Create a customer invoice with 2 product A and refund 1 product A.
Display account.invoice.report for this custumer.

Bug:

The quantity should be 1 not 3.

Fine tuning of this commit: e890682656

opw:1868116
2018-08-29 16:29:34 +02:00
Lucas Perais (lpe) 4ba87e073d [FIX] mail: right user_ids when calling /mail/follow
On a SO, write a note to a user
The mail the user receives contains a follow button
Click on it

Before this commit, the link did not add the user as follower of the SO
this was because the wrong uid was passed to the function

After this commit, user is added as follower

OPW 1869849
closes #26634
2018-08-29 15:58:10 +02:00
Christophe Simonis 0dc8588c5b [MERGE] forward port branch saas-14 up to 2a515bc7cb 2018-08-29 14:43:54 +02:00
Toufik Benjaa b367625248 [FIX] sale_payment: create payment.token when needed
- Before this commit, a sale order that generate a subscription and paid
  by the form method do not create a payment.token.

  After this commit, we check if the sale order need a payment.token to
  be created, if so we set the correct transaction type.
2018-08-29 13:55:03 +02:00
Nicolas Martinelli b53b637745 [FIX] mrp: 'To Consume' in workorder
Hide the field since it is always set to zero.

opw-1869511
2018-08-29 13:38:51 +02:00
Christophe Simonis 2a515bc7cb [MERGE] forward port branch 10.0 up to 068f1cd302 2018-08-29 12:13:48 +02:00
Christophe Simonis 068f1cd302 [MERGE] forward port branch 9.0 up to 5f25b902e5 2018-08-29 12:12:01 +02:00
len-odoo 683ecab8dd [FIX] web: use an unused variable in mock server
Fine-tuning of commit:
https://github.com/odoo/odoo/commit/818c18e55d0718286ff5bf332186a10f4d7a58ef
which introduced a variable that it didn't use.

opw 1867049
2018-08-29 11:04:46 +02:00
Goffin Simon 6bc2be09f5 [FIX] stock: Description for receptions are not being shown in Delivery Slip
Steps to reproduce

- Create a product with a custom description for receptions

- Create a purchase order

- Open the resulting picking

Shown behavior

- Product name is shown, description for receptions isn't shown in the delivery slip report

PS: Same scenario with a sale order

opw:1879069
2018-08-29 10:07:53 +02:00
Martin Trigaux a8469c4590 [FIX] tools: handle code in po
The previous code, as explained at b505ba9e0a, was to avoid creating duplicated
code entries for the same source (as only one is considered).

In case of a po comment like
 #. openerp-web
 #: model:ir.ui.view,arch_db:base.ir_access_view_search
 #: code:addons/web/static/src/js/chrome/search_inputs.js:716
 #: code:addons/web/static/src/xml/base.xml:1125
 #, python-format

the condition was not triggered (trans_type is model), creating two code entries

Necessary in #26614 to fix #26553
2018-08-28 18:10:03 +02:00
Martin Trigaux fe9cd11ab5 [FIX] base: generate translations in po format
Instead of csv, it allows to benefit from some features of POFile class like
handeling the duplicated terms correctly

In #26553, generating the missing terms was creating a new translation for
base.xml with no translation (value=src), making a previously translated term
no longer translated.

Closes #26614
Fixes #26553
2018-08-28 18:09:36 +02:00
Martin Trigaux 0312c604f4 [FIX] hr_gamification: allow employees to grant each other badges
When creating a new wizard, the related field user_id = employee_id.user_id
forces a write on employee model

Make sure we actually have the same value (to avoid using the wizard to modify
employees) and use sudo to grant the badge.

In master, the field should not be stored
2018-08-28 17:32:56 +02:00