Commit Graph
131089 Commits
Author SHA1 Message Date
Jigar Vaghela 2cc2fca17a [FIX] l10n_in: Fix report query
this is removed in https://github.com/odoo/odoo/commit/3936d655c4bfd845b6ead724cecdc8e7c62816eb#diff-10f4702f062a1eab9a272542d2914710L231
but need to group by parent tax_id if available

closes odoo/odoo#38094

X-original-commit: 79ea0b379c87103c6b9167f53722f195b444b0fb
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-10-07 13:13:44 +00:00
Goaman 52ec2d378c [FIX] web_editor: highlight selected pictogram
Before this commit, the selection of a pictogram in the media
dialog of the website builder and the mass_mailing was not
working.

The pictogram already has the class "o_we_attachment_selected"
upon selection. This commit allow the class "font-icons-icon"
to be included in an existing selector.

closes odoo/odoo#38085

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
2019-10-07 12:48:09 +00:00
Mathieu Duckerts-Antoine b919d438c7 [FIX] web: repair keyboard navigation in filter menu
Before this commit, invisible filters were rendered by
QWeb but hidden in the filter menu. This used to break
the keyboard navigation in the filter menu.
Now we don't render at all those filters since they were
completely useless anyway. This fixes the original
problem.

Task ID: 2057012

closes odoo/odoo#37567

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-10-01 08:32:14 +00:00
Swapnesh Shah 76e941cf84 [FIX] mail: Add required argument redirect
Fixes https://github.com/odoo/odoo/issues/38144
_login_redirect expects redirect

closes odoo/odoo#38145

Signed-off-by: Adrian Torres (adt) <adt@odoo.com>
2019-10-07 20:37:07 +00:00
Alexey Pelykh 41ccb00400 [IMP] sale_timesheet: provide hooks when billing a project
This commit restructures some code part in the "create SO
from project" wizard, in order to make this feature
extendable and adds new billable type or other checks.

Closes #31047

closes odoo/odoo#37796

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-10-07 15:32:10 +00:00
Alexey Pelykh 089755c1fa [REF] project_timesheet_holidays: provide hooks
This commit provides some hook to extend values when a leaves
generates timesheets. It also use dates directly, rather than
converting them to string.

Closes #30867
Closes #30872
2019-10-07 15:32:10 +00:00
Jairo Llopis 9a787b985e [FIX] website_sale: Instruct crawlers to not sort
Follows https://github.com/odoo/odoo/pull/35852. More useless crawls saved.

closes odoo/odoo#38114

X-original-commit: 42cbe36f6fff02b71d549caf77d92f776d615863
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-10-07 15:03:00 +00:00
fw-bot f248684c50 [FIX] web: Reset correctly the selection on reference fields
Backport of 64f6e50d0c, with a test!

Closes #27109

Purpose
=======

If the model on a reference fields is not modified from the interface
by the user but by the server, the selection is not correctly
recomputed on the interface.

Specification
=============

By calling super first on the '_reset' method, the new model
is taken into account when resetting the selection.

closes odoo/odoo#38109

X-original-commit: b5b992d9c4e85c224ded795ff9ce14d1608b3ed6
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-10-07 14:52:38 +00:00
Ivan Yelizariev 236b8f120b [IMP] web: print js logs on warning in UI
It helps easily catch an error in headless tests

closes odoo/odoo#24792

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-10-07 11:37:34 +00:00
fw-bot 0b973f7461 [REF] mail: separate button rendering
original PR: https://github.com/odoo/odoo/pull/25801

closes odoo/odoo#38141

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2019-10-07 20:00:58 +00:00
Sébastien Theys cc0eb76726 [FIX] base: remove duplicate image_1920 field in partner view
Since the field was defined twice the view was not working properly.

Closes #37999

closes odoo/odoo#38108

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2019-10-07 14:43:27 +00:00
fw-bot 7b020ed318 [IMP] account: Invoice tax block is split into two pages
closes odoo/odoo#38102

X-original-commit: 724407453a8aba284c9b7edc46ec12c13b25d33d
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-10-07 13:56:26 +00:00
fw-bot 2083f8b0d8 [FIX] mail: filter void attachments when sending mail.mail
In some cases you may have a void attachment (datas being False) that you
try to send through the mail.mail send flow and this make crash the send
process. This commit fixes that behavior by filtering void attachments.

closes odoo/odoo#38098

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-10-07 14:07:11 +00:00
Florimond Husquinet (fhu) e21efb18d4 [FIX] sale, delivery: invoice status updated when adding note
-Create a sales order.
-Add product E-COM11 (invoicing policy "Delivered quantities").
-Add Delivery method "Normal Delivery Charges".
-Confirm Sale.
-Sale Order Invoice Status = "Nothing to Invoice" (OK).
-Now Open Sales Order again in Edit mode.
-Add Choose "Add a note" in the order line section and add a random note and
don't save yet.
-Check the "Invoice Status" in the "Other Information" tab.

Before this commit:

-The status of the invoice changed to "Fully Invoiced".
-If you save the invoice with the new note, the status changes to "To Invoice".

After this commit:

The status stays "Nothing to Invoice" in both cases.

closes odoo/odoo#38097

Opw: 2078581
X-original-commit: 86301d36fa7b0b6f7f524fff2623077c4366273a
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-07 13:37:32 +00:00
Laurent Smet bb53ee456d [FIX] account: Fix missing parenthesis in reversal wizard
closes odoo/odoo#38095

X-original-commit: 431d6058afe71efa6078cb5d18c547ee2a910484
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-10-07 13:14:02 +00:00
Laurent Smet a5dba54232 [FIX] account: Fix reversal with group of taxes
Reversing an invoice using a group of taxes leads to a traceback as the taxes
are not flattened explicitly.

X-original-commit: fb3b1697ed1b3fc411b42d0b6624e1907dd0824c
2019-10-07 13:14:01 +00:00
Denis Vermylen 0ea67467b1 [FIX] config: expand logfile argument
Previously, the argument

--logfile=~/logs/odoo.log

Would create the <cwd>/~/log/ directories with the odoo.log file in it,
which is typically not the behaviour one would expect.

closes odoo/odoo#37194

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-09-20 13:36:28 +00:00
Parth Choksi c73d5cb1d6 [FIX] *: removed activity exception filter from searchviews
*: account
   crm
   event
   fleet
   hr_expense
   hr_holidays
   hr_recruitment
   mail
   maintenance
   mrp
   note
   project
   purchase_requisition
   repair
   stock_landed_costs
   stock_picking_batch
   survey
   website_event_track

This commit is making sure that the exception activities filters are
only defined where it make sense (i.e. where the system can actually
create an exception activity).

We have therefore removed 'exception activities' filters where the
system won't be creating any.

Task-2056425

closes odoo/odoo#36027

Closes: #36027
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2019-10-07 12:31:01 +00:00
Parth Choksi b65d94c89a [FIX] *: ux improvements in activities
*: mrp
   product
   purchase
   stock

Renamed the 'activities_exception' filter to 'Warnings' and moved it
to the bottom of the filters, isolated by separators

Task-2056425
Closes: #36027
2019-10-07 12:30:22 +00:00
Florimond Husquinet (fhu) db1bef9166 [FIX] purchase: missing variant description in portal view of purchase order
- Set Joel Willis (the portal user) as a vendor.
- Create a purchase order and add a line with a variant product, such as the
conference chair (aluminium).
- Confirm the order.
- Then switch user to the portal user.
- In the portal view, go to the purchase orders and select the purchase order.

Before this commit:

the product line does not show the variant, only the base name of the product.

After this commit:

the product line now shows the vendor specific product name and product code.
To set this name and code, go to the Purchase tab of the product, and add a
line for the vendor in the Vendors table, or modify the existing line for
the vendor.

closes odoo/odoo#38082

Opw: 2076962
X-original-commit: c2f2169ab7574c49fa6b544299aab7214b1f4698
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-07 12:31:01 +00:00
Lucas Perais (lpe) 5fe83fc6a4 [FIX] web: dropdown boundary overflow
Open a search view modal ("search more" on a m2o)
Select a filter that will make records fall to zero
The modal will shrink
Trigger the opening of a dropdown (Filters), and make sure
that there are many many menu items there (many filters)

Before this commit, the dropdown was bigger than the modal
which had a scroll bar,
however, the dropdown itself was not scrollable properly
So, clicking in it to select a menu item will fail when scrolled
all the way down, because elements did not actually followed the scroll

After this commit, the dropdown follows the scroll, and it is possible
to use it even way down

We use a behavior of bootstrap 4 itself:
FIX: https://github.com/twbs/bootstrap/pull/24976
ISSUE: https://github.com/twbs/bootstrap/issues/24251

OPW 2076337

closes odoo/odoo#38080

X-original-commit: c3273b7a1c0c09aeef23df4ba4be8d68fd46a6f3
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2019-10-07 12:27:03 +00:00
fw-botandRomainLibert 82b24f3c77 [FIX] hr_holidays: improve action_draft and action_refuse
This is a manual forward port of #28226

Closes #28226

closes odoo/odoo#38075

Signed-off-by: Romain Libert (rli) <rli@odoo.com>
Co-authored-by: RomainLibert<rli@odoo.com>
2019-10-07 12:11:34 +00:00
fw-bot a9adfbaa18 [FIX] pos_restaurant: faulty behavior of newly created table
When a table is created, the new table appears to be selected but the
capability to resize and drag is not active. As a result, when this new
table is dragged, it is unselected instead. This is because of the call
of `save_changes`. The table widget is rendered but the event handlers
for resizing and dragging are not assigned. After this commit, the
created table can be resized and dragged immediately after creation.

closes odoo/odoo#38068

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-07 11:47:26 +00:00
Romain Estievenart b5bc4dd46a [IMP] mail: wrong image size on mail preview on mobile
Before this commit, the displayed images with 'o_mail_preview_image'
class were not correctly displayed (some icon were distorted).

Note that this is a minor issue that was already present on older versions.

closes odoo/odoo#37161

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-10-07 12:38:55 +00:00
Jorge Pinna Puissant 6343bc7797 [FIX] website_event_sale: company mandatory to access pricelist
Before this commit, when creating an event without setting the company,
an error 500 is raised, this arises because the pricelist is not found,
it depends on the company.

Now, the company field is mandatory and the pricelist is reachable.

opw-2079246

closes odoo/odoo#38067

X-original-commit: bd1e5f744dacbb97317903b99d0df92ed25c02fe
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
2019-10-07 11:18:02 +00:00
Jeremy Kersten fd7d9dc47b [FIX] website: rename old name redirect_type
Missing diff in last commit.
    redirect_301 -> has been renamed to 301
    redirect_302 -> has been renamed to 302
    rewrite -> has been renamed to 308
    not_found -> has been renamed to 404

To be coherent everywhere and because this value is used as http code into
the werkzeug redirect call.

closes odoo/odoo#38061

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-10-07 10:31:03 +00:00
Jeremy Kersten b662130c8c [FIX] web: don't call get_consumed_tours on /web/login page
Compute of get_frontend_session_info is wrong in case of a route is "auth=None".
Check that user is logged in the session.
2019-10-07 10:31:03 +00:00
Andrii Skrypka 6802c6af50 [REF] stock: _quantity_done_compute performance
Use read_group to speed up this compute.

Closes #34546

closes odoo/odoo#37894

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-10-07 08:07:36 +00:00
Arnold Moyaux d86c2c5883 [FIX] base: res_users in multi company
Usecase to reproduce:
- User1 in company A and company B (default company A)
- User2 in company A and company B (default company A)

As user1 select company B in company switcher.
-> You never see user2 as he's hidden by a record rule.

This issue was present in older version when disabling the “Common Contact Book” feature,
because it was then enabling the faulty record rule. Since [1], this faulty record rule is
always enabled.
(Note that res.partner record rules are applied to res.user through _inherits)

We chose to remove the faulty record rules so that the present usecase is now working,
but the drawback is that you now see partners from other companies.

Also remove [2] that try to fix the issue and become useless if the
rule is removed.

[1] commit 25714692b2
[2] commit d6c65aa4d4

closes odoo/odoo#37712

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-10-01 13:42:50 +00:00
Julien Mougenot da2b247146 [FIX] web: m2o updates its value after reload
Changes the behaviour of many2ones when their value is changed via a form dialog.

Before this commit, when editing a m2o with a form dialog opened by an external button,
the field triggered an onchange with its old value before reloading its widget.
This caused the edition in list views to display outdated information when
saving multiple records.

Now, the reload is executed first, then the onchange occurs so that the value is
the newly updated one.

Part of task 2078807

closes odoo/odoo#37576

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-10-07 11:22:04 +00:00
Gert Pellin 0f412d56d6 [FIX] point_of_sale: restore table style"
The global table style was changed with the purpose of affecting only one table
in commit 7c31e0d2e7.

This fix moves the changes to the style of the table in question and
restores the global style.

This reverts commit 7c31e0d2e7.

solves #37992

closes odoo/odoo#38036

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-10-07 08:14:21 +00:00
fw-bot 4c10ff6683 [FIX] crm: avoid copying stage_id and probability when duplicating a lead
When Lead is duplicated, `stage_id` should not be copied for obvious reason.
Indeed it should go through the pipeline again, with probably and stage_id
being freshly computed again.

closes odoo/odoo#37927

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-10-07 10:28:04 +00:00
Martin Trigaux 42417956c0 [I18N] *: export 13.0 source terms
closes odoo/odoo#38028

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-10-07 07:55:34 +00:00
Martin Trigaux 94ae15315d [I18N] account_cancel: remove remaining translations
The module was not removed from .tx/config file so still fetching translations
2019-10-07 07:55:34 +00:00
Swapnesh Shah 0e98e657c9 [FIX] sale: Remove depricated view_mode from action
Fixes https://github.com/odoo/odoo/issues/38016
calendar, graph, pivot views don't exists for "account.move"

closes odoo/odoo#38022

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-10-06 17:24:26 +00:00
mreficent cb4d5fbb01 [FIX] base: fix display of creation info in form view
Currently when creating an attachment in backend, history section holds
a "Creation: on" void line that is populated after create with "creation:
administator on 2019..." . This is quite ugly and not usability oriented.

Let us hide the history line while create information are not set, aka
before first save of record.

closes odoo/odoo#37940

X-original-commit: 9ef4cb3ada349b34ba8a5daa5ca9f9765bc43437
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-10-03 17:58:01 +00:00
wan 51c58782db [FIX] account: do not validate when pressing enter on edit amount
In the reconciliation widget, pressing enter validates the line
focussed. This should not happen when editing an input, like it was the
case for the partial amount input.

closes odoo/odoo#38037

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
2019-10-07 08:16:03 +00:00
fw-bot ee8147996d [FIX] project_timesheet_holidays: holiday name shouldn't be exposed
closes odoo/odoo#37976

X-original-commit: 2a7fa7e58f5ac504b260f3caed9113936991b54f
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-04 11:29:22 +00:00
Swapnesh Shah 147e61a3bc [FIX] lunch: Add required argument location_id
This commit fixes Tracbacki coming when the user removes a location on New order.
It is because of location_id was not passed on Route.

closes odoo/odoo#38023

Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-10-06 17:50:38 +00:00
Alexis de Lattre a05f4b7589 [FIX] barcodes: no update on nomenclature
Some barcodes nomenclatures and rules are added in the modules that use
the barcode module. We should set them in no update to avoid loosing
modifications when the module is updated.

closes odoo/odoo#37985

X-original-commit: c4251c1c55d010e52b956817c2d4a588ee9379a9
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-10-04 13:31:42 +00:00
Thomas Binsfeld c6480a23a6 [FIX] point_of_sale: access rights on POS for product deletion
When we are trying to delete a product, a check is made to be sure that
no POS session is running. This check is not made as sudo, leading to
raise an access right error when you are trying to delete a product
without having access rights on the pos session object.

So we just call the search_read in sudo.

closes odoo/odoo#37977

X-original-commit: edb591cc1eae65660f88e676315276bba8b70ee8
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-10-04 11:39:55 +00:00
Odoo Translation Bot b6e7ed6c7b [I18N] Update translation terms from Transifex 2019-10-07 09:11:11 +02:00
lejeune quentin 5ee7fabcd7 [IMP] point_of_sale: Change build version for IoT Box
We change the build version of IoT Box to 13.0

closes odoo/odoo#38019

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-10-06 10:02:47 +00:00
Florent de LabarreandAdrian Torres b1d5ddd18b [FIX] doc: add more information about company-dependent fields
closes odoo/odoo#37986

X-original-commit: 1b8acd57f019d4e34eac72d34a8c6ff62731d836
Signed-off-by: Adrian Torres (adt) <adt@odoo.com>
Co-authored-by: Adrian Torres <adt@odoo.com>
2019-10-04 13:40:05 +00:00
Luis González 1e75b46c25 [FIX] base: access button apply with keyboard
The button to apply a custom group (Group By -> Add Custom Group ->
Apply) was unreachable when using the keyboard.
Remove the unnecessary attribute `tabindex="-1"` probably added for no
apparent reason.

closes odoo/odoo#37982

X-original-commit: 373c69bca366180601b760f05f219a4698e3c014
Signed-off-by: Luis González [Vauxoo] <luisg123v@users.noreply.github.com>
2019-10-04 12:40:31 +00:00
Laurent Smet a0605ee442 [FIX] account: Fix sorted key on report journal
closes odoo/odoo#37941

X-original-commit: d8462c13d4aa296c4d2ddcc4e74420e7f39ba895
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-03 18:36:58 +00:00
mreficent 72333b2e09 [IMP] stock: add hook to get virtual location
Some companies may have several locations with usage == 'inventory' and they would like to choose each time which adjustment location to use.

closes odoo/odoo#37022

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-10-03 15:35:47 +00:00
baskhuu a96872defe [FIX] base: change mongolian language configuration
Change decimal point, thousand separator and date format for Mongolian
language

closes odoo/odoo#37934

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-10-04 07:42:05 +00:00
GabbasovDinar efcf137867 [IMP] binding of context (this) to an object
closes odoo/odoo#37893

X-original-commit: fb3522b54903b19aa42cb3fe23e1a029b4ccfc14
Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-10-03 13:53:22 +00:00
Naglis Jonaitis 24563df00b [FIX] base: XML-RPC controller methods
`method` has no effect, so currently XML-RPC can be called via other
methods, e.g. GET, which is against XML-RPC specification.

closes odoo/odoo#37917

X-original-commit: c2fe13d31f6b55900ad139d4e75b8c1a0c4ac165
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-10-03 16:13:14 +00:00