pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] point_of_sale: access rights on POS for product deletion

Browse Source 
When we are trying to delete a product, a check is made to be sure that
no POS session is running. This check is not made as sudo, leading to
raise an access right error when you are trying to delete a product
without having access rights on the pos session object.

So we just call the search_read in sudo.

closes odoo/odoo#37977

X-original-commit: edb591cc1eae65660f88e676315276bba8b70ee8
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
This commit is contained in:
Thomas Binsfeld
2019-10-04 11:39:55 +00:00
committed by fw-bot
parent b6e7ed6c7b
commit c6480a23a6
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/point_of_sale/models/product.py
+2 -2
View File
@@ -16,7 +16,7 @@ class ProductTemplate(models.Model):
def unlink(self):
product_ctx = dict(self.env.context or {}, active_test=False)
if self.with_context(product_ctx).search_count([('id', 'in', self.ids), ('available_in_pos', '=', True)]):
if self.env['pos.session'].search_count([('state', '!=', 'closed')]):
if self.env['pos.session'].sudo().search_count([('state', '!=', 'closed')]):
raise UserError(_('You cannot delete a product saleable in point of sale while a session is still opened.'))
return super(ProductTemplate, self).unlink()
@@ -31,7 +31,7 @@ class ProductProduct(models.Model):
def unlink(self):
product_ctx = dict(self.env.context or {}, active_test=False)
if self.env['pos.session'].search_count([('state', '!=', 'closed')]):
if self.env['pos.session'].sudo().search_count([('state', '!=', 'closed')]):
if self.with_context(product_ctx).search_count([('id', 'in', self.ids), ('product_tmpl_id.available_in_pos', '=', True)]):
raise UserError(_('You cannot delete a product saleable in point of sale while a session is still opened.'))
return super(ProductProduct, self).unlink()