Commit Graph
167138 Commits
Author SHA1 Message Date
Harsh Bhatt 2af03f45e8 [CLA] signature for harshbhatt
closes odoo/odoo#140643

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2023-11-02 15:11:02 +00:00
Nicolas Lempereur 3aa1434164 [FIX] base: fallback on model_id to fill related field
Scenario:

- go to a model in technical
- create a new field and set "Related Field" to id

=> error "Unknown field name 'id' in related field 'id'" because we
get the field in self.model which is not present in the form view.

Fix:

Fallback to self.model_id.model as was the case before 16.0 commit:
76f699ca0b

Note: without the change, the added tests fails with:

  Warning Unknown field name 'id' in related field 'id'
  AssertionError: False != 'integer

opw-3138440
closes #112495

closes odoo/odoo#140583

X-original-commit: aa406352541abd8bbf188da84fc4e370029ffc12
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2023-11-02 15:11:00 +00:00
Abdelouahab (abla) b501514a50 [FIX] website_sale: amounts on digest should be converted
To reproduce
========
- having eCommerce installed
- let's take a product with price 1 000$
- for simplicity let's say 1$ = 0.5€
- make two orders for the product in € and $
    - first order will be 1 000$
    - second one will be 500€
- send the digest email
- the email shows total eCom sales = 1 500$

Problem
=======
- the total amount is a sum between $ and € which gives a wrong value

Solution
========
use `price_subtotal` from `sale.report` that has the convertead value instead

opw-3518064

closes odoo/odoo#140549

X-original-commit: d3b4203287f0fafd359913dedfaf130190751b92
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: Abdelouahab Laaroussi (abla) <abla@odoo.com>
2023-11-02 15:10:59 +00:00
Alvaro Fuentes 74c291ef5f [FIX] hr_work_entry_holidays: fix dates computaiton in write
We need to filter out records without `request_date_from` and
`request_date_to` to avoid the error:
```
  File "/tmp/tmpiaelju95/odoo/17.0/addons/hr_work_entry_holidays/models/hr_leave.py", line 180, in write
    stop = datetime.combine(max(stop_dates) + relativedelta(days=1), time.max)
TypeError: '>' not supported between instances of 'datetime.date' and 'bool'
```

Issue observed in test upgrades of `l10n_hk_hr_payroll`

closes odoo/odoo#140286

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
2023-11-02 15:10:58 +00:00
Chrysanthe (chgo) a99c83feaa [FIX] hr_skills: provide visual feedback on link
This commit fixes an accessibility issue about a link which does not
provide any visual feedback to the user who would hover it.

Prior to this commit, this link did not provide any visual feedback,
due to the lack of `cursor-pointer` BS class or `btn-link` styling.

The easiest way to fix this is to add a `cursor-pointer` class to the
link. We could have turned the link into a button with `btn btn-link`
classes but this would requires more layout and design adjustments.

task-3573737

closes odoo/odoo#140148

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
2023-11-02 15:10:57 +00:00
Chrysanthe (chgo) 5c88190a52 [FIX] hr: adjust icons size
This commit reduces the size of the icons used for the employee presence
status.

Prior to this commit, these icons were using a rule to define if they
should be diplayed in large or not, by checking the html tag of the
element they are in.

These icons were also styled with custom CSS to adjust their size, while
classes like `fa-lg` could eventually provide a workaround.

This approach was causing issues especially in kanban cards, were these
icons would appear massive and cause visual cluttering.

To improve the render of these inside cards, we simply remove the
custom styling applied to these icons.

task-3573702

closes odoo/odoo#140139

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
2023-11-02 15:10:56 +00:00
Adrien Widart (awt) 0393a60338 [FIX] purchase_stock,mrp_subcontracting_purchase: decrease POL qty
When decreasing the qty of a subcontracted POL, it can create an
unexpected receipt

To reproduce the issue:
1. Create a BoM for a subcontracted product P
2. Create and confirm a PO with 5 x P
3. Process the receipt
4. Return one
5. Update the POL qty to 4

Error: a new receipt is created for 3 x P. When updating the POL,
nothing should happen with the receipts

Updating the POL qty leads to the create/update of the related picking:
https://github.com/odoo/odoo/blob/1495b54aa452498c79f4178c2e38426b1b423e66/addons/purchase_stock/models/purchase.py#L426
And this will lead to `_prepare_stock_moves`:
https://github.com/odoo/odoo/blob/1495b54aa452498c79f4178c2e38426b1b423e66/addons/purchase_stock/models/purchase.py#L447-L450
Where we will define the values of the new SM (for the new qty).
However, there are two similar issues: to get the current qty, we
sum the quantities of the incoming/outgoing stock moves. But, the
condition is incorrect and we therefore consider the subcontracting
return as an incoming qty. So, this current qty is incorrect. Then,
we get the dest moves to compute some quantities to push/attach.
Here is the second issue, the filter condition to exclude the return
SM is incorrect: again, we don't exclude the subcontracting return

OPW-3515275

closes odoo/odoo#139957

X-original-commit: 7767c9e14230902826da3f17c94797b9698e11fa
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Signed-off-by: Adrien Widart (awt) <awt@odoo.com>
2023-11-02 15:10:54 +00:00
Serge Bayet (seba) bf54de9a71 [FIX] web_editor: force widget with reload to no-preview
This commit resolves the issue that arises when a widget contains a
reload attribute but lacks a no-preview attribute. That config leads to
an "Uncaught Promise" error. With this update, when a reload attribute
is detected, the no-preview attribute is now automatically added,
preventing the error from occurring. The problem occurs since [1].

Steps to reproduce:
- Go to website
- Edit
- Click on the header
- In the navbar options, change the Mobile Alignment option.
=> Works but traceback anyway.

[1]: https://github.com/odoo/odoo/commit/fcb16a3b1bd373726ffb54f0fbe41fb6d1784769

task-3572334

closes odoo/odoo#139909

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2023-11-02 15:10:53 +00:00
Lucas Lefèvre (lul) fb8c608e3d [IMP] spreadsheet: restrict text filter to range
Purpose
=======

This task answers two use cases making text filters more useful and easier to
use:

Always using the same few values
--------------------------------
The text filter allows to type any arbitrary text. However, some users will
always use the same few values. They will always again and again type the
same values, every time they want to set or change the filter value. That's
cumbersome. There's also a risk of making a typo while typing.

Parametric dashboards
---------------------
Some dashboards are built to be parametric (our business analysts do that a
lot). e.g. They put the measure field in a cell, then reference that cell in
PIVOT functions. If you want to have the same dashboard, but with another
measure: just update the cell with the new measure and that's it.

In read-only mode however, you can't update that cell :(

But you can mimic a variable parameter with a text filter. Create the text
filter, then get the filter value in a cell with the function
=ODOO.FILTER.VALUE("..."). Now you can update the cell value by setting
different values in the filter input.

However, you need to know exactly what value would be correct/valid for the
parameter. Typing any arbitrary text would lead to errors or unexpected
results. Business analysts can know that kind of technical stuff, but
lambda users don't. The solution is currently to duplicate the dashboard and
change the cell value with the exact parameter value you want.

Specification
=============
In the filter config side panel, allow the user to restrict the set of
possible values to values in a range of cells in the spreadsheet. Let's say
A1, A2, A3 contains Paris, Brussels, Berlin. If the user chooses A1:A3 in the
side panel, the text filter input is no longer a free text input, but becomes
a select with the 3 cities.

If a value from the range is selected, then the cell with this value is
changed to another value: keep the previous selected value selected.

display the values with their cell format but use their raw format for the
logic behind it (using the value as a cell value from ODOO.FILTER.VALUE)

closes odoo/odoo#139191

Task: 3554062
Related: odoo/enterprise#49204
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
2023-11-02 15:10:52 +00:00
stefanorigano (SRI) 3fbe3d8801 [IMP] hr: improve employee image placeholder
task-3568588

closes odoo/odoo#139421

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
2023-11-02 13:25:49 +00:00
Odoo's Mergebot a2e3eddc93 [MERGE] mail: fine-tune activity view improvement
[IMP] mail: add/modify activity client tests

We add a test that checks the rendering of the activity view and the activity
popover with activities done.

We also add a test that marks as done an activity and verify that the activity
view is updated accordingly.

And we do a correction in the test "activity menu widget: activity menu with 2
models" (assert.ok(selectContaining... was always true as an array is always
returned and [] is true in javascript).

[FIX] mail: fix invalid date done in the activity list popover

Date done field was in camel case instead of snake case leading to undefined
value and "Invalid date" in the interface.

Task-3558929

closes odoo/odoo#139373

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2023-11-02 13:25:48 +00:00
Pierre-Yves Dufays d2f44211b9 [IMP] mail: add/modify activity client tests
We add a test that checks the rendering of the activity view and the activity
popover with activities done.

We also add a test that marks as done an activity and verify that the activity
view is updated accordingly.

And we do a correction in the test "activity menu widget: activity menu with 2
models" (assert.ok(selectContaining... was always true as an array is always
returned and [] is true in javascript).

Task-3558929

Part-of: odoo/odoo#139373
2023-11-02 13:25:48 +00:00
Pierre-Yves Dufays 949039135d [FIX] mail: fix invalid date done in the activity list popover
Date done field was in camel case instead of snake case leading to undefined
value and "Invalid date" in the interface.

Task-3558929

Part-of: odoo/odoo#139373
2023-11-02 13:25:48 +00:00
Joseph Caburnay 21e551f254 [FIX] point_of_sale: should not load default pricelist
Since 40f0482b680a7872d338fa8fd10eec4663637b46, pricelist is no longer required.
Because of that, pos no longer needs to implicitly load a default pricelist when
"Flexible Pricelists" (use_pricelist) flag is active. Therefore, when
deactivating the option, we clear the value of pos.config.pricelist_id.

We also make sure that during loading of data when opening a session,
default_pricelist is not set if use_pricelist is false.

Also note that we are not clearing available_pricelist_ids because of some
limitation in the synchronization between res.config.settings and pos.config. It
should okay to keep the links because they won't be loaded when use_pricelist is
false. Also, it's nice to see the field filled when reactivating the flag.

closes odoo/odoo#140599

X-original-commit: 54a6f1688fb8d15b662848b03cecbe8236292d07
Signed-off-by: Robin Heinz (rhe) <rhe@odoo.com>
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
2023-11-02 12:03:54 +00:00
Manushi Shah (mash) ec2c7f0f54 [FIX] web: discard unnecessary scrollbar in kanban examples
Steps:
- Open Project
- Create New Project
- Select the blank new project and click on see examples below the stage.
- This also appears in the existing project where you want to add more stages.
- A Kanban Examples popup view will open.

Issue:
- A scrollbar appears on the bottom left due to the long name of the example.

Cause:
- Due to the overflow property, when the name is long, it will automatically
create a scrollbar, making it look weird.

Fix:
- Add overflow-x visible in notebook It will counterbalance the overflow-x: auto;
rule used in the general (aka. horizontal) use case, and force the overflowing
element to take the space it needs, adjusting the headers column's width accordingly.

closes odoo/odoo#140590

Task: 3422009
X-original-commit: 4fff4fbb308bf411603cfc239e9f651598d0de78
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-11-02 12:03:53 +00:00
MerlinGuillaume ac1e5dd3d8 [FIX] base: add a smart button on category related to partners
When we add a smart button on a contact tag related to contacts, the
button adds a default search filter that hides the related records

Steps to reproduce:
1. Install Contacts and Studio
2. Go to Contacts > Configuration > Contact Tags
3. Open tag "Vendor / Desk Manufacturers"
4. Toggle Studio
5. Add a button (at the top right of the form) related to field "Tags
   (Contact)"
6. Close Studio
7. Click on the button
8. A list view of the related contacts opens but there is a filter that
   hides the records

Solution:
Remove the `filter_domain` attribute on the field category_id and
replace it by the `operator` attribute in order to use the raw value in
the domain

Problem:
In `_getFieldDomain`, we replace the `self` in the domain by the
stringified id which essentially checks for a category that has a name
containing the id

opw-3471959

closes odoo/odoo#140564

X-original-commit: 18640a2ddddcf2ef90948295a41b0d7d30ec09e3
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>
2023-11-02 12:03:52 +00:00
Youssef Bashandy 3e0ab80368 [FIX] event_sale : Incorrect event sales value upon cancelling
Steps to reproduce:
	1- Install Sales and Events modules
	2- Create a new Event and event registeration
	3- Create a sale order for this event
	4- Check the sales smart button in the event's form
	5- Cancel the sale order and check the smart button

Current behavior before PR:
When you create a sale order for an event and then cancel it the value of this sale order will not be deducted from the sum of the sale values at the sale smart button in the event form.

Desired behavior after PR is merged:
When you cancel a sale order related to an event the sale smart button value will be updated

opw-3543943

closes odoo/odoo#140547

X-original-commit: b5554f6f7597b44adfa318655bab1eab19158303
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Youssef Bashandy (yoba) <yoba@odoo.com>
2023-11-02 12:03:49 +00:00
Mathias Mathy (MAMA) af9343b521 [FIX] repair: traceback on generate serials
Main changes :
    Force context values to avoid traceback in
    action_generate_lot_line_vals
Before :
    When calling action_generate_lot_line_vals from a repair order,
    a traceback occurs due to the missing 'default_location_dest_id'
    in the context.
After :
    We enforce 'default_location_dest_id' in the repair order form
    to ensure it is available when we call action_generate_lot_line_vals

closes odoo/odoo#140500

Signed-off-by: William Henrotin (whe) <whe@odoo.com>
2023-11-02 12:03:48 +00:00
snd 32b3e1bb6a [FIX] stock: receipt transfers almost always ready
Incoming picking should almost never be in a waiting ('confirmed') state. So we check if the location bypasses reservation and that no move is in MTO.
Changing the main_flow_tour because removing the "Waiting" status from incoming picking forms makes it unable to find "Ready" in Mobile UI.

closes odoo/odoo#140180

Signed-off-by: William Henrotin (whe) <whe@odoo.com>
2023-11-02 12:03:45 +00:00
Sébastien Geelen (sge) 30f6ff4f93 [FIX] web_editor: collaboration error
In order to improve the user Experience and not uselessly
block access to the document, we prevent collaboration error
to open the traceback dialog.

task-3568680

closes odoo/odoo#139964

X-original-commit: df39cbc4dbc1922e91c53278db7fdcb12f01306e
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Geelen Sébastien (sge) <sge@odoo.com>
2023-11-02 12:03:44 +00:00
Sébastien Geelen (sge) c89ab9aa2d [FIX] web_editor: commit changes in onWillUnmount
In some cases the changes done in the editor were lost when using other element of the the UI.
For example : changing the tab containing the editor component to another one.

To avoid loosing the changes made by the user in those cases, we force an urgent commit change
in the `onWillUnmount` hook.

task-3530998

closes odoo/odoo#137716

closes odoo/odoo#139959

X-original-commit: b2c3775ea01bfdb8e0dd40b3b8e57534c1785116
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Geelen Sébastien (sge) <sge@odoo.com>
2023-11-02 12:03:43 +00:00
Elisabeth Dickinson 89082fbd56 [IMP] web, *: fix favorite alignment
*: account, hr_recruitment, project, lunch, mrp

By removing the absolute positioning on ".o_favorite" inside kanban
views, we allow it to align naturally with the rest of the elements,
thus removing the custom code that was needed for padding.

By doing so however the icon - which is now only visible on hovering the
card in the Project's kanban view - should remain visible at all times.
The behaviour would be the same as in other kanban views: an outlined
star when not active and a full yellow star when it is.

The margin on the kanban heading in the Manufacturing orders has been
removed to realign the top elements.

task-3462098

closes odoo/odoo#131559

Signed-off-by: Pierre Paridans (app) <app@odoo.com>
2023-11-02 12:03:40 +00:00
Christophe Monniez 7094215e65 [FIX] web: skip clickbot qunit test
The clickbot test fails after October because of a hard coded month. It
needs to be refactored but let's skip it in emergency.

closes odoo/odoo#140641

X-original-commit: f9ec63dc3d865a24ec7da3f9389ce6b46fb66a83
Related: odoo/enterprise#49990
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2023-11-02 10:15:05 +00:00
Anh Thao Pham (pta) 80dcf62086 [FIX] account_payment: fix failed payment transaction from invoice
Steps to reproduce:
- Configure a payment provider (e.g. Stripe)
- Go to the portal account of an user (e.g. Marc Demo)
- Click on "Manage payment methods"
- Save a payment method to create a payment token
- /!\ Go back to payment provider configuration and make a typo in the credentials
(This will be needed later to trigger a payment transaction error)
- Go to Accounting and create an invoice for Marc Demo
- Confirm the invoice
- Register payment:
  * Payment Method: Stripe
  * Saved payment token: [payment token of Marc Demo]
- Create payment

[1st issue]
The payment transaction fails (as the credentials are incorrect),
but no information about it appears on the invoice.

[2nd issue]
It is not possible to register another payment (with the payment provider) because
there is an unique constraint on the reference field of "payment.transaction" model
and each attempt of registering a payment uses the same reference.

Solution:
[1st issue]
Link invoice to payment transaction.
Messages related to payment transaction will be logged on the invoice automatically.

[2nd issue]
Generate reference with "_compute_reference" method instead of always using the same one.

opw-3499200

closes odoo/odoo#140533

X-original-commit: 8c98efe036972c43a95c28509e91c356ddc84084
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: Anh Thao Pham (pta) <pta@odoo.com>
2023-10-31 20:54:05 +00:00
Arnold Moyaux e220953e82 [FIX] stock: hide forecast button and field
It adds advanced data on the picking view.
It's not needed by default so we hide it

closes odoo/odoo#140577

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
2023-10-31 16:59:15 +00:00
roen-odoo 22a10e1eb2 [FIX] point of sale: check if config_currencies null
A traceback is generated if config currencies are none. This is because we are trying to access the 0 index which does not exist in a None object.

Steps to reproduce:
1. Go to studio.
2. Click on reports.
3. Search for sale details.
4. Click on sale details report.

Current Behavior:
As we click on the sales details report, a traceback pops up.

Expected Behavior:
There should be no traceback and the report editor should open smoothly if nothing wrong.

Note:
We also remove Timezone information from the start_date to match the
format of the date when it's provided by the user.
e.g. : "23/05/2024 08:25:34" instead of "23/05/2024 08:25:34 TZInfo"

OPW-3501650

closes odoo/odoo#140575

X-original-commit: c816f47eaabcb2aedce91887287f34ac8f16320a
Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>
Signed-off-by: Robin Engels (roen) <roen@odoo.com>
2023-10-31 16:59:14 +00:00
Sébastien Theys 2426cf369b [FIX] mail: no crash on opening non-existing channel
closes odoo/odoo#140562

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2023-10-31 15:54:33 +00:00
Louis (wil) a46c800d53 [I18N] *: export source terms
closes odoo/odoo#140529

Related: odoo/enterprise#49925
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
2023-10-31 15:54:32 +00:00
Katherine Zaoral bb77211c66 [CLA] add new members to Adhoc CLA
closes odoo/odoo#140514

X-original-commit: 208ba9a0bba7a11d5eef2dcff1ab548470b63e55
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2023-10-31 15:54:30 +00:00
Xavier Morel f6e01d6b53 [FIX] l10n_sa_edi: markup usage
`''.join` would strip the `Markup` out, so the markup would appear
literally in the result instead of being interpreted as HTML.

Also switch to using dict-style formatting, it's a touch clearer (and
shorter) for this case, since `e` is already a dict (hopefully).

closes odoo/odoo#140496

X-original-commit: 4d88e1df4deb5f1aab23ca117f6b6261babec3f7
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2023-10-31 15:54:29 +00:00
Claire Bretton (clbr) 99f03b3d12 [FIX] account,account_edi_ubl_cii,l10,_{es,it}_edi{_facturae}: fix error message formatting
With https://github.com/odoo/odoo/pull/139311, we broke the formatting of errors.
We need to handle two formats:
- one for the raised Error, likely formatted with \n
- one for the chatter, likely formatted with html

closes odoo/odoo#139812

Related: odoo/enterprise#49614
Signed-off-by: Laurent Smet (las) <las@odoo.com>
2023-10-31 15:54:25 +00:00
aliya 19ed26bbfc [FIX] account_peppol: restrict peppol journal
Currently, although the journals are filtered to only show purchase journals,
there is no constraint preventing users creating a new journal of any
other type. This commit adds a constraint.

closes odoo/odoo#140458

X-original-commit: 014435f09cabbf0b21f3f9809eb1e0f13d35661a
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Aliya Tastemirova (alta) <alta@odoo.com>
2023-10-31 14:41:00 +00:00
Mathias Mathy (MAMA) 64ca8398bb [FIX] stock : Put In Pack button
Main changes:
    Change the style and postion of the Put In Pack Button on the
    stock.picking form view
Before:
    Button is aligned on the left and has the style primary
After:
    Button is aligned on the right and has the style secondary

closes odoo/odoo#140430

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
2023-10-31 14:40:59 +00:00
Walid f949af22ce [FIX] stock: use existing lots when importing lots
Steps to reproduce:
1. Install Inventory app.
2. Enable "Storage Locations" in Inventory settings.
3. Create a new product known as "X". Set it's tracking to "By Unique Serial Number".
4. In Inventory -> Configuration -> Operation Types -> Receipts, set "Use Existing Ones" to true.
5. Create a new Receipt, add a new line of product X.
6. In the "Details" page of the X line, click "Import Serials/Lots".
7. Enter at least two lines of two serial numbers and import.

Bug:
Notice that the "Lot/Serial Number" column on each row are blank.
This is happening because the view used for stock move lines here will
display either the lot_id field of a sml, or the lot_name field,
based on varying conditions. In this case, setting "Use Existing Ones"
to true will cause the lot_id field to be displayed (and the lot_name
field to be invisible). When importing lots, only the lot_name  is set
with the user's input but the lot_id is left blank. So because lot_id
is empty, the column is empty. But this works as expected
when "Use Existing Ones" is false because it displays the correctly
set lot_name. When the receipt is validated,
the lot is created and lot_id for each of the smls is set,
so now it displays properly.

Fix:
when "Use Existing Ones" is set first check if lot exists and set it in
that case, otherwise create and set a new lot at that moment

opw-3498812

closes odoo/odoo#140400

X-original-commit: c5a35a1c2a7e16adbd3f2b1e37509003bcfac957
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
2023-10-31 14:40:57 +00:00
Alexandre Kühn f65699dbd1 [FIX] mail: OdooBot has a request notif should not be muted
Before this commit, the "OdooBot has a request" notification in the
Messaging Menu -- which suggest to enable push notifications -- had
a muted style, which looks as if the item is unimportant and was
read by the current user.

This is an important notification, at an equivalent level of
importance than needaction notifications. This was already
highlighted by this item contributing to the global Messaging Menu
counter.

This commit fixes the issue by not muting this notification. To do
so, it enhances prop `muted` on `NotificationItem` component:
- 0 (default): the notif is unmuted
- 1: the notif is slightly muted
- 2: the notif is hard-muted

0/1 are equivalent to the different muted style of notification in
16.4, while `muted: 2` shows a hard-muted notification when the user
choose to manually mute a channel, as to not receive any notification
from it.

Some logic related to "mark as read"/"counter" logic has been moved
to this muted prop concern, as not all notification that have mark
as read or a counter necessarily must be muted, e.g. with "OdooBot
has a request".

Task-3566799

closes odoo/odoo#140380

X-original-commit: c60fdbb25b38899ceeb89e76abc35c3474ce1f5b
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2023-10-31 14:40:56 +00:00
vlst a4792a373e [IMP] pos_self_order: ignore printing error
In this commit we hide the printing errors in `pos_self_order`.
At the moment, they are show to the user, but that is not
desirable behavior in a kiosk environment.

Such printing errors might, for example, be encountered when the printer
is out of paper.

closes odoo/odoo#140271

Signed-off-by: David Monnom (moda) <moda@odoo.com>
2023-10-31 14:40:53 +00:00
Christophe Simonis 35e22b8fe9 [IMP] core: reflect the model inherits in the database
This will help the upgrade process. Currently, there is an harcoded[^1]
inherit tree stored in the upgrade source. By storing this information
in the databases, we:
 - avoid this hardcoded list.
 - support more than the standard modules.

task-3504720

[^1]: hardcoded, but autogenerated.

closes odoo/odoo#140261

Signed-off-by: Raphael Collet <rco@odoo.com>
2023-10-31 13:26:44 +00:00
Martin Maes d170e913ab [FIX] mrp: ui improvement
This commit fixes:
 - hide `read_duration` and `expected_duration` in MO list view.
 - hide `component availability` byt default in bom overview,
unless if coming from mrp forecast.

task-3547356

closes odoo/odoo#140244

Related: odoo/enterprise#49802
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
2023-10-31 13:26:42 +00:00
Antoine (anso) 124f247bd5 [FIX] web: fix hover style on disabled o_arrow_button
This commit fixes an issue where the interior of the arrow of the
disabled `o_arrow_button` was darker on hover

task-3573542

closes odoo/odoo#140122

Signed-off-by: Pierre Paridans (app) <app@odoo.com>
2023-10-31 13:26:41 +00:00
Rahul Prajapati 089e46ae59 [FIX] mail: channel unpin/delete issues
Before this commit:

Channel was not getting unpinned after being deleted

After this commit:

- Channel gets unpinned for all the channel members after being deleted
- If a user leaves channel/group then all of the messages of that channel/group
  are removed from the user's history/starred/inbox channel.

Task-2814440

closes odoo/odoo#139972

X-original-commit: 4767d6001d15628768388bcac98c04ab185040c8
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2023-10-31 13:26:40 +00:00
Benjamin Vray ad8feceedf [FIX] website: fix hover effect and Images Wall
Steps to reproduce the bug:

- In Website edit mode, drag and drop an "Images Wall" snippet onto the
page.
- Click on the first image of this snippet.
- In the "Animation" options of the image, select "On Hover".
- Save the page.
- Click on the first image of the "Images Wall" snippet.
- Bug: The image in the slideshow still has the overlay that appeared
due to the hover effect.

This commit fixes this issue by resetting images to their original
source in the slideshow.

task-3562305

closes odoo/odoo#139695

Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
2023-10-31 13:26:39 +00:00
Odoo's Mergebot 469d94a94d [IMP] website: events redesign
This PR improves the overall design of all the views in the Frontend
side of the module Event.
The design was outdated and was not consistent between the different
pages.

List of changes:
- events: cleaning of scss, filters consistency and responsive
(with off-canvas).
- submenu: design and responsive behavior (dropdown)
- registration page : overall design and the ticket list is inside a
modal, to help with cases like having a lot of tickets. To be improved,
on a separate page instead of a modal.
- talks and agenda: design, cleaning of scss, filters consistency and
responsive (with off-canvas).
- sponsor template: minor design modification
- exhibitors: design, cleaning of scss, filters consistency and responsive
(with off-canvas).
- location: minor design modification to be consistent with others pages,
but need improvement in the near future.
- meet: design, cleaning of scss
- booth selection: overall design

task-3083658

closes odoo/odoo#137729

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
2023-10-31 13:26:38 +00:00
Morgane (morm) 6b1d11a60d [IMP] website: search button color
Prior to this commit, the button with the search icon, inside the search
bar,  was `primary, which is not consistent with the filters that are
`light`.

Part-of: odoo/odoo#137729
2023-10-31 13:26:38 +00:00
Morgane (morm) 4a890e1f92 [IMP] website_event: frontend redesign
This commit improves the overall design of all the views in the Frontend
side of the module Event.
The design was outdated and was not consistent between the different
pages.

task-3083658

List of changes:
- events: cleaning of scss, filters consistency and responsive
(with off-canvas).
- submenu: design and responsive behavior (dropdown)
- registration page : overall design and the ticket list is inside a
modal, to help with cases like having a lot of tickets. To be improved,
on a separate page instead of a modal.
- talks and agenda: design, cleaning of scss, filters consistency and
responsive (with off-canvas).
- sponsor template: minor design modification
- exhibitors: design, cleaning of scss, filters consistency and responsive
(with off-canvas).
- location: minor design modification to be consistent with others pages,
but need improvement in the near future.
- meet: design, cleaning of scss
- booth selection: overall design

Part-of: odoo/odoo#137729
2023-10-31 13:26:38 +00:00
Mathieu Duckerts-Antoine ef97eaf987 [FIX] web: drag and drop: allow pointer down blur
If one edits an input value in a dialog and click on the dialog header,
the blur event is prevented because the dialog is draggable and the
pointer down native behaviour is prevented by the draggable hook builder.
This can cause data losses or the dialog content to not be render correctly.
For instance, this happens with the debug input of the domain selector
dialog.
We fix that by triggering the blur event programatically.

closes odoo/odoo#140436

Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
2023-10-31 10:34:01 +00:00
Xavier Morel 090b721f7e [FIX] mass_mailing: markup usage
- using a string to join `Markup`s is useless, that just strips out
  the `Markup`
- the entire toplevel `Markup` can be formatted in one shot

closes odoo/odoo#140428

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2023-10-31 10:34:00 +00:00
Brieuc-brd d786992973 [FIX] payment: adapt long payment summary
Prior to this commit, the content of the payment summary did not include
line breaks when the text was too long, creating layout issue.

To fix that, this commit adapts the font size and forces the text to
break.

task-3576830

closes odoo/odoo#140423

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
2023-10-31 10:33:58 +00:00
Lucas Lefèvre (lul) b3369c42bb [FIX] spreadsheet: test invalid pivot expression detection
See https://github.com/odoo/odoo/pull/139871/files#r1377199846

closes odoo/odoo#140418

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
2023-10-31 10:33:57 +00:00
Antoine Vandevenne (anv) f294bc10f8 [FIX] website_sale: handle missing express checkout providers
The express checkout form template could not be rendered when no payment
provider supporting express checkout was passed.

closes odoo/odoo#140415

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
2023-10-31 10:33:56 +00:00
Achraf a1981c0279 [FIX] website_sale: Allow users to see delivery cost with carrier radio input
Steps:
	- Install `website_sale`
	- Enable `On-site payment & picking`
	- Set 200$ for on-site picking fees
	- Go to /shop
	- Put a product in the cart and go to checkout

If you click in the element box containing on-site picking it will compute
the delivery fees, but if you select it with the radio button it will not.

closes odoo/odoo#140376

X-original-commit: 3d81439f7ded68a2002a8585da63c6d72a7b65ca
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>
2023-10-31 10:33:56 +00:00