Commit Graph
125841 Commits
Author SHA1 Message Date
Pierre Paridans 1f33ee82d0 [IMP] mail: chat window send message
On a chat window on mobile, the keyboard can be closed by clicking in
the conversation, then there's no way to send your message.

This commit add a "send" icon in the input, after emoji and attachments
icon. Actually the button was already present on mobile but hidden
because of the class o_composer_button_send (used for multiple "send"
buttons). This is fixed by restricting the hidding only to the desired
button.

It also removes an unused 1px top/bottom margin on the thread composer
(wasn't visible as the buttons' background color is the same as their
parent's background).

Finally applying the brand-primary text color on the "send" button only
when not being in a "mini composer" mode instead of globally.

Task ID: 1943863

closes odoo/odoo#32568

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-04-10 07:38:04 +00:00
Hetal Dhanak 8b7f88edd2 [IMP] stock : Route button on consumable products
-Previously, route state button was visible only on stockable products but now it'll be visible on consumable products too.
This task is related to task id: 1945832

closes odoo/odoo#31623

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-04-05 07:02:54 +00:00
Sapan Zaveri 1208d7f839 [IMP] base: contacts email and phone clickable
Purpose of  this task is,
Before this task, the customer was able to click on on the email of a contact from the res.partner view.
But, he wasn't able to click on this same email when the modal of a contact was open.

For the phone it's the opposite. You can't click on the phone from the res.partner view but well from the contact's modal.

So, I made both the fields clickable in both (res.partner view and contact's modal)

Task ID: 1965730
Closes: #32586

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-10 13:10:15 +00:00
Mitali Patel b50ffac657 [IMP] sale_management: fill the mandatory field 'applied to' with 'sale order' when create new confirmation email template
Purpose of the task is to fill the mandatory field 'applied to' when create new confirmation email template
from quotation template.

Related Task ID #1934678 closes #31350

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-11 05:18:07 +00:00
qsm-odoo 54ae48f2ce [IMP] website: make text snippet's col full width
task-1967273

closes odoo/odoo#32609

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-04-11 04:50:49 +00:00
Swapnesh Shah f5c6c68165 [FIX] stock: Fix typo on field's attribute
closes odoo/odoo#32562

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-04-09 20:06:03 +00:00
Kirti Choudhary 0152e95eb3 [IMP] hr_timesheet: hide remaining hours if planned hours not set
If the planned hours are not defined on a project.task, the remaining hours should be hidden.

Task ID - 1930975

closes odoo/odoo#30802

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-04-10 09:26:29 +00:00
Kazantcev Andrey 6b73d23f7a [IMP] http: code cleaning
reuse current_thread result
No needed to call threading.current_thread() on evry arg setting

closes odoo/odoo#32000

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-10 07:18:59 +00:00
Heckad 1656557e81 [CLA] signature for heckad 2019-04-10 07:16:42 +00:00
Cedric Snauwaert 60dc5df281 [FIX] l10n_be: remove duplicated tax groups
There was one tax group per tax which was strange, so remove all duplicated tax group and only keep one tax group per tax percentage (0%, 6%, 12%, 21%)

closes odoo/odoo#32517

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-04-08 13:57:19 +00:00
Suraj Shukla dc2a93792a [IMP] web: properly set margin for the kanban dropdown
While everything looks pretty perfect without this commit,
setting margin on `.dropdown-toggle` and not on its parent
`.o_dropdown_kanban` itself will cause glitches in Studio.

While selecting the dropdown using Studio, the class responsible
for displaying outline (that indicates the selection) is applied
on '.o_dropdown_kanban', which is okay, but the actual child is
positioned using margin, so the outline on parent div looks ugly.

This commit fixes the issue by applying the margin on the proper
selector.

Task 1916583

closes odoo/odoo#30049

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
2019-04-09 12:44:01 +00:00
Suraj Shukla 13222fcd68 [IMP] web: better ModelFieldSelector layout
This commit improves the usability of ModelFieldSelector widget
with following points:
- add a placeholder on the input for searching fields
- add more height to the same input for consistency
- properly show 'X' sign within header

Task 1916583
2019-04-09 12:42:40 +00:00
mgh-odoo b993a2d9c8 [IMP] website_sale: restrict deleting/archiving pricelist for ecommerce
Before this commit, if none of the pricelist is available for the website
then frontend ecommerce will crash. This issue is arrived from #30675 PR.
The reason behind crash is, if there is no pricelist associated with
the website then the ecommerce will not get the currency and breaks the
frontend shop.

This commit will restrict user from making those changes which breaks the
frontend shop. We will ensure that atleast one pricelist is available for
each website.

task-1966811
Closes: #32534

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-10 06:49:37 +00:00
wan 5eaa4f2967 [IMP] account: remove user_type_id
OPW 1961781
The related field user_type_id on account.move.line was slowing down the ORW when whanging the type of an account. This field was almost never used except in account_reports.

closes odoo/odoo#32303

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-04-01 13:02:38 +00:00
Juhil Somaiya 92685d33a5 [IMP] website_forum: improvement karma error message
Changed the error message when the user hasn't enough karma.
Add link to the FAQ to understand how to get more karma.

Task-ID: 1952473
Closes: #32161

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-10 06:28:48 +00:00
dbh-odoo d5cab8a40d [IMP] website_rating: visual improvements for product rating
Rating Improvements on product page:
  1) Now we display ratings filter in descending order which
     is common behavior for eCommerce/Appstore sites
  2) Stop scrolling to top while removing selected rating filter
  3) UI improvements for mobile/tablet view
  4) Percentage is rounded up to two decimal points so that
     it does not look ugly

task-1850446

closes odoo/odoo#28245

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-04-10 06:27:36 +00:00
Sapan Zaveri 98d4b21437 [IMP] website: properly show navbar on iPad
Currently, when we open the website on iPad, the navbar is not displayed
properly (systray items are overlapping on the website menu). This
commit fixes the issue by using '+' icon on the navbar top menus if
there is not ample space. This commit also converts multi company
selector with 'fa-building' and multi website selector with 'fa-globe'
icons on smaller screens.

task-1945020

closes odoo/odoo#32321

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-04-10 05:39:29 +00:00
Xavier Morel 265926f971 [IMP] website_sale: overhead on every page
website_sale adds a call to sale_get_order to ~every website page (in
order to validate & display the shopping cart).

Before this change, this calls get_pricelist_available() and triggers
two different computations of property_product_pricelist on every page
even for a public user with no cart / SO. This, in turn, generates ~20
queries and adds 20ms (total) / 10ms (sql) to ~every page load.

Fix: early return if the user doesn't have an SO (either in session or
in DB) and we're not in a case where we want to force one.

Loading "/" with just website_sale installed on a new DB,

- before: 53 queries, 31ms ±5 (sql), 75ms ±5 (all)
- after: 32 queries, 21ms ±1 (sql), 53ms ±3 (all)

closes odoo/odoo#32492

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-04-08 11:40:08 +00:00
Sapan Zaveri be8af5dc9c [IMP] sale: Improvement in payment reference for wire transfer
Purpose of this task is,
Default payment ref for wire transfer is confusing and not really helpful as it will induce encoding errors customer side

So, I removed modulo part in payment reference

Task Id : 1946656
Closes : #31853

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-09 10:32:11 +00:00
mgh-odoo 13ed1c6aa0 [IMP] product: pricelists - multiple prices per product
currently, if the user selects Multiple prices per product
in Multiple Product Prices, the user cannot set product
directly from product.pricelist formview.

purpose of this commit is to make multiple prices par product
fromview quick editable and reflect that to the product.product formview.

Task-ID: 1904777
Closes: #30540

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-08 05:02:01 +00:00
Jeremy Kersten 82ea590264 [MRG] website_form[_editor]: merge modules together
closes odoo/odoo#32491

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-08 10:07:49 +00:00
Juhil Somaiya 48b373f8e4 [FIX] payment: font awesome text outside of tag
So text do not inherit from font awesome font style

closes odoo/odoo#31730

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-09 06:46:14 +00:00
Juhil Somaiya 5a9530cdfd [IMP] account, payment, sale, website_sale: added extra fees on payment
Purpose of the task is when extra fee is activated on the payment acquirer,
the customer is no warned about extra cost when choosing the payment acquirer.

so display the extra fees on payment acquirer when doing the payment.

Related Task ID : 1845815
Closes : #31730
2019-04-09 06:44:48 +00:00
Yenthe666 556d6d6059 [ADD] mail: add activities menu and views under Settings/Technical
closes odoo/odoo#32287

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-04-01 08:47:36 +00:00
Felix H. Hoßfeld 3a92c2644d [CLA] Thought Gang GmbH Contributor License Aggrement
closes odoo/odoo#32152

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-08 12:18:03 +00:00
Priyanka Kakadiya b82f6fee71 [IMP] hr: display warning when user is not linked to employee
On user form view, when no employee is linked to the user, we want
to display a message to the HR Officer (only) with the possibility
to create the employee profile with prefilled information.

Task-1916925

closes odoo/odoo#29659

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-04-08 07:58:01 +00:00
jem-odoo 3be372cfc4 [FIX] hr: restrict sudoing fields_view_get of res.users
Since d77ce4c2a9, the feature of editing own employee profile was
added. It was complicated with the access rights point of view because the
hr.employee fields are protected (groups="hr.group_hr_user"). To allow editing
its own hr.employee, it was required to `sudo` the field_view_get of res.users
(as the profile form view is a res.users form view, with related field from the
employee).

- Bug
The problem is that calling `fields_view_get` as `sudo` each time breaks the `groups`
mecanism on res.users views (not only form view). For instance, adding a field
on the form view with a group will always make it visible as the `groups`check
is done in sudo mode.

- Solution
This commit tries to fix this matter but reducing the `sudo` usage to
- only form view (we don't want this to applied to every res.users view type)
- only for internal user
- only in the flow of the "self editing profile", by checking the current action
- only for the current user (avoid to get the profile of other res.users by
using the same action)

- Side effect
The `groups` mecanism is still breaking on the "my profile" form view, as the
`sudo` is still applied in that case. We might tolerate this as the view should
only be accessible for the current user.

This is not perfect at all, but cleaning that properly might involve to redevelop
this sensitive feature.

Task-1916925
2019-04-08 07:58:01 +00:00
xtanuiha ea4a782f49 [ADD] base: add Archived filter for ir.rule
To easily find archived rules

closes odoo/odoo#32261

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-08 10:18:31 +00:00
xtanuiha 4c4f79dd73 [CLA] signature for xtanuiha 2019-04-08 10:18:12 +00:00
Aurélien Warnon 4b7fb75bc2 [IMP] survey: improve survey form usability
Task #1949652

Some fields were renamed/moved around to improve the survey.survey
form usability.

closes odoo/odoo#31775

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-08 07:09:01 +00:00
David Beguin 85b0b37dcc [IMP] survey : add retry survey button if no scoring or nbr of attempts left > 0
In order to allow the user to ealisy retake the survey he just either passed
or failed (in case of scoring activated), a retry button is added not only
in case of failed scoring survey (like it was already the case)
but also for non scoring survey.

This button is also added in the review survey page, to get direct access to
retry the survey.

The rule is the following and apply to all survey types :
If not quizz passed (this will be always true for non scoring survey):
    if is_attempts_limited
        if attempts left
            Add retry button
    else
        Add retry button

Task ID : 1950429
PR #31802

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-03-13 08:20:54 +00:00
Jeremy Kersten 20fa4e7ba1 [FIX] website_form_editor: fix dependencies 2019-04-08 08:09:26 +02:00
Jeremy Kersten 20f17a0948 [MRG] website_form_editor: move to community 2019-04-08 07:28:34 +02:00
Jeremy Kersten a8f83f6541 [FIX] website_form_editor: prepare move to community 2019-04-08 07:26:57 +02:00
asa-odoo e16fbee993 [IMP] sale: terms and conditions improvement
purpose: de88a727b2 introduced
a change in the sale order view. it reduced dramatically the size
of the 'terms and conditions' widget.
This commit set back easily readable dimensions

Task : 1950799

closes odoo/odoo#32129

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-04-05 11:55:01 +00:00
Thibault Delavallée 0b47b2f22c [REF] l10n_it_edi, website_forum: give email_from / author when creating messages and mails
Purpose: clean mail.mail creation code and use standard mail creation or
template send_mail method. In those addons we ensure author and email_from
are set to maching values, leading to more consistent emails.

Related task ID 1965040
PR #32459

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-05 14:05:31 +00:00
Thibault Delavallée ea3f4690aa [REF] crm_iap_lead: correctly use template to send emails
Purpose: clean mail.mail creation code and use standard mail creation or
template send_mail method.

In crm iap lead we can avoid custom mail creation by correctly using
send_mail method of mail template and its arguments.

Related task ID 1965040
PR #32459
2019-04-05 14:05:31 +00:00
Thibault Delavallée e7905b820d [REF] calendar: clean strange email send code
Purpose: clean mail.mail creation code and use standard mail creation or
template send_mail method.

In calendar there was strange code creating an email based on a template
then updating some values on its mail.message record created through
inherits. It seems simpler to correctly set some specific email arguments
to MailTemplate.send_mail() method and avoid this kind of code construction.

Related task ID 1965040
PR #32459
2019-04-05 14:05:31 +00:00
Thibault Delavallée 742effec8d [FIX] mail_template: correctly compute / update attachment_ids in send mail
Attachments when generating an email based on a template are done in two
steps, see notably [1]. However mail generation replaces attachments using
a 6 command. This means existing attachments given through email_values
are not correctly managed and this leads to invalid command given to the
m2m field.

This commit fixes that by correctly generating a list of commands, using
4 (add) for new attachments coming notably from reports linked to the template.

Related task ID 1965040
PR #32459

[1] https://github.com/odoo/odoo/commit/f789005c9a6c26322565a1af7cc4e57a60eab9f0
2019-04-05 14:01:13 +00:00
Christophe Monniez f60636aefa [IMP] web_tour: add a startTour helper on odoo
As a start_tour helper was added on the python side (PR #32316),
a javascript helper counterpart was needed as suggested on the PR.

closes odoo/odoo#32441

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-04-05 08:53:14 +00:00
Darshil Trivedi bedfaac989 [IMP] point_of_sale: point of sale onboarding improvement.
- Improved description of point of sale application
- Removed status from card like 'In Progress' and 'Unused'
- Click on top-right corner of POS kanban card, it shows 'Sessions' and 'Sales Orders', now it will shows 'Orders' and 'Sessions'. (for usability purpose).
- Improved Multi-Currencies wording same as invoicing
- Removed 'Advanced Currencies Setup' from settings(when clicking on 'Multi-Currencies').
- Improved list view label on 'Point of Sale'.
- Added 'PoS Product Categories' feature in 'Restrict Available Product Categories'.
- In PoS config setting, 'Pos Interface' string is put instead of 'Order Interface'.
- Filter and display issues were there when setting 'Currencies' from 'Multi-Currencies', now it is resolved.
- String 'PoS Product categories' is put instead of 'PoS Category', as it seems meaningful.
- 'Restrict Available Product Category' is ticked but any category is not selected (it means it is kept blank), then all categories are shown at POS screen.
- Allow to set default category from the available categories
- 'iface_start_categ_domain_ids' is removed because domain for 'iface_start_categ_id' is given directly in the model. So 'iface_start_categ_domain_ids' will not be required anymore.

 This commit is related to task id: 1925458

closes odoo/odoo#30808

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-04-04 12:34:01 +00:00
Shreya Modi c7c0221a48 [IMP] Delivery: Hide shipping button
On a sale order, if all for product are services, we hide
the delivery related button ('add a shipping cost' and 'recompute delivery price')

Task : 1940491

closes odoo/odoo#32145

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-04-05 06:59:03 +00:00
Juhil Somaiya 6f42b5ed0f [IMP] website_sale: make 'description_sale' editable in frontend
With this commit, `description_sale` is now editable in frontend.
We also display a clear placeholder to warn user that anything in this field
will be reflected on backend document (SO/Invoices).

task-1951231

closes odoo/odoo#32206

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-05 04:50:32 +00:00
Sébastien Theys 1b8b76cf7a [IMP] tests, *: add start_tour helper
Enterprise counterpart of https://github.com/odoo/odoo/pull/32316

closes odoo/enterprise#3987

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-04-04 08:45:38 +00:00
Sébastien Theys df7326f0be [IMP] tests, *: add start_tour helper
Before this commit, the syntax to start a tour was extremely verbose.
With this new method, it is possible to start a tour by just giving the
essential parameter: the tour name.
The full set of features from browser_js are kept by using **kwargs.

closes odoo/odoo#32316

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-04-04 08:44:59 +00:00
Robot Odoo 7529bd35fa [MERGE][IMP] sale_*: report and portal fine tuning
This merge changes lot of small things in sale modules. The 3
main points are
- Sales Orders form view: reorganize fields for a better usability
and renaming labels
- Sale PDF report: renaming labels and titles, moving some report section
- Quotation Portal: improving style, moving section and renaming labels

Task-1920476

closes odoo/odoo#30550

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-04-04 16:28:14 +02:00
asa-odoo fb2fc0b3d8 [IMP] sale, account, purchase, repair, POS, delivery: shorter fields label
In described Modules, there are some fields label like Unit of measure, Discount,
Ordered Quantity, etc... in views(list,form), report and portal, that are messy
and barely readable when lots of features are installed.

Purpose of the task is to shorter that all fields label to make clean view in
order to make it more readable without getting labels uselessly spread out on
several lines

Related to task #1933746
Closes #31962

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-04 09:38:18 +00:00
Prakash Prajapati f5628b1b8d [IMP] sale: Improve the Sale order mail template.
Rename the attachment file name.

Restore the option : have the name of the customer who viewed the quotation on the email notification

TaskID: 1920476

closes odoo/odoo#30550
2019-04-04 08:59:01 +00:00
Prakash Prajapati c76c93a9ac [IMP] sale, website_sale, *: Improve the sale order form.
Relabel placeholder of terms & conditions.

Restructure tab "Other Information".

Improve the tooltips.

TaskID: 1920476

closes odoo/odoo#30550
2019-04-04 08:59:01 +00:00
Prakash Prajapati 407834d1ca [IMP] product: “Public Price” into “Sales Price” in the pricelist.
TaskID: 1920476

closes odoo/odoo#30550
2019-04-04 08:59:01 +00:00