Commit Graph
127612 Commits
Author SHA1 Message Date
Robot Odoo 1af67ffdfa [MERGE] website_slides: improve layout of courses main pages and apply various fixes
Purpose of this merge is to provide several fixes related to new elearning
application [1]. This is second batch of fixes [2]. Those are mainly fixes
and improvements for front-end templates: layouting, clean design. Some
other fixes are also included, notably links and search capabilities.

See sub commits for more details.

Thanks to @awa-odoo @jem-odoo @stefanorigano @qmo-odoo @dbeguin
for their work as most of code come from cherry-picks.

Merge linked to task ID 1941250.

[1] eLearning feature: see task ID 1902304
[2] First batch of fixes landed at 5cec06b179

closes odoo/odoo#31317
2019-02-21 18:29:32 +01:00
Christophe Simonis b2db72c9d1 [FIX] core: handle multiple m2o levels in Form
closes odoo/odoo#31335
2019-02-21 17:03:27 +00:00
Christophe Simonis 644aeb2cd6 [FIX] test_testing_utilities: correct on_change
Avoid searching `[('name', 'ilike', False)]` as it doesn't make any
sense (and behavior changed in saas~12.1)
2019-02-21 17:47:46 +01:00
jem-odoo 039df4a79e [FIX] website_slides: fix vote widget
Fix route of vote widget. Set it to auth=public so that instead of a crash
we have correct popup asking to login. Better than a SessionException, which
will not be displayed.

Another fix is done to avoid having one widget for all displayed like / dislike
buttons. Each slide should have its own vote widget.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:39:56 +00:00
Thibault Delavallée fdc36c5c37 [IMP] website_slides: improve main course page in documentation mode
Purpose is to clean a bit the card layout in documentation courses, notably

 * better layout for cards:
 * fetch (in controller as slides in course display are sudo-ed to display
   a card even if current user has no access) completion data and display it;

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:20 +00:00
jem-odoo 95ab97c2f3 [FIX] website_slides: reload page when joining channel
When a user join a channel, the button 'join' changed and indicates
him that he is now member, but since the page is not refreshed, he
still can not access to slides displayed on the page.
This commit makes the widget trigger a page refresh.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:17 +00:00
jem-odoo 1a89a3fcc4 [FIX] website_slides: bad xml ids on fields
Having bad xml ids, even on groups fields, causes crashes, even
when duplicating a record.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:16 +00:00
jem-odoo 7d1af42c06 [FIX] website_slides: fix some rating issues
Last review should be a comment. When fetching the last message on a course
the returned message can be a system notification (like "Channel created").
This is not what we want, mostly with the feature allowing to modify the body
of a message. This commit add restriction on the domain fetch last message.

Fix default rating value on popup widget. The conversation ratio (rating 1-10
and 5 stars) was not applied everywhere. So, the number of displayed stars was
doubled. This is now fixed.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:14 +00:00
Aurélien Warnon 55f93a240f [FIX] website_slides: handle "My courses" to filter user's channels
Purpose: the "My courses" button on the slides home page now redirects the user
to the list of channels for which he is a member of.

In this commit we also clean a bit controller code to remove support of
category_id which makes no sense on a page displaying courses as categories
are not cross-courses, only course-specific.

A clear search icon is also added.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:11 +00:00
Aurélien Warnon 9f74ccf403 [FIX] website_slides: fix some styling issues on training course page
This commit do some small UI adjustment:

 * remove a potential doubled <hr/>;
 * remove a "mb8" to make views consistent whether you're a channel publisher
   or not;
 * add a specific parameter to see 'uncategorized' slides on a documentation
   channel as /category is a slug and does not allow Falsy values;

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:04 +00:00
sri-odoo 0a73e14805 [REF] website_slides: improve design of "all courses" main pages
Containing notably

 * improve banners;
 * sidebar achievement design;
 * some sidebar adjustments;
 * adapt to circular rank progress the current user sidebar;
 * improve overall spacing;
 * improve cards design and size;
 * improve 'all courses' grid layout;
 * clean unused css and templates;

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:00 +00:00
sri-odoo 920a48b32f [REF] website_profile: add circular rank progress
Purpose of this commit is to add a circular progress around the rank of
a user when seing its profile. It allows to see at a glance advance for
next karma rank.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:37:58 +00:00
Fabrice Henrion 45bb68db0a [IMP] website_profile: improve wording and fix typos
Manual backport of commit done in master at 20e48b84f8. It is interesting
to have those fixes in 12.2.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:37:55 +00:00
Thibault Delavallée e85c99c145 [FIX] gamification: improve next rank icons
Background of icons should be transparent.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:37:52 +00:00
Thibault Delavallée 026663fb2b [IMP] website_slides: slightly improve demo data
Some addition to demo data, notably some members and a few more slides.
I bet there will be other commits improving demo data, one slide at a time.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:37:47 +00:00
Christophe Simonis 1d2b6f1bef [MERGE] forward port branch 12.0 up to 84143a34b3 2019-02-21 15:37:19 +01:00
Christophe Matthieu d5468974f7 [FIX] web_editor: trigger blur when click in an other iframe
Issue: in studio, when the user click in the iframe instead of click on
an other menu (on left sidebar) the editor does not trigger blur event,
the content are not saved.

closes odoo/odoo#31331
2019-02-21 14:25:57 +00:00
Toufik Ben Jaa f907ffdeb9 [FIX] hr_payroll: allow to request leaves
- When having multiples contracts, at least one open and one closed, we may
  not be able to request a leave.

  This issue is triggered if the closed contract has no end date.
  The code checks if the leave you try create overlap over multiple contracts.
  But if a contract has no end date and is closed, the check may never
  succeed.

  So if a contract has no end date and is closed we don't take it in
  account.

closes odoo/odoo#32909

Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>
2019-05-02 11:34:36 +00:00
Denis Ledoux fd0a10026c [MERGE] forward port branch saas-12.1 up to b11930047f 2019-05-02 09:45:14 +02:00
Antoine Guenet 27eb8ba617 [FIX] web_editor, website: never indent/outdent list groups
The "comparisons" website snippet uses a list group with the class set
on a UL. In consequence, the web editor considers it as a regular list
and may try to outdent it, which is not the expected behavior with a
list group. This fix ensures that ULs with the `list-group` class cannot
be in/outdented.

closes odoo/odoo#32709

Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
2019-04-25 10:03:14 +00:00
Antoine Guenet cb9263a823 [FIX] web_editor: properly merge a LI with text with a LI with text in P
A list item with text can be written as <li>text</li> or as
<li><p>text</p></li>. Issues occurred when both syntaxes need to be
merged together. Namely, the <p>text</p> was being appended to the other
list item, thereby creating a visible new line.
2019-04-25 10:03:05 +00:00
Antoine Guenet 41088bb311 [FIX] web_editor: properly handle delete in nested lists of all syntaxes
This addresses various bugs that occured with nested lists - including
lists that are nested with a UL within a LI (as opposed to a UL directly
within another UL).
2019-04-25 10:03:00 +00:00
Antoine Guenet 8e89ffb175 [FIX] web_editor: properly convert a checklist to an ordered list
The `o_checklist` class was preserved when converting a checklist to an
ordered list.
2019-04-25 10:00:43 +00:00
Martin Trigaux 91b6c1076c [FIX] base: use correct code for Filipino
Backport of 6d9862f860 to saas-12.2

Instead of fil - fil_PH, it should have been fil_PH - fil.

closes odoo/odoo#33040

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-30 09:17:25 +00:00
Odoo Translation Bot 01a5464509 [I18N] Update translation terms from Transifex 2019-04-28 06:07:42 +02:00
Sébastien Theys 26d951f7e1 [IMP] base,product,website_sale: move image fallback mixin -> variant
Backport of d3d58b60dc

Only the variant is using this code, so it was a bad idea to make the mixin
more complicated than it had to be.

Update the image tests to make sure this is working correctly. The test were
only testing the size of the images, now they also test the actual content.

Part of task-1949729

Original PR: odoo/odoo#32253

closes odoo/odoo#32814

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-25 09:01:46 +00:00
Antoine Guenet fe2496350c [FIX] web_editor: properly paste text in non-HTML fields
This resolves an issue with pasting in text only mode (no HTML): the
list of nodes to paste was being modified with the `_mergeAdjacentULs`
method which is irrelevant to text nodes. Because of that, a corrupted
list of nodes was inserted into the DOM.

opw-1962743

closes odoo/odoo#32454

Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
2019-04-25 11:33:00 +00:00
Toufik Ben Jaa c42ccf2ca7 [FIX] lunch: performance issue when retrieving lunch orders
- When retrieving lunch orders for specific users, the search could take a
  long time to be resolved.

  To fix this issue we rewrote the SQL View that retrieves the
  information for lunch orders.

closes odoo/odoo#32908

Signed-off-by: Denis Ledoux <beledouxdenis@users.noreply.github.com>
2019-04-24 09:56:09 +00:00
Aurélien Warnon 8c145f6407 [IMP] (website_)survey: hide header/footer when taking a certification
Purpose
=======

We need to hide header and footer of survey and website layouts when
the user is taking a certification ("certificate" field of survey.survey).

This is done to have a more "immersive" taking and avoid that the user
clicks on other links in the layout header or footer and moves to another page.

closes odoo/odoo#31503

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-24 06:40:24 +00:00
8bcb17b674 [FIX] web: grouped Kanban: traceback on click during reload
Have a grouped Kanban view with an x2many field. Interact with the
searchview, and then click anywhere.

The fetch of the x2many relational data is batched for the whole view
a single RPC for all groups) since e10fd346.

If the click occurs before all search_read are done (i.e. before the
fetch of relational data is started), there is a crash.

This is due to a call to get({raw: true}) to obtain the current model's
state, which is currently being reloaded and in an intermediate state.
Ideally, this shouldn't happen, but with the sync API of get, we can't
change that easily. So at most, we can ensure that it doesn't crash.
Moreover, sensitive functions requesting the state for the data can do
that in the mutex to ensure that the state isn't currently being reloaded.

Related to Issue: 1937149

closes odoo/odoo#32587

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>


Co-authored-by: Mohammed Shekha <msh@openerp.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>
2019-04-24 07:07:41 +00:00
Aurélien Warnon 11b24c6b45 [IMP] website_sale_slides: improve course purchase flow
Slight improvement to the course purchase flow that directly redirects the user
to the checkout process when he buys a course.

closes odoo/odoo#32649

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-23 13:46:43 +00:00
Robot Odoo 96e3442c32 [MERGE][FIX] website_(sale)_slides(_survey): apply various UI fixes and improvements
Purpose of this merge is to provide some fixes and tweaks related to design
of eLearning application. Notably this merge provides fixes for mobile
display, forum integration, certification-specific design and some cleaning
in SCSS and bootstrap customizations. See sub commits for more details about
them.

Linked to task 1958372
Related to PR #32648

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-23 13:07:31 +02:00
sri-odoo 3d463640fc [IMP] website_slides_survey: add a specific background for certification channels
This commit introduces a specific icon/design for certifications. It is applied
to channels having at least one slide of certification type.

Linked to task 1958372
Related to PR #32648
2019-04-23 09:40:35 +00:00
sri-odoo cf0d12a9f4 [FIX] website_slides_forum: fix navbar overflow and mobile bg
Linked to task 1958372
Related to PR #32648
2019-04-23 09:34:52 +00:00
sri-odoo 8b61a4d18c [FIX] website_sale_slides: tweak and fix course price
Purpose: clean display of price for payment-based courses.

Linked to task 1958372
Related to PR #32648
2019-04-23 09:34:49 +00:00
sri-odoo 6867f7ba9f [FIX] website_slides: fix display of 'All Courses' menu in mobile
Purpose: clean and fix display of All Courses menu in mobile

Linked to task 1958372
Related to PR #32648
2019-04-23 09:34:43 +00:00
sri-odoo e5c7e43c71 [IMP] website_slides: reduce bootstrap customization and improve circular progress design
Purpose: reduce some customization and ease eLearning link with themes. For
that purpose use the body class name propagation recently added.

Linked to task 1958372
Related to PR #32648
2019-04-23 09:34:42 +00:00
sri-odoo e621e728e4 [IMP] website_profile: reduce bootstrap customization and improve circular progress design
Purpose: reduce some customization and ease eLearning link with themes. For
that purpose use the body class name propagation recently added.

Also mask the initial part of the circular progress, removing the border
radius effect.

Linked to task 1958372
Related to PR #32648
2019-04-23 09:34:41 +00:00
sri-odoo e59c034bf5 [IMP] website: allow to set custom class on body in frontend layout
Purpose: allow <body> to accept other classes rather than just the
'o_connected_user' one. It is useful notably to tweak the display of some
pages without breaking themes.

Linked to task 1958372
Related to PR #32648
2019-04-23 09:34:38 +00:00
Odoo Translation Bot 8815f9744c [I18N] Update translation terms from Transifex 2019-04-21 06:08:14 +02:00
Antoine Guenet 17aff7b59b [FIX] web_editor: uncheck new checklist item on split
On ENTER in a checklist item, a new checklist item is created. The new
one should never be checked. This ensures that ENTER in a checked
checklist item never creates a checked checklist item but instead cleans
the class.

closes odoo/odoo#32684

Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
2019-04-15 11:40:05 +00:00
Dharmraj Jhala 8b31b3b18d [FIX] event: fix traceback while downloading ics file
Currently while downloading ics for an event, it gives
traceback due to improper handling of kwargs.

It was introduced from https://github.com/odoo/odoo/commit/a03faab03fdf8a164c2f1298cc138b3fa83b0bea

This commit fixes the issue by properly handling
kwargs in the method definition.

task-1938637

closes odoo/odoo#32750

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-04-18 05:22:34 +00:00
Sapan Zaveri 41b1333a38 [FIX] payment_payulatam: Fix error while making payment
In https://github.com/odoo/odoo/commit/e21f185d3c6a3bac3a1a7ba482df4d6cf616a159 acquirer_reference is changed to reference for payment,
but while validating the payment values there is still acquirer_reference so it's giving traceback

Now changed acquirer_reference to reference while validating payment and
check proper transactionID with acquirer_reference.

Task-ID: 1964073
closes: #32439

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-04-05 09:38:38 +00:00
Xavier-Do b583b118f8 [FIX] mail: find direct partner from right channel
Previously, when getting channel info, it was possible that the
channel name was the name of the partner of another channel.

This bug was introduced with 975164473c

closes odoo/odoo#32730

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2019-04-12 12:36:52 +00:00
Christophe Simonis fdd0179f4f [FIX] l10n_be_hr_payroll_fleet: inherit from direct parent view
This avoids being dependent on the order of records returned by PostgreSQL.

closes odoo/odoo#32689

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-04-15 12:43:26 +00:00
Odoo Translation Bot 85f5a98ea5 [I18N] Update translation terms from Transifex 2019-04-14 06:08:11 +02:00
qmo-odoo 7c8834459e [IMP] website_slides,_profile: Improve elearning UX
This commit changes:
  - In elearning homepage, change "Heroes of the week"
    to "leaderboard of the week"
  - In user profile, change "Rank: Master" to
    "Current Rank: Master"
  - In the "Edit Profile" view, remove the required
    on the description text area

Task: #1961116
PR: #32621

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-11 15:02:13 +00:00
David Beguin a515e21b6e [FIX] website_profile : set badge image instead of badge level icon in badge page
Set badge image if any instead of forcing badge level icon in badge page.
If badge has no image, use the badge level icon. And if no badge level, show default placeholder icon.

Task ID: 1961700
PR #32255

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-03-29 14:46:57 +00:00
Lucas Lefèvre 0a76be740b [FIX] hr_presence: Fix duplicate xmlid
Commit d77ce4c introduced a new inherited kanban view
for employees.
However an other kanban used the same xmlid.
Only one is loaded.

This commit changes the xmlid for the new kanban view.

closes odoo/odoo#32567

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-04-10 15:13:53 +00:00
Priyanka Kakadiya 078c209650 [FIX] website_sale_slides: correct demo data file path
Correctly set demo in demo instead of data.

Related to Issue: 1965630

closes odoo/odoo#32481

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-12 08:25:48 +00:00