Issue:
======
When we have a product with `out of stock:continue selling` disabled,
accessing the shop page will give an access error.
Steps to reproduce the issue:
=============================
- Make sure to have a storable product with `out of stock: continue
selling` disabled in the sales tab of the product.
- Log out and go to shop
- Access error related to warehouse records
Origin of the issue:
====================
The function `_website_show_quick_add` being called from the template in
odoo/addons/website_sale/views/templates.xml to display the shopping
card button in at the bottom of the product. Since the user is public he
doesn't have the right to access the record in warehouse to see if the
product is out of stock or not.
The test `test_back_in_stock_notification_product` already tests the fix
and doesn't work without this fix , so no need to add extra test.
opw-3620172
closesodoo/odoo#145916
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
The issue of the start date appearing before the task name in the project task
list view is caused by a duplication of the company_id in the list view
definition. Consequently, this problem is linked to the task with ID 3213526.
task-3468392
closesodoo/odoo#145856
X-original-commit: ff384b259808f3106daea7de685f5501c13ebf2d
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Description of the issue/feature this PR addresses:
When selecting the "group by date" option in the timesheet portal view, a
traceback error occurs.
Fix:
This PR addresses the traceback error by improving the handling of recordsets
when grouping by date.
task:3468392
closesodoo/odoo#145854
X-original-commit: f244a0685ceeff24edd4b6ab4a2213298dbf8621
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Before this commit, when `mrp_account` module is installed, a new report
to print is added in all views of `account.analytic.line`. the problem
is since timesheet model is `account.analytic.line` then that report
is available in the timesheets views and when the user chooses that
report to print in a timesheet view then he will get a traceback
because that report does not for the timesheet record.
This commit hides `WIP` report in the print menu when the view displayed
timesheets records only. That is all the views in the timesheets app.
task-3465424
closesodoo/odoo#145597
X-original-commit: https://github.com/odoo/odoo/pull/132005/commits/b293a6c9a5b2f7fb3a0c7624eccf5406c71521f1
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Steps:
- Install mrp_account and hr_timesheet modules
- Got to timesheet > my timesheet list view
- Select multi timesheet (AAL with different AA)
- Click on print action
- Print WIP report
Current behavior:
The WIP report currently assumed the AALs selected are linked to the same AA
and use the name of the AA to complete the title of that pdf report.
But since it is not really the case, all the time since it depends on the user
selection then the user could get a traceback without knowing why and could
think that report does not work when many AALs are selected.
Solution:
If many AA are contained then map the names and join the name with `, `
to display the name of each AA in the title of that report.
task-3465424
x-Original-commit=https://github.com/odoo/odoo/pull/132005/commits/4256ea305e1388ff6e39e936c2a864c6579e7e0d
Part-of: odoo/odoo#145597
Currently there is the following issue with cached conversion rates
from the "from currency" to the "to currency".
When the rate of the res_currency_rate of the "to currency" changes the cache is not invalidated.
Thus the cached value may be used wrongly (leading to wrong results).
This commit simply invalidates all the cached rates in case we update or
create a res_currency_rate.
closesodoo/odoo#143847
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
Steps:
- Install `contacts` and `l10n_se`
- Open swedish contact in `contacts`
Address are in this format
```
{street}
{street2}
{city} {state_code} {zip}
{country_name}
```
instead of
```
{street}
{street2}
{zip} {city}
{country_name}
```
opw-3393569
closesodoo/odoo#142832
X-original-commit: c49e6a97463945cdb449fad78253ed5e3c80cd11
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>
When using a loyalty program reward with a discount on a specific
product category in PoS, it was not being applied correctly.
The reward contained a discount_product_domain with the category ids.
However in PoS the many2one fields are replaced with the
corresponding values https://github.com/odoo/odoo/commit/e7632a3bcfa60fa416fff5e2e9daaf2571c5f7f1.
To fix this, I replace the ids in the discount_product_domain with
the category name values before sending to the PoS.
opw-3502703
closesodoo/odoo#145016
X-original-commit: 494a07251c23dd7e30980dd5a455f1b37daea16f
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
See commit [1] for in-depth explanation and framework-js change but
basically, `renderToElement` do not allow multiple root nodes since
[2].
The fix is just about using the correct method to render multiple root
nodes. Without the fix, it just crashed when you click on the page
dependencies links.
Step to reproduce:
- Go to /
- Open Page Properties
- Edit / to /test
- A list of possible dependencies will be shown, it's a link that can be
clicked to open a tooltip to have more details
- Clicking on it crash without this commit
[1]: https://github.com/odoo/odoo/commit/2cff7e4094ebb4b56ab17a1462ff358b4b3e7ffd
[2]: https://github.com/odoo/odoo/commit/6303a3eacdca012649a2ffda627b65c17a7217f1closesodoo/odoo#145715
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
The test tries to import data from an sql file.
The problem is that it is trying to import partners, but when
the test is ran with the l10n_co localization, one of the required
field is not filled.
We just change the model to import to avoid the issue with the
missing required field.
Linked to runbot error 32740, 32742, 32745, 32738
closesodoo/odoo#145708
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
The "Scan your badge" login option was not working properly when trying
to log in to the POS shop.
The barcode scanner styles were missing which caused the issue.
opw-3608077
closesodoo/odoo#145627
X-original-commit: 075fd9f7408aaced3beb6b50b5bf5d28472956e7
Related: odoo/enterprise#52464
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
Current behavior:
Firefox customer display was not correctly loading the CSS and the display was not correct.
Steps to reproduce:
- Setup an IoT box with a customer display
- Open the IoT box customer display in Firefox
- Link the customer display to a POS
- Open the POS and add some products to the order
- The customer display is not correctly displayed
opw-3509606
closesodoo/odoo#145839
X-original-commit: 3bebc6caaccb08cc8f856b42bd635fafc9a1c4a2
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
Signed-off-by: Robin Engels (roen) <roen@odoo.com>
This commit simply replaces the shortcut for the action_done_schedule_next
buttons from alt+q to alt+z in the activity view dialog because the alt+q
shortcut is already used for the Save/Schedule buttons. This overlap was
introduced by mistake in https://github.com/odoo/odoo/commit/6c412be2ea7c0fb64677152db753a1007934f892
opw-3565747
closesodoo/odoo#145838
X-original-commit: c2a0db9ce18c00a17fd93f87434d3d3a7a2630fe
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Julien Carion (juca) <juca@odoo.com>
Before this commit, the default picture (when no picture is set to a product) has been
changed for `product.template` but not for `product.product` in commit 0625434
This commit also applies the changes in `product.product` to have the same default
picture than `product.template` when there is no picture set on the product.
task-3484150
closesodoo/odoo#145831
X-original-commit: 40ee98e7b96bbd7d92f1bc085389e98fb43fd8d1
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
To reproduce
============
- go on any record with list view (for example a Quotation)
- Check many hidden fields in the list view to show them
- The dialogue box for checking and unchecking hidden fields moves
with the horizontal scrollbar, sometimes even going off screen.
Problem
=======
the position of the dropdown menu is computed using the position of the toggler
butoon, so if this button moves the menu moves with it
Solution
========
make the toggler button sticky so it's always visible and the dropdawn menu
will keep same position.
opw-3589726
closesodoo/odoo#145784
X-original-commit: 6fb2619866893b47c8cb947a40f3457625960a5c
Signed-off-by: Bastien Fafchamps (bafa) <bafa@odoo.com>
Signed-off-by: Abdelouahab Laaroussi (abla) <abla@odoo.com>
Current behaviour:
When removing the ribbon from a product,
the other ribbons are removed as well.
Steps to reproduce:
1. Go to website
2. Go to Shop
3. Click on Edit (top right)
4. Add a ribbon to multiple products
5. Click on Save
6. Select a product with a ribbon
7. Remove the ribbon
8. (other ribbons are gone)
Cause of the issue:
Reverting fix introduced by https://github.com/odoo/odoo/commit/5d13fa522e7d06b03a098ada5fa6be15ddc49618
t-out was modified into t-field to be considered dirty when modified.
but when removing a ribbon, t-field is set as empty,
which overwrites ribbons html value.
opw-3487397
closesodoo/odoo#145864
X-original-commit: 71bdf1f674d0340a726dba96c65af6fdff25822f
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Steps to reproduce:
- Make an invoice and setup the layout of the document
- A preview will be displayed
- Make the invoice and download it
Issues:
The layout of the preview and the invoice doesn't match the updated layout from commit 3764914c86.
Solution:
Correct the view of the report templates.
opw-3584286
closesodoo/odoo#145815
X-original-commit: 778cc239010f3bb8618824fdaf06cb19922d6498
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Steps to reproduce:
- Install Accounting app
- Go to the Accounting app
- Go to Configuration > Chart of Accounts and create a New account with a name containing %
- Go to Accounting > Journal Items
- Select a Jounral item and from Actions, choose move to Account
- In the popup displayed, choose the new account created ealier in the To field, and choose a Journal
- Click `Create Journal Entries`, an error arises
Invistigation:
When the `account_target_name` contains a % literal (ex. "test %"), the `transfer_format` beccomes `"{amount} ({debit_credit}) from %s were transferred to <strong>test %</strong> by {link}"` https://github.com/odoo/odoo/blob/a56586119845969e9d867a220f5330a6c7daa5c2/addons/account/wizard/account_automatic_entry_wizard.py#L429-
- You can notice that now the string has two % placeholders that need two be substituted, but only argument is provided which is `account.display_name` and so we get a the error `TypeError: not enough arguments for format string` https://github.com/odoo/odoo/blob/a56586119845969e9d867a220f5330a6c7daa5c2/addons/account/wizard/account_automatic_entry_wizard.py#L433
opw-3601886
closesodoo/odoo#145762
X-original-commit: 1582a0ae28fec12175845dcfdebbb8d6b4bcde33
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Ali Hassan Youssef (alhy) <alhy@odoo.com>
Steps to reproduce:
- install the e-commerce module
- in General settings, add and switch French -or any- language
- Go to website
- Under e-commerce > product in the menu bar
- click on any product
- click on go to website smart button
- click on edit button to edit the website page
- choose any block to insert, You can notice the message (DROP BUILDING BLOCKS HERE TO MAKE THEM AVAILABLE ACROSS ALL PRODUCTS) stays in English
Investigation
- The message is not add to website_sale.pot file, as the message string passed to an attribute not an actual string inside a tag.
opw-3573881
closesodoo/odoo#145755
X-original-commit: 9a595cd19fba3a68dacd5159d0b04102bc76cadf
Signed-off-by: Ali Hassan Youssef (alhy) <alhy@odoo.com>
Issue:
The _predicted_field is still slow after refactor.
Analyze:
Due to the refactor of the query made in account_move.py
_predicted_field, an index is needed on partner_id.
Fix:
Add an index on partner_id Many2One.
Note:
The previous PR has already been merged
https://github.com/odoo/enterprise/pull/50911 but without the index it
is not as fast as expected. This index had been added by
hand.
Benchmark:
| # Input data | Before PR | After PR |
|:-------------:|:----------:|:---------:|
| 30M | 22.827 s | 18.59 ms|
Related task:
opw-3539632
closesodoo/odoo#145836
X-original-commit: 50ecb11320c739f734641cf912902f5620dd891d
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Benjamin Hanquin (beha) <beha@odoo.com>
The aim of this commit is to fix runbot build error.
Before the commit:
The test could fail if the EUR currency was inactive
After the commit:
The test activate the currency first
closesodoo/odoo#145817
Runbot-error-build: 51509
X-original-commit: 09808f2c91985263090cb9bd38b34d3443a2d7d7
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
The accuracy "Product Unit Of Measure" does not exist, it is "Product Unit of Measure"
closesodoo/odoo#145805
X-original-commit: 8a8a3720bf2ed938dddc1c5889b4207562381234
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Before this commit:
The readonly readonly modifier of the statusbar field was not taken into
account when the "clickable" option was set.
After this commit:
Even if the "clickable" option is set to true, if a readonly modifier is
set, it will prevent (or not) changing the stage of a status bar.
closesodoo/odoo#145766
Opw: 3222998
X-original-commit: 9e1d01bc44e5e90ed2b809cfadbd05a5793b3c07
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Bastien Fafchamps (bafa) <bafa@odoo.com>
Steps:
- Install timesheet_grid.
- Start the timer.
- Try to add new task without selecting project.
Issue:
- We can create a new task and afterwards the task would have the projects as
private.
Fix:
- We are taking the canCreateEdit option from props.
task-3378532
closesodoo/odoo#145760
X-original-commit: a92d7d5a92d84074e1d4b0511051c906953c5003
Related: odoo/enterprise#52518
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Currently Team Expense Approver have full access to journal, we
shouldn't do that
closesodoo/odoo#145737
X-original-commit: 9078b6cf4770c8b3b42bde8e36c4eff5f924c7bd
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
Steps to reproduce:
- Decimal Accuracy for Product Price > 4 digits
- Purchase a product using a price (1.2345 in my example)
- Go to Purchase > Reporting
- Enable the List View
- Add the field Average Cost (price_average)
- This displays as just two decimals
Note:
can be edited with studio but you can just add the field "price_average"
to the "purchase_report_view_tree" view xml
Fix:
round using product price Accuracy
opw-3560792
closesodoo/odoo#145667
X-original-commit: d5a3430cecb673a06057673d0671228449fa3f60
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
Since the update in https://github.com/odoo/odoo/commit/d4b366f2d741f2087a947d61d7e0618492cc2bf1, the POS loyalty program stopped
printing customer names on receipts for transactions without points won
or spent. Originally, printing a loyalty program also included the
customer's name, which users relied on to print the customer's name
on receipts.
This commit ensures the customer's name is printed on the receipt,
regardless of whether any loyalty points were won or spent.
opw-3620536
closesodoo/odoo#145629
X-original-commit: 57037253a472b4a25e2be6622c505a08b7f207ff
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
If the current company is a branch and we're in the product form, we
will not be able to access our parent's account in the following fields:
- `property_account_income_categ_id`
- `property_account_expense_categ_id`
- `property_account_income_id`
- `property_account_expense_id`
This commit aims to fix that behavior by updating the domain to consider
branch companies too
closesodoo/odoo#145355
Task-id: 3549961
Related: odoo/enterprise#52299
Signed-off-by: William André (wan) <wan@odoo.com>
When getting a domain from activeFields in Owl, sometimes the value
passed is not a list or function.
When the field mentioned have a `check_company=True` in the
initialization, the domain passed will be in a form of string instead of
a list.
This commit aims to publicize the domain handler in Field so that it can
be used anywhere by calling the function, as getting field's domain is
getting increasingly common
Task-id: 3549961
Part-of: odoo/odoo#145355
Before this commit, if a new order was created with an existing
pos_reference, it would not be captured even though it was a completely
new order. This occurred because pos_reference was assumed to be unique.
However, there have been several customer reports of orders not being
captured when the receipt contains a pos_reference that already exists.
Some bugs causing duplicate pos_references were found but the root cause
remains unclear.
With this commit, orders are now synced even if pos_reference matches a
previous order. This prevents lost orders and allows customers to access
all their receipts via pos_reference lookup.
An investigation into the cause of duplicate pos_references needs to
continue, but this change unblocks the more serious issue of missing
orders.
opw-3499011
closesodoo/odoo#139974
X-original-commit: 269702891980eb56ddc83e199a9673b1e146d348
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
This commit enables support for functional color notation in CSS
(https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/color).
This new feature accommodates various color spaces utilized within the
'color()' CSS function, seamlessly converting them into an RGBA format
that is comprehensible to the right panel.
Steps to reproduce:
- Enter edit mode
- Add a snippet with a column
- Click on the column
- Set border-width to 5px, enter
=> A gray border appears but the option colorpicker shows no color
Since [this commit] the border has as default opacity of 15%. But now
the custom color in the colorpicker is correctly set.
[this commit]: https://github.com/odoo/odoo/commit/fad514ebdc25b9de03fd387a0c07dbbc274c364e
task-3536051
closesodoo/odoo#137698
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Previously, products loaded from the background included the internal
reference in their displayed name. This behavior was due to the
'display_default_code' context, which prevents the inclusion of
'default_code' in the product name, not being utilized within the
'get_pos_ui_product_product_by_params' function.
opw-3617195
closesodoo/odoo#145644
X-original-commit: b6c87e4c3451fbb554557be95788c8e1a5e0332f
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
- refund tax repartition lines lack tax grids -> added
- Outgoing credit notes lack base line grids -> should decrease total
active transactions -> added.
- Purchase taxes 0% G and 0% S should increase total passive
transactions, not increase total active transactions -> fixed
closesodoo/odoo#145636
Taskid: 3175384
X-original-commit: 114a3e3c1587a057da96d4148d61416cfd434dac
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Antoine Dupuis (andu) <andu@odoo.com>
Issue:
======
Attachment files aren't sent with the event invitation email.
Steps to reproduce the issue:
=============================
- Add any attachment to the email template : `Calendar: Meeting
Invitation` and save it.
- Go to website and book an appointment.
- Go to Scheduled Actions and run manually email queue manager to send
the notification.
- The sent email doesn't have the attachement you provided, it has only
1 attachement which is the calendar one.
Origin of the issue:
====================
The notification of the event invitation was taking only the calendar as
attachment and ignores the template attachemnt.
Solution:
==========
Now the calendar event invitation email will take into account the
attachment of the email_template.
opw-3593140
closesodoo/odoo#145628
X-original-commit: 28880c32e62b6e2e6c87c35094da0e20c6c14c21
Signed-off-by: Mahdi Cheikh Rouhou (macr) <macr@odoo.com>
This change allows to remove discounts from all sale order lines at once, by enabling 0% discounts in the discount wizard.
task-3584450
closesodoo/odoo#144244
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Steps to reproduce:
-------------------
- on ecommerce, activate "Extra Info" feature;
- go to the extra info form;
- write something for "Your Reference";
- press Enter.
Issue:
------
The Bad Request message is displayed.
Cause:
------
Pressing Enter triggers the form's default submit.
To use the controller of the `/website/form/shop.sale.order` route,
we need to apply the JS logic of the `s_website_form`
widget (the `send` function).
Solution:
---------
Add an event for the `submit` which will prevent
the default behaviour and send the form data.
opw-3591135
closesodoo/odoo#145707
X-original-commit: 14fc7f3c923847f5e052888c2cfda0bf92316972
Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
In Accounting settings set 'Cash Discount Tax Reduction' to Always
Create an invoice
Add a line with tax
Add as payment terms "2/7 Net 30"
Confirm
Click "Add a credit note" and create the credit note
Confirm
Issue: Credit note is missing the epd vals from the invocie so the moves
cannot fully reconcile
opw-3429678
closesodoo/odoo#145653
X-original-commit: f7b371be24a842392a8b46f337256ef13bf8a5ae
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Andrea Grazioso (agr) <agr@odoo.com>
Current behaviour:
When checking the overview of a normal BoM,
the product is available if component is in stock
Expected behaviour:
The product should not be available unless BoM type is kit
Steps to reproduce:
1. Go to Manufacturing
2. Go to Products > Bills of Materials
3. Create a new BoM
4. Product: p1 (and create product p1)
5. Component: p2 (and create product p2)
6. BoM type: Manufacture this product (normal)
7. Save the BoM
8. Click on Overview
9. p1 and p2 are not available (Normal behavior)
10. Go to the p2 product page
11. Click on Update Quantity > new quantity > Apply all
12. Go back to the p1 BoM
13. Click on Overview
14. p1 and p2 are available
15. p1 should only be available if BoM type is kit
Cause of the issue:
Caused by https://github.com/odoo/odoo/commit/f13b4d1ae8c12a1668222e6994dea26a27c6f5d4
opw-3601298
closesodoo/odoo#145598
X-original-commit: f34d5ef9dd2d1ad0c0acaa6a40c8ab7c517fc75d
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Antoine Demany (ande) <ande@odoo.com>
Applied fixes:
- a lot of translations were outdated, not matching official ones
- box 205 was missing
- box 289 had translation of missing box 205
- box 200 had translation of the section
- boxes 381a and 381b removed, completely outdated: we already removed all other 3X1 boxes.
- boxes 200,299,479 had wrong computation
- reordering lines to match the report
Source: https://www.estv.admin.ch/estv/fr/accueil/taxe-sur-la-valeur-ajoutee/decompter-tva/formulaires-tva.html
task-3349511
closesodoo/odoo#145328
X-original-commit: c43f34b
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Claire Bretton (clbr) <clbr@odoo.com>
If you have the backend in a language A but the website in English only,
you can:
1) modify a record's (event, product...) name in language A (say "New
Name").
2) visit the page `/new-name-11` => the server will redirect you to the
English page `/origin-11`, with the only slug that actually exists on
the website. Chrome caches the redirection.
3) give the same name in English as in language A, try to visit
=> the server now wants to access `/new-name-11`
=> Chrome uses the cache to redirect `/new-name-11` to `/origin-11`,
=> the server tries to redirect to `/new-name-11`
=> infinite loop, Chrome puts an end to it after ± 20 redirects.
In effect, Chrome injects a "Too many redirects" layout inside the
iframe, which in turn raises a CORS error when the app tries to update
it.
At the time of this commit, the flow described here should be expected
of users, because the translation UI in the backend is not clear: the
default field displayed is in language A even though the website does
not use it, and the way to update translations is not obvious (you have
to click on the language tag, which doesn't look like a button).
Another way to artificially reproduce the issue would be:
- Create a website.redirect from /dog to /cat
- Same from /cat to /dog
- Go to /@/dog
After this commit, if we detect that behavior, we reload the iframe with
a new query parameter, making the URL brand-new (and not cached) for
Chrome.
opw-3479651
closesodoo/odoo#145306
X-original-commit: 16d47ddf128f31f13e8d0d74597635faf7f9702a
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
Before, the websocket client was built manually, usign string
concatenation.
Now, urllib.parse() is used to appropriately adapt the database URL.
This update enhances security.
closesodoo/odoo#144303
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
Current behaviour before commit:
When pressing crop button, crop widget is not getting
opened and 'connection lost' notification is appeared.
This happens because in wysiwyg.js file _rpc function
does not get the proper arguments from loadImageInfo
function.
Desired behaviour after commit:
Now, _rpc function is removed from wysiwyg.js as it
doesn't need anymore and _serviceRpc is passed directly
through the props. As result crop option works.
task-3546160
closesodoo/odoo#138482
Signed-off-by: Nicolas Bayet (nby) <nby@odoo.com>
Steps:
- Open sales.
- Go to products.
- Create a new product.
- Keep the 'Can be sold' option unchecked.
Issue:
- If a product is not sellable then the user should not be able to create
invoicing policy 'Based on Timesheets' or 'Based on Milestones'.
Fix:
- We are raising the user error 'This option is only for sellable products.'
when a user tries to select any of these two options.
task-3378532
closesodoo/odoo#145631
X-original-commit: 94982163f81175c9d2d670dc28704a716696604f
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Steps:
- Open Project
- Go to Tasks > My Tasks or All Tasks
- Create New Task
- Create Project from Quick Create
- Clicking on Save, will give a Validation Error
Issue:
- Validation Error is raised and thus, we aren't able to add the project and
thus creating a task.
Cause:
- Due to the addition of context, the default_type_ids isn't obtained, and thus
the SQL error occurs as the name of the task stage isn't set which is a mandatory
field.
Fix:
- removing the context from the form view of Quick Create and set the stage
closesodoo/odoo#145599
Task: 3378510
X-original-commit: 83119d5de49ae69d08a0f798453d9c5c56b2276a
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Following fdb692c25b:
- when creating/unarchiving an employee, we should only create global
time-off of the same company as the employee itself
- when computing the working hours relative to the GTO, if we had both
calendar GTO and company GTO (not linked to a specific calendar), we
were not correctly creating calendar GTO; we should merge those
intervals intead of company GTO interval simply overwriting calendar
GTO intervals
closesodoo/odoo#145596
Task-id: 3619083
X-original-commit: 8ec0c6c106352c19e5c7b5613be2f610fa6e0adb
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
In the `onMounted` hook of the calendar renderer, the given callback
function will schedule a new function call using `setTimeout` with a
delay of 0 if some conditions are satisfied. The scheduled function will
then trigger a scroll in the calendar view to display a precise timeslot.
If the component is destroyed before the scheduled function is executed,
the scheduled function may trigger an error as the root element of the
calendar will be removed from the DOM when the component is destroyed.
This commit will fix that issue by checking that the root element of the
calendar exists before calling the `scrollToTime` function.
Steps to reproduce the error:
1. Open Knowledge
2. Open the template gallery
3. Select the template "Sprint Calendar"
4. Quickly apply the template
=> If you have the right timing: a traceback will be displayed indicating
that the function `scrollToTime` is not defined on `null`.
TO BE: No traceback should be displayed when applying the template.
task-3627780
closesodoo/odoo#145292
Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>
Mahdi Cheikh Rouhou (macr)