14 Commits
Author SHA1 Message Date
Mattis Megevand 3b3d4cb55b [FIX] portal: remove adresses box in portal
Steps to reproduce:
- Install eCommerce
- Go to My account

Issues:
There is a box "Addresses" which is useless for the moment as it's
the same page that can be accessed by clicking on "Edit information".

The feature to have multiple addresses is going to be present in master at some point, however for now we're removing the box as it's useless.

opw-3869920

closes odoo/odoo#162626

Signed-off-by: Mattis Megevand (mmeg) <mmeg@odoo.com>
2024-04-25 11:21:49 +00:00
Mattis Megevand 770e32eeb2 [FIX] portal_rating: catch error when no message submitted
Steps to reproduce:
- Install e-Commerce
- Go to your portal into a quotation
- Go to the chatter and send an empty message

Issues:
A traceback is shown

Solution:
Catch the error and discard it as the parent method is already
displaying the error message to the user.

opw-3877096

closes odoo/odoo#162424

Signed-off-by: Mattis Megevand (mmeg) <mmeg@odoo.com>
2024-04-25 11:21:48 +00:00
Mattis Megevand (mmeg) e9add31a6d [FIX] mrp,stock: compute correct quantity for stock move
Steps to reproduce:
- Install MRP
- Enable packages and multi-step routes
- Enable two steps manufacturing
- Create a component and a product
- Create a BOM for the product and add the component
- Make an MO for 100 units of the product
- Go to the picking and make a move of 20 units of the component with a
  destination package
- Put in pack
- Create the backorder and validate the transfer of the remaining
  components
- Go back to the MO

Issues:
Units reserved is wrong. The problem is when we are unpacking, we were
using result package inside the key. But what we want is to remove
quantity from the package the quantity originate from.

opw-3759006

closes odoo/odoo#160091

X-original-commit: 1cc04382f7ebaaa68ebe9313f1cd6b1284e13665
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Mattis Megevand (mmeg) <mmeg@odoo.com>
2024-04-02 17:04:48 +00:00
Mattis Megevand (mmeg) a04942c9aa [FIX] sale: disable locking of subscription sale order
Steps to reproduce:
- Install 'Subscriptions'
- Enable 'Lock Confirmed Sales' in the settings
- Make a new subscription
- Invoice the subscription

Issues:
The subscription is now locked, this behaviour is not intended.
As confirmed with the PO this settings should never affect the
subscriptions.

opw-3754106

closes odoo/odoo#159652

X-original-commit: b472c9e6f743aa467f7f4851ac95a367b364dfb1
Related: odoo/enterprise#59625
Signed-off-by: Mattis Megevand (mmeg) <mmeg@odoo.com>
2024-03-29 09:12:20 +00:00
Mattis Megevand (mmeg) 0c5b2e25bd [FIX] sale_timesheet: allow selection of SO for person with company
Steps to reproduce:
- Create a new company contact and add a contact inside that company
- Create two service product that are service with following config:
    - Invoicing policy: Based on Timesheets
    - Create on Order: Project & Task
- Make an SO for the contact inside the company with the two service in
  the order
- Confirm the SO
- Click on the smart button "Recorded"
- Click on new
- Click on new line at the "Sale Order item" column

Issues:
The list display "No records"

Solution:
Make sure that we search with the correct attributes, before we were
trying to match partner_id and commercial_partner_id.
Although similar in our case they are not equal as commercial_partner_id
represent the company and partner_id represent the individual.

opw-3750939

closes odoo/odoo#156471

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-03-08 14:30:56 +00:00
Mattis Megevand (mmeg) 5fc24f84ea [FIX] base_automation: allow multiple automation rules for same trigger
Steps to reproduce:
- Install base_automation_hr_contract and helpdesk
- Setup two automation rules with model "Helpdesk Ticket" and "On
  incoming message" as trigger
- Create a ticket in helpdesk

Issues:
Traceback is shown because `_message_post` doesn't have the origin
attributes. This is due to the closure being wrong as explained here: https://github.com/odoo/odoo/blob/e2ad568e6cd4de2d721149eb76d04f58c8510191/addons/base_automation/models/base_automation.py#L686-L691

Solution:
Encapsulate the `_message_post` function definition, so that each times
we patch message_post we patch it with a new function.
This wasn't the case before since `_message_post` wasn't isolated.
This solution is similar to the other method patched.
https://github.com/odoo/odoo/blob/e2ad568e6cd4de2d721149eb76d04f58c8510191/addons/base_automation/models/base_automation.py#L711-L734

opw-3758851

closes odoo/odoo#155596

Signed-off-by: Raphael Collet <rco@odoo.com>
2024-03-06 14:30:38 +00:00
Mattis Megevand (mmeg) cf1ead245c [FIX] account, point_of_sale: allow branches own account payment
Steps to reproduce:
- Install point of sale and accounting
- Create a branch
- Make a copy of the outstanding receipts account and change company to
  the branch
- Attach the branch to this account in the accounting settings
- Open a PoS make a transaction and close the session

Issues:
An error is displayed notifying the user that the journal entry draft is
not valid.

Solution:
Accounts that are attached to a branch should be valid for them as well
as their parents account.

opw-3659707

closes odoo/odoo#148810

Signed-off-by: Quentin De Paoli <qdp@odoo.com>
2024-03-04 17:02:42 +00:00
Mattis Megevand (mmeg) eacb2a7d51 [FIX] sale_purchase: use the associated company with SO on service PO
Steps to reproduce:
- Setup two companies and a product
- For one of the company activate "Subcontract Service" on the product
- Make an SO with the product and in Other Infos set the company with
  the one that has subcontract service on
- Confirm the SO with the company that doesn't have it on

Issue:
No PO is generated.

Solution:
Make sure we got the right context when generating purchase.

opw-3622278

closes odoo/odoo#150626

Related: odoo/enterprise#54316
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
2024-03-04 08:11:51 +00:00
Mattis Megevand (mmeg) cac7a44dd2 [FIX] sales_team: display correct alias in pipeline
Steps to reproduce:
- Create a new user with no affiliated sales team
- Activate custom mail server with an alias domain
- Login with new user
- Check pipeline in CRM
- The empty pipeline message will show the wrong alias

Issues:
The alias displayed is not for the team of the user.

opw-3608263

closes odoo/odoo#152563

X-original-commit: f862673885aa8fad9b8b225d020cd2757d7be013
Signed-off-by: Mattis Megevand (mmeg) <mmeg@odoo.com>
2024-02-06 14:29:04 +00:00
Mattis Megevand (mmeg) 980e6a53b2 [FIX] sale{,_timesheet}: Generate activity on duplicated sales order
Steps to reproduce:
- Create a service product with Project & Task created on order
- Make an SO for 1 hour and confirm it
- In the task add 5 hours of timesheet
- An activity should be made in the SO
- Copy the SO and add the 5 hour of timesheet like before

Issue:
No activity is made.

opw-3660169

closes odoo/odoo#148929

X-original-commit: 1f7844f9384e3d78599923c2487ae938de9cddfc
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Mattis Megevand (mmeg) <mmeg@odoo.com>
2024-01-11 08:46:58 +00:00
Mattis Megevand (mmeg) aed0bab7ff [FIX] purchase: always display inactive taxes on purchase order
Steps to reproduce:

- Create a PO with a tax
- Confirm PO and bill it
- Deactivate tax

Issue:
Tax is shown on bill but not on PO

Solution:
Make sure that we display tax even if inactive.

opw-3631087

closes odoo/odoo#148778

X-original-commit: 4e424750eccff168c3cbb1a3f8411b35905717f3
Signed-off-by: Adrien Widart (awt) <awt@odoo.com>
Signed-off-by: Mattis Megevand (mmeg) <mmeg@odoo.com>
2024-01-10 19:39:32 +00:00
Mattis Megevand (mmeg) 50652f265c [FIX] hr_holidays, resource: use employee time-zone for leave compute
Steps to reproduce:
- Create Allocation for 20 days for Mitchell Admin and validate (12/01 to 12/31).
- Set Working Schedule "Standard 40 hours/week" to UTC timezone.
- Set Mitchell Admin's timezone to Europe/Zurich.
- Create a time off with type Extra Time Off with dates 12/29 - 12/29 and try to save.
- Receive Validation Error: There is no valid allocation to cover that request.

Issues:
You cannot request that leave due to a timezone mismatch, even though you should be able to.

Solution:
To solve the zone mismatch we use the employee timezone to compute the
attendance intervals.

opw-3619178

closes odoo/odoo#146938

Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
2023-12-22 16:14:47 +00:00
Mattis Megevand (mmeg) ae9efe2a17 [FIX] web: match preview of invoice and its report
Steps to reproduce:
- Make an invoice and setup the layout of the document
- A preview will be displayed
- Make the invoice and download it

Issues:
The layout of the preview and the invoice doesn't match the updated layout from commit 3764914c86.

Solution:
Correct the view of the report templates.

opw-3584286

closes odoo/odoo#145815

X-original-commit: 778cc239010f3bb8618824fdaf06cb19922d6498
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2023-12-12 10:34:47 +00:00
Mattis Megevand (mmeg) 90cd47424a [FIX] l10n_eg_edi_eta: division by zero during computation exchange rate
Steps to reproduce:
- Install modules: 'account_accountant', 'l10n_eg', 'l10n_eg_edi_eta'.
- Switch company to "EG Company".
- Configure "Large Cabinet Accounting" with ETA item code "10001138" and set Customer Taxes to "VAT 14%".
- In "Journal Customer Invoices", disable "Factur-X (FR)" under Advanced Settings -> Electronic invoicing. Also, set Branch to "Deco Addict", ETA Activity Code to "Accounting, auditing, bookkeeping and tax advice activities", and ETA Branch ID to 0.
- Update "Deco Addict" with Tax ID "204899053" and set building number to 2.
- Update "Azure Interior" with Tax ID "204899052" and set building number to 2.
- In Accounting -> Configuration -> Thumb Drive, create a new record using "EG Company" with 123 as both the ETA USB Pin and Access Token.
- Manually set the certificate in the Thumb Drive record.
- Create a new Customer Invoice with Customer set to "Azure Interior", Invoice Date as today, add a line item "Large Cabinet", set the Price to 0, remove "0% taxes" and add "VAT 14%", and set Journal to "Customer invoices in EUR".
- Confirm the invoice and attempt to "Sign Invoice".

Issue:
A traceback occurs with a divide by zero error in the invoice calculation when different currencies are involved.

Solution:
Refined _l10n_eg_edi_exchange_currency_rate function to calculate the currency exchange rate. Now, it ensures the division by amount_currency only occurs when it's not zero, preventing divide by zero errors during currency conversion in invoices.

opw-3580529

closes odoo/odoo#143064

X-original-commit: 14af8243188b86a0d654298feca6dc0980cbebeb
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-11-22 07:43:11 +00:00