pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] improved to get higher score on pylint

Browse Source 
bzr revid: qdp@tinyerp.com-20090115103615-8qunbjw23fajwhxp
This commit is contained in:
qdp
2009-01-15 11:36:15 +01:00
parent 3f53a2fd6a
commit a2a55cbe31
2 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/base_module_quality/base_module_quality.py
+12 -6
View File
@@ -23,6 +23,7 @@ import pooler
import os
import osv
from tools import config
from tools.translate import _
class abstract_quality_check(object):
'''
@@ -52,24 +53,28 @@ class abstract_quality_check(object):
#Used to provide more details if necessary.
self.result_details = ""
#This bool defines if the test can be run only if the module is installed.
#This bool defines if the test can be run only if the module
#is installed.
#True => the module have to be installed.
#False => the module can be uninstalled.
self.bool_installed_only = True
#This variable is use to make result of test should have more weight (Some tests are more critical than others)
#This variable is used to give result of test more weight,
#because some tests are more critical than others.
self.ponderation = 1.0
#Specify test got an error on module
self.error = False
#The tests have to subscribe itselfs in this list, that contains all the test that have to be performed.
#The tests have to subscribe itselfs in this list, that contains
#all the test that have to be performed.
self.tests = []
self.list_folders = os.listdir(config['addons_path']+'/base_module_quality/')
self.list_folders = os.listdir(config['addons_path'] +
'/base_module_quality/')
for item in self.list_folders:
self.item = item
path = config['addons_path']+'/base_module_quality/'+item
if os.path.exists(path+'/'+item+'.py') and item not in ['report', 'wizard', 'security']:
if os.path.exists(path + '/' + item + '.py') and item not in ['report', 'wizard', 'security']:
item2 = 'base_module_quality.' + item +'.' + item
x = __import__(item2)
x2 = getattr(x, item)
@@ -87,7 +92,8 @@ class abstract_quality_check(object):
def get_objects(self, cr, uid, module):
# This function returns all object of the given module..
pool = pooler.get_pool(cr.dbname)
ids2 = pool.get('ir.model.data').search(cr, uid, [('module','=', module), ('model','=','ir.model')])
ids2 = pool.get('ir.model.data').search(cr, uid,
[('module', '=', module), ('model', '=', 'ir.model')])
model_list = []
model_data = pool.get('ir.model.data').browse(cr, uid, ids2)
for model in model_data:
addons/base_module_quality/terp_test/terp_test.py
+3 -6
View File
@@ -22,6 +22,7 @@
import os
import tools
from tools.translate import _
from base_module_quality import base_module_quality
import pooler
@@ -30,9 +31,6 @@ import re
class quality_test(base_module_quality.abstract_quality_check):
def __init__(self):
# '''
# This test checks the quality of __terp__.py file in the selected module.
# '''
super(quality_test, self).__init__()
self.name = _("Terp Test")
self.note = _("This test checks if the module satisfies the current coding standard used by OpenERP.")
@@ -94,16 +92,15 @@ class quality_test(base_module_quality.abstract_quality_check):
feel_bad_factor += 1
else:
if not res[key]:
feel_bad_factor += 1
feel_bad_factor += 1
if key == 'installable' and not res[key]: # installable tag is provided and True
if key == 'installable' and not res[key]: # installable tag is provided and False
feel_bad_factor +=1
else:
feel_bad_factor += 1
score = round((feel_good_factor) / float(feel_good_factor + feel_bad_factor),2)
# self.result += "__terp__.py : "+ str(self.score) + "/10\n"
return [_('__terp__.py file'), score]