pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[REF] spreadsheet: assign filter in history

Browse Source 
The filter can be assigned in the history directly with its
"id". No need to copy the object

closes odoo/odoo#112309

Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
This commit is contained in:
Lucas Lefèvre
2023-02-13 08:19:00 +01:00
parent 2fdacf2334
commit 68c1aad930
1 changed files with 2 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/spreadsheet/static/src/global_filters/plugins/global_filters_core_plugin.js
+2 -22
View File
@@ -72,13 +72,13 @@ export class GlobalFiltersCorePlugin extends spreadsheet.CorePlugin {
handle(cmd) {
switch (cmd.type) {
case "ADD_GLOBAL_FILTER":
this._addGlobalFilter(cmd.filter);
this.history.update("globalFilters", cmd.filter.id, cmd.filter);
break;
case "EDIT_GLOBAL_FILTER":
this._editGlobalFilter(cmd.id, cmd.filter);
break;
case "REMOVE_GLOBAL_FILTER":
this._removeGlobalFilter(cmd.id);
this.history.update("globalFilters", cmd.id, undefined);
break;
}
}
@@ -132,26 +132,6 @@ export class GlobalFiltersCorePlugin extends spreadsheet.CorePlugin {
// Handlers
// ---------------------------------------------------------------------
/**
* Add a global filter
*
* @param {GlobalFilter} filter
*/
_addGlobalFilter(filter) {
const globalFilters = { ...this.globalFilters };
globalFilters[filter.id] = filter;
this.history.update("globalFilters", globalFilters);
}
/**
* Remove a global filter
*
* @param {string} id Id of the filter to remove
*/
_removeGlobalFilter(id) {
const globalFilters = { ...this.globalFilters };
delete globalFilters[id];
this.history.update("globalFilters", globalFilters);
}
/**
* Edit a global filter
*