From 68c1aad93083bf56f4cb6800a341bbf2ee79112d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= <lul@odoo.com>
Date: Thu, 9 Feb 2023 12:24:01 +0000
Subject: [PATCH] [REF] spreadsheet: assign filter in history

The filter can be assigned in the history directly with its
"id". No need to copy the object

closes odoo/odoo#112309

Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
---
 .../plugins/global_filters_core_plugin.js     | 24 ++-----------------
 1 file changed, 2 insertions(+), 22 deletions(-)

diff --git a/addons/spreadsheet/static/src/global_filters/plugins/global_filters_core_plugin.js b/addons/spreadsheet/static/src/global_filters/plugins/global_filters_core_plugin.js
index 55704453486..cd3fb39e764 100644
--- a/addons/spreadsheet/static/src/global_filters/plugins/global_filters_core_plugin.js
+++ b/addons/spreadsheet/static/src/global_filters/plugins/global_filters_core_plugin.js
@@ -72,13 +72,13 @@ export class GlobalFiltersCorePlugin extends spreadsheet.CorePlugin {
     handle(cmd) {
         switch (cmd.type) {
             case "ADD_GLOBAL_FILTER":
-                this._addGlobalFilter(cmd.filter);
+                this.history.update("globalFilters", cmd.filter.id, cmd.filter);
                 break;
             case "EDIT_GLOBAL_FILTER":
                 this._editGlobalFilter(cmd.id, cmd.filter);
                 break;
             case "REMOVE_GLOBAL_FILTER":
-                this._removeGlobalFilter(cmd.id);
+                this.history.update("globalFilters", cmd.id, undefined);
                 break;
         }
     }
@@ -132,26 +132,6 @@ export class GlobalFiltersCorePlugin extends spreadsheet.CorePlugin {
     // Handlers
     // ---------------------------------------------------------------------
 
-    /**
-     * Add a global filter
-     *
-     * @param {GlobalFilter} filter
-     */
-    _addGlobalFilter(filter) {
-        const globalFilters = { ...this.globalFilters };
-        globalFilters[filter.id] = filter;
-        this.history.update("globalFilters", globalFilters);
-    }
-    /**
-     * Remove a global filter
-     *
-     * @param {string} id Id of the filter to remove
-     */
-    _removeGlobalFilter(id) {
-        const globalFilters = { ...this.globalFilters };
-        delete globalFilters[id];
-        this.history.update("globalFilters", globalFilters);
-    }
     /**
      * Edit a global filter
      *