pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] crm: improve visibility of partner_id field in lead form view

Browse Source 
When the crm.lead is of type 'lead', we don't want to display the
"Customer" field on the form view unless it's set (or debug mode).

Indeed, most of the times leads will not have this information set,
since when we assign a Customer we usually convert the lead to
an opportunity as well.

This means that on the lead form, we don't want to display this field
since it may be misleading for the end user.

When it's set however, we want to display it, mainly because there are
a few automatic synchronizations between the lead and its partner
(phone and email for examples), and this needs to be clear that modifying
one of those fields will in turn modify the linked partner.

Task-2596955

closes odoo/odoo#76233

Signed-off-by: awa-odoo <awa-odoo@users.noreply.github.com>
This commit is contained in:
dht-odoo
2021-10-04 11:29:51 +00:00
parent 80e8f11796
commit 67bcdbb2a2
2 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/crm/models/crm_lead.py
+19
View File
@@ -226,6 +226,7 @@ class Lead(models.Model):
# UX
partner_email_update = fields.Boolean('Partner Email will Update', compute='_compute_partner_email_update')
partner_phone_update = fields.Boolean('Partner Phone will Update', compute='_compute_partner_phone_update')
is_partner_visible = fields.Boolean('Is Partner Visible', compute='_compute_is_partner_visible')
_sql_constraints = [
('check_probability', 'check(probability >= 0 and probability <= 100)', 'The probability of closing the deal should be between 0% and 100%!')
@@ -551,6 +552,24 @@ class Lead(models.Model):
for lead in self:
lead.partner_phone_update = lead._get_partner_phone_update()
@api.depends_context('uid')
@api.depends('partner_id', 'type')
def _compute_is_partner_visible(self):
""" When the crm.lead is of type 'lead', we don't want to display the "Customer" field on the form view
unless it's set (or debug mode).
Indeed, most of the times leads will not have this information set, since when we assign a Customer we
usually convert the lead to an opportunity as well.
This means that on the lead form, we don't want to display this field since it may be misleading for the
end user.
When it's set however, we want to display it, mainly because there are a few automatic synchronizations between
the lead and its partner (phone and email for examples), and this needs to be clear that modifying
one of those fields will in turn modify the linked partner."""
is_debug_mode = self.user_has_groups('base.group_no_one')
for lead in self:
lead.is_partner_visible = bool(lead.type == 'opportunity' or lead.partner_id or is_debug_mode)
@api.onchange('phone', 'country_id', 'company_id')
def _onchange_phone_validation(self):
if self.phone:
addons/crm/views/crm_lead_views.xml
+2 -1
View File
@@ -95,6 +95,7 @@
<group>
<group name="lead_partner" attrs="{'invisible': [('type', '=', 'opportunity')]}">
<!-- Preload all the partner's information -->
<field name="is_partner_visible" invisible='1'/>
<field name="partner_id" widget="res_partner_many2one"
context="{
'default_name': contact_name,
@@ -113,7 +114,7 @@
'default_team_id': team_id,
'default_website': website,
'show_vat': True
}" groups="base.group_no_one"/>
}" attrs="{'invisible': [('is_partner_visible', '=', False)]}"/>
<field name="partner_name"/>
<label for="street" string="Address"/>
<div class="o_address_format">