pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] account: forbid creating multiple foreign VAT fiscal positions for the same region

Browse Source 
Having the same VAT fiscal position for the same region multiple times doesn't make sense and is not supported by the report enfinge. We should prevent that.

closes odoo/odoo#77663

X-original-commit: d9dfeeb498dab359df52db87ff601d68fcf0ad7c
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
This commit is contained in:
oco-odoo
2021-10-04 09:16:25 +00:00
parent e4f9859722
commit 80e8f11796
1 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/account/models/partner.py
+22 -8
View File
@@ -76,15 +76,29 @@ class AccountFiscalPosition(models.Model):
@api.constrains('country_id', 'state_ids', 'foreign_vat')
def _validate_foreign_vat_country(self):
for record in self:
if record.foreign_vat and record.country_id == record.company_id.account_fiscal_country_id:
if record.foreign_vat == record.company_id.vat:
raise ValidationError(_("You cannot create a fiscal position within your fiscal country with the same VAT number as the main one set on your company."))
if record.foreign_vat:
if record.country_id == record.company_id.account_fiscal_country_id:
if record.foreign_vat == record.company_id.vat:
raise ValidationError(_("You cannot create a fiscal position within your fiscal country with the same VAT number as the main one set on your company."))
if not record.state_ids:
if record.company_id.account_fiscal_country_id.state_ids:
raise ValidationError(_("You cannot create a fiscal position with a foreign VAT within your fiscal country without assigning it a state."))
else:
raise ValidationError(_("You cannot create a fiscal position with a foreign VAT within your fiscal country."))
if not record.state_ids:
if record.company_id.account_fiscal_country_id.state_ids:
raise ValidationError(_("You cannot create a fiscal position with a foreign VAT within your fiscal country without assigning it a state."))
else:
raise ValidationError(_("You cannot create a fiscal position with a foreign VAT within your fiscal country."))
similar_fpos_domain = [
('foreign_vat', '!=', False),
('country_id', '=', record.country_id.id),
('company_id', '=', record.company_id.id),
('id', '!=', record.id),
]
if record.state_ids:
similar_fpos_domain.append(('state_ids', 'in', record.state_ids.ids))
similar_fpos_count = self.env['account.fiscal.position'].search_count(similar_fpos_domain)
if similar_fpos_count:
raise ValidationError(_("A fiscal position with a foreign VAT already exists in this region."))
def map_tax(self, taxes):
if not self: