pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] gamification: prevent misconfiguration

Browse Source 
Do not allow to select field that will be used read_group but not stored in db

Fixes #8545
This commit is contained in:
Martin Trigaux
2016-05-25 12:10:50 +02:00
parent e5c2e6e001
commit 5245dc5d9b
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/gamification/models/goal.py
+2 -1
View File
@@ -148,7 +148,8 @@ class gamification_goal_definition(osv.Model):
if not model_id:
return {'domain': {'field_id': expression.FALSE_DOMAIN, 'field_date_id': expression.FALSE_DOMAIN}}
model = self.pool['ir.model'].browse(cr, uid, model_id, context=context)
model_fields_domain = ['|', ('model_id', '=', model_id), ('model_id', 'in', model.inherited_model_ids.ids)]
model_fields_domain = [('store', '=', True),
'|', ('model_id', '=', model_id), ('model_id', 'in', model.inherited_model_ids.ids)]
model_date_fields_domain = expression.AND([[('ttype', 'in', ('date', 'datetime'))], model_fields_domain])
return {'domain': {'field_id': model_fields_domain, 'field_date_id': model_date_fields_domain}}