From 5245dc5d9b45d45d36675ac80634dba4b6beede6 Mon Sep 17 00:00:00 2001 From: Martin Trigaux Date: Wed, 25 May 2016 12:04:08 +0200 Subject: [PATCH] [IMP] gamification: prevent misconfiguration Do not allow to select field that will be used read_group but not stored in db Fixes #8545 --- addons/gamification/models/goal.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/addons/gamification/models/goal.py b/addons/gamification/models/goal.py index 1607a6005d1..557a2811609 100644 --- a/addons/gamification/models/goal.py +++ b/addons/gamification/models/goal.py @@ -148,7 +148,8 @@ class gamification_goal_definition(osv.Model): if not model_id: return {'domain': {'field_id': expression.FALSE_DOMAIN, 'field_date_id': expression.FALSE_DOMAIN}} model = self.pool['ir.model'].browse(cr, uid, model_id, context=context) - model_fields_domain = ['|', ('model_id', '=', model_id), ('model_id', 'in', model.inherited_model_ids.ids)] + model_fields_domain = [('store', '=', True), + '|', ('model_id', '=', model_id), ('model_id', 'in', model.inherited_model_ids.ids)] model_date_fields_domain = expression.AND([[('ttype', 'in', ('date', 'datetime'))], model_fields_domain]) return {'domain': {'field_id': model_fields_domain, 'field_date_id': model_date_fields_domain}}