[IMP] tests: make phantomjs work on Windows
Since Python 3.2, close_fds parameter is True by default on POSIX platforms. On Windows, it's set to False when one of the standard descriptors is set. This commit will give the opportunity to run phantom js tests on Windows.
This commit is contained in:
committed by
Vincent Schippefilt
parent
3ae9dde258
commit
4ba6d2a405
@@ -449,7 +449,7 @@ class HttpCase(TransactionCase):
|
||||
_logger.info('phantomjs unlink localstorage %s', i)
|
||||
os.unlink(i)
|
||||
try:
|
||||
phantom = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=None, close_fds=True)
|
||||
phantom = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=None)
|
||||
except OSError:
|
||||
raise unittest.SkipTest("PhantomJS not found")
|
||||
try:
|
||||
|
||||
Reference in New Issue
Block a user