From 4ba6d2a405c7362986e8a09702e6228887632ea1 Mon Sep 17 00:00:00 2001
From: Christophe Monniez <moc@odoo.com>
Date: Wed, 14 Feb 2018 08:06:12 +0100
Subject: [PATCH] [IMP] tests: make phantomjs work on Windows

Since Python 3.2, close_fds parameter is True by default on POSIX
platforms. On Windows, it's set to False when one of the standard descriptors
is set.

This commit will give the opportunity to run phantom js tests on
Windows.
---
 odoo/tests/common.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/odoo/tests/common.py b/odoo/tests/common.py
index 165e4459779..3c4344b3a1e 100644
--- a/odoo/tests/common.py
+++ b/odoo/tests/common.py
@@ -449,7 +449,7 @@ class HttpCase(TransactionCase):
             _logger.info('phantomjs unlink localstorage %s', i)
             os.unlink(i)
         try:
-            phantom = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=None, close_fds=True)
+            phantom = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=None)
         except OSError:
             raise unittest.SkipTest("PhantomJS not found")
         try: