pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] website_*: prevent record to be unpublished on website change

Browse Source 
Before this commit, when changing the website field in a record form view,
the is_published field would be force to false, ending unpublishing the record
if it was published.

That behavior was coming from the fact that is_published field is missing from
the form view. Thus, onchange on website is triggering a recompute server side
without is_published as the JS framework is not sending the field.
The ORM is then fallbacking on default Boolean value (False) for is_published
when sending back the onchange result.

This would only appear on object with 'website.published.multi.mixin' and with
website_id in the form view.

Replacing website_published by is_published will fix the behavior and has more
sense has website_published is the 'is_published' state in a website context.
In the backend, we are not in a website context.

task-1919689
This commit is contained in:
Romain Derie
2019-01-04 15:50:45 +00:00
parent 59cc261448
commit 30ed4c08cc
13 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/website_blog/views/website_blog_views.xml
+1 -1
View File
@@ -65,7 +65,7 @@
<div class="oe_button_box" name="button_box">
<button class="oe_stat_button" name="website_publish_button"
type="object" icon="fa-globe">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
<button name="toggle_active" type="object" class="oe_stat_button" icon="fa-archive">
<field name="active" widget="boolean_button" options='{"terminology": "archive"}'/>
addons/website_crm_partner_assign/views/res_partner_views.xml
+1 -1
View File
@@ -60,7 +60,7 @@
<div class="oe_button_box" name="button_box">
<button class="oe_stat_button" name="website_publish_button"
type="object" icon="fa-globe">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
</div>
<div class="oe_title">
addons/website_event/views/event_views.xml
+1 -1
View File
@@ -39,7 +39,7 @@
type="object"
class="oe_stat_button"
icon="fa-globe">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
</button>
<label for="is_online" position="after">
addons/website_event_track/views/event_track_views.xml
+1 -1
View File
@@ -116,7 +116,7 @@
<field name="website_url" invisible="1"/>
<button class="oe_stat_button" name="website_publish_button"
type="object" icon="fa-globe">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
<button name="toggle_active" type="object" class="oe_stat_button" icon="fa-archive">
<field name="active" widget="boolean_button" options='{"terminology": "archive"}'/>
addons/website_forum/views/res_users_views.xml
+1 -1
View File
@@ -14,7 +14,7 @@
<button name="toggle_active" position="before">
<button class="oe_stat_button" name="open_website_url"
type="object" icon="fa-globe">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
</button>
</field>
addons/website_hr/views/hr_employee_views.xml
+1 -1
View File
@@ -9,7 +9,7 @@
<button name="toggle_active" position="before">
<button class="oe_stat_button" name="website_publish_button"
type="object" icon="fa-globe" groups="hr.group_hr_user">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
</button>
<xpath expr="//page[@name='public']/group" position="inside">
addons/website_hr_recruitment/views/hr_recruitment_views.xml
+1 -1
View File
@@ -19,7 +19,7 @@
<div name="button_box" position="inside">
<button class="oe_stat_button" name="website_publish_button"
type="object" icon="fa-globe">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
</div>
</field>
addons/website_livechat/views/website_livechat_view.xml
+1 -1
View File
@@ -10,7 +10,7 @@
<div name="button_box" position="inside">
<button class="oe_stat_button" name="website_publish_button"
type="object" icon="fa-globe">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
</div>
</field>
addons/website_partner/views/res_partner_views.xml
+1 -1
View File
@@ -10,7 +10,7 @@
<button name="toggle_active" position="before">
<button class="oe_stat_button" name="website_publish_button"
type="object" icon="fa-globe">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
</button>
</data>
addons/website_sale/views/product_views.xml
+1 -1
View File
@@ -79,7 +79,7 @@
<xpath expr="//button[@name='toggle_active']" position="before">
<button class="oe_stat_button" name="website_publish_button"
type="object" icon="fa-globe" attrs="{'invisible': [('sale_ok','=',False)]}">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
</xpath>
<xpath expr="//page[@name='sales']" position="after">
addons/website_sale_delivery/views/website_sale_delivery_views.xml
+1 -1
View File
@@ -13,7 +13,7 @@
</xpath>
<xpath expr="//button[@name='toggle_active']" position='before'>
<button class="oe_stat_button" name="website_publish_button" type="object" icon="fa-globe">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
</xpath>
</field>
addons/website_slides/views/slide_channel_views.xml
+1 -1
View File
@@ -51,7 +51,7 @@
<div class="oe_button_box" name="button_box">
<button class="oe_stat_button" name="website_publish_button"
type="object" icon="fa-globe">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
<button name="toggle_active" type="object" confirm="(Un)archiving a channel automatically (un)archives its slides. Do you want to proceed?" class="oe_stat_button" icon="fa-archive">
<field name="active" widget="boolean_button" options='{"terminology": "archive"}'/>
addons/website_slides/views/slide_slide_views.xml
+1 -1
View File
@@ -40,7 +40,7 @@
<div class="oe_button_box" name="button_box">
<button class="oe_stat_button" name="website_publish_button"
type="object" icon="fa-globe">
<field name="website_published" widget="website_button"/>
<field name="is_published" widget="website_button"/>
</button>
<button name="toggle_active" type="object" class="oe_stat_button" icon="fa-archive">
<field name="active" widget="boolean_button" options='{"terminology": "archive"}'/>