From 30ed4c08ccf3586134757bf006fc76f814d964a7 Mon Sep 17 00:00:00 2001
From: Romain Derie <rde@odoo.com>
Date: Fri, 21 Dec 2018 15:56:18 +0000
Subject: [PATCH] [FIX] website_*: prevent record to be unpublished on website
 change

Before this commit, when changing the website field in a record form view,
the is_published field would be force to false, ending unpublishing the record
if it was published.

That behavior was coming from the fact that is_published field is missing from
the form view. Thus, onchange on website is triggering a recompute server side
without is_published as the JS framework is not sending the field.
The ORM is then fallbacking on default Boolean value (False) for is_published
when sending back the onchange result.

This would only appear on object with 'website.published.multi.mixin' and with
website_id in the form view.

Replacing website_published by is_published will fix the behavior and has more
sense has website_published is the 'is_published' state in a website context.
In the backend, we are not in a website context.

task-1919689
---
 addons/website_blog/views/website_blog_views.xml                | 2 +-
 addons/website_crm_partner_assign/views/res_partner_views.xml   | 2 +-
 addons/website_event/views/event_views.xml                      | 2 +-
 addons/website_event_track/views/event_track_views.xml          | 2 +-
 addons/website_forum/views/res_users_views.xml                  | 2 +-
 addons/website_hr/views/hr_employee_views.xml                   | 2 +-
 addons/website_hr_recruitment/views/hr_recruitment_views.xml    | 2 +-
 addons/website_livechat/views/website_livechat_view.xml         | 2 +-
 addons/website_partner/views/res_partner_views.xml              | 2 +-
 addons/website_sale/views/product_views.xml                     | 2 +-
 .../website_sale_delivery/views/website_sale_delivery_views.xml | 2 +-
 addons/website_slides/views/slide_channel_views.xml             | 2 +-
 addons/website_slides/views/slide_slide_views.xml               | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/addons/website_blog/views/website_blog_views.xml b/addons/website_blog/views/website_blog_views.xml
index 85386651ec1..df95e8e76e2 100644
--- a/addons/website_blog/views/website_blog_views.xml
+++ b/addons/website_blog/views/website_blog_views.xml
@@ -65,7 +65,7 @@
                         <div class="oe_button_box" name="button_box">
                             <button class="oe_stat_button" name="website_publish_button"
                                 type="object" icon="fa-globe">
-                                <field name="website_published" widget="website_button"/>
+                                <field name="is_published" widget="website_button"/>
                             </button>
                             <button name="toggle_active" type="object" class="oe_stat_button" icon="fa-archive">
                                 <field name="active" widget="boolean_button" options='{"terminology": "archive"}'/>
diff --git a/addons/website_crm_partner_assign/views/res_partner_views.xml b/addons/website_crm_partner_assign/views/res_partner_views.xml
index 9510ed6aa4c..58b10d3345a 100644
--- a/addons/website_crm_partner_assign/views/res_partner_views.xml
+++ b/addons/website_crm_partner_assign/views/res_partner_views.xml
@@ -60,7 +60,7 @@
                     <div class="oe_button_box" name="button_box">
                         <button class="oe_stat_button" name="website_publish_button"
                                 type="object" icon="fa-globe">
-                            <field name="website_published" widget="website_button"/>
+                            <field name="is_published" widget="website_button"/>
                         </button>
                     </div>
                     <div class="oe_title">
diff --git a/addons/website_event/views/event_views.xml b/addons/website_event/views/event_views.xml
index 7e4df97c36a..a5c25cc2611 100644
--- a/addons/website_event/views/event_views.xml
+++ b/addons/website_event/views/event_views.xml
@@ -39,7 +39,7 @@
                         type="object"
                         class="oe_stat_button"
                         icon="fa-globe">
-                    <field name="website_published" widget="website_button"/>
+                    <field name="is_published" widget="website_button"/>
                 </button>
             </button>
             <label for="is_online" position="after">
diff --git a/addons/website_event_track/views/event_track_views.xml b/addons/website_event_track/views/event_track_views.xml
index 5e22b4af8f3..ee4d4b433b8 100644
--- a/addons/website_event_track/views/event_track_views.xml
+++ b/addons/website_event_track/views/event_track_views.xml
@@ -116,7 +116,7 @@
                             <field name="website_url" invisible="1"/>
                             <button class="oe_stat_button" name="website_publish_button"
                                 type="object" icon="fa-globe">
-                                <field name="website_published" widget="website_button"/>
+                                <field name="is_published" widget="website_button"/>
                             </button>
                             <button name="toggle_active" type="object" class="oe_stat_button" icon="fa-archive">
                                 <field name="active" widget="boolean_button" options='{"terminology": "archive"}'/>
diff --git a/addons/website_forum/views/res_users_views.xml b/addons/website_forum/views/res_users_views.xml
index e5327141f80..d85abcb14e6 100644
--- a/addons/website_forum/views/res_users_views.xml
+++ b/addons/website_forum/views/res_users_views.xml
@@ -14,7 +14,7 @@
                 <button name="toggle_active" position="before">
                     <button class="oe_stat_button" name="open_website_url"
                         type="object" icon="fa-globe">
-                        <field name="website_published" widget="website_button"/>
+                        <field name="is_published" widget="website_button"/>
                     </button>
                 </button>
             </field>
diff --git a/addons/website_hr/views/hr_employee_views.xml b/addons/website_hr/views/hr_employee_views.xml
index e48c6e6b38d..be2c7accda9 100644
--- a/addons/website_hr/views/hr_employee_views.xml
+++ b/addons/website_hr/views/hr_employee_views.xml
@@ -9,7 +9,7 @@
             <button name="toggle_active" position="before">
                 <button class="oe_stat_button" name="website_publish_button"
                     type="object" icon="fa-globe" groups="hr.group_hr_user">
-                    <field name="website_published" widget="website_button"/>
+                    <field name="is_published" widget="website_button"/>
                 </button>
             </button>
             <xpath expr="//page[@name='public']/group" position="inside">
diff --git a/addons/website_hr_recruitment/views/hr_recruitment_views.xml b/addons/website_hr_recruitment/views/hr_recruitment_views.xml
index b74351b389a..66932f93654 100644
--- a/addons/website_hr_recruitment/views/hr_recruitment_views.xml
+++ b/addons/website_hr_recruitment/views/hr_recruitment_views.xml
@@ -19,7 +19,7 @@
             <div name="button_box" position="inside">
                 <button class="oe_stat_button" name="website_publish_button"
                     type="object" icon="fa-globe">
-                    <field name="website_published" widget="website_button"/>
+                    <field name="is_published" widget="website_button"/>
                 </button>
             </div>
         </field>
diff --git a/addons/website_livechat/views/website_livechat_view.xml b/addons/website_livechat/views/website_livechat_view.xml
index 20c8fd38ec9..1441f0642ff 100644
--- a/addons/website_livechat/views/website_livechat_view.xml
+++ b/addons/website_livechat/views/website_livechat_view.xml
@@ -10,7 +10,7 @@
                 <div name="button_box" position="inside">
                     <button class="oe_stat_button" name="website_publish_button"
                         type="object" icon="fa-globe">
-                        <field name="website_published" widget="website_button"/>
+                        <field name="is_published" widget="website_button"/>
                     </button>
                 </div>
             </field>
diff --git a/addons/website_partner/views/res_partner_views.xml b/addons/website_partner/views/res_partner_views.xml
index 53236bce708..8c19de877ac 100644
--- a/addons/website_partner/views/res_partner_views.xml
+++ b/addons/website_partner/views/res_partner_views.xml
@@ -10,7 +10,7 @@
                 <button name="toggle_active" position="before">
                     <button class="oe_stat_button" name="website_publish_button"
                         type="object" icon="fa-globe">
-                        <field name="website_published" widget="website_button"/>
+                        <field name="is_published" widget="website_button"/>
                     </button>
                 </button>
             </data>
diff --git a/addons/website_sale/views/product_views.xml b/addons/website_sale/views/product_views.xml
index 8d3ff588bb3..10bba1cc085 100644
--- a/addons/website_sale/views/product_views.xml
+++ b/addons/website_sale/views/product_views.xml
@@ -79,7 +79,7 @@
             <xpath expr="//button[@name='toggle_active']" position="before">
                 <button class="oe_stat_button" name="website_publish_button"
                     type="object" icon="fa-globe" attrs="{'invisible': [('sale_ok','=',False)]}">
-                    <field name="website_published" widget="website_button"/>
+                    <field name="is_published" widget="website_button"/>
                 </button>
             </xpath>
             <xpath expr="//page[@name='sales']" position="after">
diff --git a/addons/website_sale_delivery/views/website_sale_delivery_views.xml b/addons/website_sale_delivery/views/website_sale_delivery_views.xml
index 0e60a35fb70..7cd811fddc6 100644
--- a/addons/website_sale_delivery/views/website_sale_delivery_views.xml
+++ b/addons/website_sale_delivery/views/website_sale_delivery_views.xml
@@ -13,7 +13,7 @@
             </xpath>
             <xpath expr="//button[@name='toggle_active']" position='before'>
                 <button class="oe_stat_button" name="website_publish_button" type="object" icon="fa-globe">
-                    <field name="website_published" widget="website_button"/>
+                    <field name="is_published" widget="website_button"/>
                 </button>
             </xpath>
         </field>
diff --git a/addons/website_slides/views/slide_channel_views.xml b/addons/website_slides/views/slide_channel_views.xml
index 308610c0e90..c89b13d0261 100644
--- a/addons/website_slides/views/slide_channel_views.xml
+++ b/addons/website_slides/views/slide_channel_views.xml
@@ -51,7 +51,7 @@
                         <div class="oe_button_box" name="button_box">
                             <button class="oe_stat_button" name="website_publish_button"
                                     type="object" icon="fa-globe">
-                                <field name="website_published" widget="website_button"/>
+                                <field name="is_published" widget="website_button"/>
                             </button>
                             <button name="toggle_active" type="object" confirm="(Un)archiving a channel automatically (un)archives its slides. Do you want to proceed?" class="oe_stat_button" icon="fa-archive">
                                 <field name="active" widget="boolean_button" options='{"terminology": "archive"}'/>
diff --git a/addons/website_slides/views/slide_slide_views.xml b/addons/website_slides/views/slide_slide_views.xml
index a64b55630f0..0cf7bb08751 100644
--- a/addons/website_slides/views/slide_slide_views.xml
+++ b/addons/website_slides/views/slide_slide_views.xml
@@ -40,7 +40,7 @@
                         <div class="oe_button_box" name="button_box">
                             <button class="oe_stat_button" name="website_publish_button"
                                     type="object" icon="fa-globe">
-                                <field name="website_published" widget="website_button"/>
+                                <field name="is_published" widget="website_button"/>
                             </button>
                             <button name="toggle_active" type="object" class="oe_stat_button" icon="fa-archive">
                                 <field name="active" widget="boolean_button" options='{"terminology": "archive"}'/>