pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[REF] stock_account: _run_fifo_vacuum: get moves to vacuum

Browse Source 
Do not perform useless calls to `search`.

Closes #29962

closes odoo/odoo#30392
This commit is contained in:
Graeme Gellatly
2019-01-21 08:51:30 +00:00
committed by Simon Lejeune
parent 0fa969a4a7
commit 194fc8a136
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/stock_account/models/stock.py
+2 -4
View File
@@ -485,10 +485,8 @@ class StockMove(models.Model):
'product_variant_ids')
fifo_valued_categories = self.env['product.category'].search([('property_cost_method', '=', 'fifo')])
fifo_valued_products |= self.env['product.product'].search([('categ_id', 'child_of', fifo_valued_categories.ids)])
moves_to_vacuum = self.env['stock.move']
for product in fifo_valued_products:
moves_to_vacuum |= self.search(
[('product_id', '=', product.id), ('remaining_qty', '<', 0)] + self._get_all_base_domain())
moves_to_vacuum = self.search(
[('product_id', 'in', fifo_valued_products.ids), ('remaining_qty', '<', 0)] + self._get_all_base_domain())
moves_to_vacuum._fifo_vacuum()
@api.multi