From 194fc8a13641e45ec723939f2346f91e98addac9 Mon Sep 17 00:00:00 2001 From: Graeme Gellatly Date: Sat, 5 Jan 2019 09:29:22 +0000 Subject: [PATCH] [REF] stock_account: _run_fifo_vacuum: get moves to vacuum Do not perform useless calls to `search`. Closes #29962 closes odoo/odoo#30392 --- addons/stock_account/models/stock.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/addons/stock_account/models/stock.py b/addons/stock_account/models/stock.py index b7a9ee8c2c4..50444266362 100644 --- a/addons/stock_account/models/stock.py +++ b/addons/stock_account/models/stock.py @@ -485,10 +485,8 @@ class StockMove(models.Model): 'product_variant_ids') fifo_valued_categories = self.env['product.category'].search([('property_cost_method', '=', 'fifo')]) fifo_valued_products |= self.env['product.product'].search([('categ_id', 'child_of', fifo_valued_categories.ids)]) - moves_to_vacuum = self.env['stock.move'] - for product in fifo_valued_products: - moves_to_vacuum |= self.search( - [('product_id', '=', product.id), ('remaining_qty', '<', 0)] + self._get_all_base_domain()) + moves_to_vacuum = self.search( + [('product_id', 'in', fifo_valued_products.ids), ('remaining_qty', '<', 0)] + self._get_all_base_domain()) moves_to_vacuum._fifo_vacuum() @api.multi