[FIX] sms: fix some issues in SMS composer

PURPOSE

Followup of merge 4287481 .

SPECIFICATIONS

Display "Missing number" in recipients invalid message when not having
any number to ease user experience;

Use note subtype when logging through composer, like already done in standard
sms API method at 2b7ad217f1a55a0687ba4ec4765bc7777114aac0;

LINKS

Task 1922187
This commit is contained in:
Remi Rahir
2019-07-23 08:29:15 +00:00
committed by Thibault Delavallée
parent cce91e35f7
commit 17679bd44c
+2 -2
View File
@@ -70,7 +70,7 @@ class SendSMS(models.TransientModel):
def _compute_description(self):
if self.partner_ids:
description = ''
description = ','.join('%s - %s' % (partner.display_name, partner.mobile or partner.phone) for partner in self.partner_ids[:self._RECIPIENTS_DISPLAY_NBR])
description = ','.join('%s - %s' % (partner.display_name, partner.mobile or partner.phone or _('Missing number')) for partner in self.partner_ids[:self._RECIPIENTS_DISPLAY_NBR])
if len(self.partner_ids) > self._RECIPIENTS_DISPLAY_NBR:
description += _(' (and %s more)') % (len(self.partner_ids) - self._RECIPIENTS_DISPLAY_NBR)
self.recipient_description = description
@@ -163,7 +163,7 @@ class SendSMS(models.TransientModel):
def _action_send_sms_comment(self, records=None):
records = records if records is not None else self._get_records()
subtype_id = self.env['ir.model.data'].xmlid_to_res_id('mail.mt_comment')
subtype_id = self.env['ir.model.data'].xmlid_to_res_id('mail.note')
messages = self.env['mail.message']
for record in records: