From 17679bd44c615d86999d50a1f9f2ea07658a409d Mon Sep 17 00:00:00 2001 From: Remi Rahir Date: Mon, 22 Jul 2019 08:58:58 +0000 Subject: [PATCH] [FIX] sms: fix some issues in SMS composer PURPOSE Followup of merge 4287481 . SPECIFICATIONS Display "Missing number" in recipients invalid message when not having any number to ease user experience; Use note subtype when logging through composer, like already done in standard sms API method at 2b7ad217f1a55a0687ba4ec4765bc7777114aac0; LINKS Task 1922187 --- addons/sms/wizard/sms_composer.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/sms/wizard/sms_composer.py b/addons/sms/wizard/sms_composer.py index b811699b194..e3a05d30f2e 100644 --- a/addons/sms/wizard/sms_composer.py +++ b/addons/sms/wizard/sms_composer.py @@ -70,7 +70,7 @@ class SendSMS(models.TransientModel): def _compute_description(self): if self.partner_ids: description = '' - description = ','.join('%s - %s' % (partner.display_name, partner.mobile or partner.phone) for partner in self.partner_ids[:self._RECIPIENTS_DISPLAY_NBR]) + description = ','.join('%s - %s' % (partner.display_name, partner.mobile or partner.phone or _('Missing number')) for partner in self.partner_ids[:self._RECIPIENTS_DISPLAY_NBR]) if len(self.partner_ids) > self._RECIPIENTS_DISPLAY_NBR: description += _(' (and %s more)') % (len(self.partner_ids) - self._RECIPIENTS_DISPLAY_NBR) self.recipient_description = description @@ -163,7 +163,7 @@ class SendSMS(models.TransientModel): def _action_send_sms_comment(self, records=None): records = records if records is not None else self._get_records() - subtype_id = self.env['ir.model.data'].xmlid_to_res_id('mail.mt_comment') + subtype_id = self.env['ir.model.data'].xmlid_to_res_id('mail.note') messages = self.env['mail.message'] for record in records: