Yolann Sabaux
f5da45537a
Steps to reproduce: - Create two Bills with different payment terms with one having no "early_discount" such as '30% Now, Balance 60 Days' - Select the Bills and click on Register Payment (make sure the payment is not grouped) Issue: Server Error Cause: We try to Register Payment for all the Bills at once, but the "early_discount" is not defined for all the Bills. So, whenever there is a move with an early discount, the mode is always considered as "early_payment". Therefore, we call `_get_invoice_counterpart_amls_for_early_payment_discount` with an empty list since there is no early discount https://github.com/odoo/odoo/blob/0ffaaebfa5c25c4bf71fb0e02288767dbfac959d/addons/account/wizard/account_payment_register.py#L750-L755 https://github.com/odoo/odoo/blob/0ffaaebfa5c25c4bf71fb0e02288767dbfac959d/addons/account/wizard/account_payment_register.py#L760 Causing the "local variable 'aml' referenced before assignment" error. Solution: We only iterate through moves belonging to the batch. This way, we avoid setting the mode to "early_payment" and entering the confition. opw-3378445 closes odoo/odoo#132113 X-original-commit: 9bba9576d3365500a5c1eda0cfd57457fd999878 Signed-off-by: Laurent Smet (las) <las@odoo.com> Signed-off-by: Yolann Sabaux (yosa) <yosa@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials