f1dbd84e9dc9ca2ac475e1c1a47aab7adf6e0911
The MoneyDetailsPopup accepts the prop `total`. This popup is used to keep track of the bills selected by the user and it's total should thus simply be computed from the given bills information. Passing the `total` prop and using it as `state` serves no purpose and leads to bugs, such as the one addressed in this task. Steps to reproduce: 1. Click on "Close Session". 2. Input a value in the "counted" field 3. Open the "MoneyDetailsPopup" 4. Observe the fact that the "Total" value is the one from the "counted" field, instead of "0". This is caused because the `ClosePosPopup` has to also independently keep track of this `total`, in order to be able to pass it to the `MoneyDetailsPopup` on future calls. In order to fix this problem from the root cause, we completely remove the prop `total` and instead allow the popup to compute it from it's information about the selected bills. This simplifies the code, preventing future similar bugs. Task: 3499242 Part-of: odoo/odoo#131171
…
…
…
…
…
…
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials
Languages
Python
49.6%
JavaScript
47.8%
SCSS
2%
CSS
0.3%
HTML
0.2%