Arthur Detroux (ard)
d7c7823d8c
The website now being displayed in the backend of Odoo (since [1]) within an iframe. To be able to send events inside this iframe, the `PublicRoot` widget from within the iframe is "captured" (using the `OdooFrameContentLoaded` event). This is used to send events to Public Widgets such as notifying them that the edition is about to start, so they need to reload in edit mode. Prior to this commit, the WebsiteRootInstance would be set to `undefined` when the page was about to be unloaded (`beforeunload` event). This is useful as this prevents the editor to start in an inconsistent state if a user clicks on a link or changes page and clicks edit too soon. Unfortunately, the beforeunload event can be canceled. Two ways this can be noticed: - On firefox, enter edit mode and edit the page - Try to close the tab - A browser dialog is displayed asking the user to confirm if they want to leave the page - This is done using the beforeunload event - It is triggered in both the iframe and the top window on firefox when trying to close a tab - Clicking on cancel won't allow you to resume the edition as the `websiteRootInstance` was set to `undefined` - On any browser, enter edit mode - Upload a document using the media dialog - Save - Click to download the document - Try to enter edit mode Clicking on the link triggers a `beforeunload` as the browser is about to leave the page. The browser somehow detects a download and cancels the beforeunload. But the `websiteRootInstance` was already set to undefined. This commit fixes that by only setting the websiteRootInstance to undefined in some context: - When clicking on a link that will result in navigating inside the iframe - When changing website - When the `WebsitePreview` component is asked to reload the iframe - Doing it again when a `pagehide` event is triggered. This last one is only for safety (e.g. if a widget within the iframe triggers navigation which leads to a pagehide). Though using this event is often too late, as the editor has time to start but often not fully, and destroying it so early can lead to tracebacks. [1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b task-3046473 closes odoo/odoo#112048 X-original-commit: e47a9900e4a7842774d33a332b325e1f08c3ca45 Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com> Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials