Adrien Dieudonné
cb7cf77ed0
Before this commit, we had a traceback if we tried to activate the cookie bar on the website: `_updateScrollBar` function of s_popup's 000.js This is due to the fact that _checkScrollbar, _setScrollbar and _resetScrollbar doesn't exist anymore in BS5. It's why overrides of these functions were already removed during the migration as you can see here: https://github.com/odoo/odoo/commit/0b94da214b7017e8580e671cbaa68ade6de2fbc7#diff-348097d5de2047358549a91803882338f589af18c5dafed9f653250e150ce679L116-L138 Because of this, we have to delete _updateScrollbar and its usage. Instead of trying to control the scrollbar, another possibily would be to simply manage it with 'overflow' css properties. Desired behavior: a) Popup/Cookie bar WITHOUT backdrop, we should be able to - scroll the content behind - scroll the popup content itself - click on elements behind b) Popup/Cookie bar WITH backdrop, we shoudn't be able to - scroll the content behind - click on elements behind To do this, we now allow the scroll on '#wrapwrap' (the content). In BS a popup has a backdrop by default and there is nothing to do to block scroll and clicks behind the modal (on '#wrapwrap'). If the popup doesn't have a backdrop, we set 'pointer-events' to 'none' to allow pointer event to pass through the backdrop element and annihilate his effect. Note that 'pointer-events' property is reset by BS to 'auto' for the popup content to override inherited value from the parent. https://developer.mozilla.org/en-US/docs/Web/CSS/pointer-events#formal_definition Also note that now we have the same behavior as on desktop. If the size is set to 'Full', the cookie bar is displayed without any margins and sticks to the screen borders. Steps to reproduce: - Enable cookie bar in settings - Access a website page Related commits: - https://github.com/odoo/odoo/commit/e5a5f98819b3a70b3e2564fb91722cab415ceea9 - https://github.com/odoo/odoo/commit/97c8cf3ac263884b3eeb9862b84a426162d9794e - https://github.com/odoo/odoo/commit/a0ddaa8931601a3d5e91a5ba5859ba58658e8710 - https://github.com/odoo/odoo/commit/0b94da214b7017e8580e671cbaa68ade6de2fbc7 - https://github.com/odoo/odoo/commit/43ccc785546bbce7787ca2075aa18ebc76a6d36b Part-of: odoo/odoo#99338
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials