Arthur Detroux (ard)
c2932dfcfe
Prior to this commit and on Firefox 109, clicking on a link while in edit mode on the website app would trigger a traceback. This is caused by the fact that the LinkPopover widget is contained inside the iframe while use the ClipboardJS global defined in the top window. Indeed, ClipboardJS checks if the target (the button to copy the link) is an HTMLElement. To do so, it uses the "instanceof" keyword. However, the __proto__ (what is used for computing instanceof) of the target is different depending on the browser. For Chrome, the HTMLElement's __proto__ depends on which "document" it was created. On Firefox, when attaching an element to a parent, it will switch __proto__ to the one from the frame from which it is attached. To fix this, we use the ClipboardJS from the element's instance window. In any case, using instanceof when working with iframe is a bad idea, see [1]. In this case, the fix is made because ClipboardJS is an external library. Steps to reproduce: - Download Firefox 109+ - Go on Website and switch to edit mode - Click on a Link : A traceback appears. [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/instanceof#instanceof_and_multiple_realms closes odoo/odoo#111266 X-original-commit: 732848f2b52bea4ebae18cb5adedf581d5112aa6 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials