William Henrotin
c1ff654875
Steps to reproduce the bug: - Create an attribute with "Variant Creation Mode" = Dynamically - In a product template, add the attributes and some values - Create a new BoM for this product - Click on "Stucture&Cost" smart button Problem: A traceback is raise, because the `_match_all_variant_values` function is called but without the product, while it takes at least one: https://github.com/odoo/odoo/blob/15.0/addons/mrp/models/mrp_bom.py# L456 https://github.com/odoo/odoo/blob/15.0/addons/mrp/models/product.py#L286 As the variant creation mode is set “dynamically”, the object must be a `product.template` model and not `product.product` so the first condition should be `True` and return a `false` value: https://github.com/odoo/odoo/blob/5c16aa22c70f8a0a377a55b912307ab07222c643/addons/mrp/models/mrp_bom.py#L453-L454 Therefore, if the product has no variant, we have to use the `product_template` and set it in the `_get_bom` function, but from this commit: odoo@ca3dfec If there is no variant product, the template is no longer set: odoo@ca3dfec#diff-e8f576a790cd7f3f0976358b9b07f63cee0c6f05b0ba6203fc7bcf91af3ad283L107 The change in this commit from line 107 to line 118 is useless because it does not change any behavior and does not improve the code, the only change is that the product_template is no longer set. So it makes sense to revert this part of change opw-3008838 closes odoo/odoo#110341 X-original-commit: 1d830b5080e4d05dc1ac6fbd4c435af532443f88 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials