Benjamin Vray
b5f43b22d4
This commit fixes two bugs with the sidebar header. Steps to reproduce the 1st bug: - Go to "/shop" and edit the page. - Click on the header. - Open the header selector. - Choose the "sidebar header". - Bug: infinite loader (or traceback from V16). Steps to reproduce the 2nd bug: - Go to "/contactus" and edit the page. - Click on the header. - Change the "Header Position" option to "over the content". - Save the page. - Go to the homepage and edit the page. - Click on the header. - Open the header selector. - Choose the "sidebar header". - Save the page. - Go to /contactus. - Bug: the "sidebar" header is broken on the "/contactus" page. The first bug was caused by triggering the deactivation of the "Overlay" header from a location other than a website.page (in this case, the "/shop" page in the steps to reproduce). In this place, the "Overlay" header option isn't available. However, while trying to fix this, we noticed the second bug => When we activate the "sidebar" header (which is a general option for all pages), we were deactivating the "Overlay" header only on the current page (this option is specific to the page). It was done since this commit [1]. This doesn't make sense because the "Overlay" header should be deactivated on all pages, not just the current one. To address this in the simplest way, we modified the CSS so that the "Overlay" header doesn't have an impact when the sidebar header is activated. Without this change, we would have needed to add an RPC to remove the "Overlay" header on all pages, which wouldn't have been worth it. [1]: https://github.com/odoo/odoo/commit/618fd49642310c7b97ef3b9e6c01f8f691c7b12f task-3454161 closes odoo/odoo#139955 X-original-commit: b27279492fea98f2cd6bfba962bfd570e464d361 Signed-off-by: Colin Louis (loco) <loco@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials